login: set default subscription to one with the state of "Enabled" #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2575 +/- ##
==========================================
+ Coverage 72.32% 72.32% +<.01%
==========================================
Files 363 363
Lines 19835 19838 +3
Branches 2923 2924 +1
==========================================
+ Hits 14345 14348 +3
Misses 4582 4582
Partials 908 908
Continue to review full report at Codecov.
|
derekbekoe
approved these changes
Mar 21, 2017
| def _pick_working_subscription(subscriptions): | ||
| from azure.mgmt.resource.subscriptions.models import SubscriptionState | ||
| s = next((x for x in subscriptions if x['state'] == SubscriptionState.enabled.value), None) | ||
| return s or subscriptions[0] |
There was a problem hiding this comment.
What if the subscriptions list is empty? Is that a scenario?
There was a problem hiding this comment.
The caller of _set_subscriptions will ensure the subscriptions will not be empty, so we are fine. Thanks for asking.
IsaacCalligeros95
added a commit
to OctopusDeploy/WorkerTools
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2568