Publish DEPS for 85.0.4183.73

• DEPS[diff]

Incrementing VERSION to 85.0.4183.73

[email protected]

Change-Id: Ia82212b0ffcbf064e050aefa3dce7d919c329077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359193
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#1526}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/VERSION[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597467894-5e4f394927e9aeb3e8e5189be50e6353f2c6747d.profdata to chrome-win32-4183-1597510237-8ee9e448fb3b1dc5977965eba5fbe4796b69a302.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Iea47be07547b31a6d9208296c5ac2489569c1086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358660
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1525}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597467894-200ecedbb8a76094853ca11c4e15d5267935a2fa.profdata to chrome-win64-4183-1597510237-652984c7de8f993327387e815661cc645fbaaec7.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ifd8a7196c509c5be692a006500c35b1484a180d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358659
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1524}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

ios: Add CFBundleURLSchemes for http/https.

(cherry picked from commit 50602dd111916798014741467d67eb94515ebec2)

Bug: 1101058
Change-Id: Ic2bb25d5652a77c401471f067c76feef7e740303
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277977
Auto-Submit: Justin Cohen <[email protected]>
Commit-Queue: Rohit Rao <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788393}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358996
Reviewed-by: Bindu Suvarna <[email protected]>
Commit-Queue: Bindu Suvarna <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1523}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• ios/chrome/app/resources/Info.plist[diff]

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-4183-1597484536-ff40ca57712df9805a649e42426fe8c4d56337be.profdata to chrome-mac-4183-1597510237-5e96aa3b693ab394594c686fc5cc548540260c52.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Icef47729fdda0de455c6f14879d4f4a0a095ab56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359149
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1522}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/mac.pgo.txt[diff]

Roll ChromeOS Orderfiles from 85-4183.57-1597056056-benchmark-85.0.4183.69-r1 to 85-4183.57-1597056056-benchmark-85.0.4183.71-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: Ide545fc6e74143bfd17de695f1c0389dc4690b8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358653
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1521}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/orderfile.newest.txt[diff]

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-4183-1597449227-9fe615dd50e244f9043206576ba37e4bde1ce3c5.profdata to chrome-mac-4183-1597484536-ff40ca57712df9805a649e42426fe8c4d56337be.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Icb6c7ca35c9d6e78c8fd0d069ea9e2e0ddf4cfe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358921
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1520}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/mac.pgo.txt[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597449227-e9cac3af1b46c6be44abdc167b96db89a207282e.profdata to chrome-win32-4183-1597467894-5e4f394927e9aeb3e8e5189be50e6353f2c6747d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I663e345b72444c630aff51e19e63aecbb2006702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358880
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1519}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597449227-d554c147422411578e19f8f00a3e4b5611e58647.profdata to chrome-win64-4183-1597467894-200ecedbb8a76094853ca11c4e15d5267935a2fa.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I00952cc3e7e1402b48d9239d0d59ee8b002f8cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358881
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1518}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597418154-7ae2bef4785a1bb23b764164f5ab16f1980fcf2f.profdata to chrome-win32-4183-1597449227-e9cac3af1b46c6be44abdc167b96db89a207282e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I1dc5d6a7a36d4b2962cb4907cf46e0a105ac4339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358769
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1517}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

Roll ChromeOS Orderfiles from 85-4183.57-1597056056-benchmark-85.0.4183.65-r1 to 85-4183.57-1597056056-benchmark-85.0.4183.69-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: I37224206c4259be6dd2f5fd59faae081742c5811
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358651
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1516}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/orderfile.newest.txt[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597418154-349d1e02740dfbe0782a5c2a14bee3818cf80185.profdata to chrome-win64-4183-1597449227-d554c147422411578e19f8f00a3e4b5611e58647.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ida98286693f984d058771ce25500926f2675fe04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358610
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1515}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

[per-agent scheduling] Don't wait for non-ordinary page frame signals.

Frames for non-ordinary pages don't report signals (such as FMP or
onload). They also have no parent frame, so they are considered main
frames, and they use arbitrary agent cluster IDs. This can create
situations where we will "affect" queues forever.

The solution is to not add such frames to the "waiting for signal" set. This avoids waiting for them indefinitely, while also not throttling them.

The CL also changes it so that we don't try affect queues not associated with a frame (i.e.: have no FrameScheduler), as those are "global" queues that are not associated with a single agent.

(cherry picked from commit 18923dd9812dddd44b72e05c8211a7a3b1e9b877)

Bug: 1090251,1115389
Change-Id: I8e624626694aa5aded7bce1ab6243c57eb69ebd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352584
Commit-Queue: Tal Pressman <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Kouhei Ueno <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#797662}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358709
Cr-Commit-Position: refs/branch-heads/4183@{#1514}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• third_party/blink/renderer/platform/scheduler/main_thread/agent_scheduling_strategy.cc[diff]
• third_party/blink/renderer/platform/scheduler/main_thread/agent_scheduling_strategy_unittest.cc[diff]
• third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc[diff]
• third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h[diff]

Fix Meet flickering on macOS

As background, YUV 420 biplanar videos on macOS (basically all videos)
cannot be sampled directly in OpenGL. When we want to sample them, we do
a copy and YUV to RGB conversion.

In the compositor, we will draw either using OpenGL or using overlays.

We bracket our use with calls to Begin/EndSharedImageAccess using the
argument READ (for GL) or OVERLAY (for overlay). In the case of overlay
access, we skip the copy.

The DisplayResourceProvider will agglomerates the calls to
Begin/EndSharedImageAccess into a single pair -- so if there is already
a READ access active, and another READ access comes in, then we skip
the second call to Begin/EndSharedImageAccess.

The bug is that if we do OVERLAY access, and then want READ access, the
DisplayResourceProvider will say "oh, you already have access, I'll
skip the BeginSharedImageAccess call". Which means no copy, and
random texture contents.

To fix this, detect the case of transitioning from OVERLAY to READ
access, and do a EndSharedImageAccess followed by a new
BeginSharedImageAccess.

This is all fairly horrible. Once we move everything to the
SkiaRenderer, then we can remove the OVERLAY GL parameter and
forget that this episode ever existed.

(cherry picked from commit 9ce8a0084b60d32795a7a0cc24217f0e51ecdb6c)

Bug: 1113925
Change-Id: I25071324eb49c5fd3026a77c20034c9f5e647328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346843
Commit-Queue: ccameron <[email protected]>
Reviewed-by: Khushal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#796730}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357671
Reviewed-by: ccameron <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1513}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• components/viz/service/display/display_resource_provider.cc[diff]
• components/viz/service/display/display_resource_provider.h[diff]

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-4183-1597383601-76a5b94de790ad71759b5d07edfc2ce6c4e09964.profdata to chrome-mac-4183-1597449227-9fe615dd50e244f9043206576ba37e4bde1ce3c5.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ib7f8d528510a0040ed222bc5426211bb6c8b9abd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358511
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1512}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/mac.pgo.txt[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597401164-5884785c293ea1d1f6be7f4817c5a255bd2bf30d.profdata to chrome-win32-4183-1597418154-7ae2bef4785a1bb23b764164f5ab16f1980fcf2f.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I5be37bc7a905ade162a8714502355d8a5ab5ccbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357550
Commit-Queue: chromium-autoroll <[email protected]>
Reviewed-by: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1511}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

Incrementing VERSION to 85.0.4183.72

[email protected]

Change-Id: I6b104d1e3bee8ac5d0dc8f917d0dda9b9470d307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358469
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#1510}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/VERSION[diff]

Updating XTBs based on .GRDs from branch 4183

[email protected]

Change-Id: I9367563857dd688a6281d83c5ad38453f41371e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357951
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1509}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• ash/shortcut_viewer/strings/shortcut_viewer_strings_as.xtb[diff]
• ash/shortcut_viewer/strings/shortcut_viewer_strings_bn.xtb[diff]
• ash/shortcut_viewer/strings/shortcut_viewer_strings_fr.xtb[diff]
• ash/shortcut_viewer/strings/shortcut_viewer_strings_gu.xtb[diff]
• ash/shortcut_viewer/strings/shortcut_viewer_strings_nl.xtb[diff]
• ash/shortcut_viewer/strings/shortcut_viewer_strings_sv.xtb[diff]
• ash/shortcut_viewer/strings/shortcut_viewer_strings_ta.xtb[diff]
• ash/shortcut_viewer/strings/shortcut_viewer_strings_te.xtb[diff]
• ash/strings/ash_strings_as.xtb[diff]
• ash/strings/ash_strings_bn.xtb[diff]
• ash/strings/ash_strings_gu.xtb[diff]
• ash/strings/ash_strings_ta.xtb[diff]
• ash/strings/ash_strings_te.xtb[diff]
• chrome/app/resources/generated_resources_as.xtb[diff]
• chrome/app/resources/generated_resources_bn.xtb[diff]
• chrome/app/resources/generated_resources_bs.xtb[diff]
• chrome/app/resources/generated_resources_ca.xtb[diff]
• chrome/app/resources/generated_resources_cs.xtb[diff]
• chrome/app/resources/generated_resources_de.xtb[diff]
• chrome/app/resources/generated_resources_fr.xtb[diff]
• chrome/app/resources/generated_resources_gu.xtb[diff]
• chrome/app/resources/generated_resources_kn.xtb[diff]
• chrome/app/resources/generated_resources_nl.xtb[diff]
• chrome/app/resources/generated_resources_ru.xtb[diff]
• chrome/app/resources/generated_resources_sv.xtb[diff]
• chrome/app/resources/generated_resources_ta.xtb[diff]
• chrome/app/resources/generated_resources_te.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_as.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_bn.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_gu.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_nl.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_ta.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_te.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_as.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_bn.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_bs.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_gu.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_nl.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ta.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_te.xtb[diff]
• chromeos/components/camera_app_ui/resources/src/strings/camera_strings_fr.xtb[diff]
• chromeos/components/camera_app_ui/resources/src/strings/camera_strings_nl.xtb[diff]
• components/browser_ui/strings/android/translations/browser_ui_strings_as.xtb[diff]
• components/browser_ui/strings/android/translations/browser_ui_strings_bn.xtb[diff]
• components/browser_ui/strings/android/translations/browser_ui_strings_gu.xtb[diff]
• components/browser_ui/strings/android/translations/browser_ui_strings_kn.xtb[diff]
• components/browser_ui/strings/android/translations/browser_ui_strings_ta.xtb[diff]
• components/browser_ui/strings/android/translations/browser_ui_strings_te.xtb[diff]
• components/strings/components_strings_kn.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_as.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_bn.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_gu.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_kn.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_ta.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_te.xtb[diff]
• ui/chromeos/translations/ui_chromeos_strings_as.xtb[diff]
• ui/chromeos/translations/ui_chromeos_strings_bn.xtb[diff]
• ui/chromeos/translations/ui_chromeos_strings_gu.xtb[diff]
• ui/chromeos/translations/ui_chromeos_strings_ta.xtb[diff]
• ui/chromeos/translations/ui_chromeos_strings_te.xtb[diff]
• ui/strings/translations/ui_strings_as.xtb[diff]
• ui/strings/translations/ui_strings_bn.xtb[diff]
• ui/strings/translations/ui_strings_gu.xtb[diff]
• ui/strings/translations/ui_strings_ta.xtb[diff]
• ui/strings/translations/ui_strings_te.xtb[diff]

Fix grey bar when viewing local capture in Google Meet

Meet gives an option to request video quality of 360. Not all cameras
will natively return a height-360 size, so Chrome will go with the
next-biggest capture size, and letterbox-and-scale the video frame.

On the machine where I reproduced this, the media::VideoFrame had the
following attributes.
- visible_rect:0,60 640x360
- natural_size:640x360
- coded_size:640x480

This exposed the following bug in the combination of the functions
VideoResourceUpdater::CreateForSoftwarePlanes and
PaintCanvasVideoRenderer::Copy.
* The function VideoResourceUpdater::CreateForSoftwarePlanes creates a
  resource of size |coded_size|, and expects that
  PaintCanvasVideoRenderer::Copy will populate the |visible_rect|
  sub-rectangle of that resource.
* PaintCanvasVideoRenderer::Copy actually copies not to |visible_rect|,
  but rather to rectangle at (0,0) that has the size of |visible_rect|.

The consequence is that we end up viewing the resource through a
misaligned letterbox.

The fix is is to inline PaintCanvasVideoRenderer::Copy (which is only a
few lines long) in VideoResourceUpdater::CreateForSoftwarePlanes, and
specify the correct destination rectangle.

Also add some comments to clarify the function's behavior. Note that
this behavior was switched in crrev.com/545920.

[email protected]

(cherry picked from commit e3e055a5060de18fd6a4452b73e12f3fdfb5d18d)

Bug: 1090435
Change-Id: Icef81728defc0cf46b35180dada5d68f24e6b21d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318313
Auto-Submit: ccameron <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Commit-Queue: ccameron <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#791480}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357670
Reviewed-by: ccameron <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1508}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• media/renderers/paint_canvas_video_renderer.h[diff]
• media/renderers/video_resource_updater.cc[diff]

[ios] Early return if webState is not valid

Sometimes [ToolbarMediator updateShareMenuForWebState:]
is passed a null WebState, so do nothing if that is the case.

[email protected]

(cherry picked from commit c751db7dc96d2bda5d1a04dc12f49e650ab0bfbb)

Bug: 
Change-Id: Id083687df59199489a80ca21a9182113e2ad62ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354710
Auto-Submit: Chris Lu <[email protected]>
Reviewed-by: Sergio Collazos <[email protected]>
Commit-Queue: Chris Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#797763}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358049
Reviewed-by: Chris Lu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1507}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• ios/chrome/browser/ui/toolbar/toolbar_mediator.mm[diff]

Switch GetNetworkList to use getifaddrs() on Android N+

Previous implementation used RTM_GETLINK which is no longer supported
in Android 11 as per https://developer.android.com/preview/privacy/mac-address
I verified the results roughly the same on my Pixel 2.

(cherry picked from commit 3a754978b2e628ba70d69e427ff4d13e1defbd91)

Bug: webrtc:11775
Change-Id: I8c152823b3921d483aaec9c281c09720f17e6263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297712
Commit-Queue: Zhongyi Shi <[email protected]>
Reviewed-by: Zhongyi Shi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#791446}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357252
Reviewed-by: Paul Jensen <[email protected]>
Commit-Queue: Paul Jensen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1506}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• net/BUILD.gn[diff]
• net/base/address_tracker_linux.cc[diff]
• net/base/address_tracker_linux_unittest.cc[diff]
• net/base/network_interfaces_getifaddrs.cc[diff]
• net/base/network_interfaces_getifaddrs.h[diff]
• net/base/network_interfaces_linux.cc[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597401164-99fa40fee33d0badbbb9d1781d3bdb90332b4246.profdata to chrome-win64-4183-1597418154-349d1e02740dfbe0782a5c2a14bee3818cf80185.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I3a69cc72deaeec5021a64c416d7e1f6b798e4a51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357510
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1505}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

Add a param for controlling default browser promo on P- and no default

(cherry picked from commit 4121f6fda23d9a7747a3914aa80fa45ee435307d)

Bug: 1116309
Change-Id: I5e0a52c07a81336ef11329993676766613a7b06e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355573
Commit-Queue: Lijin Shen <[email protected]>
Reviewed-by: Theresa  <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#798052}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357129
Cr-Commit-Position: refs/branch-heads/4183@{#1504}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/ui/android/default_browser_promo/java/src/org/chromium/chrome/browser/ui/default_browser_promo/DefaultBrowserPromoManager.java[diff]
• chrome/browser/ui/android/default_browser_promo/java/src/org/chromium/chrome/browser/ui/default_browser_promo/DefaultBrowserPromoUtils.java[diff]

Roll ChromeOS Broadwell AFDO profile from 85-4183.48-1597052943-benchmark-85.0.4183.69-r1 to 85-4183.48-1597052943-benchmark-85.0.4183.71-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: I4c5a2ff0ce574b2da3c86fc211c093cba20f4720
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357594
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1503}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/broadwell.afdo.newest.txt[diff]

Roll ChromeOS Silvermont AFDO profile from 85-4183.57-1597056056-benchmark-85.0.4183.69-r1 to 85-4183.57-1597056056-benchmark-85.0.4183.71-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: I3ba7fa2f8504a2112a743ca1123e4c3e2ad6161a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357592
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1502}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/silvermont.afdo.newest.txt[diff]

Add use counter for comma as separator in allow attribute.

Bug: 1062400
Change-Id: I787f4996c76946b53e67122672ef085036ee33c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323821
Reviewed-by: Yoav Weiss <[email protected]>
Commit-Queue: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/heads/master@{#792348}
(cherry picked from commit 9ed18b4e3a87fa956ac1bf98190f14772e80d6c8)


[email protected]

Change-Id: I995af46e63b08f83d5e523aedd061abefae8dbe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356605
Reviewed-by: Ian Clelland <[email protected]>
Commit-Queue: Ian Clelland <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1501}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• third_party/blink/public/mojom/web_feature/web_feature.mojom[diff]
• third_party/blink/renderer/core/html/html_iframe_element.cc[diff]
• third_party/blink/renderer/core/html/html_iframe_element_test.cc[diff]
• tools/metrics/histograms/enums.xml[diff]

Roll ChromeOS Airmont AFDO profile from 85-4183.57-1597054331-benchmark-85.0.4183.69-r1 to 85-4183.57-1597054331-benchmark-85.0.4183.71-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: Ib3f88dec1c4e2970217bad1b297e7e5e510ee18a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357590
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1500}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/airmont.afdo.newest.txt[diff]

Update settings-dropdown-menu to observe array mutations of menuOptions

Currently changes to menuOptions via array mutations do not cause
shouldDisableMenu_() to be called again. In particular, this causes
and issue with the resolution dropdown for CrOS Display Settings since
we rebuild the list of resolutions by assigning an empty array and then
calling the 'push' array mutation.

(cherry picked from commit b060adce8ea864059ed5fdaa0c38044bd2ac53e9)

Fixed: 1105149
Change-Id: I9e275454254af56ea3aab5f83176a51cd447d0c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327790
Commit-Queue: Bailey Berro <[email protected]>
Auto-Submit: Bailey Berro <[email protected]>
Reviewed-by: Kyle Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#793154}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356270
Reviewed-by: Bailey Berro <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1499}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/resources/settings/controls/settings_dropdown_menu.html[diff]

Handle immersive mode in WebUI tab strip's autoclose behavior

In immersive mode, the toolbar floats on top of the tab content. Their
bounds intersect.

The WebUI tab strip would autoclose whenever an event occured inside the
tab content's bounds. However, this didn't consider if the event would
ultimately be delivered to browser UI instead.

This CL lets events whose locations are in the toolbar pass through. It
also adds test coverage for these behaviors.

A more robust solution would consider the event's target window rather
than just its location, but this is more complex. For now these bounds
checks should be sufficient.

(cherry picked from commit 369a40b00c1268c6f8e59bb4a409ce68d3aec3ac)

Bug: 1112028
Change-Id: I99ea8942171848c903c385e875b9c573fa2bf1c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339591
Commit-Queue: Collin Baker <[email protected]>
Reviewed-by: Peter Boström <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#795659}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356932
Reviewed-by: Collin Baker <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1498}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/ui/views/frame/browser_view.cc[diff]
• chrome/browser/ui/views/frame/webui_tab_strip_container_view.cc[diff]
• chrome/browser/ui/views/frame/webui_tab_strip_container_view.h[diff]
• chrome/browser/ui/views/frame/webui_tab_strip_interactive_uitest.cc[diff]

Ensure web_contents is non-null before TabAndroid::FromWebContents

(cherry picked from commit f6bfdab230f7f07b5c048ff9b9c08961d1bda8c0)

Bug: 1094885
Change-Id: Ie3fb46b2fb7029671f91612fefee7fcb2352a613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353012
Reviewed-by: Theresa  <[email protected]>
Commit-Queue: Brandon Wylie <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#797438}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357109
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Brandon Wylie <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1497}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/chrome_content_browser_client.cc[diff]

[M85 cherry-pick] Guard against MakePromiseSkImageFromRenderPass failure

SkDeferredDisplayListRecorder::makePromiseTexture can fail for a
variety reasons (in the repro case the requested width/height is
320/10048 while the max texture size is 8192) so try to fail
gracefully.

(cherry picked from commit 729b9b172f364a71a6298a9da8379e31aa4d6842)

Bug: 1068253
Change-Id: I5fcb25343fe397240330e23db902c97cee71c239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351955
Reviewed-by: Peng Huang <[email protected]>
Commit-Queue: Robert Phillips <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#797280}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356790
Reviewed-by: Robert Phillips <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1496}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• components/viz/service/display/skia_renderer.cc[diff]
• components/viz/service/display_embedder/skia_output_surface_impl.cc[diff]

Add a WebLayer API to prewarm a spare renderer process.

(cherry picked from commit 78fcc39954e1ef34bfd20b19654390ef706329e9)

Bug: 1114946
Change-Id: Id73c5537ab2de1912af57e3235e88adcdb52016c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343770
Commit-Queue: John Abd-El-Malek <[email protected]>
Reviewed-by: Darin Fisher <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#797754}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357069
Reviewed-by: John Abd-El-Malek <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1495}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• weblayer/browser/java/org/chromium/weblayer_private/ProfileImpl.java[diff]
• weblayer/browser/java/org/chromium/weblayer_private/interfaces/IProfile.aidl[diff]
• weblayer/browser/profile_impl.cc[diff]
• weblayer/browser/profile_impl.h[diff]
• weblayer/public/java/org/chromium/weblayer/Profile.java[diff]
• weblayer/public/profile.h[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597383601-6e196060e35f4d140a03d9ab3bf99e4c72e82c4e.profdata to chrome-win32-4183-1597401164-5884785c293ea1d1f6be7f4817c5a255bd2bf30d.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I53d93c393b23ec8601f8439be59a0b75b2834d54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355560
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1494}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597383601-6aa8b25107a214eec4ae3431d5a647714a9975f2.profdata to chrome-win64-4183-1597401164-99fa40fee33d0badbbb9d1781d3bdb90332b4246.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ic3cf1f98842471c15105151193ad748df8fe5fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355562
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1493}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

[iOS][Omnibox] Check paste availability without checking contents

On iOS 14, using pasteboard.string triggers a notification saying that
the app pasted. There is a better property hasStrings that doesn't
trigger this notification. It is also the recommended way from Apple
to check if the pasteboard contains any strings.

(cherry picked from commit 8810c74e71213d89ee8df58e49bcf296c44e1b05)

Bug: 1110848
Change-Id: Ia892c76ee17d5230582e8907db927ad3a27e82b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351832
Reviewed-by: Stepan Khapugin <[email protected]>
Commit-Queue: Robbie Gibson <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#797639}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356524
Reviewed-by: Robbie Gibson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1492}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597333722-100d6802f59d966733da4caaebf73c7581587112.profdata to chrome-win64-4183-1597383601-6aa8b25107a214eec4ae3431d5a647714a9975f2.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I0bd586aa00670c36632d5ee6a67a126ad4054172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355836
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1491}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597361872-5c043a22c745770d04f076bb1a244c22eaaf9c88.profdata to chrome-win32-4183-1597383601-6e196060e35f4d140a03d9ab3bf99e4c72e82c4e.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ida0f96aae04c0ae64c209435463dd0e3df74f666
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355835
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1490}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

[merge m85][blink scheduler] Disable all throttling on pages using WebRTC.

A page that uses WebRTC may use a timer to poll video frames and do
video processing on them. Very often, these pages are already opted-out
from throttling because they play audio. However, to allow them to
work reliably when silent (e.g. when other participants stop talking
for a few seconds), this CL disables all throttling for pages using
WebRTC.

In the long-term, there should be an event-based mechanism to do
video processing on frames when they become available. When this
mechanism is available, this policy will be revisited.

This policy is controlled by a base::Feature so we can assess its
impact on performance.

(cherry picked from commit 66c328cbdda0671da2978ba2f422942025240883)

Bug: 1101731,b/159893852
Change-Id: I6d7e98c544d65223fbbad41148ec201c83a63f7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280161
Reviewed-by: Florent Castelli <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Reviewed-by: Kentaro Hara <[email protected]>
Commit-Queue: François Doray <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787738}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354670
Cr-Commit-Position: refs/branch-heads/4183@{#1489}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• third_party/blink/common/features.cc[diff]
• third_party/blink/public/common/features.h[diff]
• third_party/blink/renderer/modules/peerconnection/adapters/ice_transport_proxy.cc[diff]
• third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc[diff]
• third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc[diff]
• third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h[diff]
• third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc[diff]
• third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc[diff]
• third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h[diff]
• third_party/blink/renderer/platform/scheduler/public/scheduling_policy.h[diff]

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-4183-1597361872-44dfb46f69cb10eb22849fd408390b8af381ab57.profdata to chrome-mac-4183-1597383601-76a5b94de790ad71759b5d07edfc2ce6c4e09964.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I11e6bf9dab6440ccd7c95d26002c2f89472e9431
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355824
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1488}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/mac.pgo.txt[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597333722-978a264369be23365fccdd7cb0f0a41f1030f853.profdata to chrome-win32-4183-1597361872-5c043a22c745770d04f076bb1a244c22eaaf9c88.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I764f21db7445bda18f3515c2134a6bf3be39bd31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355126
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1487}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

Updating XTBs based on .GRDs from branch 4183

[email protected]

Change-Id: I64db6c2ecd51efc9a73863d36aff1e5d3de271ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355251
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1486}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• ash/shortcut_viewer/strings/shortcut_viewer_strings_de.xtb[diff]
• ash/strings/ash_strings_de.xtb[diff]
• chrome/app/resources/chromium_strings_eu.xtb[diff]
• chrome/app/resources/generated_resources_de.xtb[diff]
• chrome/app/resources/generated_resources_sk.xtb[diff]
• chrome/app/resources/generated_resources_zh-TW.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_ca.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_de.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_de.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_sk.xtb[diff]
• components/browser_ui/strings/android/translations/browser_ui_strings_de.xtb[diff]
• components/strings/components_strings_de.xtb[diff]
• ios/chrome/app/strings/resources/ios_strings_de.xtb[diff]
• third_party/libaddressinput/chromium/resources/address_input_strings_id.xtb[diff]
• ui/chromeos/translations/ui_chromeos_strings_de.xtb[diff]
• ui/strings/translations/ui_strings_de.xtb[diff]

Disable UIL-FST by default on M-85.

Bug: b:162183648
Change-Id: I7d3bfeba05495e0c74a7f59aa6e03b9982c37770
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348237
Commit-Queue: My Nguyen <[email protected]>
Reviewed-by: My Nguyen <[email protected]>
Reviewed-by: David Vallet <[email protected]>
Reviewed-by: Darren Shen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1485}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/constants/chromeos_features.cc[diff]

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-4183-1597333722-7a2197dd48b193e4d11c6d3d37a05fd5d361df16.profdata to chrome-mac-4183-1597361872-44dfb46f69cb10eb22849fd408390b8af381ab57.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I8a1511071e1e4c10c010d76a6c8a17f8ec81c693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355269
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1484}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/mac.pgo.txt[diff]

Incrementing VERSION to 85.0.4183.71

[email protected]

Change-Id: I4ba39f805613ef2f095509f8072aba14141c8132
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354425
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#1483}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/VERSION[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597317393-bdc91d1ec38c62d3f413d23dc593ccd7596c51d4.profdata to chrome-win32-4183-1597333722-978a264369be23365fccdd7cb0f0a41f1030f853.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I3a90a698269fc303ee15ac0427dbc724f580b001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355029
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1482}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

[M85] RFHI: Refresh feature policy after learning a new frame's origin

This is a merge of a fix to a long-standing bug with inconsistent
Feature Policy state between the renderer and the browser in some same-
origin subframes that have not committed navigations. It manifested
itself during a gradual rollout of a feature in M84. We mitigated the
resulting crashes in M84 with a change partly disabling a server-side
rollout config, and got approval to merge the fix to M85 in order to
unblock the rollout.

Merge approval: https://crbug.com/1111735#c43
Deltas with original CL: only tests, to accommodate some M85->M86
differences in test scaffolding and Trust Token API syntax. Confirmed
locally that the test fails without the functional change in place.

-- Original CL message:

The browser's views of certain same-origin subframes' feature policies
can disagree from the values available to a well-behaved renderer,
erroneously triggering this renderer kill. This is because not all
same-origin subframes commit navigations, but the Feature Policy code in
RenderFrameHostImpl depends on a call to DidNavigate to update RFHI's
|feature_policy_| member after learning a new frame's origin. For frames
that don't see DidNavigate calls, RFHI::feature_policy_ ends up in a
state that can disagree with the renderer-side feature policy state for
the same frame, stored in blink::SecurityContext.

This change adds a fix by adding a call to ResetFeaturePolicy to
RFHI::SetOriginAndIsolationInfoOfNewFrame, which is the first time that
the browser's representation of a new frame learns the frame's origin.
This allows computing a correct feature policy for features whose
values depend on the frame origin. (Currently, we compute the policy
before knowing the origin, which leads to the problematic inconsistent
state.)

(cherry picked from commit 35460b0e4f4262341af56d699f9e4512fc0d8f74)

Bug: 1112959, 1111735
Test: Add a browser test that crashes before the fix and passes after
Change-Id: Ic3c42fbf10a468d230d85981eba10b4be4533307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335910
Reviewed-by: Łukasz Anforowicz <[email protected]>
Reviewed-by: Charlie Hu <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Commit-Queue: David Van Cleve <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#795625}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354514
Reviewed-by: Alex Moshchuk <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1481}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• content/browser/frame_host/render_frame_host_impl.cc[diff]
• content/browser/frame_host/render_frame_host_impl.h[diff]
• content/test/data/page-executing-trust-token-signing-from-204-subframe.html[Added - diff]
• content/test/trust_token_browsertest.cc[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597293047-6f493514a8c174c5f67428e410d157fa92f7f235.profdata to chrome-win64-4183-1597333722-100d6802f59d966733da4caaebf73c7581587112.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I7c0f67e11a6dd241e5eca6be2b2c888561bf9cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354461
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1480}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

Remove “Open” Context Menu option for Javascript in iframes

Links containing Javascript strings can’t be executed in the source
frame with WKWebView APIs (pre-iOS14) so removing the option from the
context menu is preferable. The user can still copy the javascript from
the link.

(cherry picked from commit ff4573fd4accad665a6564cb9c58dd83243796bb)

Fixed: 1109120
Change-Id: I7744871aeddbf461b9a1d4ea480c5d9bcd02beed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352639
Commit-Queue: Mike Dougherty <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#797589}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354718
Reviewed-by: Mike Dougherty <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1479}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• ios/chrome/browser/ui/browser_view/browser_view_controller.mm[diff]
• ios/web/public/ui/context_menu_params.h[diff]
• ios/web/web_state/context_menu_params.mm[diff]
• ios/web/web_state/context_menu_params_utils_unittest.mm[diff]
• ios/web/web_state/ui/crw_context_menu_controller.mm[diff]
• ios/web/web_state/web_state_delegate_bridge_unittest.mm[diff]

Roll src/third_party/libavif/src/ 01ee4caa5..4cfee6282 (29 commits)

Merge to release branch 4183 for Chromium M85.

https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/01ee4caa5ab5..4cfee6282b97

$ git log 01ee4caa5..4cfee6282 --date=short --no-merges --format='%ad %ae %s'
2020-08-10 ccom Add AVIF_FMT_ZU to fix compiling with non-standard/old compilers (#260)
2020-08-10 wtc Fail if a tile is completely outside grid bounds
2020-08-10 wtc Pass true to avifDecoderDataGenerateImageGridTiles
2020-08-10 wtc Fail if any tile in an image grid is not supported
2020-08-10 wtc Add the disableGridImages setting to avifDecoder
2020-08-10 wtc Update codec_dav1d.c
2020-08-10 wtc Set max image size to 16384 * 16384
2020-08-10 wtc avifImageIdentity8ToRGB8ColorFullRange needs 4:4:4
2020-08-07 wtc Fix incorrect 8-to-16 monochrome YUV conversion
2020-08-06 jdrago Revert "Disable libgav1 until abseil-cpp stops using CMP0077 on newer CMake versions"
2020-08-05 wtc Check out Abseil release tag 20200225.2
2020-08-05 jdrago Update references of VS2017 in comments to VS2019 (minor)
2020-08-05 jdrago v0.8.1
2020-08-05 jdrago Minor changelog tweak
2020-08-05 jdrago Fix incorrect 16-to-8 monochrome YUV conversion
2020-08-03 kornel Make decoding optional
2020-08-03 linkmauve Add an ignoreAlpha field to avifRGBImage
2020-07-28 dnovomesky Save support in gdk-pixbuf component
2020-07-31 jdrago Update changelog
2020-07-31 jdrago Only ever create one iref box, filled with multiple cdsc boxes
2020-07-24 asn cmake: Include avif INTERFACE_INCLUDE_DIRECTORIES first
2020-07-22 asn cmake: Use correct include dir for apps/shared
2020-07-22 dnovomesky Fix a crash in the gdk-pixbuf loader, removed unnecessary asserts
2020-07-21 ccom CMake: Add -Wno-error=c11-extensions for dav1d
2020-07-19 ccom CMake: Set C standard to c99
2020-07-19 ccom CMake: Only enable CXX if using libgav1
2020-07-16 wtc Move ptrU8,ptrV8,ptrU16,ptrV16 out of i for loop
2020-07-17 linkmauve Fix a crash in the gdk-pixbuf loader when error is NULL
2020-07-19 jdrago Disable libgav1 until abseil-cpp stops using CMP0077 on newer CMake versions

Created with:
  roll-dep src/third_party/libavif/src

Disable grid images.

Test:
Manually test with
https://github.com/AOMediaCodec/av1-avif/blob/master/testFiles/Microsoft/Summer_in_Tomsk_720p_5x4_grid.avif

[email protected],[email protected]

(cherry picked from commit 247f7d9577308e465c7952dd7cc7002b27d456e2)

Bug: 1114916
Change-Id: I310959b081803b9e169ad912aaa10ab0077a5ad6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347085
Commit-Queue: Wan-Teh Chang <[email protected]>
Reviewed-by: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#796913}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353340
Commit-Queue: Peter Kasting <[email protected]>
Reviewed-by: Dale Curtis <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1478}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• DEPS[diff]
• third_party/blink/renderer/platform/image-decoders/avif/avif_image_decoder.cc[diff]

[Native Cast MRP] Presentation connection for site-initiated mirroring

Cherrypick into M85. Omitting the mirroring_activity changes as they
were causing merge conflicts and not crucial for the fix, so it's lower
risk to omit them.

Original commit message:
This fixes a regression relative to the extension MRP where we were
establishing a presentation connection only if a client ID is set.
If mirroring is initiated by a site with cast:0F5096E8 there is no
client ID but we still need a presentation connection.

[email protected]

Bug: 1114891, b/163366468
Change-Id: Ia1e4196ca5c36afe20754abd668eb02016c08411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354494
Reviewed-by: Takumi Fujimoto <[email protected]>
Commit-Queue: Takumi Fujimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1477}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/media/router/providers/cast/cast_activity_manager.cc[diff]
• chrome/browser/media/router/providers/cast/cast_activity_manager_unittest.cc[diff]

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-4183-1597317393-67923b32348978f13c4a668af308aed5fbeda9d8.profdata to chrome-mac-4183-1597333722-7a2197dd48b193e4d11c6d3d37a05fd5d361df16.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I8f2e222054b008d7e6d0221f45c3fffb125c6b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354680
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1476}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/mac.pgo.txt[diff]

Revert "[omnibox] Dedup history matches HQP matches."

This reverts commit 14f12b979c0aba04407c2bc1610981c8e3d92f77.

Reason for revert: As mpearson pointed out, this CL has an unintended affect on HQP suggestions.

This is a partial revert. A full revert would fail tests due to other
changes since the original CL landed. This revert keeps test changes
from the original CL and updates another test. Additionally, it retains
a variable rename and formatting change since those have no functional
effect and we prefer the newer versions.

Original change's description:
> [omnibox] Dedup history matches HQP matches.
>
> This CL filters duplicate history matches in
> URLIndexPrivateData::HistoryItemsForTerms used by the HQP. Previously,
> we relied on the autocomplete controller's deduping which
> 1) may affect performance since it occured after additional processing
> of each suggestion (I would guess it's insignificant), and
> 2) prevented the HQP provider from making full use of it's allocated
> per-provider-limit.
>
> Also update a few HQP unit tests.
>
> Bug: 591981
> Change-Id: I1c6ce02050ba1b674e3507368c1a095f5a5b0c6d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219027
> Commit-Queue: manuk hovanesian <[email protected]>
> Reviewed-by: Tommy Li <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#773185}

[email protected],[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

(cherry picked from commit 3646277ba48f1c8bddc6f04500e203048d206926)

Bug: 591981
Change-Id: I00ad1ebdcb40163b0eb488dd5771f1b703566aeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327955
Reviewed-by: Mark Pearson <[email protected]>
Reviewed-by: manuk hovanesian <[email protected]>
Reviewed-by: Justin Donnelly <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Commit-Queue: manuk hovanesian <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#796553}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354615
Cr-Commit-Position: refs/branch-heads/4183@{#1475}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• components/omnibox/browser/history_quick_provider_unittest.cc[diff]
• components/omnibox/browser/url_index_private_data.cc[diff]

Reland "Use only SafeSearch filter for EduCoexistence webview."

This is a reland of b545f5895c1ff5a12a83c82386979e7663dd9145
The original cl failed in the MSAN test in
SupervisedUserNavigationThrottleTest::
AllowEDUCoexistenceInnerWebContents
where the inner WebContents is not attached by the time it is expected to.
This only happens in the MSAN test case. The fix simply delays the test
until it is sure that the inner WebContent is attached.

Bug: 1113054

Original change's description:
> Use only SafeSearch filter for EduCoexistence webview.
>
> This cl fixes the bug where the child user is stuck
> in EDU account addition flow when the user's parental
> control setting is 'Only allow certain sites'.
>
> Inorder to prevent this error from happening we will do
> only safe search filter for the EduCoexistence webview
> and not enforce the 'Only allow certain cites' settings
> potentially set by the child's parents.
>
> "https://accounts.google.com" is manually whitelisted. This
> is because there is a race condition where we don't know
> whether the WebContent is an inner WebContent belonging
> to EduCoexistence flow or not by the time throttling happens.
> This happens because navigation to accounts.google.com is
> started before the <webview> WebContents is attached to
> the outer WebContents hosted by the EduCoexistence flow WebUI.
>
> We are making this exception only to the webview that is present in
> the EDUCoexistence flow. The exception is made because the parent is
> present with the child during the flow. Extending this exception
> to every inner webcontents will may allow the child to break parental
> settings.
>
> Bug: 1079510
> Change-Id: I4f3e65e58537a845613b0c49b03f801f0a3caa08
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316443
> Reviewed-by: Marc Treib <[email protected]>
> Reviewed-by: Aga Wronska <[email protected]>
> Commit-Queue: Yilkal Abe <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#794661}

(cherry picked from commit 87e6cc8e3fbd5246b339429380552357fd21bf22)

Bug: 1079510
Change-Id: Ida69bb2fc63efbdbc3e06365290ddc2aed9790c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338856
Reviewed-by: Marc Treib <[email protected]>
Reviewed-by: Aga Wronska <[email protected]>
Commit-Queue: Yilkal Abe <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#796898}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353398
Reviewed-by: Yilkal Abe <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1474}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/supervised_user/supervised_user_navigation_observer.cc[diff]
• chrome/browser/supervised_user/supervised_user_navigation_throttle.cc[diff]
• chrome/browser/supervised_user/supervised_user_navigation_throttle_browsertest.cc[diff]
• chrome/browser/supervised_user/supervised_user_service.cc[diff]
• chrome/browser/supervised_user/supervised_user_service.h[diff]
• chrome/browser/supervised_user/supervised_user_url_filter.cc[diff]
• chrome/browser/supervised_user/supervised_user_url_filter.h[diff]
• chrome/browser/supervised_user/supervised_user_url_filter_unittest.cc[diff]
• chrome/browser/ui/webui/signin/inline_login_dialog_chromeos.cc[diff]
• chrome/browser/ui/webui/supervised_user_internals_message_handler.cc[diff]
• chrome/common/webui_url_constants.cc[diff]
• chrome/common/webui_url_constants.h[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597293047-81100902d4dc0f954ca8d1da4e08d5c44d1bc030.profdata to chrome-win32-4183-1597317393-bdc91d1ec38c62d3f413d23dc593ccd7596c51d4.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I3e11deabcd44460b3e354f9a10d5d95c7893b8e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354221
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1473}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-4183-1597293047-68a35eff31c51f8c15ade769a390a8631488f3d1.profdata to chrome-mac-4183-1597317393-67923b32348978f13c4a668af308aed5fbeda9d8.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I620072a4839eccd804f5f2e3f27d09d88c1bbb3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354216
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1472}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/mac.pgo.txt[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597274328-9f9d30e010d3a8f8f64e08d522f9b2a2847f3adc.profdata to chrome-win32-4183-1597293047-81100902d4dc0f954ca8d1da4e08d5c44d1bc030.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I6ef28ce6f764206b4f58deaf779fba27727092a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351765
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1471}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597274328-8c5d8bdd4d4f87b42e308eace29a5c80b3110c52.profdata to chrome-win64-4183-1597293047-6f493514a8c174c5f67428e410d157fa92f7f235.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Idcf7cc457311e9529e69221e880c65f17f0acfe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351762
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1470}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-4183-1597253420-96bcc5db03bec5e11f24f1dc426f7821c1854620.profdata to chrome-mac-4183-1597293047-68a35eff31c51f8c15ade769a390a8631488f3d1.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I79bcb3b85f436406f8bc907785c00a52acc2d5fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353713
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1469}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/mac.pgo.txt[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597253420-365d1abe6b478dafc28d3a156fc1c74c01c02a80.profdata to chrome-win32-4183-1597274328-9f9d30e010d3a8f8f64e08d522f9b2a2847f3adc.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ia21d5d63c77a40b392772aee2f7d888be96cd799
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351422
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1468}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597253420-a1ef64c5bc2bc9a15c79e9a479aa7823b3625fb1.profdata to chrome-win64-4183-1597274328-8c5d8bdd4d4f87b42e308eace29a5c80b3110c52.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I77837fc789d2fa631b32a3881c754ccdea30a613
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353729
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1467}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

Allow extension ids for TS Helper and Fleet Monitor

(cherry picked from commit c062dccd0a5c08ee60595106879bc861583fcd6e)

Bug: 1105137
Change-Id: I84440d73d5cb14601e1a559c261c4b17e25d637e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316127
Reviewed-by: Toni Baržić <[email protected]>
Reviewed-by: Mattias Nissler <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#794778}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351501
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1466}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• extensions/common/api/_permission_features.json[diff]

Ash Tray: Add metrics for toggling the integrated privacy screen.

BUG=1057204
[email protected],[email protected]

(cherry picked from commit 8660836ae3b1b8aa4d2ec73a42b6853a1b7a5f8d)

Change-Id: Ie829a462889890d9fe57d47f9043a46759a26b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150077
Commit-Queue: Tim Song <[email protected]>
Reviewed-by: Ahmed Fakhry <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Ahmed Mehfooz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#792418}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353026
Reviewed-by: Tim Song <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1465}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• ash/accelerators/accelerator_controller_impl.cc[diff]
• ash/display/privacy_screen_controller.cc[diff]
• ash/display/privacy_screen_controller.h[diff]
• ash/display/privacy_screen_controller_unittest.cc[diff]
• ash/system/privacy_screen/privacy_screen_feature_pod_controller.cc[diff]
• ash/system/privacy_screen/privacy_screen_toast_controller.cc[diff]
• tools/metrics/histograms/enums.xml[diff]
• tools/metrics/histograms/histograms.xml[diff]

Incrementing VERSION to 85.0.4183.70

[email protected]

Change-Id: I4c4965b777b996a72133cb2263f17310ff174315
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353407
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4183@{#1464}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/VERSION[diff]

Introduce an allowlist for external experiment ids.

The allowlist provides a way to specify which external experiment
ids can be sent and also provides a way to associate a study name
for such external experiment ids.

Since the API now uses an allowlist, its use is no longer restricted
via metrics service accessor, which allows us to simplify the plumbing.

A metrics client API is provided to disable the allowlist, which is
needed for some configurations such as WebLayer.

Additionally, the new allowlist support is implemented behind a
base::Feature, which is off by default in this CL. When the
feature is disabled, the behavior from before is unchanged.

(cherry picked from commit dd6dc05207dbc76d10eb0f9f308ca3809bf47bae)

Bug: 1111941
Change-Id: I63b92254e27a32dd5236c37f0b70fb3683f447e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324172
Commit-Queue: Alexei Svitkine <[email protected]>
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Peter Conn <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#795502}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351396
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1463}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java[diff]
• chrome/browser/android/metrics/uma_session_stats.cc[diff]
• chrome/browser/android/metrics/uma_session_stats.h[diff]
• chrome/browser/metrics/chrome_metrics_service_accessor.cc[diff]
• chrome/browser/metrics/chrome_metrics_service_accessor.h[diff]
• components/metrics/metrics_service.cc[diff]
• components/metrics/metrics_service_accessor.cc[diff]
• components/metrics/metrics_service_accessor.h[diff]
• components/metrics/metrics_service_client.cc[diff]
• components/metrics/metrics_service_client.h[diff]
• components/variations/synthetic_trial_registry.cc[diff]
• components/variations/synthetic_trial_registry.h[diff]
• components/variations/synthetic_trial_registry_unittest.cc[diff]
• components/variations/synthetic_trials.h[diff]
• weblayer/BUILD.gn[diff]
• weblayer/browser/android/metrics/weblayer_metrics_service_accessor.h[Deleted - diff]
• weblayer/browser/android/metrics/weblayer_metrics_service_client.cc[diff]
• weblayer/browser/android/metrics/weblayer_metrics_service_client.h[diff]
• weblayer/browser/weblayer_impl_android.cc[diff]

Disable updating credentials by background thread

(cherry picked from commit a2fd9e8209fe662646499a4e6c6a0042ee304c50)

Bug: 1115255
Change-Id: I29378e7a30a1997480e09580ff172e2e8ac1029b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350112
Commit-Queue: Yusuf Sengul <[email protected]>
Commit-Queue: Rakesh Soma <[email protected]>
Reviewed-by: Rakesh Soma <[email protected]>
Auto-Submit: Yusuf Sengul <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#797011}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353609
Reviewed-by: Yusuf Sengul <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1462}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/credential_provider/gaiacp/gaia_credential_provider.cc[diff]
• chrome/credential_provider/gaiacp/mdm_utils.cc[diff]
• chrome/credential_provider/gaiacp/mdm_utils.h[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597232541-dab1ea1d95dadebe35335556a808b44628d3ad96.profdata to chrome-win32-4183-1597253420-365d1abe6b478dafc28d3a156fc1c74c01c02a80.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ifc9ee1b46ee52bee32ed2023e3b908231f802fa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353311
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1461}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

[tracing] Record host app package name for renderer/browser processes

This change populates host_app_package_name field of the
ChromeProcessDescriptor message. It will be used to match
renderer and browser processes to host apps.

(cherry picked from commit b2fe9f919bcb1a4e4a0382811e042d95b550eb71)

Bug: b/159477965
Change-Id: I49316a2e0e82a67366fa452a03bd795579723be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311125
Commit-Queue: Oksana Zhuravlova <[email protected]>
Reviewed-by: Eric Seckler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#793715}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353350
Reviewed-by: Oksana Zhuravlova <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1460}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• services/tracing/public/cpp/perfetto/trace_event_data_source.cc[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597232541-e72ff887a8e05ca1b026e9122417492bbc0eb17f.profdata to chrome-win64-4183-1597253420-a1ef64c5bc2bc9a15c79e9a479aa7823b3625fb1.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I466d5388fcb8a875f92e9330b960054691d296c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353119
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1459}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

Revert "Use Views context menus on tabstrip on Mac."

This reverts commit 6ed3f7bb4ab31c67e7c06292c69367799e5dc162.

Reason for revert: Decision was made to not use Views context menus on the Mac.

Original change's description:
> Use Views context menus on tabstrip on Mac.
> 
> This was the result of a discussion with ellyjones@ regarding the best
> way to handle features that could only easily be implemented in Views
> that we needed for user education.
> 
> The decision was made that context menus in Top Chrome could be moved to
> Views, but not for web contents and context menus on text fields, which
> would remain in Cocoa to provide visual distinction and to provide
> access to e.g. the system emoji chooser.
> 
> This CL adds a mechanism by which Top Chrome code can force a context
> menu that would otherwise be rendered natively to use Views code
> instead, and applies it to tabstrip context menus.
> 
> (cherry picked from commit e35a8ac49a462dcc291e38172a8be0087b42a318)
> 
> Bug: 1109256
> Change-Id: Ib3c3970f56df0714687aaf87a1267d7ae8e2c17b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317809
> Commit-Queue: Dana Fried <[email protected]>
> Reviewed-by: Elly Fong-Jones <[email protected]>
> Reviewed-by: Peter Boström <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#792451}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330088
> Reviewed-by: Dana Fried <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4183@{#1072}
> Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1109256
Change-Id: I1d2e1a94827193593e6c53cb3217d9bca7d6d837
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350496
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Dana Fried <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1458}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc[diff]
• ui/views/controls/menu/menu_runner.h[diff]
• ui/views/controls/menu/menu_runner_impl_cocoa.mm[diff]

Track HomeToOverview nudge dismiss metrics.

Some metrics are missing for home to overview gesture. This CL adds
metrics to HomeToOverviewController::HideNudge().

(cherry picked from commit 1f763a92330ff6bd402b08f0db616e5506b487c6)

Bug: 1101105
Change-Id: I166cce0a489925f0e03ed61b0808044af35aaea4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293459
Reviewed-by: Yulun Wu <[email protected]>
Reviewed-by: Toni Baržić <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787829}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352616
Cr-Commit-Position: refs/branch-heads/4183@{#1457}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• ash/shelf/home_to_overview_nudge_controller.cc[diff]
• ash/shelf/home_to_overview_nudge_controller_unittest.cc[diff]

Roll ChromeOS Broadwell AFDO profile from 85-4183.48-1597052943-benchmark-85.0.4183.66-r1 to 85-4183.48-1597052943-benchmark-85.0.4183.69-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: I8432ab72abc1c0d6455390ea2204715153d351ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353122
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1456}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/broadwell.afdo.newest.txt[diff]

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-4183-1597190007-27179162254680d523a3ac15493266fc9fda0993.profdata to chrome-mac-4183-1597253420-96bcc5db03bec5e11f24f1dc426f7821c1854620.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ibc43b6089ff520ddfbf88e53efa41b40dd13da2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351755
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1455}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/mac.pgo.txt[diff]

Roll ChromeOS Airmont AFDO profile from 85-4183.57-1597054331-benchmark-85.0.4183.66-r1 to 85-4183.57-1597054331-benchmark-85.0.4183.69-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: Ibbd8d2ac1ab05d05a17a6168d9d2b8d2dd191a5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353120
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1454}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/airmont.afdo.newest.txt[diff]

Measure InAppToHome gesture performed metric.

(cherry picked from commit 21303508fe7728a0f3836a1c27149f7c16c39d0f)

Bug: 1101105
Change-Id: I93d354011c225f9032eeb40407ba5847f16315ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289212
Reviewed-by: Yulun Wu <[email protected]>
Reviewed-by: Toni Baržić <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#787043}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352691
Cr-Commit-Position: refs/branch-heads/4183@{#1453}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• ash/shelf/drag_handle.cc[diff]
• ash/shelf/drag_handle.h[diff]
• ash/shelf/shelf_drag_handle_unittest.cc[diff]
• ash/shelf/shelf_layout_manager.cc[diff]

Remove an unused MetricsServiceAccessor API.

Note: Cherry-picking to M85 as a pre-req for merging the CLs for crbug.com/1111941

(cherry picked from commit 1bdeda31b4e60c781cb4b98da97e823604f582b1)

Bug: None
Change-Id: If395ad9984c944efd609f7ea2c9c86ee3f904d71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324882
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Alexei Svitkine <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#792693}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351167
Reviewed-by: Alexei Svitkine <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1452}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/metrics/chrome_metrics_service_accessor.cc[diff]
• chrome/browser/metrics/chrome_metrics_service_accessor.h[diff]
• components/metrics/metrics_service_accessor.cc[diff]
• components/metrics/metrics_service_accessor.h[diff]
• ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor.cc[diff]
• ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor.h[diff]

Roll ChromeOS Silvermont AFDO profile from 85-4183.57-1597056056-benchmark-85.0.4183.66-r1 to 85-4183.57-1597056056-benchmark-85.0.4183.69-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: I9e5793e3c43cd0e8e3b77fe51a5d179bbe691a44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352368
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1451}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/silvermont.afdo.newest.txt[diff]

Update perfetto version to aa0099498c7e3efbdf0efcd445ab6848e984666a.

which includes this cherry pick:
https://android-review.googlesource.com/c/platform/external/perfetto/+/1398550

on top of the original M85 pinned perfetto version.

The upstream branch in the perfetto repo is this one:
https://android.googlesource.com/platform/external/perfetto/+/refs/heads/chromium/4183

Bug: 1115160
Change-Id: I242c53225e5dd3a4596ce27b8705e00ce8b2ebfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352730
Reviewed-by: Sami Kyöstilä <[email protected]>
Reviewed-by: Oksana Zhuravlova <[email protected]>
Commit-Queue: Eric Seckler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1450}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• DEPS[diff]

Reland "Make intentWithEffect an ObservableSupplier"

This reverts commit 64f3c8ed364fb5a7825a4e2525f8f7448e2b312d.

Reason for revert: Underlying cause patched in https://crrev.com/c/2346950

Original change's description:
> Revert "Make intentWithEffect an ObservableSupplier"
> 
> This reverts commit ad14ecbccd0077b808e74aaadf08854195fde359.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Make intentWithEffect an ObservableSupplier
> > 
> > (cherry picked from commit 8bdfa5937130d7a31b703f9af18971f4971ee5ce)
> > 
> > Bug: 1108189
> > Change-Id: I7e4b8194dcfe0fdb5d815590438ba5a7f60080c4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315538
> > Reviewed-by: David Trainor <[email protected]>
> > Commit-Queue: Patrick Noland <[email protected]>
> > Cr-Original-Commit-Position: refs/heads/master@{#792047}
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341030
> > Reviewed-by: Patrick Noland <[email protected]>
> > Cr-Commit-Position: refs/branch-heads/4183@{#1274}
> > Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}
> 
> [email protected]
> 
> Change-Id: I742235d41f1174e4fe520c738cf739d2f1659b47
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1114156
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343108
> Reviewed-by: Tanmoy Mollik <[email protected]>
> Commit-Queue: Tanmoy Mollik <[email protected]>
> Cr-Commit-Position: refs/branch-heads/4183@{#1310}
> Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

[email protected],[email protected]

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1114156
Change-Id: I130f03af41db8ea56da83d81de536fb51b3454f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351962
Reviewed-by: Patrick Noland <[email protected]>
Commit-Queue: Patrick Noland <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1449}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java[diff]
• chrome/android/java/src/org/chromium/chrome/browser/tabbed_mode/TabbedRootUiCoordinator.java[diff]

Add tests for in app to home gesture metrics.

This CL adds tests for gesture metrics and updates shelf layout manager
to get both in_app and in_tablet_mode from shelf config.

(cherry picked from commit ce00a6a75b6657fd3a1551286e5c1bec74273ed6)

Bug: 1101105
Change-Id: Ib0ad71700f082ea759adc037661327f1d016520b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285289
Reviewed-by: Yulun Wu <[email protected]>
Reviewed-by: Toni Baržić <[email protected]>
Commit-Queue: Yulun Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#786960}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352615
Cr-Commit-Position: refs/branch-heads/4183@{#1448}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• ash/public/cpp/shelf_config.h[diff]
• ash/shelf/drag_handle.cc[diff]
• ash/shelf/in_app_to_home_nudge_controller.cc[diff]
• ash/shelf/shelf_drag_handle_unittest.cc[diff]
• ash/shelf/shelf_layout_manager.cc[diff]

[cc/metrics] Fix UAF in ReportThroughputUkm

After we landed:
https://chromium-review.googlesource.com/c/chromium/src/+/2300402

There were much less crash reports than it used to be. But
we are still seeing reports.

The problem is still use-after-free. As we can see, in the
destructor of LayerTreeHostImpl, we call
    frame_trackers_.SetUkmManager(nullptr);
This sets FrameSequenceTrackerCollection::throughput_ukm_reporter_|
to nullptr. Note that FrameSequenceMetrics has a raw pointer
|throughput_ukm_reporter_| that points to the above, but that
pointer doesn't know that it is nullptr now. So in the
~FrameSequenceMetrics() which calls ReportMetrics, it tries
to use the raw pointer, which causes the problem.

(cherry picked from commit c89c1c9761e526ea07472b7f09822c4f2de333e3)

Bug: 1105854, 1100868, 1077696
Change-Id: I5c2045afd361a527baebce574377fbd43fd32879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309094
Commit-Queue: Xida Chen <[email protected]>
Reviewed-by: vmpstr <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#791571}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351925
Reviewed-by: Sami Kyöstilä <[email protected]>
Reviewed-by: Xida Chen <[email protected]>
Commit-Queue: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1447}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• cc/metrics/frame_sequence_metrics.cc[diff]
• cc/metrics/frame_sequence_metrics.h[diff]
• cc/metrics/frame_sequence_metrics_unittest.cc[diff]
• cc/metrics/frame_sequence_tracker.cc[diff]
• cc/metrics/frame_sequence_tracker.h[diff]
• cc/metrics/frame_sequence_tracker_collection.cc[diff]
• cc/metrics/frame_sequence_tracker_collection.h[diff]
• cc/trees/layer_tree_host_impl.cc[diff]

[cc/metrics] Fix UAF in ReportThroughputUkm

This CL fixes a use-after-free problem in the
ThroughputUkmReporter::ReportThroughputUkm. The root cause of
this problem is that the ThroughputUkmReporter is freed when
this is getting called.

(cherry picked from commit 0d55b1d2de4c1b782a41aaeef94a8fa6260ad86b)

Bug: 1105854, 1100868, 1077696
Change-Id: I514a8012c10680734e97e14b0e731493e9e4eb7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300402
Reviewed-by: vmpstr <[email protected]>
Commit-Queue: Xida Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#789053}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351838
Reviewed-by: Xida Chen <[email protected]>
Reviewed-by: Sami Kyöstilä <[email protected]>
Commit-Queue: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1446}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• cc/metrics/frame_sequence_tracker_collection.h[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597190007-78d9a1947fd15a2468640277eb30ce64c07ff357.profdata to chrome-win32-4183-1597232541-dab1ea1d95dadebe35335556a808b44628d3ad96.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I1cfeeda01c12e92031c909393376d8ab3b849354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352351
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1445}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

Null check in ThroughputUkmReporter::ReportThroughputUkm

It looks like in this function, the ukm_manager_ could be null,
and that could cause crash. I think it is possible being null
when a tab is shutting down and that the ukm_manger_ has
been cleared.

This CL does null check and thus prevent crash.

(cherry picked from commit 16c4ba4889ff0e7cba30cd02df99a3e467691c94)

Bug: 1100868, 1077696
Change-Id: I6efd5064eed1aa60cf45d087677bdb49d08e70b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277348
Reviewed-by: vmpstr <[email protected]>
Reviewed-by: Kevin Ellis <[email protected]>
Commit-Queue: Xida Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#784920}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352238
Reviewed-by: Sami Kyöstilä <[email protected]>
Reviewed-by: Xida Chen <[email protected]>
Commit-Queue: Sami Kyöstilä <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1444}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• cc/metrics/throughput_ukm_reporter.cc[diff]
• cc/metrics/throughput_ukm_reporter.h[diff]

[LiteVideo] Add rebuffer event to blocklist and add to UKM.

This change updates the user blocklist on rebuffer events and updates
the UKM metrics that a rebuffer event occurred.

A future change will add a threshold for the number of rebuffers to be
observed before stopping active throttles rather than immediately.

(cherry picked from commit 01de79ce5e98554ecb639bdc4c5894d30e9a57e1)

Bug: 1097792, 1101563
Change-Id: I4e078a38102c1bc7a8bc12e76bad7edf7caceb03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333741
Reviewed-by: Robert Kaplow <[email protected]>
Reviewed-by: rajendrant <[email protected]>
Reviewed-by: Tarun Bansal <[email protected]>
Reviewed-by: Sophie Chang <[email protected]>
Commit-Queue: Michael Crouse <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#794846}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351371
Reviewed-by: Michael Crouse <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1443}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/data_saver/lite_video_browsertest.cc[diff]
• chrome/browser/lite_video/lite_video_decider.cc[diff]
• chrome/browser/lite_video/lite_video_decider.h[diff]
• chrome/browser/lite_video/lite_video_keyed_service_browsertest.cc[diff]
• chrome/browser/lite_video/lite_video_navigation_metrics.cc[diff]
• chrome/browser/lite_video/lite_video_navigation_metrics.h[diff]
• chrome/browser/lite_video/lite_video_observer.cc[diff]
• chrome/browser/lite_video/lite_video_user_blocklist.cc[diff]
• chrome/browser/lite_video/lite_video_user_blocklist.h[diff]
• chrome/browser/lite_video/lite_video_user_blocklist_unittest.cc[diff]
• tools/metrics/histograms/enums.xml[diff]
• tools/metrics/ukm/ukm.xml[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597211835-514f60e2b1def01778fcabe12478801d1cacd3af.profdata to chrome-win64-4183-1597232541-e72ff887a8e05ca1b026e9122417492bbc0eb17f.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I54ce2cc73ec2ff0e21409afe59cc9090d408fe3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352352
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1442}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

[M85] Ignore second callback call for service worker fetch events

In the previous patch, I added IsCompleted() for early return when
service worker fails to be started and the callback is called.
However, there're a case where Complete() could be called twice but the
IsCompleted() cannot cover. (methods in ResponseCallback can be called
even if there's an error during starting the worker because a fetch
event is dispatched before checking the result of script evaluation, for
instance.)
This CL handles those cases.

(cherry picked from commit a213e6d24cd6c67e1f393519900f866adb0e611b)

Bug: 1106977, 824858
Change-Id: I0f985d8fb8572a8b04f3335cc36aebf71f3b746c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336375
Commit-Queue: Makoto Shimazu <[email protected]>
Auto-Submit: Makoto Shimazu <[email protected]>
Reviewed-by: Matt Falkenhagen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#794421}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351268
Reviewed-by: Makoto Shimazu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1441}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• content/browser/service_worker/service_worker_fetch_dispatcher.cc[diff]
• content/browser/service_worker/service_worker_fetch_dispatcher.h[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597190007-42840301041a5984ac9c10bf839d4700ebade74c.profdata to chrome-win64-4183-1597211835-514f60e2b1def01778fcabe12478801d1cacd3af.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I5f439b6509923f25abd3eecfd2f5472364ed3b4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351626
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1440}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

[M85] Fix crashes when starting a worker fails during dispatching fetch event

ServiceWorkerFetchDispatcher now dispatches a fetch event without
waiting for an ACK of start worker message when ServiceWorkerOnUI is
enabled. However, due to the change, ServiceWorkerFetchDispatcher can
invoke a callback twice when starting a worker fails - one for a failure
of start worker and the other for a failure of dispatched event, and
this caused crashes.

This CL added a branch to ignore the latter callback when starting a
worker fails because the error status for starting a worker is more
detailed.

(cherry picked from commit 336a0596d07f54bfa6bd7ed90b355a9e55359646)

Bug: 1106977, 824858
Change-Id: I4cc408a850f40fb3db101584e71eb2164a90c28f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309525
Reviewed-by: Matt Falkenhagen <[email protected]>
Commit-Queue: Makoto Shimazu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#790308}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351600
Reviewed-by: Makoto Shimazu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1439}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• content/browser/service_worker/service_worker_browsertest.cc[diff]
• content/browser/service_worker/service_worker_fetch_dispatcher.cc[diff]
• content/browser/service_worker/service_worker_fetch_dispatcher.h[diff]
• content/browser/service_worker/service_worker_script_cache_map.h[diff]

Roll ChromeOS Airmont AFDO profile from 85-4183.57-1597054331-benchmark-85.0.4183.65-r1 to 85-4183.57-1597054331-benchmark-85.0.4183.66-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: I7594e3b27e0ae468f450227342780047c619d9d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351148
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1438}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/airmont.afdo.newest.txt[diff]

Roll ChromeOS Broadwell AFDO profile from 85-4183.48-1597052943-benchmark-85.0.4183.65-r1 to 85-4183.48-1597052943-benchmark-85.0.4183.66-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: I44fc886c94a0bc5f4eeba73775693487c3f14baa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351145
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1437}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/broadwell.afdo.newest.txt[diff]

[LiteVideo] Add commandline control for downlink bandwidth.

This change adds a commandline switch for controlling the default
donwlink bandwidth. This will be used for testing and local evaluation.

(cherry picked from commit 8c7b5a1300be6fa3a230849d4fedc1c8dbb15968)

Bug: 1112788
Change-Id: Ibe50133f1182506d363a010bbb0194f3fd010520
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336295
Reviewed-by: Sophie Chang <[email protected]>
Reviewed-by: rajendrant <[email protected]>
Auto-Submit: Michael Crouse <[email protected]>
Commit-Queue: rajendrant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#794614}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351715
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: Michael Crouse <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1436}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/lite_video/lite_video_decider.cc[diff]
• chrome/browser/lite_video/lite_video_decider_unittest.cc[diff]
• chrome/browser/lite_video/lite_video_switches.cc[diff]
• chrome/browser/lite_video/lite_video_switches.h[diff]

Roll ChromeOS Silvermont AFDO profile from 85-4183.57-1597056056-benchmark-85.0.4183.65-r1 to 85-4183.57-1597056056-benchmark-85.0.4183.66-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: [email protected]
Change-Id: I01255dab033c94b426602528daa2511de9a40bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351865
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1435}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chromeos/profiles/silvermont.afdo.newest.txt[diff]

Roll Chrome Win32 PGO Profile

Roll Chrome Win32 PGO profile from chrome-win32-4183-1597145849-5eeb842fd5f272b66dda0b2bf8150eb6a7209f04.profdata to chrome-win32-4183-1597190007-78d9a1947fd15a2468640277eb30ce64c07ff357.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: Ie6911591ffaa853b0ad4c7607c0a6e9b487faa34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351621
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1434}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win32.pgo.txt[diff]

[M85] Calling DispatchFetchEvent just after InitializeGlobalScope

Currently, events are dispatched after a service worker is launched.
However, Mojo can enqueue messages before waiting for receiver's being
ready. This CL is to dispatch FetchEvent without waiting for the worker
ready.

This CL adds a state called "is endpoint ready", which means
InitializeGlobalScope is called and ServiceWorkerVersion::endpoint() is
ready to dispatch events. For active workers, InitializeGlobalScope is
called in StartWorker synchronously, and FetchEvent can be dispatched
just after calling ServiceWorkerVersion::RunAfterStartWorker().

This is expected to eliminate performance regression we observed by
enabling ServiceWorkerOnUI because the worker don't have to wait for
OnStarted() message before dispatching an event.

Design doc:
https://docs.google.com/document/d/1VxFWsTOXJyJc7CMp4wxh_z0u8NVPi_7E5Aj6hxf2MUM/edit?usp=sharing

(cherry picked from commit 7ff4f8f5c8d4552f466e50251dab098e2d18eec8)

Bug: 824858
Change-Id: Ib4a5e2778a1beb4ade16cfcf47d4ec7786750cd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279305
Commit-Queue: Makoto Shimazu <[email protected]>
Reviewed-by: Makoto Shimazu <[email protected]>
Reviewed-by: Kenichi Ishibashi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#788995}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351339
Cr-Commit-Position: refs/branch-heads/4183@{#1433}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• content/browser/service_worker/service_worker_browsertest.cc[diff]
• content/browser/service_worker/service_worker_fetch_dispatcher.cc[diff]
• content/browser/service_worker/service_worker_fetch_dispatcher.h[diff]
• content/browser/service_worker/service_worker_version.cc[diff]
• content/browser/service_worker/service_worker_version.h[diff]

[content] Bind PageBroadcast in CreateNewWindow

This CL makes sure that when a tab is created through CreateNewWindow
(e.g. window.open / ctrl+click), a page inside the tab establishes
PageBroadcast mojo connection.

Previously we only established the connection inside RenderViewHostImpl
::CreateRenderView, but with CreateNewWindow, we do not go through
CreateRenderView because RenderView is already there and RenderViewHost
is created after that.

Now we establish a connection after browser responds in
CreateNewWindowReply.

(cherry picked from commit d46f498a5c4643696a83eb0fe8e908c4c50ec3f6)

Bug: 1108035,1108947,1108904
Change-Id: I5e10163ba2326f6b07ea5a044db1eff102fa8c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331959
Commit-Queue: Yuzu Saijo <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#794361}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340846
Reviewed-by: Yuzu Saijo <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1432}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• content/browser/frame_host/render_frame_host_impl.cc[diff]
• content/browser/renderer_host/page_lifecycle_state_manager_browsertest.cc[diff]
• content/browser/renderer_host/render_view_host_impl.cc[diff]
• content/browser/renderer_host/render_view_host_impl.h[diff]
• content/common/frame.mojom[diff]
• content/renderer/render_view_impl.cc[diff]

Roll Chrome Win64 PGO Profile

Roll Chrome Win64 PGO profile from chrome-win64-4183-1597168459-5a6cd7c56d61d8c8ddcecbad052a8ac6132e44a4.profdata to chrome-win64-4183-1597190007-42840301041a5984ac9c10bf839d4700ebade74c.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:win64-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I0101f5072cca4c7413e8de7a79165f5be297585d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351448
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1431}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/win64.pgo.txt[diff]

Reland "[LiteVideo] Observe MediaPlayer rebuffer events to stop throttling."

This is a reland of 57fd8da7a27bbaf615106aa354ea8b09c6c1cf96

The browsertest is really flaky because of the timeout. The test is
not there to verify the code being added so I'm going to decouple
adding these tests. I removed or disabled the tests causing failures
so hopefully this resolves it.

Original change's description:
> [LiteVideo] Observe MediaPlayer rebuffer events to stop throttling.
>
> This change adds plumbing to allow the LiteVideo optimization to
> observe when rebuffer events occur so that all throttling can be
> stopped.
>
> A future change will record the even in the user blocklist and
> record the event in UKM.
>
> Bug: 1082554
> Change-Id: I9109fe221800b355e46c78e80254f75f433f9448
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316849
> Reviewed-by: Tarun Bansal <[email protected]>
> Reviewed-by: Kinuko Yasuda <[email protected]>
> Reviewed-by: rajendrant <[email protected]>
> Reviewed-by: Dale Curtis <[email protected]>
> Commit-Queue: Michael Crouse <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#793232}

[email protected],[email protected],[email protected]

(cherry picked from commit e75c7a42b87964e5da67cb432ebfcd076ea03a3d)

Bug: 1082554
Change-Id: I5b11eb841a62b1c90f465c84eb68df6fcd0e573d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332684
Reviewed-by: Michael Crouse <[email protected]>
Commit-Queue: Michael Crouse <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#793751}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350746
Cr-Commit-Position: refs/branch-heads/4183@{#1430}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/data_saver/lite_video_browsertest.cc[diff]
• chrome/browser/lite_video/lite_video_observer.cc[diff]
• chrome/browser/lite_video/lite_video_observer.h[diff]
• chrome/renderer/lite_video/lite_video_hint_agent.h[diff]
• chrome/renderer/previews/resource_loading_hints_agent.cc[diff]
• chrome/renderer/previews/resource_loading_hints_agent.h[diff]
• content/browser/media/media_web_contents_observer.cc[diff]
• content/browser/media/media_web_contents_observer.h[diff]
• content/browser/web_contents/web_contents_impl.cc[diff]
• content/browser/web_contents/web_contents_impl.h[diff]
• content/common/media/media_player_delegate_messages.h[diff]
• content/public/browser/web_contents_observer.h[diff]
• content/renderer/media/renderer_webmediaplayer_delegate.cc[diff]
• content/renderer/media/renderer_webmediaplayer_delegate.h[diff]
• media/blink/webmediaplayer_impl.cc[diff]
• media/blink/webmediaplayer_impl_unittest.cc[diff]
• media/test/data/multi_frame_mse_player.html[Added - diff]
• third_party/blink/public/mojom/loader/previews_resource_loading_hints.mojom[diff]
• third_party/blink/public/platform/media/webmediaplayer_delegate.h[diff]
• third_party/blink/renderer/modules/mediastream/webmediaplayer_ms_test.cc[diff]

Roll Chrome Mac PGO Profile

Roll Chrome Mac PGO profile from chrome-mac-4183-1597168459-9b5ccb36c5ddf92e2f19b06b4f47050ae6f2579b.profdata to chrome-mac-4183-1597190007-27179162254680d523a3ac15493266fc9fda0993.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium-beta
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome-beta
Tbr: [email protected],[email protected],[email protected]
Change-Id: I4442b9578f9e86335ab04859c04a4e0a7e956f76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351084
Reviewed-by: chromium-autoroll <[email protected]>
Commit-Queue: chromium-autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1429}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/build/mac.pgo.txt[diff]

Updating XTBs based on .GRDs from branch 4183

[email protected]

Change-Id: I0efb487f2f4d95852136971fa699c760b2127494
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350312
Commit-Queue: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1428}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• build/android/lint/suppressions.xml[diff]
• chrome/android/features/autofill_assistant/java/strings/translations/android_chrome_autofill_assistant_strings_vi.xtb[diff]
• chrome/android/features/tab_ui/java/strings/translations/android_chrome_tab_ui_strings_vi.xtb[diff]
• chrome/app/resources/generated_resources_af.xtb[diff]
• chrome/app/resources/generated_resources_am.xtb[diff]
• chrome/app/resources/generated_resources_ar.xtb[diff]
• chrome/app/resources/generated_resources_as.xtb[diff]
• chrome/app/resources/generated_resources_az.xtb[diff]
• chrome/app/resources/generated_resources_be.xtb[diff]
• chrome/app/resources/generated_resources_bg.xtb[diff]
• chrome/app/resources/generated_resources_bn.xtb[diff]
• chrome/app/resources/generated_resources_bs.xtb[diff]
• chrome/app/resources/generated_resources_ca.xtb[diff]
• chrome/app/resources/generated_resources_cs.xtb[diff]
• chrome/app/resources/generated_resources_da.xtb[diff]
• chrome/app/resources/generated_resources_de.xtb[diff]
• chrome/app/resources/generated_resources_el.xtb[diff]
• chrome/app/resources/generated_resources_en-GB.xtb[diff]
• chrome/app/resources/generated_resources_es-419.xtb[diff]
• chrome/app/resources/generated_resources_es.xtb[diff]
• chrome/app/resources/generated_resources_et.xtb[diff]
• chrome/app/resources/generated_resources_eu.xtb[diff]
• chrome/app/resources/generated_resources_fa.xtb[diff]
• chrome/app/resources/generated_resources_fi.xtb[diff]
• chrome/app/resources/generated_resources_fil.xtb[diff]
• chrome/app/resources/generated_resources_fr-CA.xtb[diff]
• chrome/app/resources/generated_resources_fr.xtb[diff]
• chrome/app/resources/generated_resources_gl.xtb[diff]
• chrome/app/resources/generated_resources_gu.xtb[diff]
• chrome/app/resources/generated_resources_hi.xtb[diff]
• chrome/app/resources/generated_resources_hr.xtb[diff]
• chrome/app/resources/generated_resources_hu.xtb[diff]
• chrome/app/resources/generated_resources_hy.xtb[diff]
• chrome/app/resources/generated_resources_id.xtb[diff]
• chrome/app/resources/generated_resources_is.xtb[diff]
• chrome/app/resources/generated_resources_it.xtb[diff]
• chrome/app/resources/generated_resources_iw.xtb[diff]
• chrome/app/resources/generated_resources_ja.xtb[diff]
• chrome/app/resources/generated_resources_ka.xtb[diff]
• chrome/app/resources/generated_resources_kk.xtb[diff]
• chrome/app/resources/generated_resources_km.xtb[diff]
• chrome/app/resources/generated_resources_kn.xtb[diff]
• chrome/app/resources/generated_resources_ko.xtb[diff]
• chrome/app/resources/generated_resources_ky.xtb[diff]
• chrome/app/resources/generated_resources_lo.xtb[diff]
• chrome/app/resources/generated_resources_lt.xtb[diff]
• chrome/app/resources/generated_resources_lv.xtb[diff]
• chrome/app/resources/generated_resources_mk.xtb[diff]
• chrome/app/resources/generated_resources_ml.xtb[diff]
• chrome/app/resources/generated_resources_mn.xtb[diff]
• chrome/app/resources/generated_resources_mr.xtb[diff]
• chrome/app/resources/generated_resources_ms.xtb[diff]
• chrome/app/resources/generated_resources_my.xtb[diff]
• chrome/app/resources/generated_resources_ne.xtb[diff]
• chrome/app/resources/generated_resources_nl.xtb[diff]
• chrome/app/resources/generated_resources_no.xtb[diff]
• chrome/app/resources/generated_resources_or.xtb[diff]
• chrome/app/resources/generated_resources_pa.xtb[diff]
• chrome/app/resources/generated_resources_pl.xtb[diff]
• chrome/app/resources/generated_resources_pt-BR.xtb[diff]
• chrome/app/resources/generated_resources_pt-PT.xtb[diff]
• chrome/app/resources/generated_resources_ro.xtb[diff]
• chrome/app/resources/generated_resources_ru.xtb[diff]
• chrome/app/resources/generated_resources_si.xtb[diff]
• chrome/app/resources/generated_resources_sk.xtb[diff]
• chrome/app/resources/generated_resources_sl.xtb[diff]
• chrome/app/resources/generated_resources_sq.xtb[diff]
• chrome/app/resources/generated_resources_sr-Latn.xtb[diff]
• chrome/app/resources/generated_resources_sr.xtb[diff]
• chrome/app/resources/generated_resources_sv.xtb[diff]
• chrome/app/resources/generated_resources_sw.xtb[diff]
• chrome/app/resources/generated_resources_ta.xtb[diff]
• chrome/app/resources/generated_resources_te.xtb[diff]
• chrome/app/resources/generated_resources_th.xtb[diff]
• chrome/app/resources/generated_resources_tr.xtb[diff]
• chrome/app/resources/generated_resources_uk.xtb[diff]
• chrome/app/resources/generated_resources_ur.xtb[diff]
• chrome/app/resources/generated_resources_uz.xtb[diff]
• chrome/app/resources/generated_resources_vi.xtb[diff]
• chrome/app/resources/generated_resources_zh-CN.xtb[diff]
• chrome/app/resources/generated_resources_zh-HK.xtb[diff]
• chrome/app/resources/generated_resources_zh-TW.xtb[diff]
• chrome/app/resources/generated_resources_zu.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_ar.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_tr.xtb[diff]
• chrome/browser/resources/chromeos/accessibility/strings/accessibility_strings_vi.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_af.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_am.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ar.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_as.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_az.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_be.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_bg.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_bn.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_bs.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ca.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_cs.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_da.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_de.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_el.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_en-GB.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_es-419.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_es.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_et.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_eu.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_fa.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_fi.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_fil.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_fr-CA.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_fr.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_gl.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_gu.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_hi.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_hr.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_hu.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_hy.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_id.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_is.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_it.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_iw.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ja.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ka.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_kk.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_km.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_kn.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ko.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ky.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_lo.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_lt.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_lv.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_mk.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ml.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_mn.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_mr.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ms.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_my.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ne.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_nl.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_no.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_or.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_pa.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_pl.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_pt-BR.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_pt-PT.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ro.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ru.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_si.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_sk.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_sl.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_sq.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_sr-Latn.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_sr.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_sv.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_sw.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ta.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_te.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_th.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_tr.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_uk.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_ur.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_uz.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_vi.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_zh-CN.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_zh-HK.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_zh-TW.xtb[diff]
• chrome/browser/ui/android/strings/translations/android_chrome_strings_zu.xtb[diff]
• components/browser_ui/strings/android/translations/browser_ui_strings_es-419.xtb[diff]
• components/policy/resources/policy_templates_vi.xtb[diff]
• components/strings/components_strings_eu.xtb[diff]
• ui/accessibility/extensions/strings/accessibility_extensions_strings_eu.xtb[diff]
• ui/accessibility/extensions/strings/accessibility_extensions_strings_sw.xtb[diff]

M85: Add a file type description when saving edited PDFs.

When calling chrome.fileSystem.chooseEntry() to save edited PDFs, there
is an option for the file types to accept. For each file type, the
description is optional. The API documentation [1] says "if not present,
a description will be automatically generated", but the generated
description ended up being an empty string in this case. Fix this by
manually setting the file type description.

[1] https://developer.chrome.com/apps/fileSystem

(cherry picked from commit 2498c970d7a5a4bca6f45ff95776cdeb543ac84e)

Tbr: [email protected]
Bug: 1114127
Change-Id: If3440fcd13a152bb55e8f80193b4960103776cd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343782
Reviewed-by: Sam McNally <[email protected]>
Commit-Queue: Lei Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#796427}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350137
Reviewed-by: Lei Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4183@{#1427}
Cr-Branched-From: 740e9e8a40505392ba5c8e022a8024b3d018ca65-refs/heads/master@{#782793}

• chrome/browser/resources/pdf/pdf_viewer.js[diff]