Publish DEPS for 81.0.4044.26
Incrementing VERSION to 81.0.4044.26
[email protected]
Change-Id: Iaaa930e39c4008f9ddda9e34de494f3cf5e8873f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063888
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#340}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Collect watchdog V2 metrics on numbers of users who stay in Chrome during the extra wait time
Three histograms are added.
GPU.WatchdogThread.WaitTime.ProgressAfterWait
GPU.WatchdogThread.WaitTime.NumOfUsers
GPU.WatchdogThread.ExtraThreadTime.NumOfUsers
The purpose is to calculate the numbers of users who quit during the
extra wait time. The number of users who quit is equal to the number of
users who stay in Chrome plus the number of users who see the GPU makes
a progress.
(cherry picked from commit d0a2a4dad565a0e6215ff194171e2e6891701bd6)
Bug: 1051178
Change-Id: I1869489fa2bb4ff19c4cc15c1ecefdda11b9a5c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050040
Commit-Queue: Maggie Chen <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741320}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063669
Reviewed-by: Maggie Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#339}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix the get start url logic in AppsNavigationThrottle.
Currently when there is a redirect link open on in new tab (e.g. link
from gmail, youtube sharing link), the get start URL gets empty URL
and hence didn't trigger an app query. The reason is that we were using
the SiteInstance's Site URL. This is no longer working in some cases due
to the site isolation fixes. Change it to use initiator origin from the
NavigationHandle.
BUG=1048042
(cherry picked from commit e89d11fb91ebe0e4458d4ce499e530e9a6bce312)
Change-Id: Ib264d35c31284826dabdfc65056fbc99d5fe9014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055908
Commit-Queue: Maggie Cai <[email protected]>
Reviewed-by: Dominick Ng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741364}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063609
Reviewed-by: Maggie Cai <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#338}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Revert browserAction.setIcon implementation for Extension Service workers.
This CL partially reverts I1bc55cd5da2cc106e8d74dba172122d2bf943d31
that added support for setIcon from Extension Service workers. This
is because setIcon doesn't work for svg images.
This CL also disables the relevant tests
(*/BrowserActionApiLazyTest.Update with Service workers.)
(cherry picked from commit 774f1e702723e0e2e120c3ea9e8727a784d4d4c1)
Bug: 1049214
Test: browser_tests -f *BrowserActionApiLazyTest*:*NavigatingExtensionPopupBrowserTest*:*BrowserActionApiCanvasTest*
Change-Id: Ie3e755c198477b72d27935a54d934bd86dc79c1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042142
Auto-Submit: Istiaque Ahmed <[email protected]>
Commit-Queue: Devlin <[email protected]>
Reviewed-by: Devlin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739384}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063581
Reviewed-by: Istiaque Ahmed <[email protected]>
Commit-Queue: Istiaque Ahmed <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#337}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
crostini: Log failure reason when failing to start Crostini container.
(cherry picked from commit dae6dab115b644671851a19b940898331393d7b9)
Test: Inject a failure and check logs.
Bug: chromium:1048056
Change-Id: Ib48aa40afc15206bf933343091b1c94a55a4ef89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035814
Auto-Submit: David Munro <[email protected]>
Reviewed-by: Nic Hollingum <[email protected]>
Commit-Queue: David Munro <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738040}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063608
Reviewed-by: David Munro <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#336}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Image-Orientation] Fix canvas drawImage
M-81 Merge
Image orientation was not correctly applied in base_rendering_context_2d,
resulting in always oriented images sometimes drawn with the wrong source
rect. This change fixes that.
The image-orientation setting we respect always comes from the canvas
into which the image is being drawn. This keeps the rules for which
orientation to apply simple.
As part of this change, orientation is added to StaticBitmapImage and
used in the necessary cases to track the orientation of the source
image.
As part of this change, the code to correct an image source rect is
moved to Image and callers updated.
(cherry picked from commit 026ec7f0aef60b53bd41296e770e959d7da10230)
TBR: [email protected]
Bug: 1043790
Change-Id: I13d74b66cff912382f8f5efe0050eae6a0f283c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044050
Reviewed-by: Fredrik Söderquist <[email protected]>
Reviewed-by: Xida Chen <[email protected]>
Reviewed-by: Reilly Grant <[email protected]>
Reviewed-by: Fernando Serboncini <[email protected]>
Commit-Queue: Reilly Grant <[email protected]>
Auto-Submit: Stephen Chenney <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741635}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062943
Commit-Queue: Stephen Chenney <[email protected]>
Reviewed-by: Stephen Chenney <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#335}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix crash introduced while cleaning up ui_proxy_config_service.cc
Crash was introduced here:
https://chromium-review.googlesource.com/c/chromium/src/+/1930832
[email protected]
(cherry picked from commit d2f326f225342edd384e704d025b3ea3ad1f9751)
Bug: 1047790
Change-Id: I4a603f4db03209e8e770b045ff981298988ccc74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052201
Reviewed-by: Andreea-Elena Costinas <[email protected]>
Commit-Queue: Steven Bennetts <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741101}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063263
Reviewed-by: Steven Bennetts <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#334}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[search-ranker] Add a UMA metric
This CL adds a UMA metricthat records number of result list launch with
non-empty query. It also makes GetLastQueryLength() returns trimmed
query length instead of raw query length.
[email protected], [email protected]
(cherry picked from commit 0ab877ac6d20457b5a3dbb02836435e53cd92e37)
Bug: 1006133
Change-Id: I42eb211d4b45682ca1b55d66f9a205ab4c0e0f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999967
Commit-Queue: Thanh Nguyen <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Jenny Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740460}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063548
Reviewed-by: Thanh Nguyen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#333}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Tab Groups] Gesture is broken with drag.
Once drag starts, root_view sets the gesture_handler_ to the
TabStrip (through RootView::PreDispatchEvent and
RootView::SetMouseHandler?)so neither the Tab nor the
TabGroupEditorBubble get any gesture events after the MaybeStartDrag.
It also looks like TabStrip itself handles Ending and Continuing drag
(cherry picked from commit b8364f352260964b5a50684a738ded412ec5df7f)
Bug: 1050662,1052205
Change-Id: Ie3ec1fd4b976951819759856d8182bbd32945e6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047989
Commit-Queue: Charlene Yan <[email protected]>
Reviewed-by: Connie Wan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740104}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063258
Cr-Commit-Position: refs/branch-heads/4044@{#332}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Stop observing all animation sequences before deleting
StackedNotificationBarIcon.
Issue 100% reproducible without the fix.
With the fix the crash does not happen.
Confirmed over 3 runs for each case.
(cherry picked from commit 765405775d71f825de36cd066eac147178d753f6)
Bug: 1050685
Change-Id: Id3e5f7204f7f124a1d258b2f45864b451ff6647a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055846
Reviewed-by: Tim Song <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Ahmed Mehfooz <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741586}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063353
Reviewed-by: Ahmed Mehfooz <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#331}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Always set background on every row in the autofill dropdown.
Somehow on Ubuntu it's painted grey by default instead of the background of the
parent view.
(cherry picked from commit 67095eab9a8c333c2320fbff69ef71a64da90a3a)
Bug: 1048598
Change-Id: I1cc98fb839a1f861c42bbea679e6c092c4d03e01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051986
Reviewed-by: Friedrich [CET] <[email protected]>
Commit-Queue: Vasilii Sukhanov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740662}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063035
Reviewed-by: Srinivas Sista <[email protected]>
Commit-Queue: Prudhvi Kumar Bommana <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#330}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge 81]Fix default page break for Krane devices.
Adding default page break too early will cause the default page break
gets deleted immediately.
Now move the installation of default page break after ChromeOS settings
app is installed.
[email protected]
Bug: 1031410
Test: Manual
(cherry picked from commit ace0df391356777f70bda8b9f9ed5551e04636b3)
Change-Id: If8d6522993518ccc109ac0bf368cdd077a97f301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056578
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Long Cheng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#742304}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062919
Reviewed-by: Long Cheng <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#329}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ICU to fix SEGV_MAPERR bug
https://chromium.googlesource.com/chromium/deps/icu.git/+log/dbd3825..9f4020916
(cherry picked from commit 4d09af54617e24ed9969d6f7abb425786c69b993)
Bug: chromium:1044570
Change-Id: If3612265bae968fdb64cbd5eeb3ec9d2e0ce3c4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036515
Commit-Queue: Jungshik Shin <[email protected]>
Reviewed-by: Jungshik Shin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738068}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062096
Reviewed-by: Srinivas Sista <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#328}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Updating XTBs based on .GRDs from branch 4044
[email protected]
Change-Id: I589d99ad2460ada1bcb96c7c38e35b674ec45bdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062895
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#327}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
ThinWebView : Using TextureView for M81
This CL disables SurfaceView for ThinWebView since currently we have an
issue with surface control in Q which breaks this feature.
https://chromium-review.googlesource.com/c/chromium/src/+/2029240 will fix
this, but it will land in M82. Hence disabling SurfaceView for now so
as to unblock features like ephemeral tab.
(cherry picked from commit a41f7d16bbb26f86be581ec02f59d8e7b2f4da3e)
Bug: 1024622
Change-Id: Id6825934bd2270e6b45d66c2f3e9aa6db9dadf76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048507
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Khushal <[email protected]>
Commit-Queue: Shakti Sahu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741207}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062935
Reviewed-by: Shakti Sahu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#326}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4044.5-1581936963-benchmark-81.0.4044.24-r1 to 81-4044.5-1581936963-benchmark-81.0.4044.25-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I77b71fc067d020f8f314d94509e8853d7508bbb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062780
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#325}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge M81][WebLayer] Make error_page_helper handle commands for safebrowsing committed interstitials
MERGE to M81
Some safebrowsing specific interstitial commands do not work in the
current weblayer implementation when committed interstitials are
enabled (kCommittedSBInterstitials).
This patch makes sure to handle safebrowsing specific interstitial
commands such as CMD_OPEN_DIAGNOSTIC and CMD_REPORT_PHISHING_ERROR.
The CMD_OPEN_DIAGNOSTIC command loads "google transparency report"
site with "safe browsing site status". The CMD_REPORT_PHISHING_ERROR
command proceeds to the "report incorrect phishing warning" site.
BUG=1044596,1042662
(cherry picked from commit 35c4015cbe6e8c8622008f53b1dad8d3aa2cfbd9)
Change-Id: I092c3574222f51e30b8c4159eb2fa6e1a4bf0d30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044192
Commit-Queue: Tim Volodine <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Tobias Sargeant <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741076}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062272
Reviewed-by: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#324}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Check for job tracker in list before processing.
(cherry picked from commit 4d1d5527ca593055deed5a4652e0454e97e3bd13)
TBR: [email protected]
Bug: 1052442
Change-Id: I51a9476de93f1401b2de902834849fb031fe7b24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057629
Commit-Queue: Alex Gough <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741597}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060823
Reviewed-by: Alex Gough <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#323}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4044.15-1581938983-benchmark-81.0.4044.24-r1 to 81-4044.15-1581938983-benchmark-81.0.4044.25-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I107f7893511ab56c9d7c4fdee511d0ed8d10a24e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062779
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#322}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4028.0-1581936053-benchmark-81.0.4044.24-r1 to 81-4028.0-1581936053-benchmark-81.0.4044.25-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ie4cba626ee4783a7330af58acbd98bf07ed76ab1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062781
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#321}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[M81] Fix use-after-move in PasswordReuseDetectionManager::OnPaste
Bug: 995566
(cherry picked from commit f70cb75a868c17be8e122dd142896d96ac90db80)
Change-Id: I78f1987c4f1ad1c793eafad34f995ea6d01e6e17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044280
Commit-Queue: Vadym Doroshenko <[email protected]>
Reviewed-by: Vadym Doroshenko <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741008}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061058
Reviewed-by: Xinghui Lu <[email protected]>
Reviewed-by: Bettina Dea <[email protected]>
Reviewed-by: Varun Khaneja <[email protected]>
Commit-Queue: Varun Khaneja <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#320}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Directly write the brand file.
It's possible that there's a newer Chrome already installed on the
target Mac. In that case, the installer will skip the Chrome app
installation, and the postinstall script won't know what brand code
to write. Therefore, bake the brand code into the postinstall script.
(cherry picked from commit 5125e6132ecb47ae8bc38e6a81280d932c4da946)
Bug: 1048228
Tbr: [email protected]
Change-Id: I57857bf5f43804fa4cfb3a552cb3a131e9ee94fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036255
Reviewed-by: Robert Sesek <[email protected]>
Commit-Queue: Avi Drissman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737978}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062094
Reviewed-by: Avi Drissman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#319}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Android line/word backward navigation traverse events not announcing fix
This CL addresses a regression that appeared as part of the change:
https://chromium-review.googlesource.com/c/chromium/src/+/1998829
This CL fixes backwards navigation by granularity of line or word
which was not announcing any traverse events due to a bug in the
above CL.
(cherry picked from commit d7ce96504a25eae3d7c14ce86f4f3ffb4ab08c38)
Bug: 1048246
Change-Id: I128f5e532bf6a6212daae41eb4d571fa7f10bdbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037454
Reviewed-by: Dominic Mazzoni <[email protected]>
Commit-Queue: Mark Schillaci <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738570}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061999
Reviewed-by: Akihiro Ota <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#318}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge to M81] Polish icon drag from applistview to shelf
There are two issues in the current code:
(1) ScrollableShelfView::GetTargetScreenBoundsOfItemIcon is used to
calculate the target bounds of the animation. However, that function
assumes that shelf is horizontally aligned.
(2) ScrollableShelfView::drag_icon_ is created when moving an icon to a
different shelf page. There is an edge case that the user drags an icon
from AppListView and meanwhile drags it to a different page. In this
case, |drag_icon_| is created but never destructed.
This CL fixes the above two issues.
[email protected]
Bug:1052123
(cherry picked from commit bf5d1ae98810dfa677de87c7ce64743f9750732c)
Change-Id: I463bb5a672ed309ee674618c36ae743711927739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053150
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Andrew Xu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741246}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062252
Reviewed-by: Andrew Xu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#317}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge M81][WebLayer] Rename ssl_error_helper to error_page_helper and update comments
MERGE to M81
As noted in comments on crrev.com/c/2003857, safebrowsing commands for
committed interstitials are currently handled by the ssl_error_helper,
which is confusing.
This patch renames the ssl_error_helper to a more generic
error_page_helper and updates the relevant comments.
BUG=1044596,1042662
(cherry picked from commit 86e9ad4e34d43f93e4e560014fa6e73a3cc1bb37)
Change-Id: Iabe7720945361136e1e6ea29548a05c07115a825
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042950
Commit-Queue: Tim Volodine <[email protected]>
Reviewed-by: Carlos IL <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Reviewed-by: Tobias Sargeant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739659}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062432
Reviewed-by: Tim Volodine <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#316}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ChromeOS orderfile from 81-4037.0-1581331510-benchmark-81.0.4044.23-r1 to 81-4044.15-1581938983-benchmark-81.0.4044.24-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I40ab4ea97fd6c2f5cf1eeb32ed7de23e1a90c380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062314
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#315}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[iOS] Fix WebStateDelegateTabHelperTest.GetJavaScriptDialogPresenter
The default cancellation handler is deleted after calling Cancel(),
so the observer needs to be removed before cancellation.
(cherry picked from commit 37e22c2c4e88f9254af477e26fbfb6e1c8bf4da0)
Bug: 1038514
Change-Id: I9a638b9ae7c6c44e4655fb5d80674285620c308d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032062
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: Kurt Horimoto <[email protected]>
Auto-Submit: Kurt Horimoto <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737213}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062452
Reviewed-by: Kurt Horimoto <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#314}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Revert "[CrOS Settings] Prevent pin input from losing focus incorrectly."
This reverts commit 58089b0364100cd47cb02d0321e363a8def1a539.
Reason for revert: Makes the virtual keyboard appears on the pin-pad button tap.
Original change's description:
> [CrOS Settings] Prevent pin input from losing focus incorrectly.
>
> Currently, when any inactive digit area is clicked or tapped in the row
> containers (i.e backbutton when pin is empty or empty digit button
> next to 0), the pin input loses focus momentarily. This CL ensures
> that extraneous clicks on the immediate parent of the digits will not
> cause the pin input form to lose focus.
>
> Fixed: 1034939
> Change-Id: I7d687508944411cb596b1453e3f61eaeb9b9d4b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977746
> Commit-Queue: Regan Hsu <[email protected]>
> Reviewed-by: Steven Bennetts <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#726690}
Bug: 1040309
[email protected],[email protected]
# Not skipping CQ checks because original CL landed > 1 day ago.
(cherry picked from commit d718b38f258f94d50b37f2694496b8c3cddbd014)
Change-Id: I1119573ed79fcf4434d314e67ca6f8d760f6b09a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050499
Reviewed-by: Roman Aleksandrov <[email protected]>
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Commit-Queue: Roman Aleksandrov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741902}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061755
Cr-Commit-Position: refs/branch-heads/4044@{#313}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
ReadableStreamDefaultController: Guard calls to Enqueue() or Close()
ReadableStreamDefaultController::Enqueue() and Close() should not be
called unless ReadableStreamDefaultController::CanCloseOrEnqueue() is
true. Make sure all callers respect this invariant.
BUG=1045931
[email protected]
(cherry picked from commit 6d1511d16f5ba72a2fda52e76722826edb669f10)
Change-Id: Idf46643489232724e624760ce88a624d2508963e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032452
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739798}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060365
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#312}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
QuicTransport: Use WritableStreamDefaultController::ErrorIfNeeded
In QuicTransport::OnConnectionError, use ErrorIfNeeded() rather than
Error(). This is more correct in the case where the stream is already
errored for some reason.
BUG=1045931
TBR=yhirano
(cherry picked from commit aa22abc939d28ef913a0d335c85c9f06fc73c8d6)
Change-Id: I2c4a012f631238780890b88986e880cc242fdcf3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032650
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738107}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060219
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#311}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Streams: Convert state DCHECKs to CHECKs
For "cheap" checks of state in the streams implementation, use CHECKs
instead of DCHECKs. This will improve robustness against logic errors.
BUG=1045931
TBR=yhirano
(cherry picked from commit 122b074f0354079f3d9044cc14890dcfd2d72918)
Change-Id: I01af9c21feca586c74e354faa8f919fbb7565c64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032471
Reviewed-by: Yutaka Hirano <[email protected]>
Commit-Queue: Adam Rice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737234}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060364
Reviewed-by: Adam Rice <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#310}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.25
[email protected]
Change-Id: I9394e3c96bf9ab50ad3e60af1ed9761eeda8607c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061328
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#309}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4037.0-1581332741-benchmark-81.0.4044.23-r1 to 81-4044.5-1581936963-benchmark-81.0.4044.24-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ic0a2bf8465a00072c45ee25447819119d4bd93ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059963
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#308}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4028.0-1581332223-benchmark-81.0.4044.23-r1 to 81-4028.0-1581936053-benchmark-81.0.4044.24-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I8205e68c4ac8d1c3a5f24d6942772584cdb2478b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058785
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#307}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4037.0-1581331510-benchmark-81.0.4044.23-r1 to 81-4044.15-1581938983-benchmark-81.0.4044.24-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I8e569742881982ca2a67a22f91be78425fc6ed50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060747
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#306}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
m81: Fixes speak text under mouse in ChromeVox
(cherry picked from commit 872070178ec67d3a611421d7d8d4951449e41872)
Bug: 1047069
Test: manual (there isn't an easy stable way to test this in either js or interactive ui tests).
Change-Id: Ia91a585ec314066a4cceea244e4872a15598cc9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037731
Reviewed-by: Hiroki Sato <[email protected]>
Commit-Queue: David Tseng <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738577}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060652
Reviewed-by: David Tseng <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#305}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ChromeOS orderfile from 81-4037.0-1581331510-benchmark-81.0.4044.22-r1 to 81-4037.0-1581331510-benchmark-81.0.4044.23-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I7428b0be890db9a65f0c19f4901396ca05814592
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060648
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#304}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Revert "[css-grid] Accommodate spanning items crossing flexible tracks"
This reverts commit 7b72bfb4e734e6216bb76f93230e341f057c8fa1.
Reason for revert: not web compatible, too much breakage
Original change's description:
> [css-grid] Accommodate spanning items crossing flexible tracks
>
> The specification added a step to increase sizes to accommodate spanning
> items crossing flexible tracks instead of ignoring their contents
> completely. This is done after handling all grid items that don't cross
> such tracks, and this time items are considered together, not grouped by
> their span size.
>
> This is a reland of r705228, which was reverted due to a performance
> regression. The main problem was that non-spanning items in flex tracks
> have to be handled with a variant of the algorithm for arbitrary spans,
> which was much slower. But now that has been greatly improved by
> r714511 and r715665. I have also refactored the patch to avoid worsening
> the performance of spanning items that don't cross flex tracks.
>
> However, the algorithm for arbitrary spans is still a bit slower than
> the one for span of 1. Therefore the nested-grid perf test will decrease
> by ~5%. This is expected since it has lots of non-spanning items in
> flexible tracks, that will now be handled with the arbitrary span algo.
>
> Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items
>
> BUG=935102
>
> TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html
> TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html
> TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html
> TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html
>
> Change-Id: I4dfae4a0293aea611b04b59738cfced5e4fe8d44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913406
> Commit-Queue: Oriol Brufau <[email protected]>
> Reviewed-by: Sergio Villar <[email protected]>
> Reviewed-by: Javier Fernandez <[email protected]>
> Reviewed-by: Manuel Rego <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#719104}
[email protected],[email protected],[email protected],[email protected]
(cherry picked from commit 54a70f604d356d735b592d54a091411a499fb9f9)
Bug: 1051039, 935102
Change-Id: I6f1fd18fd8f0f1e43acbac9bb47a6d2925b7c2ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055623
Reviewed-by: Oriol Brufau <[email protected]>
Reviewed-by: Manuel Rego <[email protected]>
Commit-Queue: Oriol Brufau <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741241}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059010
Cr-Commit-Position: refs/branch-heads/4044@{#303}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
cros: Fix title for Recommend Apps screen
Typo in CL:1955728
(cherry picked from commit 83b993b9c72ce720167743968a624c58fa058200)
Bug: 1052792
Change-Id: Ib9d630b8ab1a709f9f43fb6a67e9f131b6e875c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051278
Auto-Submit: Roman Sorokin [CET] <[email protected]>
Commit-Queue: Roman Aleksandrov <[email protected]>
Reviewed-by: Roman Aleksandrov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741022}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058972
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Commit-Queue: Roman Sorokin [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#302}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[crashpad] Use MATCH_UNINSTALLED_PACKAGES for crashpad Java trampoline
If chrome is disabled for a secondary user on N-P, then the package from
which we loaded webview will still have a BuildInfo that reflects the
fact that chrome is the provider, but crashpad isn't able to load the
PackageInfo for it, unless it passes MATCH_UNINSTALLED_PACKAGES, since
the package appears to be uninstalled for the secondary user.
(cherry picked from commit 4506afb467eb771b8e9aa6b6a783aa9ea770838b)
Bug: 1052371
TBR: [email protected]
Test: manual test following steps in bug
Change-Id: I49364bf3f3addb482492a9a2d1c6cdae6b360ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057305
Commit-Queue: Tobias Sargeant <[email protected]>
Reviewed-by: Richard Coles <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741503}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058810
Reviewed-by: Tobias Sargeant <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#301}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Autofill Auth Metrics] Logging auth-method per form submission.
We would like to know the relative conversion rates between CVC and WebAuthn.
This CL introduces metrics that logs which authentication method was used when
a form was submitted.
(cherry picked from commit b4a3bf71d7762468ad6ecf2e1461ff2135473063)
Bug: 1051413
Change-Id: I6c362327b3538b0c8890628316429654e6fae10b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048043
Reviewed-by: Jared Saul <[email protected]>
Reviewed-by: Tommy Martino <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Commit-Queue: Manas Verma <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740548}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055224
Reviewed-by: Manas Verma <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#300}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[settings logging] Log accessibility changes from the system tray.
(cherry picked from commit 12308d918561390bdb3786731fff1b67c07dfc77)
TBR: [email protected]
Bug: 1014839
Change-Id: Icd2ff4b14e42118f05bc964824bea004e3a14bf5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029388
Reviewed-by: Jenny Zhang <[email protected]>
Reviewed-by: Jia Meng <[email protected]>
Commit-Queue: Rachel Wong <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737205}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059035
Reviewed-by: Tony Yeoman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#299}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[settings logging] Add accessibility enum to UKM metrics.
(cherry picked from commit d998cfeb579d6ea61e59fd4cff2519bccea5d5f5)
TBR: [email protected]
Bug: 1014839
Change-Id: I9104d53beebc430a285b570f640d671ffad91c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029387
Reviewed-by: Steven Holte <[email protected]>
Reviewed-by: Tony Yeoman <[email protected]>
Commit-Queue: Rachel Wong <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737197}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059034
Cr-Commit-Position: refs/branch-heads/4044@{#298}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ChromeOS orderfile from 81-4037.0-1581331510-benchmark-81.0.4044.15-r1 to 81-4037.0-1581331510-benchmark-81.0.4044.22-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I921e954ce0f0ebd0872f17306b616f6e043ad5f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059224
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#297}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.24
[email protected]
Change-Id: I136528218ee78b5e979d2b9d73bbb8b8380647b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058832
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#296}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4028.0-1581332223-benchmark-81.0.4044.22-r1 to 81-4028.0-1581332223-benchmark-81.0.4044.23-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ia4ff4d889fe5b44f45a231846dd36495b7b71c62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059341
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#295}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4037.0-1581331510-benchmark-81.0.4044.22-r1 to 81-4037.0-1581331510-benchmark-81.0.4044.23-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3ac1566fa2b3aa21b3fdff864858fe9d33bf8683
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059492
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#294}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4037.0-1581332741-benchmark-81.0.4044.22-r1 to 81-4037.0-1581332741-benchmark-81.0.4044.23-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I89c00299884ae4ede637bb86ca587432d19850b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059491
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#293}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.23
[email protected]
Change-Id: I12d0313ef8739679a07f4009e36f5c535c6dfbfb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059090
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#292}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Android: Animation effect for 'Open In a New Tab' button for Preview Tab
This CL gives animation (alpha) effect to the 'Open in a New Tab' button
on preview tab header when sliding up/down the panel.
[email protected]
(cherry picked from commit 93642db2416c795add037c3993b1b5401bf49235)
Bug: 1047889
Change-Id: I28504f8fd89d8cfe67d5523bdd5e2f186000cbd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032458
Commit-Queue: Jinsuk Kim <[email protected]>
Reviewed-by: Donn Denman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737687}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051647
Reviewed-by: Jinsuk Kim <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#291}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4028.0-1581332223-benchmark-81.0.4044.21-r1 to 81-4028.0-1581332223-benchmark-81.0.4044.22-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: Ie0a0fb9156335bd50f60a6524afad219dcaa33fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058690
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#290}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4037.0-1581332741-benchmark-81.0.4044.15-r1 to 81-4037.0-1581332741-benchmark-81.0.4044.22-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I3bac128e51850872ad6e135b54b95f74604d3adc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058689
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#289}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4037.0-1581331510-benchmark-81.0.4044.21-r1 to 81-4037.0-1581331510-benchmark-81.0.4044.22-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I26d17cd2d4543a43d97b918c2dc109d399eacf58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058361
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#288}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Make tooltip icon (in Incognito NTP) respond to Enter key
(The change is a bug fix. Please refer to bug for details.)
The cookie controls tooltip icon in the Incognito NTP is made to
respond to mouse clicks so that a setting can easily be found.
To improve accessibility, this change makes the icon respond to
Enter key.
(cherry picked from commit e942d725842c0572e99321232541a5d16c6319a9)
Bug: 1048121
Change-Id: I5bb2c5367c6661404131677af3eb3b88cd62b1ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040410
Commit-Queue: Huanzhong Huang <[email protected]>
Reviewed-by: David Tseng <[email protected]>
Reviewed-by: Evan Stade <[email protected]>
Reviewed-by: Christian Dullweber <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740608}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056821
Reviewed-by: Huanzhong Huang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#287}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4028.0-1581332223-benchmark-81.0.4044.15-r1 to 81-4028.0-1581332223-benchmark-81.0.4044.21-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I605095036e260a5be07c68654dcdba49bfcdfba6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058347
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#286}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4037.0-1581331510-benchmark-81.0.4044.15-r1 to 81-4037.0-1581331510-benchmark-81.0.4044.21-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I5eeabb618a998d9b49987619d1614a9bf5395f8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058346
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#285}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge M81] arc: Cleanup merge session for auth context.
This removes merge session stage for auth context preparation once it
is deprecated and source of extra failures.
TEST=Locally
BUG=b:148670963
(cherry picked from commit 8abf1c89f6bf3c8d9c56df63939db9fa60eec7d6)
Change-Id: I61fafb236a83cf2b9e9f1f65cd8ae029c734fe3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048109
Reviewed-by: Xiyuan Xia <[email protected]>
Reviewed-by: Kush Sinha <[email protected]>
Commit-Queue: Yury Khmel <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740305}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057292
Reviewed-by: Yury Khmel <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#284}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.22
[email protected]
Change-Id: Ia36a3bc066dd1c905efd619dfacf39e72b71e34c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058163
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#283}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[ios] Hide the navigation bar when displaying the bug report UI
Since the bug report UI uses a MDCAppBar, hide the navigation bar
when displaying it to avoid having the tile displayed twice which
breaks tests.
(cherry picked from commit 7df5c2e36ed3f5dd2c1e0626350982c7b22f8457)
Bug: 1042741
Change-Id: I8c491be4d8a05ffa71f780896c74cd23c7a988c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048912
Auto-Submit: Sylvain Defresne <[email protected]>
Commit-Queue: Gauthier Ambard <[email protected]>
Reviewed-by: Gauthier Ambard <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740233}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057743
Reviewed-by: Sylvain Defresne <[email protected]>
Commit-Queue: Sylvain Defresne <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#282}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Updating XTBs based on .GRDs from branch 4044
[email protected]
Change-Id: Ia38fae65d435e3a4e321c1ba44f7c154b677ec65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056507
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#281}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Reland "Add DomainDiversityReporter for domain diversity metrics"
This is a reland of 835cde27843d43fc1f2c74ddd98c2c6a373f6e1e
that was previously reverted due to crbug/1048145.
Now LocalMidnight() is not called on the last report time if the
latter was too long ago. This prevents crbug/1048145 where
LocalMidnight() may behave unexpectedly for certain regions
that historically observed a different local time from their
modern timezone.
Original change's description:
> Add DomainDiversityReporter for domain diversity metrics
>
> This CL adds DomainDiversityReporter to schedule domain metrics
> computation tasks and emit histograms. The reporting task is
> executed shortly after startup and then scheduled once per 24
> hours thereafter.
>
> Bug: 1015424
> Change-Id: Id4b8043c1a9b9ea0ee70d4be68e9c35017a82de1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864522
> Commit-Queue: Mingjing Zhang <[email protected]>
> Reviewed-by: Gabriel Charette <[email protected]>
> Reviewed-by: Mark Pearson <[email protected]>
> Reviewed-by: Scott Violet <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#735713}
(cherry picked from commit 939f1542a9d37aec1483eff2efc868c5c9d16e32)
Bug: 1015424
Change-Id: I364f5a5b136d3816daa8e4d2e3d0496c58e80788
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040375
Reviewed-by: Scott Violet <[email protected]>
Reviewed-by: Mark Pearson <[email protected]>
Commit-Queue: Mingjing Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739407}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057102
Commit-Queue: Sadrul Chowdhury <[email protected]>
Reviewed-by: Sadrul Chowdhury <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#280}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Merge to M81: Add pre-finalizer to SpeechSynthesisUtterance.
Avoids a UAF by disconnecting the mojo::Receiver from the pre-finalizer.
(cherry picked from commit b739e83fb99ab2d00d5ed7d029d53d56d42a0fbb)
Bug: 1043603
Tbr: [email protected]
Change-Id: I1592a517bf74dd4fcb8e947e1122442864e0dacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042276
Reviewed-by: Darin Fisher <[email protected]>
Commit-Queue: Dominic Mazzoni <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739140}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057096
Reviewed-by: Dominic Mazzoni <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#279}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[signin] Fix reconcilor loop
This is a speculative fix.
This is a revert of https://chromium-review.googlesource.com/c/chromium/src/+/1831863
on Dice platforms.
This won't fix the underlying bug in reconciliation, but should prevent the
reconcilor from looping in this case.
(cherry picked from commit 10c7348b1940b60a3a36c4ff056081a4867a487f)
(cherry picked from commit c6a0085d83a557d7a2cc307f2c8ea30692686d63)
Bug: 1051864
Change-Id: Ica04d799cb5b159de99f06cab819bf53bef659b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054205
Reviewed-by: Monica Basta <[email protected]>
Commit-Queue: David Roger <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#741039}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053301
Reviewed-by: Srinivas Sista <[email protected]>
Cr-Original-Commit-Position: refs/branch-heads/4057@{#7}
Cr-Original-Branched-From: 272ec7d34b745e1f516312d07823f14ab3baed07-refs/heads/master@{#740899}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057266
Reviewed-by: David Roger <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#278}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll ChromeOS orderfile from 81-4028.0-1580727432-benchmark-81.0.4044.4-r1 to 81-4037.0-1581331510-benchmark-81.0.4044.15-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-orderfile-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
CQ_EXTRA_TRYBOTS=
[email protected]
Change-Id: I719a088c7852db1de7c259db0f7a16c6b19534c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057368
Reviewed-by: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#277}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge] Reland: Sequentialise access to callbacks in DWriteFontLookupTableBuilder
This reland fixes the sequenced task runner initialisation. Set the
task runner in the constructor and reset it for each unit test execution.
Since there may be multiple instance of DWriteFontProxyImpl instantiated
for multiple RenderProcessHosts, and
DWriteFontProxyImpl::GetUniqueNameLookupTable may access
DWriteFontLookupTableBuilder::QueueShareMemoryRegionWhenReady from
separate threads, there may be race conditions around the
pending_callbacks_ member of DWriteFontLookupTableBuilder.
Sequentialise and guard access to pending_callbacks_ with a separate
sequenced task runner.
Remove explicit configuration of the FontUniqueNameBrowserTest cache
directory as [1] introduced a callback function in
ShellContentBrowserClient which sets this correctly. This avoids
instantiating DWriteFontLookupTableBuilder too early when the ThreadPool
is not yet available in a BrowserTest.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/1776358/9/content/shell/browser/shell_content_browser_client.cc#422
(cherry picked from commit d4564dcc2520b00c23c287461f8fa0489e6d1d32)
Fixed: 1047054
Change-Id: I38cf8b84a48315980624b68bbf55d3727be457b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032119
Reviewed-by: Matthew Denton <[email protected]>
Commit-Queue: Dominik Röttsches <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737466}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056810
Reviewed-by: Dominik Röttsches <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#276}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fixes issue with buzzing noise in combination with WebRTC
Avoids usage of an invalid number of input channels (=0) on machines
with a discrete multi channel input channel configuration. Without this
change, the user can experience a loud (buzzing) distorted audio signal.
(cherry picked from commit d454afdce23fdf2c1f24d68b509683f62348f439)
Bug: 1051043, 1051900
Change-Id: I8ebaee33959ae0da50bf93f0756810bc7f524349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054089
Commit-Queue: Henrik Andreasson <[email protected]>
Reviewed-by: Tommi <[email protected]>
Reviewed-by: Olga Sharonova <[email protected]>
Reviewed-by: Guido Urdaneta <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#741046}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056544
Reviewed-by: Henrik Andreasson <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#275}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Autofill Assistant] Use string instead of picture for onboarding title
Currently the title of the onboarding screen is a picture. This cl
changes it to a string so that it can be translated.
(cherry picked from commit 752239fee5a0c3ed4db72dd09d624d594da36167)
Bug: 1049970
Bug: b/142367194
Change-Id: Icd501c7c9d19eaf88c4c91706250a62fb46a7dd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020929
Reviewed-by: Mathias Carlen <[email protected]>
Commit-Queue: Luca Hunkeler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738927}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054252
Reviewed-by: Sandro Maggi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#274}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
enable crostini's arc sideload feature by default
We have tested this feature and need to enable it by default in
preparation for launching it. This should have been done earlier but was
forgotten in error.
(cherry picked from commit 710c43a11780cbe8c976a7c8d5a0ea2123d1f2b5)
Bug: 1033095
Change-Id: I8c85f6a5d4d491eab96f43c59bc733bb6815ab26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044259
Commit-Queue: Nic Hollingum <[email protected]>
Reviewed-by: Fergus Dall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739792}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056004
Commit-Queue: Fergus Dall <[email protected]>
Reviewed-by: David Munro <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#273}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.21
[email protected]
Change-Id: Idbaf88bf0ee9db891ff66af0695fc8d56187b00f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055436
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#272}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge to M81] Structured metrics: Add UMA metrics for usage and errors.
Two questions for metrics team:
1. One of the metrics uses an existing enum,
PersistentPrefStore::PrefReadError, which doesn't have a kMaxValue.
Instead, I've used the old three-argument version of the histogram
macro. Is this okay, or should I make my own enum and use the
two-argument version?
2. I've added the histograms as StructuredMetrics.*, but I'm hesitant
to create a new top-level namespace. Would UMA.StructuredMetrics.*
be better?
(cherry picked from commit f90b244e10d0ed2250bd0f6898307e8222b32ce4)
TBR: [email protected]
Bug: 1051353
Change-Id: I6f51e32100b3e379a01f4e8d2136ba9d4a8d0903
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035475
Commit-Queue: Tony Yeoman <[email protected]>
Reviewed-by: Steven Holte <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740515}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055903
Reviewed-by: Tony Yeoman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#271}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Reland "Don't validate clients for display items copied from cached subsequence"
This is a reland of 0aec6da69cf422ed80e2b743314d1e6d1f3b2b98
This reland reverts the change about paint chunks, and modified the
test to test client of display item only.
Original change's description:
> Don't validate clients for display items copied from cached subsequence
>
> This avoids callbacks to clients that are already validated in the
> previous cycle, and checks or protects from under-invalidation of
> subsequences when any contained client has been deleted.
>
> Bug: 1050090
> Change-Id: I1ba11bd82d64b8e80c09fd6f0dee3ad6924eb161
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033822
> Reviewed-by: Philip Rogers <[email protected]>
> Commit-Queue: Xianzhu Wang <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#739552}
[email protected], [email protected]
(cherry picked from commit 2aaf264e6f60ebc2db2fa857968dffd7d73a9bf2)
Bug: 1050090
Change-Id: I65cfb07520e9fb2b336a3f214c559a609b7d3197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046239
Reviewed-by: Xianzhu Wang <[email protected]>
Commit-Queue: Xianzhu Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739776}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055985
Cr-Commit-Position: refs/branch-heads/4044@{#270}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Add flag for night mode tab reparenting
This flag can be used to turn the feature off if there are problems in
production.
(cherry picked from commit 3c77d4418d4be97ce2775a468e835e93a9b35f80)
Bug: 1031332
Change-Id: I69c158111daccf2c4cc7faf35450b1c55613192a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016205
Commit-Queue: Brandon Wylie <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737495}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054825
Reviewed-by: Brandon Wylie <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#269}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[M81] FileURLLoaderFactory feature to respect isolated_world_origin.
This CL doesn't change the default behavior (as discussed in the bug),
but introduces a feature (disabled by default) that makes
FileURLLoaderFactory respect isolated_world_origin.
(cherry picked from commit 272ec7d34b745e1f516312d07823f14ab3baed07)
Bug: 1049604
Change-Id: Icfa5a473d1105be3da5246f1ced49ca44ed46617
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2046624
Commit-Queue: Łukasz Anforowicz <[email protected]>
Reviewed-by: Łukasz Anforowicz <[email protected]>
Reviewed-by: Charlie Reis <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740899}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054843
Cr-Commit-Position: refs/branch-heads/4044@{#268}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge to M81] Structured metrics: Re-enable launcher collection.
This re-enables the launcher collection that we disabled while moving
from the hashed logging prototype to the structured metrics framework.
All logging is the same, with one exception: we previously had two
metrics aimed at recording which provider a search result comes from,
with each determining about half of the providers. I've simplified this
by combining them into one metric, which records the value of
RankingItemType, the enum we use for type identification for all
on-device models.
To do this I've cleaned up the RankingItemType enum, removing item
types that we no longer use and adding a "don't change this" header.
(cherry picked from commit be04493319715d80cabc6f6b6d4cfedfde68fbd5)
TBR: [email protected], [email protected]
Bug: 1051353
Change-Id: Id04156a4818f842af6489aea23d4048d7aeb4824
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038292
Reviewed-by: Charles . <[email protected]>
Reviewed-by: Jenny Zhang <[email protected]>
Commit-Queue: Tony Yeoman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739241}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053863
Reviewed-by: Tony Yeoman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#267}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Assistant Voice Search] Add colorful flag variant
Replace the regular grey mic with the colorful one. This will allow
experimenting the following configurations:
- Regular voice search, grey mic.
- Assistant voice search, grey mic
- Assistant voice search, colorful mic
To support this addition, I needed to factor out the logic into its own
service which can be used by NewTabPageLayout and LocationBarLayout.
It also increases the modularity of the feature, which will make merges
easier.
(cherry picked from commit 5fe339c375abd365bb5d5a2497366e6fe43bb4fb)
Bug: 1046170,1045203
Change-Id: I728beffa69d0db75eeafd48dcf1918cfacfcbf27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023300
Commit-Queue: Brandon Wylie <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Patrick Noland <[email protected]>
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Ender <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738776}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053114
Reviewed-by: Brandon Wylie <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#266}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Updating XTBs based on .GRDs from branch 4044
[email protected]
Change-Id: Ic4382934538d5919eca510507c1d5d589f867b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055346
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#265}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Don't clip Assistant suggestion chip icons.
Reverts a recent change made for conversation starters which clipped
Assistant suggestion chip icons to a circle. Noticed a few cases where
the clipping looks bad so its better to just update icons on the server
side as needed.
(cherry picked from commit 9d6bea2d7aea8c3fb0d7476dd4483636c0b145d3)
Bug: b:148246719
Change-Id: I95eaf44b1717b34b3816016812ea0e6bb2a8bf38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045199
Reviewed-by: Xiaohui Chen <[email protected]>
Commit-Queue: David Black <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739672}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055051
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#264}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Add support for blurred background to proactive suggestions UI.
Per UX request, this increases readability of the proactive suggestions
UI as it has a semi-transparent background and sits atop other content.
This also helps it to blend more with other system UI.
(cherry picked from commit ed77d71b6d0bc3085a0e1b050143bd3af6fd0f69)
Bug: b:145056104
Change-Id: Idf54bdf68b0cf459ef87484c449db8ad34031709
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044663
Commit-Queue: David Black <[email protected]>
Reviewed-by: Xiaohui Chen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739949}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053149
Commit-Queue: Xiaohui Chen <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#263}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Better handle app list bounds and config changes in apps grid
Fixes few issues that cause problems when device screen is rotated
(which might also cause app list config change) while drag is in
progress:
* Update AppsGridView state in a less destructive manner than
AppsGridView::Update (which recreates all item views, and
does not handle drag_view_ well) - instead it should be
sufficient to update the item icons and relayout the grid
* Clear app list folder drag and selection state when hiding the
folder because the apps container show state changed.
* AppsGridView::UpdateOpacity should not destroy item layers if
a drag is in progress (as layers will still be needed to move
the items around).
* AppsContainerView layout should update the apps grid layout
regardless of show state (as the grid is visible both when a
folder is open and when an folder item is being dragged to be
reparented)
* End app list item drag if mouse capture is lost.
BUG=1049428
[email protected]
(cherry picked from commit 45650c9372d3f14e2c327ccf2a78ff832a9370c9)
Change-Id: I593e3ea5bff6438e6cf09631e2be1e02d994be85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040925
Commit-Queue: Toni Baržić <[email protected]>
Reviewed-by: Xiyuan Xia <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739920}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055183
Reviewed-by: Toni Baržić <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#262}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge M81] Fix WebLayer crashing in Monochrome
WebLayer was crashing in Monochrome because BundleUtils.setIsBundle()
was never called.
This looks like it was caused by http://crrev.com/c/1989243.
[email protected]
(cherry picked from commit eba198504a432b5931b370e6d1d4fae1007a313f)
Bug: 901465
Change-Id: I6f2220b3def3d1783677f8a48b5b4555fd896bc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036267
Commit-Queue: Bo <[email protected]>
Reviewed-by: Bo <[email protected]>
Auto-Submit: Clark DuVall <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738394}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053256
Commit-Queue: Clark DuVall <[email protected]>
Reviewed-by: Clark DuVall <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#261}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Sanitize selected content and truncate long text for display.
(cherry picked from commit 0b025e47a5c7d6513e7ffb8c6f924afb18db2c56)
Bug: 1050763
Test: unit tests
Change-Id: Ib0b2f97ee7233789b4209cc3a72833a5c07ac5a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048026
Reviewed-by: Avi Drissman <[email protected]>
Commit-Queue: Li Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740778}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053250
Cr-Commit-Position: refs/branch-heads/4044@{#260}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Autofill Assistant] Fix bug that marks text inputs as incomplete
At the moment if there is a text input fields the collect user data
action is considered incomplete and the Continue button is disabled.
This CL restores the original behaviour of never considering the
text inputs as incomplete.
(cherry picked from commit e1353394389666ea946543dda3b7f0c14e7b79e9)
Bug: 1049568
Bug: b/147653652
Change-Id: Ia807a414d63ef9d5731dfc11ee80b46d5707bea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047227
Reviewed-by: Clemens Arbesser <[email protected]>
Commit-Queue: Luca Hunkeler <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739908}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054101
Cr-Commit-Position: refs/branch-heads/4044@{#259}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Autofill Assistant] Add List popup section
Adds a new type of additional section which prompts a list
of items for the user to chose from.
If it's a required field and no item is selected an error
message is displayed and the Continue button is disabled.
We technically support multiple selection if specified (although
not needed yet it was not much more complicated to support it rather
than not). However at the moment we only display the first of the
selected items in the ui when the section is collapsed.
Moreover, the results of TextInputSection can also be sent to the
backend now, if specified in the proto.
Screenshots
Collapsed:
https://screenshot.googleplex.com/C9B0DLtT8nU.png
Popup:
https://screenshot.googleplex.com/3OzWxsbDrgY.png
(cherry picked from commit 685e460834294313f209ac6e7b65b109b8aeffe7)
Bug: 1049568
Bug: b/147653652
Change-Id: I6bad58d1a6b5b79b2c2ca0bab5a396dca7b8f313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014915
Commit-Queue: Luca Hunkeler <[email protected]>
Reviewed-by: Clemens Arbesser <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738617}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054543
Cr-Commit-Position: refs/branch-heads/4044@{#258}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix data dir lock handling on old OS versions.
Older versions of Android implement file locking incorrectly in the
Java standard library: they throw IOException instead of returning null
when the lock is already held by another process. This causes us to
crash when the lock is already held, without attempting to retry or
considering whether we're intending to crash vs warn.
Catch and ignore the exception when it comes from the tryLock call, and
only consider IOException fatal when it's thrown by the RandomAccessFile
constructor.
(cherry picked from commit 91e33bab020d11f95fbe554dcef22701225fa38e)
Bug: 558377
Fixed: 1048982
Change-Id: I66c5665a8e94e2713233b9799db6694ce5bfa077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050366
Commit-Queue: Richard Coles <[email protected]>
Commit-Queue: Tobias Sargeant <[email protected]>
Auto-Submit: Richard Coles <[email protected]>
Reviewed-by: Tobias Sargeant <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740287}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054186
Reviewed-by: Richard Coles <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#257}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Passwords] Don't show empty TTF sheet
This change makes sure that Touch To Fill does not show an empty sheet
to the user if no credentials are present. This case is treated as if
the user dismissed the sheet, so that the soft keyboard gets triggered
automatically.
TBR=fhorschig
(cherry picked from commit dd6e6799b031b17c55ca1535bc65f9fb8905b92f)
Bug: 1050565
Change-Id: Ie6aabe78d5cab285c13766b5ed04e5bbe3ba0f1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047184
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Reviewed-by: Friedrich [CET] <[email protected]>
Reviewed-by: Ilya Sherman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740219}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054092
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#256}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Autofill Assistant] Generalize additional section values
In a follow-up cl a new section will be added that requires storing
types other than strings. In this cl we change strings into ValueProto
to accommodate that.
Other minor modifications:
-Collect user data will now only return additional values that were
set by the action itself.
-Keys with empty strings will also be added to the additional values
(they were ignored before)
(cherry picked from commit 1f35a10fbd91e189c1167066ac6868557632d0e4)
Bug: 1049568
Change-Id: I379c1061f7381dc75b68650602583e75ec5db7cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027550
Commit-Queue: Luca Hunkeler <[email protected]>
Reviewed-by: Clemens Arbesser <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737752}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054245
Cr-Commit-Position: refs/branch-heads/4044@{#255}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[merge-m81] Fix the ChromeOS video player for HTML5 imports deprecation.
Some undocumented functionality regressed in r713537 with the feature
removal.
Skip presubmit. Change has +1/OWNERS approval, but a linter complains
about changes outside the scope of this CL.
[email protected]
(cherry picked from commit 002a81c4f7d96ace1b9a3cb6a49d13a50e79e515)
No-Presubmit: true
Bug: 1035051
Change-Id: Ie106df252fcf1784fdeffbcf1d789df5c8b7ea40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040754
Commit-Queue: Trent Apted <[email protected]>
Reviewed-by: Luciano Pacheco <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739167}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053464
Reviewed-by: Trent Apted <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#254}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Android][Mfill] Any BottomSheet suppresses the keyboard accessory
With this CL, the manual filling UI listens to the bottom sheet
controller and suppresses any keyboard accessory or accessory sheet as
soon as a BottomSheet of any kind is opened.
This solution has the following constraints:
* _Any_ bottomsheet will suppress the filling UI, always.
* If the bottomsheet is closed, the filling UI will require another
interaction (an opened keyboard, focusing a field, rotation) to reopen
the filling UI.
* The autofill dropdown is not affected in any way. Only if the keyboard
accessory V2 is active (i.e. flag \#autofill-keyboard-accessory-view),
the popup will be replaced by chips in the suppressed accessory.
Launch of V2 has an uncertain target as of this writing.
(cherry picked from commit 3ee270672169e8152b4c04e6cdf890c140d8d956)
Bug: 1033849
Change-Id: I55fffa1bb7dd62a08af95705085c4884d38d9877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036103
Commit-Queue: Friedrich [CET] <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738494}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054183
Reviewed-by: Friedrich [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#253}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Autofill Assistant] Add support for InfoPopups to generic UI.
(cherry picked from commit ec32558d0a03d5acd3c65b9ba8cfebedae6369d3)
Bug: 1049568
Bug: b/145043394
Change-Id: I37d416be30ccbf46d990548566f3d2521c7baeef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033152
Reviewed-by: Mathias Carlen <[email protected]>
Commit-Queue: Clemens Arbesser <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737735}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054163
Reviewed-by: Luca Hunkeler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#252}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
cros: Increase maximum number of users on login screen
The limitation is outdated and there is no reason to limit it anymore.
Setting the limit to 50 to have sensible scroll view of users.
This has nothing to do with the disk space exhaustion. That handled
separetely.
(cherry picked from commit 8df293597c4e5eaa3558842a0ed3a51081abba32)
Fixed: 1040890
Change-Id: Ib13d065f55cc9cc1d1d6f65a2b4db9d65805bb61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041442
Commit-Queue: Roman Sorokin [CET] <[email protected]>
Commit-Queue: Denis Kuznetsov [CET] <[email protected]>
Auto-Submit: Roman Sorokin [CET] <[email protected]>
Reviewed-by: Denis Kuznetsov [CET] <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738933}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054103
Reviewed-by: Roman Sorokin [CET] <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#251}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Introduce a strong restriction to disallow redirects in Pepper
This patch will improve the interoperability on flash.
As Firefox has a restriction to disallow 307/308 POST redirects
for requests from the flash plugin, we will follow the same
approach, but will have a stronger restriction to allow only
GET and HEAD.
(cherry picked from commit eab4ff72b79fbb63e3a7177e049296d554866b3d)
TBR: [email protected], [email protected], [email protected]
Bug: 332023
Change-Id: I17924315f1770c61b8cffca64f897e6be2e09cda
TEST: browser_tests --gtest_filter="*PPAPI*.URLLoader*"
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026839
Reviewed-by: Raymes Khoury <[email protected]>
Reviewed-by: Kinuko Yasuda <[email protected]>
Reviewed-by: Mike West <[email protected]>
Commit-Queue: Takashi Toyoshima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739799}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053905
Reviewed-by: Takashi Toyoshima <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#250}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Offline indicator v2] Fix wrong toolbar offset when swiping new tab
This CL fixes a bug where if the user swipes the toolbar immediately
after opening a new tab (easily reproducible w/ context menu > open in
incognito tab), top controls have the wrong offset and get hidden.
This is caused by ChromeFullscreenManager#onInteractabilityChanged()
which pushes offsets from TabBrowserControlsOffsetHelper even if the
offsets aren't initialized.
This is fixed by adding a simple check and returning early if the
offsets aren't initialized.
(cherry picked from commit 192cdd7c21d4e90d7b9bb61a90d2c6be608f646e)
Bug: 1048596
Change-Id: I3db087db835f81067018f808ee03974fb4d1adc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042677
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Matthew Jones <[email protected]>
Commit-Queue: Sinan Sahin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739202}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053622
Reviewed-by: Sinan Sahin <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#249}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[MIX-DL] Add link to blog post to console message.
This CL adds a link to the MIX-DL blog post to the console message
printed when mixed-content downloads occur.
(cherry picked from commit d684bea8f81df4a6b338539106ebf82f2f12e46b)
TBR: [email protected]
Bug: 1049133
Change-Id: Id3df23e2d4ab6f63e9c33b23155fa27a056378ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042380
Commit-Queue: Joe DeBlasio <[email protected]>
Commit-Queue: Mustafa Emre Acer <[email protected]>
Auto-Submit: Joe DeBlasio <[email protected]>
Reviewed-by: Mustafa Emre Acer <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739063}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052571
Reviewed-by: Joe DeBlasio <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#248}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge to M81] Structured metrics: Add metric collection and upload logic.
PS1 is the original reland, PS2 is the re-reland, including:
1. A fix for the original problem in structured_metrics_provider.cc
2. A test covering that case into s_m_p_unittest.cc
3. A deleted include that's no longer necessary after another CL.
This is a reland of 4b79ed37ba4b4bb58ff8de30a92b94f343752f5d
Original change's description:
> Reland "[Structured metrics] Add metric collection and upload logic."
>
> This is a reland of 2fe77415627b03da0af0edaf07cff9cccc3a2836
>
> Original change's description:
> > [Structured metrics] Add metric collection and upload logic.
> >
> > This is the final CL for the core of the structured metrics system. It
> > ties together the KeyData class (for managing keys and computing hashes)
> > with the metrics provider, and implements logic to:
> >
> > 1. Hash and store incoming structured metrics events.
> > 2. Provide stored metrics events for upload.
> >
> > It also adds integration tests for the system, checking that an event
> > created through the public API is correctly prepared for upload.
> >
> > Other misc changes:
> >
> > - Some minor refactoring of event_base.{h,cc} and equivalent changes
> > to events_template.py, to fix some bad style.
> > - Added a missing RemoveObserver call to the metrics provider dtor.
> >
> > Bug: 1016655
> > Change-Id: I3daae2ba7927742d26db8d5750538584bf13b94f
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975386
> > Commit-Queue: Tony Yeoman <[email protected]>
> > Reviewed-by: Andrew Moylan <[email protected]>
> > Cr-Commit-Position: refs/heads/master@{#735748}
>
> Bug: 1016655
> Change-Id: I83e69de7a9b865d35036b714f068cfda3c423b76
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026913
> Reviewed-by: Andrew Moylan <[email protected]>
> Commit-Queue: Tony Yeoman <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#736590}
(cherry picked from commit 1b60b248dcf7b05dce75637016f395b94315437e)
TBR: [email protected]
Bug: 1051353
Change-Id: I54b06543c5ac3075cd1256d651d3232e6739c7a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034387
Commit-Queue: Tony Yeoman <[email protected]>
Reviewed-by: Andrew Moylan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738390}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051909
Reviewed-by: Tony Yeoman <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#247}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Tell observers of ArcInputMethod bounds the removal of InputMethodSurface.
We need to tell the observers of ArcInputMethod bounds when the input
method surface is being removed.
Without doing that, the observers can't know whether the input method
surface is still there or not.
device to clamshell mode.
(cherry picked from commit 00e3f38e53404a09cf0fa94778d172c5ef5cffd7)
Bug: 1042549
Test: manual - show Chrome OS VK on an ARC++ app and flipping back the
Change-Id: Ib3e8fed3aa24a856c016ebcf7d3f6af2b2e2e1d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043186
Commit-Queue: Yuichiro Hanada <[email protected]>
Reviewed-by: Tetsui Ohkubo <[email protected]>
Auto-Submit: Yuichiro Hanada <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739362}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053226
Reviewed-by: Yuichiro Hanada <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#246}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Don't create discard button when prompting for scanning
When prompting the user for APP scanning, the "Discard" button is still
present in the download shelf. It hidden behind the "Scan" button,
but still accessible via Tab/Enter keys, leading to accidental discards
when operating via keyboard.
This CL makes no visible changes to the UX.
(cherry picked from commit 72e2f9c08c720d16c0d58d0dba4588ab408252f5)
Bug: 1049748
Change-Id: Ie4cb9fbc42341cca76bc5479e4ca9f207f7e9226
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042388
Reviewed-by: Shakti Sahu <[email protected]>
Commit-Queue: Daniel Rubery <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739147}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053169
Reviewed-by: Daniel Rubery <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#245}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.20
[email protected]
Change-Id: I767a68840eee1319f461bec6fec347fd143db4b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053045
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#244}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[m81 merge] webgl: Fix incorrect redraw due to read pixels with software compositing
The issue is that we don't reset the contents_changed_ flag to false at
the end of DrawingBuffer::FinishPrepareTransferableResourceSoftware.
Here's the problem:
1) We draw something into webgl canvas (DrawingBuffer) and export it as
a software resource (FinishPrepareTransferableResourceSoftware).
2) Later we do a readPixels on the canvas (which is
preserveDrawingBuffer: false). The readPixels will clear the canvas
to match spec behavior
(WebGLRenderingContextBase::ClearIfComposited).
3) The next time blink document lifecycle happens (rAF, resize, etc.)
DrawingBuffer thinks it needs to export the back buffer to compositor
again because contents_changed_ is still true.
4) DrawingBuffer exports the cleared back buffer to compositor.
This CL includes a pixel test that simulates the above case by switching
tabs (and calling readPixels) to force a document lifecycle update. The
included test fails before this fix and passes afterwards.
(cherry picked from commit af59acd7afbf6b15c8578ced43fb99fb4ce6e633)
Bug: 1047829
Change-Id: I1496919b974d84e975db28eafd9b8e6ffc71d91e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040732
Reviewed-by: Kenneth Russell <[email protected]>
Reviewed-by: Zhenyao Mo <[email protected]>
Commit-Queue: Sunny Sachanandani <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739141}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052611
Reviewed-by: Sunny Sachanandani <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#243}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix the Crostini new Terminal web app crash issue for M81.
The Crostini new terminal app is a system web app, although the app type
in AppService is still Crostini. So update IsOpenedInBrowser to return
true for the new terminal app id kCrostiniTerminalSystemAppId, so that
AppServiceAppWindowLauncherController can skip that, and leave it to
BrowserStatusMonitor to handle all windows related requests.
BUG=1048906
[email protected]
(cherry picked from commit b6631bfb1ddc62cb66d7c748184b8812b9e1134e)
Change-Id: Ie06f0616cf3a3ff6f25d2ad878151c8f71c98e84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038930
Reviewed-by: Xiyuan Xia <[email protected]>
Commit-Queue: Nancy Wang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739102}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053463
Reviewed-by: Nancy Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#242}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Removes AddRuleForHostname() from ProxyBypassRules
This API is allowing embedders of ProxyBypassRules to add rules directly
without ProxyBypassRules' parsing function, which isn't ideal. We should
have a central function to parse the input from outside of
ProxyBypassRules.
This CL removes AddRuleForHostname() and replace it with
AddRuleFromString(). In issue 1049876, we passed an IP address like
hostname to the internal class SchemeHostPortHostnamePatternRule, which
is now invalid.
(cherry picked from commit 26295ae55f0bd20ec65b20a5d7e6acf2ca7e852c)
Bug: 1049876
Change-Id: I2136d6b03e5cf53a246b7ffd582c158a25e5a8b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045311
Reviewed-by: Zhongyi Shi <[email protected]>
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: David Jacobo <[email protected]>
Commit-Queue: Shimi Zhang <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740039}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050739
Reviewed-by: Shimi Zhang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#241}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Merge "Add feature flags for latency recovery" to M81
To be able to control latency recovery via Finch experiments, feature
flags are added for it.
(cherry picked from commit b2910bd9d51f398c57c860eddbe39ed21666bc94)
Bug: 993895
Change-Id: Iff2c48c4d7fe6d9e5db9a4980ac1b6c123cd5029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030046
Commit-Queue: Mohsen Izadi <[email protected]>
Reviewed-by: Stefan Zager <[email protected]>
Reviewed-by: kylechar <[email protected]>
Auto-Submit: Mohsen Izadi <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737589}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051775
Reviewed-by: Mohsen Izadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#240}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Merge to M-81] Night Light: Fix a blue flash when switching users
Switching users can lead to a display reconfiguration.
We used reapply the current color temperature immediately
on display config changes with disregard to the possibility
of an on-going animation towards the same temperature.
As a result the target value was incorrectly set in the middle
of the animation, then the animation continues towards that
target value, resulting in a blue flash.
This CL fixes this issue.
[email protected]
BUG=999395
TEST=Manually, switch users (one with NL on, and the other off)
and see no blue flashes.
(cherry picked from commit 6416c3bc44d34f94c483ddd17f4d685c6bd2cb66)
Change-Id: Ib41dadcd3e45defbc5b09f32d1a8c0c2aa49e5dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051525
Reviewed-by: James Cook <[email protected]>
Commit-Queue: Ahmed Fakhry <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740748}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052572
Reviewed-by: Ahmed Fakhry <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#239}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[MERGE to 4044] [RELAND] Add more System Information collection via WMI
This CL adds code to collect metrics regarding the processor that the
user is running on.
[email protected]
[email protected], [email protected], [email protected]
(cherry picked from commit 5a9da84c04325831154a6f037812478a41aba313)
Bug: 1032858
Change-Id: Ia42dff38af54a87af164e35b0d58b5e0b95f4478
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982237
Commit-Queue: Rahul Chaturvedi <[email protected]>
Auto-Submit: Rahul Chaturvedi <[email protected]>
Reviewed-by: Alexei Svitkine <[email protected]>
Reviewed-by: Lei Zhang <[email protected]>
Reviewed-by: Sébastien Marchand <[email protected]>
Reviewed-by: Will Harris <[email protected]>
Reviewed-by: Ken Rockot <[email protected]>
Cr-Original-Original-Commit-Position: refs/heads/master@{#739252}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044059
Reviewed-by: Rahul Chaturvedi <[email protected]>
Reviewed-by: Sébastien Marchand <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739754}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051774
Cr-Commit-Position: refs/branch-heads/4044@{#238}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Merge "Separate impl and main latency recovery settings" to M81
Currently, there is a single settings flag controlling CC latency
recovery both on main thread and impl thread. This CL breaks that into
two separate flags that can be controlled independently.
(cherry picked from commit ed1ba912153480209ca58c14d73c4ccef0b1a06b)
Bug: 993895
Change-Id: I2caae6f5f2cd25332d8a164e082b313152e5e0b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869749
Reviewed-by: Sadrul Chowdhury <[email protected]>
Reviewed-by: Chris Harrelson <[email protected]>
Reviewed-by: Stefan Zager <[email protected]>
Auto-Submit: Mohsen Izadi <[email protected]>
Commit-Queue: Stefan Zager <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737561}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052336
Commit-Queue: Mohsen Izadi <[email protected]>
Reviewed-by: Mohsen Izadi <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#237}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[M81]Gate UNKNOWN password type pings with SBER.
The pings should be gated as the modal warning is
not shown for UNKNOWN password types.
(cherry picked from commit 8fa2c29c756f7155b283ceda59c8105623a75e13)
[email protected]
Bug: 1050128
Change-Id: I4ab0db5fb076958b996a7aeb2166f1f113016c25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044484
Commit-Queue: Bettina Dea <[email protected]>
Reviewed-by: Xinghui Lu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740046}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052467
Reviewed-by: Bettina Dea <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#236}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.19
[email protected]
Change-Id: Id5b6451ffa83d1d86a501faf7022609f3b52d538
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052485
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#235}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Add login_screen_extension permission for chrome i18n API
(cherry picked from commit 7cf5282507f67bdefa9c63681847e14fd1f76afb)
Bug: 986266, 1051478
Change-Id: I08220cacd6c1957e52a36ec8cb2066774d92290d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047108
Commit-Queue: Jit Yao Yap <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740635}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051281
Reviewed-by: Jit Yao Yap <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#234}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
ShareHelper check if image file is using before delete it
create a new folder for clipboard images, and before delete the images,
check if clipboard is still in the system clipboard
(cherry picked from commit d85de2c67f2063f1f0c2c1cf110d1286c137ba89)
Bug: 1047434
Change-Id: If5edf4eba56c90495f8ccf21171f1e6aac4d3297
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032427
Reviewed-by: David Trainor <[email protected]>
Reviewed-by: Theresa <[email protected]>
Reviewed-by: Sky Malice <[email protected]>
Commit-Queue: Gang Wu <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740006}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051770
Reviewed-by: Gang Wu <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#233}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
aw: Fix invalidate heuristics for viz
We rely on existing surface damage to decide whether invalidate or not
for subclients. Previously boolean flag was which was problematic
because kModeDraw can happen before or after the next begin frame.
This CL switches to using counter of damages and draws to address this
issue.
Bug: 805739, 1050785
Change-Id: Ibe1f89c4b031178295e57fada43cb032b865ce54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047825
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Reviewed-by: Bo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#740038}
(cherry picked from commit a3355817112bac7477556940836d1326755e98d6)
Change-Id: Ibe1f89c4b031178295e57fada43cb032b865ce54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050736
Reviewed-by: Vasiliy Telezhnikov <[email protected]>
Commit-Queue: Vasiliy Telezhnikov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#232}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Updating XTBs based on .GRDs from branch 4044
[email protected]
Change-Id: Iccc632c806f995a6bb4b66da907119f3bca944a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052219
Reviewed-by: Ben Mason <[email protected]>
Reviewed-by: Krishna Govind <[email protected]>
Commit-Queue: Krishna Govind <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#231}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Incrementing VERSION to 81.0.4044.18
[email protected]
Change-Id: I4746a20ffa17c020e71a634aafab2452140d0287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051540
Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/4044@{#230}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
ChromeBrowserInitializer offers runNowOrAfterFullBrowserStarted().
Reland of
https://chromium-review.googlesource.com/c/chromium/src/+/2032049
with fixes so avoid failing ChromeCustomTabsConnectionTest
(crbug.com/1048438).
Instead of runNowOrAfterNativeInitialization(), the method should
enqueue tasks to run when full browser starts, and not when native is
started. There is a distinction - reduced mode means native is started but full browser, which includes Profiles, isn't.
This fixes a crash when transitioning from reduced mode to full browser if a task that uses Profile was scheduled with
runNowOrAfterNativeInitialization(). Now, it will only run after the
transition, rather than immediately.
Also change hasNativeInitializationCompleted() to
isFullBrowserInitialized() and update clients. All but DownloadMetrics are meant to run in full browser, so that should actually revert their behavior back to what it was before reduced mode was introduced.
DownloadMetrics still checks if native was loaded, which includes in
reduced mode.
(cherry picked from commit f3a946b6557ecc0d33a60237699b3a22405355b0)
Bug: 1045945, 1014098, 1048438
Change-Id: If99179a5720d7e550ee5653a8625021f58fc262e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037818
Reviewed-by: Mohamed Heikal <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Commit-Queue: Henrique Nakashima <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738370}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051532
Reviewed-by: Ben Mason <[email protected]>
Commit-Queue: Ben Mason <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#229}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix Crash in XrRuntimeManager::InitializeProviders
All Providers are created in XrRuntimeManager::GetOrCreateInstance, of
these providers all are created with make_unique except for the
ArCoreDeviceProvider, which is created via a factory method. If this
factory hasn't been installed (which happens via a static method from
ArCoreInstallUtils.java via the ArDelegate init method), then the
provider may be null. The presence of the ArCoreDelegateImpl (which
actually installs the ArCoreDeviceProviderFactory) is gated on the same
buildflag (enable_arcore) as adding the provider to the providers list.
This _should_ mean that this provider shouldn't be null. However, it
appears as though there may be some race condition or other issue that
causes this provider to be null.
To fix the crash, both the processing of the providers and the creation
of the ArCoreDeviceProvider are wrapped with null checks. This will stop
the crash, but will result in end-users believing that their device does
not support AR. In order to help diagnose those users (and to help track
down a root cause for this crash), Release logging is added as a result
of both null checks, and to indicate that this race likely occurred.
(cherry picked from commit c054e3c1cfee15825cf6693752a110c83033c0fc)
Bug: 1050470
Change-Id: Ib809253093260da396cf82324456c2ff87ae238b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047362
Commit-Queue: Alexander Cooper <[email protected]>
Reviewed-by: Klaus Weidner <[email protected]>
Auto-Submit: Alexander Cooper <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740015}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050672
Reviewed-by: Alexander Cooper <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#228}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Disabling BasicDesktopEnvironment::CreateComposingVideoCapturer for M81
The plan is to submit this change and merge it to M81 to address
multi-mon issues in that release. Once Jamie is back, he will revert
this change and finish the VideoCapturer impl for M82.
(cherry picked from commit 1490a064b5a8c018152ad18c8f6e9bcb64471be8)
Change-Id: I33f1261061c43afeffbfc76df138440daa56f80e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048306
Auto-Submit: Joe Downing <[email protected]>
Reviewed-by: Jamie Walch <[email protected]>
Commit-Queue: Joe Downing <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740318}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050671
Reviewed-by: Joe Downing <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#227}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll silvermont AFDO profile from 81-4028.0-1580121249-benchmark-81.0.4019.0-r1 to 81-4037.0-1581331510-benchmark-81.0.4044.15-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I5241264e59bad84b0c4ac5c103ae602433db0007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050959
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#226}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll broadwell AFDO profile from 81-4025.0-1580122052-benchmark-81.0.4019.0-r1 to 81-4028.0-1581332223-benchmark-81.0.4044.15-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I1a429fe2f850fe0595ed72a03e40d7853120d6b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050958
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#225}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Roll airmont AFDO profile from 81-4028.0-1580123479-benchmark-81.0.4019.0-r1 to 81-4037.0-1581332741-benchmark-81.0.4044.15-r1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium-beta
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Tbr: [email protected]
Change-Id: I4cf741cc31cd372510d1ef98a7a742932d7b6067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050957
Reviewed-by: Chrome Release Autoroll <[email protected]>
Commit-Queue: Chrome Release Autoroll <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#224}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[ChromeDriver] Restore Chrome binary search order
Prior to https://crrev.com/708243, the search order for Chrome binary on
linux started with google-chrome. That change put chrome at the top of
the search order, which breaks some user's test code. This cl restores
the original search order.
(cherry picked from commit 424bb8bf09218e7ce1a56a90b379ec34b2f2a65a)
Bug: chromium:1051528, chromedriver:3336
Change-Id: I6307313c825bea8642028fa9718f6a6f2f3a561f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051148
Reviewed-by: John Chen <[email protected]>
Commit-Queue: Tricia Crichton <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740492}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050011
Cr-Commit-Position: refs/branch-heads/4044@{#223}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Autofill Assistant] Added second container for generic UI.
This CL adds a second container for generic UI to the CollectUserData
action. The first container is right after prepended_sections (no
change), the new second container is after appended_sections.
Conceptually, this will allow the specification of additional sections,
both prepended and appended ones, in either the dedicated proto or via
generic UI.
In the mid-term, I plan to remove those legacy additional sections
completely, but for now, the two will co-exist.
(cherry picked from commit da7ab4383dfdd687580ee67b901f25502b47904d)
Bug: 1049568
Bug: b/145043394
Change-Id: Iaabfa5fd7d3b71b287e9b0458fcd0790553ee490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030488
Commit-Queue: Clemens Arbesser <[email protected]>
Reviewed-by: Mathias Carlen <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#737313}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051992
Reviewed-by: Luca Hunkeler <[email protected]>
Commit-Queue: Luca Hunkeler <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#222}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Extensions] Make g_test_content_verify_job_observer thread-safe
ContentVerifyJob has ability to inject test observer, but before this CL
the observer is accessed from different threads, leading to flaky
crashes in tests. See https://crrev.com/c/2032998.
Now this observer (ContentVerifyJob::TestObserver and pointer to it from
g_test_content_verify_gob_observer in content_verify_job.cc) supports
thread-safe refcounted pointing, therefore is not destroyed too early.
Also it's wrappend into lazy initialized since we need access to it be
no-op outside of the tests.
(cherry picked from commit fe75264e4e711cb114c7777d9d64f253eddeb18a)
Bug: 796395, 958794
Change-Id: I7479216f23083d4fd41dae08cb2e7acb62da0abd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033159
Reviewed-by: Sergey Poromov <[email protected]>
Reviewed-by: Istiaque Ahmed <[email protected]>
Commit-Queue: Oleg Davydov <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739387}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050597
Reviewed-by: Oleg Davydov <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#221}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Disable ctrl+alt+h shortcut after the enrollment started
The moment the enrollment process started, switching to hangouts meet
or back is disallowed, to avoid getting wrong policies. In order to
enroll the device in hangouts for meet, the ctrl+alt+h shortcut should
be pressed after ctrl+alt+e in the enrollment process.
BUG=chromium:1040523
TEST=Manual tests on the device
(cherry picked from commit 11af6a4e14d43eacffd9a4b00c78a529a74a9e39)
Change-Id: I4a5f589ab278bf2c6f47c8640d833b02e785735f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014406
Commit-Queue: Igor <[email protected]>
Reviewed-by: Denis Kuznetsov [CET] <[email protected]>
Reviewed-by: Igor <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#738140}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050380
Cr-Commit-Position: refs/branch-heads/4044@{#220}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix null-deref.
In refactoring I omitted a construction call, oops.
(cherry picked from commit bffbb5911eb6de9c260f3265e707f28b6c56e31f)
Bug: 1050801
Change-Id: I2712a470b1f009bdf1b458b774811dd38320744e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048308
Auto-Submit: Peter Kasting <[email protected]>
Reviewed-by: Elly Fong-Jones <[email protected]>
Commit-Queue: Peter Kasting <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740242}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051731
Reviewed-by: Peter Kasting <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#219}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[Passwords] Ignore same-document navigations in CPMClient
This change modifies ChromePasswordManagerClient::DidFinishNavigation
to ignore events that happen on the same document.
TBR=vasilii
(cherry picked from commit 9e23c5a896e63f9d4b1e4168521a2c0ccedf7644)
Bug: 1050096
Change-Id: I1c6e884769112cc2333db9733123fd8b4bfe30eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044222
Reviewed-by: Vasilii Sukhanov <[email protected]>
Commit-Queue: Jan Wilken Dörrie <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739873}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050773
Reviewed-by: Jan Wilken Dörrie <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#218}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[ios] Fix another location with null context crash
Original fix:
https://chromium-review.googlesource.com/c/chromium/src/+/2003134
Respin on 80:
https://chromium-review.googlesource.com/c/chromium/src/+/2039590
(cherry picked from commit d8b5a058cf2b197ccf9e6fff02b909f3d4f8b18e)
Bug: 1041368
Change-Id: I5e90262c2458e2afae297da54ed472270e5d8b82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044221
Reviewed-by: Gauthier Ambard <[email protected]>
Reviewed-by: Eugene But <[email protected]>
Commit-Queue: David Jean <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739922}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050772
Reviewed-by: David Jean <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#217}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
Fix issue that camera preview in account page is wrongly cropped
Adds 'resizeMode: none' in constraints to avoid being cropped
unexpectedly by Chrome.
(cherry picked from commit eb093ebc4d732fdc62b35d50fddc9c1ce932e684)
Bug: b/148045035
Test: Manually
Change-Id: I4e2062cc75b438b1b64e7aa467b7c794a67cce95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041213
Reviewed-by: Steven Bennetts <[email protected]>
Commit-Queue: Wei Lee <[email protected]>
Auto-Submit: Wei Lee <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#739257}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050289
Reviewed-by: Wei Lee <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#216}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}
[StartSurface] Add integration tests for more single start surface paths
[email protected]
(cherry picked from commit 8d23be52f3080527e5c248ab8811c931bc2b4e96)
Bug: 1051226
Change-Id: Idd065587ccd944ae8dfbc890887d939fea685c84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050579
Commit-Queue: Ganggui Tang <[email protected]>
Commit-Queue: Wei-Yin Chen (陳威尹) <[email protected]>
Auto-Submit: Ganggui Tang <[email protected]>
Reviewed-by: Wei-Yin Chen (陳威尹) <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#740485}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051444
Reviewed-by: Ganggui Tang <[email protected]>
Cr-Commit-Position: refs/branch-heads/4044@{#215}
Cr-Branched-From: a6d9daf149a473ceea37f629c41d4527bf2055bd-refs/heads/master@{#737173}