Publish DEPS for Chromium 42.0.2292.0
Replace the term "main-frame" in content_settings.json.
Following the discussion about the term "main-frame" in https://codereview.chromium.org/843413003/, I experimented with a testing webpage that embedded <iframe>s which triggered different content setting requests.
Apparently, in the descriptions in content_settings.json, we used the term "main-frame" in two different contexts. This CL get rids of the term completely in favor of "top-level frame" and "document which requests X".
BUG=447978
Review URL: https://codereview.chromium.org/883983003
Cr-Commit-Position: refs/heads/master@{#313889}
MacViews: Fix compile regression after SmartLock error bubble in r313408
toolkit-views builds on mac are getting:
Undefined symbols for architecture x86_64:
ShowProximityAuthErrorBubble
To fix, move proximity_auth_error_bubble.cc to mac_sources. This works
because the symbol is only referenced on platforms with extensions,
which are toolkit_views platforms + mac.
After proximity_auth_error_bubble_view.cc moves in
chrome_browser_ui.gypi from chrome_browser_ui_views_non_mac_sources to
chrome_browser_ui_views_sources then proximity_auth_error_bubble.cc can
be deleted.
BUG=399191
[email protected]
Review URL: https://codereview.chromium.org/887563003
Cr-Commit-Position: refs/heads/master@{#313888}
Set the quiet shutdown flag.
Currently |SSL_shutdown| is only called to avoid that the
session is marked as unresumable. Without the quiet flag the
close notify message is generated without being sent on the
network.
BUG=None
Review URL: https://codereview.chromium.org/885083002
Cr-Commit-Position: refs/heads/master@{#313887}
Mac Video Capture: Add support for pixel format NV12 for AVFoundation
BUG=346634
Review URL: https://codereview.chromium.org/860333003
Cr-Commit-Position: refs/heads/master@{#313886}
Credential Management: Support zeroclick credential in 'request()'.
If only a single credential is available, and zero-click behavior is
enabled, then we don't need to ask the user for permission to present
the credential in response to a website's call to `request()`.
This patch implements that logic, walking through the local credentials
for an origin in the password store, and returning zeroclick credentials
without prompting.
If no such credential is available, and the caller set 'zero_click_only',
then we also won't prompt the user, and will simply return an empty
credential.
BUG=400674
Review URL: https://codereview.chromium.org/879913004
Cr-Commit-Position: refs/heads/master@{#313885}
Roll src/third_party/WebKit 116cf7f:79abaa8 (svn 189234:189235)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/116cf7f..79abaa8
[email protected],[email protected]
Review URL: https://codereview.chromium.org/886963002
Cr-Commit-Position: refs/heads/master@{#313884}
Revert of Manage profiles in BluetoothAdapter on ChromeOS (patchset #5 id:80001 of https://codereview.chromium.org/851123002/)
Reason for revert:
This causes a leak on Chrome Os ASan.
https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6306/steps/device_unittests/logs/Connect
Original issue's description:
> Manage profiles in BluetoothAdapter on ChromeOS
>
> Profiles in bluez are not specific to a device.
> When client code tries to connect to two different devices, only
> one profile is created, managed by BluetoothAdapterChromeOS.
>
> dbus messages are multiplexed based on the device desired using new
> class BluetoothAdapterProfileChromeOS.
>
> BUG=chromium:421207
>
> Committed: https://crrev.com/c56186ac2901c99349cbb4b4a6b8aa0ff8088c4d
> Cr-Commit-Position: refs/heads/master@{#313837}
[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:421207
Review URL: https://codereview.chromium.org/868753006
Cr-Commit-Position: refs/heads/master@{#313883}
media: Minor fixes in ProtectedMediaIdentifier*.
[email protected],[email protected]
BUG=446263
Review URL: https://codereview.chromium.org/890813002
Cr-Commit-Position: refs/heads/master@{#313882}
Add JPEG decoder for VAAPI JPEG decode acceleration
BUG=335778
TEST=build and run vaapi_jpeg_decoder_unittest
Review URL: https://codereview.chromium.org/825843002
Cr-Commit-Position: refs/heads/master@{#313881}
Fix compile error in V4L2SliceVDA.
BUG=None
TEST=compile on CrOS
Review URL: https://codereview.chromium.org/885273002
Cr-Commit-Position: refs/heads/master@{#313880}
ozone: evdev: Remove extra PostTask during dispatch from EventFactoryEvdev
Since device processing is moved off-thread, we can't enter the device
code from nested UI message loops. So we can remove the task hop in
PostUiEvent and dispatch synchronously.
WarpCursorTo() did need update to do its own post, as it is the last
remaining case of dispatch that doesn't start in its own task. Everything
else already posts in ForwardingDeviceEventDispatcher.
We can stack-allocate the ui::Events now, too. They previously needed
heap allocation to extend their lifetime through the task hop.
BUG=449710
TEST=boot link_freon & move mouse
Review URL: https://codereview.chromium.org/858333006
Cr-Commit-Position: refs/heads/master@{#313879}
ozone: evdev: Use DeviceEventDispatcherEvdev from InputInjectorEvdev
This makes the injector use the same interface as the devices
themselves. It also allows us to remove the PostTask after ui::Event
construction from EventFactoryEvdev, because all dispatches already
start in their own task (posted by ForwardingDeviceEventDispatcher).
BUG=449710
TEST=boot link_freon & move mouse
Review URL: https://codereview.chromium.org/882503002
Cr-Commit-Position: refs/heads/master@{#313878}
Roll src/third_party/WebKit 65e27b8:116cf7f (svn 189230:189234)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/65e27b8..116cf7f
[email protected],[email protected]
Review URL: https://codereview.chromium.org/862113006
Cr-Commit-Position: refs/heads/master@{#313877}
Move services code brought in from Mojo to live under //third_party.
This CL moves services code that is brought in from the Mojo repo and currently
living in //mojo/services to instead live in //third_party/mojo_services/src.
It fixes up include paths, buildfile references, and DEPS entries to account
for the new state of the world.
Review URL: https://codereview.chromium.org/861683003
Cr-Commit-Position: refs/heads/master@{#313876}
ozone: evdev: Add a device event dispatcher that forwards to UI thread
This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.
Make a new class ForwardingDeviceEventDispatcher that wraps
EventFactoryOzone and can be safely passed to another thread. When the
other thread dispatches, we'll post to EventFactoryOzone on the UI thread
with the event.
BUG=449710
TEST=boot link_freon & move mouse
Review URL: https://codereview.chromium.org/874723002
Cr-Commit-Position: refs/heads/master@{#313875}
Provides a second version of addTraceEvent that accepts a timestamp when #WEBKIT_HAS_NEW_ADD_TRACE_EVENT_WITH_TIMESTAMP is defined. This is in preparation for adding the Blink code that writes trace events with user-supplied timestamps.
BUG=345845
Review URL: https://codereview.chromium.org/870053006
Cr-Commit-Position: refs/heads/master@{#313874}
Roll src/third_party/WebKit daa5c18:65e27b8 (svn 189225:189230)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/daa5c18..65e27b8
[email protected],[email protected]
Review URL: https://codereview.chromium.org/885063003
Cr-Commit-Position: refs/heads/master@{#313873}
Add hirono@ to chrome/browser/chromeos/extensions/file_manager/OWNERS.
BUG=None
Review URL: https://codereview.chromium.org/880123004
Cr-Commit-Position: refs/heads/master@{#313872}
Roll src/third_party/WebKit 8949229:daa5c18 (svn 189223:189225)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8949229..daa5c18
[email protected],[email protected]
Review URL: https://codereview.chromium.org/889793002
Cr-Commit-Position: refs/heads/master@{#313871}
Roll src/third_party/skia 527b287:06fb35f
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/527b287..06fb35f
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/886443004
Cr-Commit-Position: refs/heads/master@{#313870}
Correctly handle out of storage space and "actively importing" states in controller.
Changes in task state trigger import controller updates (triggering scanning and UI updates).
Update test to work with new async update model.
Also: Fix media importer code to pass logical destination when marking a file imported.
+satorux for chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
BUG=420680
TEST=browser_test: FileManagerJsTest.*
Review URL: https://codereview.chromium.org/888693002
Cr-Commit-Position: refs/heads/master@{#313869}
Rename ScrollOffsetFractionalPart to ScrollCompensationAdjustment
BUG=414283
Review URL: https://codereview.chromium.org/888743003
Cr-Commit-Position: refs/heads/master@{#313868}
Let cros_power_monitor use dump_power_status
BUG=445645
TEST=tools/perf/run_benchmark --browser=cros-chrome --remote=$device robohornet_pro
TEST=tools/telemetry/run_tests telemetry.core.platform.power_monitor.cros_power_monitor_unittest
Review URL: https://codereview.chromium.org/887613002
Cr-Commit-Position: refs/heads/master@{#313867}
This is the necessary change in the upstream to fix the issue.
Pipe DidStartNavigationToPendingEntry to WebContentsObserver and TabObserver.
BUG=442726
Review URL: https://codereview.chromium.org/877163005
Cr-Commit-Position: refs/heads/master@{#313866}
ozone: evdev: Plumb device changes to EventFactoryEvdev
This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.
We must access DeviceDataManager from the UI thread only, so send a new
list to EventFactoryEvdev when devices are added or removed, and update
DeviceDataManager from there.
InputControllerEvdev also needs to know if there's a mouse or touchpad
attached, so additionally plumb lists for those devices and update this
property on InputControllerEvdev.
BUG=449710
TEST=boot link_freon & move mouse
Review URL: https://codereview.chromium.org/868043003
Cr-Commit-Position: refs/heads/master@{#313865}
Remove old HTML app list start page.
This CL deletes the old app list start page as it is obsolete.
BUG=None
Review URL: https://codereview.chromium.org/874563003
Cr-Commit-Position: refs/heads/master@{#313864}
Re-layout list view and add thumbnails for each files.
Changes are:
- Changes layout of list view.
- Add thumbnails for each files.
- Add checkmarks for selected items.
- Selected items' colors are not inverted to blue now.
BUG=402344
TEST=run browser_tests
Review URL: https://codereview.chromium.org/886753002
Cr-Commit-Position: refs/heads/master@{#313863}
Keyboard Overlay Should Distinguish Left and Right Modifier Keys
Current the keyboard overlay doesn't highlight the right keys when the
right-hand-side modifier keys (ALT, CTRL, SHIFT) are pressed.
It also doesn't show that SHIFT is used as a shortcut to disable CAPS
LOCK when it's enabled.
[email protected]
BUG=452667,453623
TEST=manual
Review URL: https://codereview.chromium.org/889753002
Cr-Commit-Position: refs/heads/master@{#313862}
Roll src/third_party/WebKit 4f92beb:8949229 (svn 189210:189223)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4f92beb..8949229
[email protected],[email protected]
Review URL: https://codereview.chromium.org/871143003
Cr-Commit-Position: refs/heads/master@{#313861}
ozone: evdev: Move GesturePropertyProvider to InputDeviceFactoryEvdev
This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.
This properties object owns memory accessed by libgestures, and so needs
to be be on the same thread as any gestures devices. So move it from
EventFactoryEvdev into InputDeviceFactoryEvdev.
BUG=449710
TEST=boot link_freon & move mouse
Review URL: https://codereview.chromium.org/868213002
Cr-Commit-Position: refs/heads/master@{#313860}
Copy build changes to compile mojo::AsyncWaiter to the chromium repo.
mojo::AsyncWaiter was added to mojo/public/cpp/environment in
https://github.com/domokit/mojo/commit/2b6c27fbbe9b704a77e977615b945f364bf520ca
and was rolled into chromium. However, the chromium environment
implementation is on mojo/environment, which is maintained independently
of the version in the mojo repo. This CL copies the mojo repo's
mojo/environment into the chromium repo so that mojo::AsyncWaiter is
usable there.
Review URL: https://codereview.chromium.org/883583005
Cr-Commit-Position: refs/heads/master@{#313859}
Remove use of mojo.SurfacesService interface in html_viewer
I'm planning to remove this interface in favor of connecting directly
to mojo.Surface in the mojo repo, this updates html_viewer so it will
still work after the removal.
Review URL: https://codereview.chromium.org/869343004
Cr-Commit-Position: refs/heads/master@{#313858}
Remove InstallHost from the DaemonController.
The InstallHost functionality is no longer used now that our Npapi plugin is gone. I am removing it in preparation for the removal of ElevatedDaemonController.
BUG=453172
Review URL: https://codereview.chromium.org/873353004
Cr-Commit-Position: refs/heads/master@{#313857}
partial PageClickTracker migration to RenderFrameObserver
BUG=433486
Review URL: https://codereview.chromium.org/866633002
Cr-Commit-Position: refs/heads/master@{#313856}
Enable visibleOnAllWorkspaces on stable.
BUG=384644
Review URL: https://codereview.chromium.org/866893003
Cr-Commit-Position: refs/heads/master@{#313855}
Implement glGetUniformBlocksCHROMIUM: service side data packing
The plan is to implement a Chromium internal command glGetUniformBlocksCHROMIUM,
like what we did with glGetProgramInfoCHROMIUM. So we could obtain all uniform
block related information from a linked program in one command. This is to
optimize the below commands:
* glGetUniformBlockIndex
* glGetActiveUniformBlockiv
* glGetActiveUniformBlockName
By separating glGetUniformBlocksCHROMIUM from glGetProgramInfoCHROMIUM,
command buffer doesn't need to respond differently for glGetProgramInfoCHROMIUM
depending on whether it's ES2 or ES3 command. The drawback is we add an extra
client/service side round trip for some ES3 programs. If this becomes a
critical perf issue, we can easily merge these two commands into one at a future
time.
BUG=453127
TEST=gpu_unittests
[email protected]
Review URL: https://codereview.chromium.org/887513002
Cr-Commit-Position: refs/heads/master@{#313854}
win/swarming: Make 64-bit component builds work on swarming.
Fun fact: Neither main nor try waterfalls test this configuration yet.
Only our poor clang/win fyi bots ran into this.
BUG=453657
[email protected]
Review URL: https://codereview.chromium.org/888783003
Cr-Commit-Position: refs/heads/master@{#313853}
[Cast] Refactor ExternalVideoEncoder for cleaner/simpler encapsulation.
There was a lot of hopping around between two classes, each class having
code that executes on two threads. This change makes
ExternalVideoEncoder live entirely on the cast MAIN thread, and the VEA
client live entirely on the VEA's own thread. This greatly simplified
the code and improved readability (especially the create/init sequence).
Also added a new FakeVideoEncodeAcceleratorFactory class to provide
common functionality for multiple unit test modules. In a soon-upcoming
change, the video_sender_unittest.cc code will start using it.
BUG=325998, 451277
Review URL: https://codereview.chromium.org/868803007
Cr-Commit-Position: refs/heads/master@{#313852}
Viewing cached webpages while offline is not available on Chrome OS
Fixed by creating the OfflineResourceThrottle in ChromeOS only if the
"enable-offline-load-stale-cache" flag is not enabled. This allows us to
go back to the default behavior if this flag is turned off.
BUG=433388
TEST=manually
[email protected],[email protected]
Review URL: https://codereview.chromium.org/856643002
Cr-Commit-Position: refs/heads/master@{#313851}
Undef of GetMessage is not needed.
Conflict was fixed in https://codereview.chromium.org/889663003/
Review URL: https://codereview.chromium.org/893463002
Cr-Commit-Position: refs/heads/master@{#313850}
[sql] Rewrite sqlite patching "system".
Rewrite the patch system to leverage git. The patches are generated by
git-format-patch in a sub-directory. A developer can regenerate a
version-control history using git-am, then use regular git tools to work
with the changelists. Hopefully this will make it easier to keep track
of patches going forward, and also make it easier to merge Chromium
changes with upstream changes when importing new SQLite versions.
This CL should not materially modify Chromium's SQLite. sqlite3.c has
these changes:
- An ancient change to func.c has been dropped for lack of current
support.
- Code for initializing the recover virtual table was added for
testing. Chromium does not set DEFAULT_ENABLE_RECOVER to enable
this, instead sql/recovery.cc enables it as needed.
- Some comment changes which hadn't propagated from recover.c.
Otherwise, minor cleanup changes. SQLite's tests compile and run under Ububntu
14.04.01 and OSX 10.9 with Xcode 5.0, with most tests passing. See
README.Chromium for more information.
BUG=340757
Review URL: https://codereview.chromium.org/885473002
Cr-Commit-Position: refs/heads/master@{#313849}
[Mac] The Switch Person button can be moar accessible
It now reads "<name> switch person button" instead of "<name> button" if
you have multiple profiles, and "switch person button" instead of absolute
silence if you only have a single, local profile.
BUG=450419
Review URL: https://codereview.chromium.org/890693003
Cr-Commit-Position: refs/heads/master@{#313848}
Revert of Revert "compositor: Fix texture flipping for SW mirroring with surfaceless" (patchset #1 id:20001 of https://codereview.chromium.org/865673003/)
Reason for revert:
This isn't the cause of the crash
Original issue's description:
> This reverts two CLs
> "compositor: Fix texture flipping for SW mirroring with surfaceless"
> and
> "Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds."
>
> Reason for revert:
> The original patch breaks software mirroring mode on at least veyron_jerry,
> and quite possibly all non-freon systems.
>
> >Original issue's descriptions:
> > Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds.
> > This fixes the GN build on Android after https://codereview.chromium.org/846063002.
> >
> > (The GYP build didn't break because content/browser/compositor/ is completely excluded there; see https://code.google.com/p/chromium/codesearch#chromium/src/content/content_tests.gypi&sq=package:chromium&&type=cs&l=1099)
> >
> > [email protected]
> >
> > Review URL: https://codereview.chromium.org/879543002
> >
> > Cr-Commit-Position: refs/heads/master@{#313074}
>
> > compositor: Fix texture flipping for SW mirroring with surfaceless
> >
> > Ozone-surfaceless renders the scene flipped, so the texture contents are
> > inverted from what they should be. This fixes the mirroring logic to
> > un-flip the texture when needed, and also to send the right sub-buffer
> > update rect.
> >
> > BUG=434115
> >
> > Committed: https://crrev.com/c6a481fe79e0c4851a576495105edf2600bfe5be
> > Cr-Commit-Position: refs/heads/master@{#312979}
>
> [email protected],[email protected],[email protected]
> BUG=434115,451804
>
> Committed: https://crrev.com/6302d690c0b3aa762b92300564d9313876c6a2bf
> Cr-Commit-Position: refs/heads/master@{#313610}
[email protected],[email protected],[email protected]
BUG=434115,451804
Review URL: https://codereview.chromium.org/888653002
Cr-Commit-Position: refs/heads/master@{#313847}
Move AW renderer compositor context to gpu thread
Use TexSubImage2D instead of TexImage2D to avoid orphaning
EGLImage
Create the renderer compositor context on the gpu thread.
BUG=448168, 259924
Review URL: https://codereview.chromium.org/769703005
Cr-Commit-Position: refs/heads/master@{#313846}
Reland this CL since the failed test problem cleared.
Enable Roboto by default for testing purpose.
The testing team wants to enable 'Roboto' by default and have real users to help report bugs too.
In this CL 'Roboto' is enabled by default and can be disabled by going to chrome://flags and turn 'disable-roboto-font-ui' to on.
Also modify the OobeWebUITest to make the tests run in full screen, otherwise the tests will fail due to the incorrect layout of supervised user creation UI (based on xiyuan@'s advice).
Also modify the TextDoesntClip (based on asvitkine@'s advice).
BUG=448948
Review URL: https://codereview.chromium.org/867403005
Cr-Commit-Position: refs/heads/master@{#313845}
Enable sending gesture events from layout tests
BUG=451559
Review URL: https://codereview.chromium.org/886633006
Cr-Commit-Position: refs/heads/master@{#313844}
options/guest mode: only hide the 'Show advanced settings...' link when
... there's no advanced settings.
[email protected]
BUG=452804
Review URL: https://codereview.chromium.org/886843002
Cr-Commit-Position: refs/heads/master@{#313843}
Flip flag to turn CrOS Browser Compositor Single Threaded
Simply stop using threaded browser compositor for CrOS. Clean up would
be in follow up patch.
[email protected], [email protected]
BUG=329552
Review URL: https://codereview.chromium.org/781163003
Cr-Commit-Position: refs/heads/master@{#313842}
Implement Page Selection in PDF Toolbar
BUG=110020
Review URL: https://codereview.chromium.org/861673002
Cr-Commit-Position: refs/heads/master@{#313841}
IPC Fuzzer: Make ChannelMojo work when --enable-channel-mojo is given
This adds an option to enable ChannelMojo on ipc_fuzzer.
[email protected], [email protected]
BUG=453571
Review URL: https://codereview.chromium.org/885143002
Cr-Commit-Position: refs/heads/master@{#313840}
Skip displaying zoom levels for scheme and host zoom changes.
Currently, ContentSettingsHandler::UpdateZoomLevelsExceptionsView(),
skips setting the origin for scheme and host zoom changes, but still
adds an entry to be displayed in the content settings page. This causes
an entry to be displayed with an origin of undefined. This CL changes
UpdateZoomLevelsExceptionsView() to skip adding an entry altogether.
BUG=453234
Review URL: https://codereview.chromium.org/883353003
Cr-Commit-Position: refs/heads/master@{#313839}
[GCM] Fixing the initialization of last checkin/fetch time if they are
corrupted/missing in GCM store
BUG=453018
[email protected],[email protected]
Review URL: https://codereview.chromium.org/884783003
Cr-Commit-Position: refs/heads/master@{#313838}
Manage profiles in BluetoothAdapter on ChromeOS
Profiles in bluez are not specific to a device.
When client code tries to connect to two different devices, only
one profile is created, managed by BluetoothAdapterChromeOS.
dbus messages are multiplexed based on the device desired using new
class BluetoothAdapterProfileChromeOS.
BUG=chromium:421207
Review URL: https://codereview.chromium.org/851123002
Cr-Commit-Position: refs/heads/master@{#313837}
App list: Changed launcher button's tooltip to "Launcher" in Ares mode.
BUG=448644
Review URL: https://codereview.chromium.org/853643002
Cr-Commit-Position: refs/heads/master@{#313836}
Publish documentScan API documentation
This should just make the docs available for convenient referece by devs
using the API. It need not be listed in any index.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/893443002
Cr-Commit-Position: refs/heads/master@{#313835}
Add mojo apptest runner.
This patch copies apptest_runner from Mojo, stripping it down to parts that are
needed to run network service apptests on Linux. This allows us to run them in
a Chromium checkout.
BUG=450356
Review URL: https://codereview.chromium.org/874273002
Cr-Commit-Position: refs/heads/master@{#313834}
Fix black background in website settings dropdown.
The permission spinner in the website settings popup had a black
background on certain devices. The bug was that the background was a
defined using a <shape> element that didn't have a <solid> element
inside of it (and certain devices default to a black fill color if
<solid> isn't specified).
Rather than fixing the immediate problem, this rewrites the code a bit:
The line under the Spinner is now a View with 1dp height rather than the
background of the Spinner's TextView. As a side-benefit, the underline
now extends all the way to the right edge of the spinner.
BUG=449643
Review URL: https://codereview.chromium.org/870143003
Cr-Commit-Position: refs/heads/master@{#313833}
Roll src/third_party/skia 19d8f9f:527b287
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/19d8f9f..527b287
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/883403003
Cr-Commit-Position: refs/heads/master@{#313832}
Expose an app_targets variable similar to android_app_targets
This target provides Chromium embedders with an elegant way to include
additional targets for all platforms.
BUG=453606
Review URL: https://codereview.chromium.org/882253007
Cr-Commit-Position: refs/heads/master@{#313831}
Remove dead IPC message ChromeViewHostMsg_DidBlockRunningInsecureContent.
This also removes its handler and associated code. The use of this infobar has
been superseded by an Omnibox decoration and bubble.
BUG=none
Review URL: https://codereview.chromium.org/826553003
Cr-Commit-Position: refs/heads/master@{#313830}
Disable PDFBrowserTest.Scroll on Chrome OS
It fails on the official builders.
BUG=446221
TEST=none
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/885973002
Cr-Commit-Position: refs/heads/master@{#313829}
Pepper: Fix PPB_TrueTypeFont GetFontsInFamily function.
Function is incorrectly copying a std::wstring into a buffer.
BUG=452886
Review URL: https://codereview.chromium.org/883003005
Cr-Commit-Position: refs/heads/master@{#313828}
Setting Guest last-active for the User Manager doesn't create the Guest.
This is a problem created by https://codereview.chromium.org/847733005.
BUG=445036
TEST=Lock a Profile, and the User Manager opens properly. Close all
other browsers then close the User Manager, ensure Chrome's completely
shut down, and re-open Chrome. The User Manager opens straight away.
Review URL: https://codereview.chromium.org/885493005
Cr-Commit-Position: refs/heads/master@{#313827}
ozone: fix HDPMLegacy - do the PF after overlays, also clear old overlays
This lets overlays display properly in the case of switching on/off
Review URL: https://codereview.chromium.org/812913003
Cr-Commit-Position: refs/heads/master@{#313826}
Standardize "gpu_times" metric names and add GPU rasterization versions.
The GPU Times metric event names have been standardized to match the
names for other metrics. GPU Rasterization versions have also been
added for both GPU times tests. Here is the list of test names:
gpu_times.gpu_rasterization.key_mobile_sites_smooth
gpu_times.gpu_rasterization.top_25_smooth
gpu_times.key_mobile_sites_smooth
gpu_times.top_25_smooth
[email protected]
BUG=none
test=trybots
Review URL: https://codereview.chromium.org/875473003
Cr-Commit-Position: refs/heads/master@{#313825}
Create a Android Sync integration test for typed URLs
This CL introduces JNI plumbing for one method of the FakeServer's
verification API. One test (testUploadTypedUrl) has been added to use
the API; it types a URL on the client and verifies that the URL was
sent to the server.
BUG=NONE
Review URL: https://codereview.chromium.org/862113005
Cr-Commit-Position: refs/heads/master@{#313824}
device: Add armansito@ to OWNERS.
armansito@ is already an owner of device/bluetooth and device/nfc, so
make him and OWNER for the occasional unit test additions to device_tests.gyp.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/886443003
Cr-Commit-Position: refs/heads/master@{#313823}
Add OWNERS for crx_file component.
Review URL: https://codereview.chromium.org/889663004
Cr-Commit-Position: refs/heads/master@{#313822}
Roll libvpx: cf86fa:5cdd30
Now that AVX2 detection works turn on the code:
https://codereview.chromium.org/884013006
[email protected]
Review URL: https://codereview.chromium.org/858153008
Cr-Commit-Position: refs/heads/master@{#313821}
Compare non-whitelisted off-domain inclusions against browsing history.
BUG=412468
Review URL: https://codereview.chromium.org/859903002
Cr-Commit-Position: refs/heads/master@{#313820}
Removing policy_hack namespace and directory.
Now we are reusing code from components/policy, so we can get rid of the
self-shaming "hack" name in the policy_hack namespace and directory.
The changelist also:
- Inlines MockPolicyCallback into policy_watcher_unittest.cc
- Removes a misguided TODO comment in policy_watcher.h that used
to say that components/policy filters out policies that do not
match the schema (this is not true for polices from Chrome domain
- see SchemaMap::FilterMap definition).
BUG=368321
Review URL: https://codereview.chromium.org/884243003
Cr-Commit-Position: refs/heads/master@{#313819}
Roll src/third_party/WebKit a8902e8:4f92beb (svn 189209:189210)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a8902e8..4f92beb
[email protected],[email protected]
Review URL: https://codereview.chromium.org/874693005
Cr-Commit-Position: refs/heads/master@{#313818}
Post a message from Java to JS using message channels.
BUG=393291
Review URL: https://codereview.chromium.org/869133005
Cr-Commit-Position: refs/heads/master@{#313817}
cc: Control defer_commits logic by Scheduler
So far, EarlyOut_DeferCommits is controlled by Proxy.
Because Scheduler doesn't know about this deferring, it triggers next
BeginMainFrame when main thread want to defer a commit.
This CL moves the EarlyOut_DeferCommits logic from Proxy to
Scheduler so Scheduler can stop next BeginMainFrame until defer commit is off.
[email protected], [email protected], [email protected]
BUG=382572
TEST=cc_unittests
Review URL: https://codereview.chromium.org/337693005
Cr-Commit-Position: refs/heads/master@{#313816}
Make some casts in pdfium_engine.cc safe by using checked_cast
[email protected]
Review URL: https://codereview.chromium.org/889503002
Cr-Commit-Position: refs/heads/master@{#313815}
Correctly track texture cleared state for sharing
When sharing textures in mailboxes using MailboxManagerSync
there's an optimization that if textures are not updated then
there is no need to share it again. However the code that
checks whether textures are updated ignores the cleared
state, causing shared texture to remain uncleared
indefinitely.
Fix by check the cleared state. And add a unit test.
BUG=453199
Review URL: https://codereview.chromium.org/890453002
Cr-Commit-Position: refs/heads/master@{#313814}
Unify GPU raster and accelerated canvas blacklists on Android.
Accelerated canvas and GPU raster both use the same Skia codepaths and
have generally displayed the same bugs. It doesn't make sense to
blacklist one but not the other. Since GPU raster sees more usage than
canvas nowadays, and I researched GPU raster compatibility as part of
https://codereview.chromium.org/760053003, it makes sense to fold canvas
into the same blacklist.
This immediately fixes an Adreno 225 canvas bug which slipped through a
driver-reported-version based blacklist, which is apparently unreliable
and which I deleted in this patch. More generally it also should avoid
this kind of issue in the future.
BUG=453283
NOTRY=true
Review URL: https://codereview.chromium.org/877343008
Cr-Commit-Position: refs/heads/master@{#313813}
Fix "choose what to sync" in the webview signin
When "Choose what to sync" is clicked, we change the source to 3 in the
gaia continue url.
BUG=452440
Review URL: https://codereview.chromium.org/892493002
Cr-Commit-Position: refs/heads/master@{#313812}
Allow PBKDF2 key derivation using an empty password.
BUG=449409
Review URL: https://codereview.chromium.org/889493002
Cr-Commit-Position: refs/heads/master@{#313811}
chrome/browser: Remove some include entries that aren't needed anymore.
Those are not more used in chrome/browser and thus can be removed to
prevent others using them in chrome/browser land.
BUG=237267
TEST=checkdeps
[email protected]
Review URL: https://codereview.chromium.org/880293003
Cr-Commit-Position: refs/heads/master@{#313810}
Implement AES-GCM in tlslite.
This adds controls to the C++ test server but doesn't use them yet. Also
ensure that tlslite never selects a 1.2 cipher suite when negotiating an
older version.
BUG=450733
Review URL: https://codereview.chromium.org/875683002
Cr-Commit-Position: refs/heads/master@{#313809}
Plugin Power Saver: Fix Flash JS usage UMA.
GetWindowObject() get called during plugin initialization, Ignore that.
BUG=451197
Review URL: https://codereview.chromium.org/871113003
Cr-Commit-Position: refs/heads/master@{#313808}
Handle authentication failures in the v2 app by restarting the app
This CL handles the case when a token is revoked, e.g. via
https://security.google.com/settings/security/permissions.
We need to instruct chrome.identity to remove the invalid cached
token and fetch a new one. The app would then be reloaded app as
some of the app components (wcs sandbox) cached the invalid token
and cannot be cleanly reinitialized.
Summary of changes:
1. Implement app reloading using chrome.app.AppWindow API's and
base.Ipc so that it can be called from foreground pages
2. Implement handleAuthFailure in remoting.identity and remoting.oauth2.
In remoting.identity, we would remove the cached token and request a
new one by prompting the user for consent.
3. Modify the call sites to use the new method.
BUG=339677
Review URL: https://codereview.chromium.org/868203002
Cr-Commit-Position: refs/heads/master@{#313807}
reland: Plumb allow_overlay flag for video path into cc
This will allow hardware video overlays to be enabled in the compositor
Review URL: https://codereview.chromium.org/806413004
Cr-Commit-Position: refs/heads/master@{#313806}
Roll src/third_party/skia 5444393:19d8f9f
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5444393..19d8f9f
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/890703003
Cr-Commit-Position: refs/heads/master@{#313805}
Revert of Optimize all Chrome for Android PNG assets. (patchset #1 id:1 of https://chromiumcodereview.appspot.com/889683002/)
Reason for revert:
Images got corrupted
Original issue's description:
> Optimize all Chrome for Android PNG assets.
>
> This change decreases our APK size by 67,065 bytes.
>
> [email protected]
> [email protected]
> BUG=407781
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3952cc4232da78710734333340ae3181d5c20031
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=407781
Review URL: https://codereview.chromium.org/885743003
Cr-Commit-Position: refs/heads/master@{#313804}
Make Android-specific LTO disablements have effect only on Android.
Also add a TODO requested by Nico.
BUG=453195
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/880403005
Cr-Commit-Position: refs/heads/master@{#313803}
Add SSL Connection Error UMA.
BUG=440443
Review URL: https://codereview.chromium.org/885763002
Cr-Commit-Position: refs/heads/master@{#313802}
For DirectWrite font metrics use the average character width from the TEXTMETRIC structure.
Currently we fetch the average character width from the GetTextExtentPoint32 API for DirectWrite as skia
does not return this value. The width returned by the GetTextExtentPoint32 API is 1 px larger than the one
reported by the TEXTMETRIC structure causing some dialogs like the bookmark editor to display much larger than that
with GDI.
We now use the average character width from the TEXTMETRIC structure while reporting back the metrics for DirectWrite
fonts. Longer term fix is to find out a way to calculate this from DirectWrite. Does not appear to be straigthforward.
Added a TODO to that effect in the code.
BUG=434588
TEST=Updated the PlatformFontWinTest.Metrics_SkiaVersusGDI test to validate the average character widths.
For manual test, launch Chrome and open the bookmark
editor on Windows 7+. Observe that the window size is larger than the window size when using GDI for fonts.
Review URL: https://codereview.chromium.org/875303003
Cr-Commit-Position: refs/heads/master@{#313801}
[surfaces] use DEFAULT_MAX_FRAMES_PENDING if OutputSurface doesn't specify it.
To match LTHI, change the max frames pending calculation to output DEFAULT_MAX_FRAMES_PENDING if the output surface reports 0.
Review URL: https://codereview.chromium.org/885933002
Cr-Commit-Position: refs/heads/master@{#313800}
Include a machine id in log files.
This is the first step in making more reliable cross-machine history synching. A subsequent step will support reading data from the history files from other machines.
Also, updated the debug log to employ machine id.
BUG=420680
TEST=browser_test: FileManagerJsTest.*
Review URL: https://codereview.chromium.org/886483004
Cr-Commit-Position: refs/heads/master@{#313799}
Add targets for generating version files in Windows GN build.
Now chrome_version.cc and version .rc files are generated.
Review URL: https://codereview.chromium.org/874413003
Cr-Commit-Position: refs/heads/master@{#313798}
cc: Fix flakiness in LayerTreeHostCopyRequestTestMultipleDrawsHiddenCopyRequest
This test was expecting the main thread copy request to happen before a
new draw happens on the compositor thread which is racey. Instead do
this comparison on the main thread by posting and trying to end the test
after the draw happens but checking for the copy request result there
on the main thread instead of on the impl thread before posting.
R=vmpstr, weiliangc
BUG=439649
Review URL: https://codereview.chromium.org/888663003
Cr-Commit-Position: refs/heads/master@{#313797}
Move WeakPtrFactory member last in class
It was failing like this:
In file included from ../../media/mojo/services/mojo_cdm_service.cc:5:
../../media/mojo/services/mojo_cdm_service.h:71:40: error: [chromium-style] WeakPtrFactory members which refer to their outer class must be the last member in the outer class definition.
base::WeakPtrFactory<MojoCdmService> weak_factory_;
^
BUG=444089
Review URL: https://codereview.chromium.org/872773008
Cr-Commit-Position: refs/heads/master@{#313796}
Permission bubble should display URL with appropriate language pref
BUG=444586
TEST=
1. Change language to RTL language
2. Set chrome://flags/#enable-permissions-bubbles to 'Enabled'
3. Go to https://adrifelt.github.io/demos/bubble-demo.html
4. Verify that URL is displayed correctly
Review URL: https://codereview.chromium.org/882113004
Cr-Commit-Position: refs/heads/master@{#313795}
Remove //build/go, this is not used in chromium
This was added for use in mojo and is still being used in the mojo
repo but is not in chromium.
[email protected]
Review URL: https://codereview.chromium.org/871863005
Cr-Commit-Position: refs/heads/master@{#313794}
Symbolize JSON output snippets in swarming ASan runs.
This mirrors an earlier change to non-swarming runs:
https://codereview.chromium.org/810643006/
BUG=372458
[email protected]
Review URL: https://codereview.chromium.org/865853009
Cr-Commit-Position: refs/heads/master@{#313793}
Add missing NULL checks to NativeViewAccessibilityWin.
IAccessible objects are reference-counted, so the COM object
may persist if the view is deleted. We should always check the
view (which will be nulled when the view is deleted).
BUG=436074
Review URL: https://codereview.chromium.org/872683005
Cr-Commit-Position: refs/heads/master@{#313792}
Roll src/third_party/WebKit 05dd7de:a8902e8 (svn 189206:189209)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/05dd7de..a8902e8
[email protected],[email protected]
Review URL: https://codereview.chromium.org/880983005
Cr-Commit-Position: refs/heads/master@{#313791}
Cleanup ipc fuzzer. Add flags to pick random prefix on launch.
[email protected],[email protected]
BUG=450268
Review URL: https://codereview.chromium.org/888603003
Cr-Commit-Position: refs/heads/master@{#313790}
Update V8 to version 4.2.36 (based on d0f3e5302c8d89fee4995b86a2b83c9ecf5d1e7a).
[email protected]
Review URL: https://codereview.chromium.org/877343007
Cr-Commit-Position: refs/heads/master@{#313789}
ozone: evdev: Set modifier flags on touch events
This fixes a regression vs X11 where all touch events are missing
modifier flags.
BUG=450650
TEST=Open http://www.rbyers.net/eventTest.html on link, hold shift, and
tap the touchscreen. Page shows "shift" on the click event line.
Review URL: https://codereview.chromium.org/887743002
Cr-Commit-Position: refs/heads/master@{#313788}
Revert of Fix shelf dimming on secondary display (patchset #1 id:40001 of https://codereview.chromium.org/850833004/)
Reason for revert:
Causing crbug.com/451804 - probably using an invalid window
Original issue's description:
> Fix shelf dimming on secondary display
>
> BUG=449863
> TEST=ShelfLayoutManagerTest.DimmingBehaviorDualDisplay
>
> Committed: https://crrev.com/665d66d93fe22a50ba3623397b596a394098faef
> Cr-Commit-Position: refs/heads/master@{#312244}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449863
Review URL: https://codereview.chromium.org/883063003
Cr-Commit-Position: refs/heads/master@{#313787}
workers: Map the current thread-id to the WorkerRunLoop.
Instead of using an AtomicSequenceNumber to find an ID for a worker runloop,
use the ID of the current thread instead.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/886593002
Cr-Commit-Position: refs/heads/master@{#313786}
Revert of Allow new zoom bubble to override current one. (patchset #6 id:100001 of https://codereview.chromium.org/849693006/)
Reason for revert:
The changes in this CL are causing a crash: crbug.com/453564
Original issue's description:
> Allow new zoom bubble to override current one.
>
> At present, if a user changes zoom on OSX while the zoom bubble is
> already being shown, the new zoom bubble (with the most up to date
> information) is not shown. This CL changes this behaviour by allowing
> a new zoom bubble to be created, and replace the existing one.
>
> Example: load a PDF and repeatedly click the zoom +/- controls in the
> lower-right corner of the viewer.
>
> BUG=444995
>
> Committed: https://crrev.com/a95ea7031e472fd5d0968955989c963381dfaf5f
> Cr-Commit-Position: refs/heads/master@{#313564}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=444995
Review URL: https://codereview.chromium.org/867183006
Cr-Commit-Position: refs/heads/master@{#313785}
Roll BoringSSL 347f025..a87de9b.
Changes:
a87de9b Define WIN32_LEAN_AND_MEAN in the build system, not in the code.
4a0f0c4 Change CMakeLists.txt to two-space indent.
2e38008 Define _HAS_EXCEPTIONS=0 to avoid MSVC C4530 warning.
bcc4fa8 Add unit-tests for PBKDF2.
507c1ee Honor the standard BUILD_SHARED_LIBS cmake variable.
f4600ad Add missing OPENSSL_EXPORTs.
f058dae Revert "Add a test for CONF_parse_list."
dc94b54 Clean up use of Windows Platform SDK headers.
33970e6 Enable bssl client/s_client and server/s_server on Windows.
9a9a193 Build with -fvisibility=hidden.
afdaeee Enable bssl (md5sum, sha256sum, etc.) on Windows.
2fe7f2d Initialize HMAC keys to zero.
1d75c8b Improve compatibility with CMake 3.0 and later
ed30c0d Improve the documentation in BUILDING
b7f3144 Add a style guide.
69ad27f Run x86 perlasm on UNIX with -fPIC.
36eb7d5 Fix buffer size in aead_test.c.
53cbd6c Fix unused variable warning in OPENSSL_NO_ASM build.
bed8f73 Fix build after mistake addressing comments in cca4d599.
cca4d59 Add digest sum handling to the tool.
cd5c892 Add a test for CONF_parse_list.
fd4eb60 Remove duplication of common DH parameters.
b4a494c Reformat SSL/TLS headers.
For more details see: https://boringssl.googlesource.com/boringssl/+log/347f025..a87de9b
Review URL: https://codereview.chromium.org/890443002
Cr-Commit-Position: refs/heads/master@{#313784}
Fixed position layer counter-scroll with main thread scroll offset fractional part
Main thread can scroll with non-integral scroll offset, but Blink currently
only handles integral part of the scroll offset. For example, if main thread
scrolls by 10.5, Blink tells CC that the scroll offset is 10 (currently truncated
inside Blink) and Blink also sets fixed-position layer's position at 10.
This CL makes the non-integral scroll offset works correctly in this case:
1. Blink can tell CC the non-integral scroll offset 10.5 (truncation inside Blink
will be removed after this CL).
2. Blink sets fixed-position layer at 10.
3. CC tracks the fractional part of the scroll offset 0.5 and applied it when
computing scroll compensation for fixed-position layer during drawing.
BUG=414283
Review URL: https://codereview.chromium.org/877173002
Cr-Commit-Position: refs/heads/master@{#313783}
Renamed GetMessage into GetNextMessage.
Windows defines GetMessage as GetMessageW.
This makes linking fail if p224_spake included after windows headers.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/889663003
Cr-Commit-Position: refs/heads/master@{#313782}
This adds the ExtensionView to the family of GuestViews.
This...
- Wires up ExtensionView. Can apply src for navigation via inline and js call.
- Adds permission for manifests.
- Add browser tests for navigation and adding ExtensionViews to DOM.
Some code is duplicated from existing GuestViews (e.g. *ViewAttribute and some GuestViewBase implementations). Based on how GuestView code will be refactored, some of this can be consolidated.
This...
- Does not run in a detached state. (Refers to CR 845363004)
- Will have more functionality and restrictions implemented in the future.
Review URL: https://codereview.chromium.org/873933002
Cr-Commit-Position: refs/heads/master@{#313781}
Revert of Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (patchset #1 id:1 of https://codereview.chromium.org/883373002/)
Reason for revert:
Wrong revert, ipc fuzzer broke because of something else.
Original issue's description:
> Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (patchset #3 id:40001 of https://codereview.chromium.org/725733002/)
>
> Reason for revert:
> Broke ipc fuzzer
>
> Original issue's description:
> > IPC::ChannelMojo: Make IPC handling robust against bad messages.
> >
> > This change replaces some DCHECK()s with real error handling.
> > They happen when it receives broken messages.
> >
> > BUG=428800
> > [email protected]
> >
> > Committed: https://crrev.com/185ffdf58f85e47db9666d2ad9b80ff9bd7fa54b
> > Cr-Commit-Position: refs/heads/master@{#304102}
>
> [email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=428800
>
> Committed: https://crrev.com/726621f93d2802dfc2c90732c7133145c9854e38
> Cr-Commit-Position: refs/heads/master@{#313778}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428800
Review URL: https://codereview.chromium.org/892503002
Cr-Commit-Position: refs/heads/master@{#313780}
[Cast] Separate frame size from VideoSenderConfig in H264VideoToolboxEncoder.
This is a prerequisite change for supporting variable video frame sizes
in Cast. This allows a follow-up change to remove the width/height
properties from VideoSenderConfig. Instead, the width/height is passed
to the ctor in a separate gfx::Size argument.
BUG=451277
Review URL: https://codereview.chromium.org/883013003
Cr-Commit-Position: refs/heads/master@{#313779}
Revert of IPC::ChannelMojo: Make IPC handling robust against bad messages. (patchset #3 id:40001 of https://codereview.chromium.org/725733002/)
Reason for revert:
Broke ipc fuzzer
Original issue's description:
> IPC::ChannelMojo: Make IPC handling robust against bad messages.
>
> This change replaces some DCHECK()s with real error handling.
> They happen when it receives broken messages.
>
> BUG=428800
> [email protected]
>
> Committed: https://crrev.com/185ffdf58f85e47db9666d2ad9b80ff9bd7fa54b
> Cr-Commit-Position: refs/heads/master@{#304102}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428800
Review URL: https://codereview.chromium.org/883373002
Cr-Commit-Position: refs/heads/master@{#313778}
[Smart Lock] Add error message strings for the "Tx Power too high" case.
BUG=450498
TEST=none
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/868133005
Cr-Commit-Position: refs/heads/master@{#313777}
Removed kAshDisableTextFilteringInOverviewMode flag.
Now that the text filtering feature is mature, we can remove the flag
that allows disabling it safely.
BUG=452107
TEST=manual
Review URL: https://codereview.chromium.org/878173002
Cr-Commit-Position: refs/heads/master@{#313776}
Fix build breakage on clankium gn-release-builder-l
This is a missing part of https://codereview.chromium.org/873133002/ .
BUG=426751
Review URL: https://codereview.chromium.org/883183002
Cr-Commit-Position: refs/heads/master@{#313775}
Removed calls to [HyperlinkTextView setMessageAndLink:withLink:...]
Replaced occurrences of
[HyperlinkTextView setMessageAndLink:withLink:atOffset:font:
messageColor:linkColor:]
with
[HyperlinkTextView setMessage:withFont:messageColor:] +
[HyperlinkTextView addLinkRange:withName:linkColor]
BUG=253755
TEST=for bookmark_sync_promo_controller.mm: Launch the Chrome browser. Click the
star icon at the right end of the omni box. In the popover window that appears,
confirm that the text at the bottom reads, “Sign in to get your bookmarks
everywhere.” and that the text “Sign in” is a clickable link that takes you to
the Chrome sign-in page.
for extension_installed_bubble_controller.mm: Launch the Chrome browser and type
chrome://extensions in the omnibox. In the page that appears click the Get more
extensions link at the bottom. Locate the Tag Assistant by Google extension and
click it. Click the “+ FREE” button in the upper-right corner of the overlay
window that appears. Click “Add” in the overlay window that appears to confirm
your action. In the bubble window that appears that says Tag Assistant has been
added to Chrome, confirm that the text at the bottom of the bubble window says,
“Sign in to Chrome to get this extension, your history, and other Chrome
settings on all your devices.”, and that “Sign in to Chrome” is a clickable link
that takes you to the Chrome sign-in page.
for exclusive_access_bubble_window_controller.mm: Launch the Chrome browser and
go to http://davidwalsh.name/demo/fullscreen.php . Click the “Launch Fullscreen”
button that appears halfway down the page. If a bubble window appears stating,
“davidwalsh.name is now full screen” click Allow. Confirm that in the next
bubble window that appears, the text at the right says, “Exit full screen (Esc)”
and that the words “Exit full screen” are a clickable link that exits full
screen mode when clicked.
Review URL: https://codereview.chromium.org/865373002
Cr-Commit-Position: refs/heads/master@{#313774}
Delete old ScreenOrientationDelegte
In the rename from ScreenOrientationDelegte to ScreenOrientationController, apparently one of the files was not properly deleted. It is no longer referenced anywhere, so I'm deleting it as intended.
BUG=396760
Review URL: https://codereview.chromium.org/889603003
Cr-Commit-Position: refs/heads/master@{#313773}
Plumbing from WebPresentationClient to the Presentation Mojo service for
availablechange event. Blink CL: https://codereview.chromium.org/832263007
BUG=412331
Review URL: https://codereview.chromium.org/839773002
Cr-Commit-Position: refs/heads/master@{#313772}
Add glTransformFeedbackVaryings to GPU command buffer.
BUG=429053
TEST=gpu_unittests
[email protected]
Review URL: https://codereview.chromium.org/872713004
Cr-Commit-Position: refs/heads/master@{#313771}
Pass correct flags for use_lto==1 with Clang.
BUG=453195
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/884923002
Cr-Commit-Position: refs/heads/master@{#313770}
Roll src/third_party/WebKit 7020f55:05dd7de (svn 189202:189206)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7020f55..05dd7de
[email protected],[email protected]
Review URL: https://codereview.chromium.org/890713002
Cr-Commit-Position: refs/heads/master@{#313769}
[Extensions] Make extension actions use gfx::Image over gfx::ImageSkia.
gfx::Images cache different representations (such as NSImages), whereas
gfx::ImageSkias (as a representation themselves) do not. Prefer to use
gfx::Image in most icon code, so that these representations are cached.
BUG=452971
Review URL: https://codereview.chromium.org/882243002
Cr-Commit-Position: refs/heads/master@{#313768}
Roll ANGLE 2a30ccefd..bc393df9cd.
Reverts revert of the last roll, with included fix.
https://chromium.googlesource.com/angle/angle/+log/2a30ccefd..bc393df9cd
Previous roll range:
https://chromium.googlesource.com/angle/angle/+log/9e0478f62f..2a30ccefd0
BUG=450257,453037
Review URL: https://codereview.chromium.org/873353005
Cr-Commit-Position: refs/heads/master@{#313767}
Make ui::Compositor use ui::Scheduler
Taken from enne's CL 535733002 and rebased. It has been taken out of CL 134623005.
BUG=329552
Committed: https://crrev.com/36b7fc7f8b05ea627873e58a162c1c26784e472d
Cr-Commit-Position: refs/heads/master@{#298779}
Committed: https://crrev.com/b821b71ff0166e250ae4b30b56c1b7b6d3bd5db6
Cr-Commit-Position: refs/heads/master@{#306954}
Review URL: https://codereview.chromium.org/638653003
Cr-Commit-Position: refs/heads/master@{#313766}
Revert of Remove the use of page id from building the commit params. (patchset #4 id:60001 of https://codereview.chromium.org/839413004/)
Reason for revert:
NavigationControllerBrowserTest.ManualAndAutoSubframeNavigationTransitions fails on the --site-per-process FYI bot
Original issue's description:
> Remove the use of page id from building the commit params.
>
> BUG=369661
> TEST=tests stay green
>
> Committed: https://crrev.com/66f3ec8e5ee6c3b528b5a6054cdca85ac0b29699
> Reverted: https://crrev.com/96545af0f94ec1ac19a57c86806c95834de5d33c
>
> Committed: https://crrev.com/5fe8124cafd9ea996b99cfc88366315aad0c63b2
> Cr-Commit-Position: refs/heads/master@{#313589}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369661
Review URL: https://codereview.chromium.org/874743003
Cr-Commit-Position: refs/heads/master@{#313765}
Optimize all Chrome for Android PNG assets.
This change decreases our APK size by 67,065 bytes.
[email protected]
[email protected]
BUG=407781
Review URL: https://codereview.chromium.org/889683002
Cr-Commit-Position: refs/heads/master@{#313764}
ozone: Fix chromium-style warnings in rendering_helper.cc
This fixes the linux_chromium_chromeos_ozone_rel_ng bot:
../../content/common/gpu/media/rendering_helper.cc:105:31: error: [chromium-style] Overriding method must be marked with 'override' or 'final'.
virtual ~StubOzoneDelegate() {}
^
override
TBR=posciak (red build)
NOTRY=true
BUG=none
TEST=linux_chromium_chromeos_ozone_rel_ng trybot
Review URL: https://codereview.chromium.org/875573004
Cr-Commit-Position: refs/heads/master@{#313763}
[Local NTP] Add role="presentation" on the New Tab Page iframes.
BUG=449748
Review URL: https://codereview.chromium.org/869073004
Cr-Commit-Position: refs/heads/master@{#313762}
cc: fix for Ganesh in MSAA mode.
When rendering in Ganesh with MSAA enabled, request that skia flush each
canvas after drawing a tile. This will cause the MSAA render targets
to be resolved to the shared texture which CC subsequently draws.
BUG=
Review URL: https://codereview.chromium.org/885883002
Cr-Commit-Position: refs/heads/master@{#313761}
Roll src/third_party/skia 5d8388b:5444393
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5d8388b..5444393
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/880983004
Cr-Commit-Position: refs/heads/master@{#313760}
NaCl: Move src/trusted/plugin/ to components/nacl/renderer/plugin/
This moves the "trusted plugin" code so that all the NaCl
renderer-side code is in the same place, under
components/nacl/renderer/. I've used the "renderer/plugin/" subdir so
that this legacy code is distinguished from the newer code that's
directly under "renderer/".
This will make further incremental cleanups easier: It will enable
closer integration between renderer/* and renderer/plugin/*. Rather
than indirecting through PPB_NaCl_Private/PPP_PexeStreamHandler, it
would be reasonable for the two sides to share pointers to C++
objects. Doing that will be more acceptable when the two sides live
in the same directory.
* chrome/chrome_tests.gypi: Declaring a runtime dependency isn't
necessary since the trusted plugin isn't a separate DSO/DLL these
days.
* .gitignore: Remove reference to ppGoogleNaClPluginChrome.xml, which
no longer exists.
* module_ppapi.h: Added an #include guard.
BUG=239656
TEST=trybots
Review URL: https://codereview.chromium.org/876483002
Cr-Commit-Position: refs/heads/master@{#313759}
Fix setup_unittests compile break following r313626.
BUG=453313
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/884013004
Cr-Commit-Position: refs/heads/master@{#313758}
roll gyp 2028:2029
r2029: mac: Followup to ZERO_AR_DATE, touch the -o archive, rather than expecting only one
[email protected]
BUG=342974,451499
Review URL: https://codereview.chromium.org/887753002
Cr-Commit-Position: refs/heads/master@{#313757}
gpu: Perf test to check costs of texture upload at different stages.
Simple test that uploads and draws a texture on an offscreen surface.
The upload/draw code is run multiple times, timings are collected and the
average elapsed milliseconds are printed out using the perf_test framework.
The test target has not been added to the perf tests the are automatically run yet
and has to be manually run.
BUG=423481
Review URL: https://codereview.chromium.org/871093002
Cr-Commit-Position: refs/heads/master@{#313756}
Disable AccessibilityAriaGrabbed due to flakiness
BUG=453485
[email protected]
Review URL: https://codereview.chromium.org/871193007
Cr-Commit-Position: refs/heads/master@{#313755}
Fixing the super-long delay when GCMAccountTracker posts a task
* In order to sort out dependencies between initialization of components, I am doing work only when I have a valid GCM connection going (this means all the infrastructure is up and running).
* I am also making sure that time to next token reporting is always between 0 and 12 hours.
BUG=453018
Review URL: https://codereview.chromium.org/885753002
Cr-Commit-Position: refs/heads/master@{#313754}
Add more logging to debug DumpAccessibilityEvent* test failures
BUG=440579
TBR=thakis
Review URL: https://codereview.chromium.org/867483008
Cr-Commit-Position: refs/heads/master@{#313753}
Enhance audio player tests.
Enhance the audio player tests to cover multiple loops over the data and
odd sizes of data.
[email protected]
BUG=None.
Review URL: https://codereview.chromium.org/886593005
Cr-Commit-Position: refs/heads/master@{#313752}
Replace SkProxyCanvas with SkNWayCanvas.
We are removing SkProxyCanvas, which is a subset of SkNWayCanvas.
BUG=skia:3279
Review URL: https://codereview.chromium.org/876933005
Cr-Commit-Position: refs/heads/master@{#313751}
[DevTools] DevToolsEmbedderMessageDispatcher: variadic implementation of RegisterHandler
BUG=
Review URL: https://codereview.chromium.org/887453002
Cr-Commit-Position: refs/heads/master@{#313750}
Allow full-screen mode when not connected, and remember the previous setting.
This CL also includes a small refactoring of the desktop- vs. app-remoting split.
BUG=432361
Review URL: https://codereview.chromium.org/875583002
Cr-Commit-Position: refs/heads/master@{#313749}
Roll src/third_party/WebKit e9d57a2:7020f55 (svn 189200:189202)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e9d57a2..7020f55
[email protected],[email protected]
Review URL: https://codereview.chromium.org/892483002
Cr-Commit-Position: refs/heads/master@{#313748}
Extensions: Consolidate extension id hashing / searching.
Review URL: https://codereview.chromium.org/850853002
Cr-Commit-Position: refs/heads/master@{#313747}
Initialize variations seed fetching via OnAppEnterForeground.
On Android, instead of calling StartRepeatedVariationsSeedFetch()
in chrome_browser_main.cc, this changes the code to instead have
that be called by the first call to OnAppEnterForeground().
This will allow (in a future change) to have the caller of
OnAppEnterForeground() to first set the restrict mode param,
before fetching gets initialized. (Otherwise, fetching was
being initialized too early before the param could be set.)
BUG=452605
Review URL: https://codereview.chromium.org/880263005
Cr-Commit-Position: refs/heads/master@{#313746}
DevTools: rename RenderViewDevToolsAgentHost to RenderFrame*.
R=dgozman
TBR=nasko
BUG=451004
Review URL: https://codereview.chromium.org/884873004
Cr-Commit-Position: refs/heads/master@{#313745}
[Toolbar] Move the component toolbar actions test to be cross-platform.
The mac toolbar redesign has been implemented to the point where this test can
be cross-platform. Move it to be so.
BUG=429810
BUG=422381
[email protected] (moving a file)
Review URL: https://codereview.chromium.org/884473006
Cr-Commit-Position: refs/heads/master@{#313744}
Add test list for win asan dll bot.
BUG=448790
TBR=phajdan
Review URL: https://codereview.chromium.org/882823006
Cr-Commit-Position: refs/heads/master@{#313743}
Move referrer policy to a different field when serializing.
Also try to fix old entries when possible and play nice with older
versions
BUG=450589
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/869613006
Cr-Commit-Position: refs/heads/master@{#313742}
Add tests for resizing VPX larger than initial size.
libvpx/VP8 currently allows resizing upward but will crash on codec
teardown in that case; these tests ensure we don't regress when we
remove the workarounds in VideoEncoderVpx.
BUG=134202
Review URL: https://codereview.chromium.org/866533004
Cr-Commit-Position: refs/heads/master@{#313741}
Componentize TopSites, TopSitesBackend, TopSitesDatabase
TopSites prepopulated pages are not injected by the embedder via the
TopSitesFactory. The method TopSites::GetPrepopulatedSites() now does return
the sites favicon, thumbnail and color in addition to the URL and title.
TopSitesImplTest now can inject prepopulated pages to the TopSitesImpl thus
enabling the test TopSitesImplTest.BlacklistingWithPrepopulated on Android.
Change TopSites so that it does not inherit from content::NotificationObserver
as it does not need to listen to notification and move the inheritance to
TopSitesImpl (until the code is changed to use observer pattern instead of
notifications).
Remove dependency of TopSitesBackend on content::BrowserThread by injecting a
base::SingleThreadedTaskRunner reference to the corresponding thread via the
TopSitesImpl::Init() method.
Introduce //components/test/data/history and move pristine SQL files used by
the different unit tests there, helping remove dependency of the unit tests
on //chrome.
Move top_sites.{cc,h}, top_sites_database.{cc,h} into
//components/history/core/browser.
BUG=380144, 380157
TBR=sky, dgozman, samarth
Review URL: https://codereview.chromium.org/870063002
Cr-Commit-Position: refs/heads/master@{#313740}
Route resource dispatch tasks via the loading task queue
This patch should make the main thread more responsive when the user
is interacting with the device while the page is loading.
Sherrifs if you see an uptick in blink layout test flakes this patch
might be to blame.
I tried to reproduce the flakes I saw in the try runs locally.
With the exception of fast/loader/subframe-removes-itself.html
I was not able to reproduce a flake, however judging by the flakiness
dashboard, that test is already slightly flaky.
BUG=391005
Review URL: https://codereview.chromium.org/882073002
Cr-Commit-Position: refs/heads/master@{#313739}
Initialize create_disposition to FILE_OPEN in sandbox
This is a follow-up fix for:
https://crrev.com/90b41f569db5cff7a8b8d170b81516dd006f57ba
[email protected]
BUG=438157
Review URL: https://codereview.chromium.org/890643002
Cr-Commit-Position: refs/heads/master@{#313738}
Make gdb debugging on un-rooted devices work for Android 5.x.
Android 5.x does not allow running the gdb executable in
/data/local/tmp. For gdb to be executable by the package
it need to be located in /data/data/{PACKAGE-NAME} which is
allowed to run the exucutable.
BUG=453379
Review URL: https://codereview.chromium.org/884993003
Cr-Commit-Position: refs/heads/master@{#313737}
Capitalize "Cocoa" in c/b/ui/cocoa/extensions/.
Review URL: https://codereview.chromium.org/886483005
Cr-Commit-Position: refs/heads/master@{#313736}
[Password manager tests] Makes logs which we pass to sheet cleaner.
Instead of logging full exception we log only message.
[email protected]
BUG=435249
Review URL: https://codereview.chromium.org/889453006
Cr-Commit-Position: refs/heads/master@{#313735}
Mac: Fix for janky tab dragging/reordering.
-[TabView drawRect:] was called repeatedly to unnecessarily update the glow
that is not changing or should not have changed.
1. Selected tabs don't have glow, so don't redraw on mouseMoved.
2. When dragging an unselected tab, the mouse point relative to the tab view
does not change, so no need to redraw the glow.
3. When a dragged unselected tab slides behind another tab, let the dragged tab
keep the glow instead of the tab in front of it (this is a behavior change).
I think this is the more correct behavior, and we never have to redraw tabs
while dragging.
BUG=452925
Review URL: https://codereview.chromium.org/882193003
Cr-Commit-Position: refs/heads/master@{#313734}
cc: Dirty the RenderSurfaceLayerList when taking copy requests.
When removing copy requests from a LayerImpl to fulfill the request,
this changes the RenderSurfaceLayerList that CalculateDrawProperties
would output. In particular, the layer would no longer keep itself as a
render target.
Since we fail to do this, the layer becomes !HasCopyRequest(), but keeps
itself as a target in the RenderSurfaceLayerList. Then when we go to
draw again (due to an animation or the like?) we skip appending the
layer's RenderPass since the subtree is hidden, but the layer is still
in the RenderSurfaceLayerList because we didn't recompute draw properties
and the layer copy request was keeping the hidden layer in the list.
This cognitive dissonance causes us to use a null RenderPass as
the target_render_pass in CalculateRenderPasses, which causes a crash as
soon as the (hidden) layer tries to append quads to the null surface.
R=vmpstr, [email protected]
BUG=439649
Review URL: https://codereview.chromium.org/883123003
Cr-Commit-Position: refs/heads/master@{#313733}
Roll src/third_party/WebKit c7f8106:e9d57a2 (svn 189197:189200)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c7f8106..e9d57a2
[email protected],[email protected]
Review URL: https://codereview.chromium.org/891473003
Cr-Commit-Position: refs/heads/master@{#313732}
[Extensions Toolbar] Move some popup logic to be platform-agnostic
Move the "is popup showing" logic to the platform-agnostic
ExtensionActionViewController. This lets us:
- Have a slimmer platform delegate.
- Implement OnPopupShown/Closed pressed-state logic on mac.
- Add cross-platform popup browsertests.
BUG=429810
BUG=422381
[email protected] (micro changes to page_action_image_view)
Review URL: https://codereview.chromium.org/869873008
Cr-Commit-Position: refs/heads/master@{#313731}
[Extensions Toolbar Mac] Adjust button threshold for hiding
Since the toolbar frame now includes the proper padding,
icons are a little too eager to show after adjusting the
chevron. Make them a bit more shy again (hide them if they
have >= 3px not displayed when adjusting the toolbar).
BUG=452475
Review URL: https://codereview.chromium.org/881573004
Cr-Commit-Position: refs/heads/master@{#313730}
Update mojo sdk to rev 126532ce21c5c3c55a1e1693731411cb60169efd
Update HTMLViewer for de-clienting of Shell.
Update ServiceRegistryTest.java for de-clienting of MathCalculator.
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/883843002
Cr-Commit-Position: refs/heads/master@{#313729}
Remove 32-bit Mac implementation of EnableTerminationOnHeapCorruption().
This removes CrMallocErrorBreak, since in 64-bit mode, Libc's malloc already
makes this case fatal.
BUG=453141
[email protected]
Review URL: https://codereview.chromium.org/889583003
Cr-Commit-Position: refs/heads/master@{#313728}
Introducing new switches for default wallpapers for accounts for kids.
BUG=433787
Review URL: https://codereview.chromium.org/869073003
Cr-Commit-Position: refs/heads/master@{#313727}
Fix chromeos gn build
Chrome OS needs a dependency on //components/onc
BUG=453451
TEST=compiles
NOTRY=true
Review URL: https://codereview.chromium.org/880393004
Cr-Commit-Position: refs/heads/master@{#313726}
Roll src/third_party/skia 402448d:5d8388b
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/402448d..5d8388b
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/890533003
Cr-Commit-Position: refs/heads/master@{#313725}
[Extensions] Cache extension action icons
Cache extension action icons so that they don't have to be
reloaded each time a new view is created (i.e., each time a
new browser or the new overflow menu is opened).
BUG=452958
Review URL: https://codereview.chromium.org/885443004
Cr-Commit-Position: refs/heads/master@{#313724}
Roll src/third_party/WebKit ce78944:c7f8106 (svn 189190:189197)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ce78944..c7f8106
[email protected],[email protected]
Review URL: https://codereview.chromium.org/885893002
Cr-Commit-Position: refs/heads/master@{#313723}
Reland On Android, links inside headings should be announced as headings by TalkBack
https://codereview.chromium.org/845663002
BUG=446216
Committed: https://crrev.com/217066c608ea473d2ac70e737c69ff11a0425d44
Cr-Commit-Position: refs/heads/master@{#313248}
Review URL: https://codereview.chromium.org/854203003
Cr-Commit-Position: refs/heads/master@{#313722}
Add cr_cronet.py stack command to symbolize native stack from adb logcat.
BUG=
Review URL: https://codereview.chromium.org/880373003
Cr-Commit-Position: refs/heads/master@{#313721}
bluetooth: Narrow device/bluetooth DEPS in content/browser to c/b/bluetooth.
The initial addition to content/browser was needlessly broad.
Review URL: https://codereview.chromium.org/869873006
Cr-Commit-Position: refs/heads/master@{#313720}
Remove deprecated (and unused) method.
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/884873005
Cr-Commit-Position: refs/heads/master@{#313719}
Roll WebRTC 8176:8207, Libjingle 8174:8202
WebRTC 8176:8207
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9fbfe8f..1a48d11
Libjingle 8174:8202
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/6660ffc..237ae43
This rolls in a revert of a breaking change in Chromium.
[email protected]
Review URL: https://codereview.chromium.org/880553005
Cr-Commit-Position: refs/heads/master@{#313718}
Disable network state reporting.
Update the DeviceStatusCollector to no longer report network state. We will
re-enable this for M42 once we've added code to detect an auto-launched kiosk
session.
BUG=452968
Review URL: https://codereview.chromium.org/885853002
Cr-Commit-Position: refs/heads/master@{#313717}
Update histograms.xml wrt new V8.Compile{Cacheable,Noncacheable}MicroSeconds histograms.
[email protected], [email protected]
BUG=chromium:399580
Review URL: https://codereview.chromium.org/886463009
Cr-Commit-Position: refs/heads/master@{#313716}
Switch from nm to objdump for the cygprofile tools.
This is required for further refactoring (use in symbolize.py), as nm
doesn't provide the section name.
Also, some functions in symbol_extractor.py are not
used yet, they will in the next CLs of the refactoring.
BUG=452879
Review URL: https://codereview.chromium.org/886563002
Cr-Commit-Position: refs/heads/master@{#313715}
Revert of Roll WebRTC 8176:8203, Libjingle 8174:8202 (patchset #2 id:20001 of https://codereview.chromium.org/885003003/)
Reason for revert:
Appears to have broken Mac browser tests:
- WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams
- WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs
[75316:29699:0129/074049:FATAL:overuse_frame_detector.cc(388)] Check failed: processing_thread_.CalledOnValidThread().
0 libbase.dylib 0x0000000119eaf88f base::debug::StackTrace::StackTrace() + 47
1 libbase.dylib 0x0000000119eaf8e3 base::debug::StackTrace::StackTrace() + 35
2 libbase.dylib 0x0000000119f09076 logging::LogMessage::~LogMessage() + 70
3 libbase.dylib 0x0000000119f080c3 logging::LogMessage::~LogMessage() + 35
4 libcontent.dylib 0x000000012ce82cd5 webrtc::OveruseFrameDetector::TimeUntilNextProcess() + 245
5 libcontent.dylib 0x000000012c8dfdfd webrtc::ProcessThreadImpl::Process() + 525
6 libcontent.dylib 0x000000012c8df836 webrtc::ProcessThreadImpl::Run(void*) + 38
7 libcontent.dylib 0x000000012c6ce390 webrtc::ThreadPosix::Run() + 288
8 libcontent.dylib 0x000000012c6ce076 webrtc::StartThread(void*) + 38
9 libsystem_pthread.dylib 0x00007fff8fe5f899 _pthread_body + 138
10 libsystem_pthread.dylib 0x00007fff8fe5f72a _pthread_struct_init + 0
11 libsystem_pthread.dylib 0x00007fff8fe63fc9 thread_start + 13
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/2438
Original issue's description:
> Roll WebRTC 8176:8203, Libjingle 8174:8202
>
> WebRTC 8176:8203
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9fbfe8f..7b9e261
>
> Libjingle 8174:8202
> Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/6660ffc..237ae43
>
> [email protected]
>
> Committed: https://chromium.googlesource.com/chromium/src/+/8aa707b5aa26cead2ab4791672163337c92f904b
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/888593002
Cr-Commit-Position: refs/heads/master@{#313714}
Roll src/third_party/skia 9cc2f26:402448d
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9cc2f26..402448d
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/890563002
Cr-Commit-Position: refs/heads/master@{#313713}
Roll src/third_party/WebKit 15e603d:ce78944 (svn 189183:189190)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/15e603d..ce78944
[email protected],[email protected]
Review URL: https://codereview.chromium.org/887663003
Cr-Commit-Position: refs/heads/master@{#313712}
[Password manager tests] Fix bugs & use subprocesses to run tests.
Fixes indentation bug in test runner and switches from using os to
subprocesses.
[email protected]
BUG=435249
Review URL: https://codereview.chromium.org/884403002
Cr-Commit-Position: refs/heads/master@{#313711}
Fill empty fields from keyring result with default values.
This is fixing of crashes in libsecret when some of fields from keyring result are absent.
BUG=453218
Review URL: https://codereview.chromium.org/891463002
Cr-Commit-Position: refs/heads/master@{#313710}
[Win] Fix crash if the profile dir cannot be created
If the profile is NULL, the code will hit the CHECK on line 389 anyway.
BUG=414332
Review URL: https://codereview.chromium.org/878143003
Cr-Commit-Position: refs/heads/master@{#313709}
Reland Queue commands to the Os to start a video device.
This cl reland Queue commands to the Os to start a video device, originally reviewed in https://codereview.chromium.org/801363002. (patchset 1)
In patchset 2, the issue found in crbug/450382 related to patchset(1) is addressed. |Device| is made into a class and thread checks are added.
BUG=428891,450382,450226
Review URL: https://codereview.chromium.org/862063002
Cr-Commit-Position: refs/heads/master@{#313708}
Re-land: Tweak output of (memcheck|drmemory)_analyze.py.
Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
to extract them with GTestLogParser and use them as snippets.
Re-land with syntax errors fixed.
BUG=453020
[email protected]
Review URL: https://codereview.chromium.org/875353003
Cr-Commit-Position: refs/heads/master@{#313707}
GetEffectiveDomain should handle ws scheme as same as http scheme.
CookieMonster::AnyEquivalentCookie asserts that there are no multiple
cookies that are identical to each other. That is achieved by inserting / deleting
cookies carefully, but it goes wrong with WebSocket schemes.
CookieMonster::DoCookieTaskForURL for given URL loads cookies when
cookies for key = cookie_util::GeteEffectiveDomain(scheme, host) is not
yet loaded. When the task ends, it stores loaded cookies and marks the key as
loaded. cookie_util::GetEffectiveDomain consults
egistry_controlled_domains::GetDomainAndRegistry
when http or https schemes are given, whereas it doesn't when ws or wss
schemes are given.
Imagine we are about to load stored cookies for ws://www.example.com/
and http://www.example.com/. As written above, they have different keys:
www.example.com and example.com. So each of them is loaded and it breaks
the assertion.
BUG=370021
[email protected]
Review URL: https://codereview.chromium.org/859663003
Cr-Commit-Position: refs/heads/master@{#313706}
Roll WebRTC 8176:8203, Libjingle 8174:8202
WebRTC 8176:8203
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/9fbfe8f..7b9e261
Libjingle 8174:8202
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/6660ffc..237ae43
[email protected]
Review URL: https://codereview.chromium.org/885003003
Cr-Commit-Position: refs/heads/master@{#313705}
GuestViewMessageFilter: Fix include
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/865453003
Cr-Commit-Position: refs/heads/master@{#313704}
components: Cleanup and sort another components_unittests deps list.
BUG=None
TEST=components_unittests
[email protected]
Review URL: https://codereview.chromium.org/877423002
Cr-Commit-Position: refs/heads/master@{#313703}
bookmarks: BookmarkNodeData's size() cleanups.
* Fix the implementation of has_single_url() method.
It is incorrect to check is_valid() because the elements
vector can contain more than 1 item. And thus the
is_valid() check does not make sense, since it just check
if the vector is not empty, not that it just contains one element.
* Use is_valid() method when possible.
* Use has_single_url() method when it makes sense.
* Use data.size() to avoid a temp variable.
BUG=None
TEST=chrome still links and works as before, existing unit tests in components_unittests.
[email protected]
Review URL: https://codereview.chromium.org/870293002
Cr-Commit-Position: refs/heads/master@{#313702}
Fixed crash when looking for iframe when gaia is being hosted in webview
BUG=426316
TEST=manual
Review URL: https://codereview.chromium.org/882353002
Cr-Commit-Position: refs/heads/master@{#313701}
Added flag gaia-endpoint for testing with different flows
BUG=451959
TEST=manual
Review URL: https://codereview.chromium.org/878913003
Cr-Commit-Position: refs/heads/master@{#313700}
Roll src/third_party/WebKit 4e5e7f1:15e603d (svn 189181:189183)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4e5e7f1..15e603d
[email protected],[email protected]
Review URL: https://codereview.chromium.org/882393002
Cr-Commit-Position: refs/heads/master@{#313699}
Updating trunk VERSION from 2291.0 to 2292.0
Cr-Commit-Position: refs/heads/master@{#313698}
Revert of Don't refcount tracking id -> slot id mapping. (patchset #6 id:120001 of https://codereview.chromium.org/785753002/)
Reason for revert:
Reverting due to memory failures.
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%283%29/builds/5041/steps/memory%20test%3A%20content/logs/stdio
{
UNINITIALIZED READ
name=<insert_a_suppression_name_here>
content.dll!content::TouchEventQueue::TouchMoveSlopSuppressor::FilterEvent
content.dll!content::TouchEventQueue::FilterBeforeForwarding
content.dll!content::TouchEventQueue::TryForwardNextEventToRenderer
content.dll!content::TouchEventQueue::ProcessTouchAck
content.dll!content::InputRouterImpl::ProcessInputEventAck
content.dll!content::InputRouterImpl::OnInputEventAck
content.dll!InputHostMsg_HandleInputEvent_ACK::Dispatch<>
content.dll!content::InputRouterImpl::OnMessageReceived
content.dll!content::RenderWidgetHostImpl::OnMessageReceived
*!content::RenderWidgetHostViewAuraTest_TouchEventState_Test::TestBody
*!testing::internal::HandleExceptionsInMethodIfSupported<>
}
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%284%29/builds/40143/steps/memory%20test%3A%20content/logs/stdio
UninitCondition
Conditional jump or move depends on uninitialised value(s)
content::TouchEventQueue::TouchMoveSlopSuppressor::FilterEvent(blink::WebTouchEvent const&) (content/browser/renderer_host/input/touch_event_queue.cc:240)
content::TouchEventQueue::FilterBeforeForwarding(blink::WebTouchEvent const&) (content/browser/renderer_host/input/touch_event_queue.cc:715)
content::TouchEventQueue::TryForwardNextEventToRenderer() (content/browser/renderer_host/input/touch_event_queue.cc:445)
content::TouchEventQueue::ProcessTouchAck(content::InputEventAckState, ui::LatencyInfo const&) (content/browser/renderer_host/input/touch_event_queue.cc:436)
content::InputRouterImpl::ProcessTouchAck(content::InputEventAckState, ui::LatencyInfo const&) (content/browser/renderer_host/input/input_router_impl.cc:666)
content::InputRouterImpl::ProcessInputEventAck(blink::WebInputEvent::Type, content::InputEventAckState, ui::LatencyInfo const&, content::InputRouterImpl::AckSource) (content/browser/renderer_host/input/input_router_impl.cc:576)
content::InputRouterImpl::OnInputEventAck(InputHostMsg_HandleInputEvent_ACK_Params const&) (content/browser/renderer_host/input/input_router_impl.cc:483)
_Z20DispatchToMethodImplIN7content15InputRouterImplEMS1_FvRK40InputHostMsg_HandleInputEvent_ACK_ParamsEJS2_EJLm0EEEvPT_T0_RK5TupleIJDpT1_EE13IndexSequenceIJXspT2_EEE (base/tuple.h:246)
Suppression (error hash=#675E7177BFE2BE12#):
For more info on using suppressions see http://dev.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/memory-sheriff#TOC-Suppressing-memory-reports
{
<insert_a_suppression_name_here>
Memcheck:Uninitialized
fun:_ZN7content15TouchEventQueue23TouchMoveSlopSuppressor11FilterEventERKN5blink13WebTouchEventE
fun:_ZN7content15TouchEventQueue22FilterBeforeForwardingERKN5blink13WebTouchEventE
fun:_ZN7content15TouchEventQueue29TryForwardNextEventToRendererEv
fun:_ZN7content15TouchEventQueue15ProcessTouchAckENS_18InputEventAckStateERKN2ui11LatencyInfoE
fun:_ZN7content15InputRouterImpl15ProcessTouchAckENS_18InputEventAckStateERKN2ui11LatencyInfoE
fun:_ZN7content15InputRouterImpl20ProcessInputEventAckEN5blink13WebInputEvent4TypeENS_18InputEventAckStateERKN2ui11LatencyInfoENS0_9AckSourceE
fun:_ZN7content15InputRouterImpl15OnInputEventAckERK40InputHostMsg_HandleInputEvent_ACK_Params
fun:_Z20DispatchToMethodImplIN7content15InputRouterImplEMS1_FvRK40InputHostMsg_HandleInputEvent_ACK_ParamsEJS2_EJLm0EEEvPT_T0_RK5TupleIJDpT1_EE13IndexSequenceIJXspT2_EEE
}
I haven't been able to reproduce this consistently locally, which is making it tricky to pin down. Once I have (or I've determined this patch isn't what's causing the failures), I'll reland.
Original issue's description:
> Don't refcount tracking id -> slot id mapping.
>
> Previously we tried to refcount the tracking id to slot id mapping.
> This broke in some circumstances where the number of press events was
> not equal to the number of release events.
>
> This patch switches to marking some touch events such that they don't
> modify the mapping, simplifying logic, and fixing a nasty bug.
>
> BUG=439051
> TEST=EventsXTest.TouchEventNotRemovingFromNativeMapping
>
> Committed: https://crrev.com/47a823b565a4051e58d83a857738c0fb8417d9ac
> Cr-Commit-Position: refs/heads/master@{#313520}
[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=439051
Review URL: https://codereview.chromium.org/869433007
Cr-Commit-Position: refs/heads/master@{#313697}
iOS gtest launcher: retry tests in one big batch
Without it the overhead of serialized ios simulator run is too big.
BUG=426870
[email protected], [email protected]
Review URL: https://codereview.chromium.org/886463003
Cr-Commit-Position: refs/heads/master@{#313696}
Roll src/third_party/WebKit af451c1:4e5e7f1 (svn 189178:189181)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/af451c1..4e5e7f1
[email protected],[email protected]
Review URL: https://codereview.chromium.org/888553002
Cr-Commit-Position: refs/heads/master@{#313695}
Fix for Hyperlinks do not open in new tab by Print preview window.
navigate function of navigator object is not getting called.
Changes done so that navigate function of navigator will get called
with proper url and newTab as true value.
BUG=453307
Review URL: https://codereview.chromium.org/886773003
Cr-Commit-Position: refs/heads/master@{#313694}
Add option to pass path to adb to host_forwarder.
[email protected]
Review URL: https://codereview.chromium.org/882373002
Cr-Commit-Position: refs/heads/master@{#313693}
Roll src/third_party/WebKit 01a83c9:af451c1 (svn 189171:189178)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/01a83c9..af451c1
[email protected],[email protected]
Review URL: https://codereview.chromium.org/886773002
Cr-Commit-Position: refs/heads/master@{#313692}
UMA statistics for Linux password storage backend usage
Our main goal is to understand how often is the situation when no security storage is available on Linux and plain text (actually SQL lite db) is used for password storage.
BUG=355223
Review URL: https://codereview.chromium.org/880943002
Cr-Commit-Position: refs/heads/master@{#313691}
Remove gdata test files that are no longer used.
BUG=357038
Review URL: https://codereview.chromium.org/881653005
Cr-Commit-Position: refs/heads/master@{#313690}
Add missig referrer policies to sanitization code
BUG=450589
[email protected]
Review URL: https://codereview.chromium.org/890473003
Cr-Commit-Position: refs/heads/master@{#313689}
Roll src/third_party/WebKit 61cdebe:01a83c9 (svn 189164:189171)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/61cdebe..01a83c9
[email protected],[email protected]
Review URL: https://codereview.chromium.org/871403006
Cr-Commit-Position: refs/heads/master@{#313688}
Cryptohome: Notify about error in async calls if cryptohome is not ready yet.
BUG=451148
Review URL: https://codereview.chromium.org/880303003
Cr-Commit-Position: refs/heads/master@{#313687}
Revert "Enable Roboto by default for testing purpose."
This reverts commit b138032ecd37b1225ac200f561d6232d423dd89a.
This seems to make RenderTextTest.TextDoesntClip to fail on Chrome OS Asan /Lsan.
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6266
BUG=448948
[email protected]
Review URL: https://codereview.chromium.org/889533002
Cr-Commit-Position: refs/heads/master@{#313686}
Show favicons in Site Settings lists.
BUG=451374
Review URL: https://codereview.chromium.org/866713003
Cr-Commit-Position: refs/heads/master@{#313685}
Fix build flakes in GN build due to wrong deps for grit action.
BUG=452847
Review URL: https://codereview.chromium.org/877333002
Cr-Commit-Position: refs/heads/master@{#313684}
Update V8 to version 4.2.35 (based on f7dc15febeea78b22de1f57c397a3221a43d9213).
[email protected]
Review URL: https://codereview.chromium.org/882313002
Cr-Commit-Position: refs/heads/master@{#313683}
Disable AutofillPopupControllerBrowserTest.DoNotHidePopupOnWindowMove on Mac.
Flaky on Mac, see bug.
BUG=453256
[email protected]
Review URL: https://codereview.chromium.org/889483003
Cr-Commit-Position: refs/heads/master@{#313682}
Updated device reporting code to report multiple samples of free RAM
DeviceStatusCollector used to report multiple CPU usage measurements, but only a
single free-RAM measurement. This CL changes the reporting code to report
multiple free-RAM measurements.
BUG=430908
Review URL: https://codereview.chromium.org/884063003
Cr-Commit-Position: refs/heads/master@{#313681}
Files.app: Remove multi-profile related fileManagerPrivate APIs that are no more used.
The CL removes:
* fileManagerPrivate.visitDesktop
* ImageSet
BUG=450129
TEST=None
[email protected]
[email protected], [email protected]
Review URL: https://codereview.chromium.org/819953005
Cr-Commit-Position: refs/heads/master@{#313680}
VP8Decoder: Drop references to reference frames earlier.
Drop references to reference frames before requesting new surfaces to
ensure we don't hold onto them while the Accelerator is changing resolution,
risking reusing a stale buffer.
BUG=chrome-os-partner:35539
TEST=Hangouts, vdatest
Review URL: https://codereview.chromium.org/880773009
Cr-Commit-Position: refs/heads/master@{#313679}
Automated Commit: Committing new LKGM version 6735.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#313678}
Add logging to debug DumpAccessibilityEvent* tests WinClang*
Note that accessibility_event_recorder_win a test helper, this
doesn't add logging to Chrome.
BUG=440579
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/873313009
Cr-Commit-Position: refs/heads/master@{#313677}
Rename gdata_errorcode.h to drive_api_error_codes.h
The term 'gdata' is no longer relevant, since we stiched from
WAPI (GDATA based API) to Drive API.
BUG=357038
TEST=everything builds as before
Review URL: https://codereview.chromium.org/881403003
Cr-Commit-Position: refs/heads/master@{#313676}
Refix of adb gdb su usage
Quotes to command now adding only if "su -c" parameter is present.
[email protected]
BUG=452237
Review URL: https://codereview.chromium.org/880853002
Cr-Commit-Position: refs/heads/master@{#313675}
Allow getrusage under ASAN.
BUG=413528
Review URL: https://codereview.chromium.org/890493002
Cr-Commit-Position: refs/heads/master@{#313674}
Dismiss permission bubble request if it's a duplicate
Currently seeing a crash when two iframes from the same origin request the
same permission. The issue arises because they have the same ID and therefore
the same entry in the hash map, which makes the request_ptr destruct. This CL
cancels the second (redundant) permission request.
BUG=433877
Review URL: https://codereview.chromium.org/799783002
Cr-Commit-Position: refs/heads/master@{#313673}
Tab, TabStrip: Added GetClassName override.
This helps with debugging a TabbedPane views hierarchy as you can print
the proper class names of Tabs and TabStrips inside.
Review URL: https://codereview.chromium.org/889453004
Cr-Commit-Position: refs/heads/master@{#313672}
Roll src/third_party/WebKit 5e88f46:61cdebe (svn 189160:189164)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5e88f46..61cdebe
[email protected],[email protected]
Review URL: https://codereview.chromium.org/890453003
Cr-Commit-Position: refs/heads/master@{#313671}
Make ppapi TestView use default browser test timeouts rather than internal ones
BUG=450908
Review URL: https://codereview.chromium.org/861343005
Cr-Commit-Position: refs/heads/master@{#313670}
Roll src/third_party/WebKit 34bc400:5e88f46 (svn 189156:189160)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/34bc400..5e88f46
[email protected],[email protected]
Review URL: https://codereview.chromium.org/886513003
Cr-Commit-Position: refs/heads/master@{#313669}
Fix infobar scrolling.
The infobar container became non-scrollable because InfoBarContainer now
ignores all touch events in InfoBarContainer.onTouch(). These touch
events need to be swallowed to prevent them from reaching the webpage,
but they should be swallowed in ContentWrapperView, not in
InfoBarContainer, so that InfoBarContainer (which extends ScrollView)
can be scrolled.
The offending CL: https://codereview.chromium.org/824763002
BUG=453103
Review URL: https://codereview.chromium.org/872113003
Cr-Commit-Position: refs/heads/master@{#313668}
Uprev Google Input Tools.
BUG=450050
Review URL: https://codereview.chromium.org/828063007
Cr-Commit-Position: refs/heads/master@{#313667}
Files.app: Fix date string generation for cloud import destinations.
BUG=451934
Review URL: https://codereview.chromium.org/879913005
Cr-Commit-Position: refs/heads/master@{#313666}
Use the main world script context for mime handler postMessage.
Previously, calling postMessage from an isolated world would use that
world's context for calling the proxy frame's postMessage(). This
resulted in "Illegal invocation" errors. This CL avoids this problem by
using the main world script context when calling postMessage on the
proxy frame.
BUG=453184
Review URL: https://codereview.chromium.org/861073004
Cr-Commit-Position: refs/heads/master@{#313665}
NaCl: Remove the IRT's Gyp dependency on libsrpc
Since I removed the IRT's calls to NaClSrpcModuleInit() and
NaClPluginLowLevelInitializationComplete(), the IRT no longer depends
on SRPC.
BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864
TEST=build
Review URL: https://codereview.chromium.org/878623004
Cr-Commit-Position: refs/heads/master@{#313664}
Make GL bindings conditional
In addition to the extensions also parse GL/GLES version
information from the headers (hence add a few fresh headers).
Instead of brute-forcing binding in somewhat unclear order
make all dynamic bindings very specifically conditional to
the GL version or extension, given the precise name.
If a function is not available, then leave function pointer
set to NULL so it will generate a crash (report).
(Previously it might have ended up as 0
or with whatever valid or not valid pointer GetProcAddr()
returned - i.e. GetProcAddr returning something does not
imply the functionality is there.)
The version also includes whether it is GLES or not which
means we won't look up functions on GLES anymore that are
specific to desktop or vice versa.
Update gpu_unittests so that they are very specific to what
extensions they need (otherwise they might end up calling
the _NotBound fallback).
Also make WGL/GLX/EGL/MESA bindings all happen rightaway since
they don't depend on a context.
BUG=438742,325668
Review URL: https://codereview.chromium.org/871763002
Cr-Commit-Position: refs/heads/master@{#313663}
text input focus: RemoveObserver when RenderProcessHost exits.
Makes sure that a WebView as RenderProcessHostObserver is removed from RenderProcessHost's observer list when RenderProcessHost exits.
BUG=290701
Review URL: https://codereview.chromium.org/878383002
Cr-Commit-Position: refs/heads/master@{#313662}
Gallery: Remove position: absolute; line for redo button.
The line is specified for the hidden redu button does not affect layout of other
buttons, but it removes the button from the layout even if the button is
visible, and it causes overlapping of the buttons. Actually we can remove the
line because hidden items are specified display: none; in Gallery.
BUG=450186
TEST=None
Review URL: https://codereview.chromium.org/866893004
Cr-Commit-Position: refs/heads/master@{#313661}
[android] Show keyboard switcher icon.
Show the keyboard switcher icon on the right edge of the navigation bar
when two or more IMEs are enabled and a physical keyboard is connected.
BUG=452543
Review URL: https://codereview.chromium.org/879403003
Cr-Commit-Position: refs/heads/master@{#313660}
Roll src/third_party/WebKit 9903025:34bc400 (svn 189151:189156)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9903025..34bc400
[email protected],[email protected]
Review URL: https://codereview.chromium.org/885783003
Cr-Commit-Position: refs/heads/master@{#313659}
Roll src/third_party/skia 52f401e:9cc2f26
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/52f401e..9cc2f26
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/890463002
Cr-Commit-Position: refs/heads/master@{#313658}
Fix build with gcc after #313406
Multiple friend declaration is causing warning with gcc 4.8.2 (at least).
Review URL: https://codereview.chromium.org/874933003
Cr-Commit-Position: refs/heads/master@{#313657}
Don't let "aapt crunch" increase image size.
For an image that's already optimized, aapt crunch typically increases
the image size. In this case, we now use the original image instead of
the crunched image. 9-patches, however, must always be crunched, since
crunching adds important metadata to the file.
Currently, this saves 50KB, but has the potential to save up to 300KB
once we optimize all the images in the codebase.
BUG=407781
Review URL: https://codereview.chromium.org/867483005
Cr-Commit-Position: refs/heads/master@{#313656}
add is_app_ready_predicate to testWebView in AndroidAppTest
BUG=452266
Review URL: https://codereview.chromium.org/880423002
Cr-Commit-Position: refs/heads/master@{#313655}
Adding an ALAC enum to AudioDecoderConfig
This CL enables using the ALAC codec within the media pipeline.
This does not add ALAC support, as the ALAC codec is not part of the current build.
BUG=441343
Review URL: https://codereview.chromium.org/881603002
Cr-Commit-Position: refs/heads/master@{#313654}
Use conservative text blob bounds.
Speculative fix for http://crbug.com/451401.
BUG=451401
[email protected],[email protected]
Review URL: https://codereview.chromium.org/881343004
Cr-Commit-Position: refs/heads/master@{#313653}
Roll src/third_party/WebKit d0e8386:9903025 (svn 189148:189151)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d0e8386..9903025
[email protected],[email protected]
Review URL: https://codereview.chromium.org/863903003
Cr-Commit-Position: refs/heads/master@{#313652}
Re-layout grid view and add check marks for selected items.
Changes are:
- Changed layout of grid view.
- Made thumbnails fill entire item area.
- Use check marks to indicate selected items.
BUG=402344
TEST=run browser_tests
Review URL: https://codereview.chromium.org/885653002
Cr-Commit-Position: refs/heads/master@{#313651}
Run "git stash" and "git stash apply" before and after a dry test run.
Reason: We don't want to destroy local uncommited changes when running tests.
One solution was to mock bisect_utils.GitRun -- doing that caused the course of the run to change, making it so that there were no results (since git log is used to get a list of revisions, even for the dry run). So if we want to solve this problem by mocking git, we should replace it with a fake RunGit that returns different canned values depending on what the input is.
The advantage of stash/apply is that its simpler, but it's also a little bit slower than the above way.
BUG=
Review URL: https://codereview.chromium.org/847393004
Cr-Commit-Position: refs/heads/master@{#313650}
Fix Hangouts link for apps v2.
BUG=452230
Review URL: https://codereview.chromium.org/883123002
Cr-Commit-Position: refs/heads/master@{#313649}
Roll DomDistillerJS
Picked up changes:
197d576 Delete a bunch of gwt test environment-specific things
ae707d0 Remove DomToSaxVisitor and rename some classes
e8b2fcd Add a WebDocument class
52c4790 Support verbose output in jstest
ac006fe Remove ant target "test.dev" and "test.prod"
7db0bf4 Trim trailing spaces in java source code
0338d85 Fix all invalid URLs in tests
2489c81 Fix "Support test.filter for jstests"
442f8ee Reorganize all the code in the project.
2044b6f Support test.filter for jstests
ddb81f8 Disable some tests in PagingLinksFinderTest
82f505c Move PagingLinksFinderTest from test/ to jstest/
2f9ec7d Add a devtools panel to inject extraction script into the inspected window
9962247 Remove BoilerpipeProcessingException and other unused things.
491c7ce Use pre-compiled regexes for many things in PagingLinksFinder
e26e5ff Fix "Move ElementActionTest and TextBlockBuilderTest from test/ to jstest/"
6893a1a Move ElementActionTest and TextBlockBuilderTest from test/ to jstest/
6a97c63 Add util/TextBlockBuilderTest into DomDistillerTestSuite
d331041 Fix ElementActionTest
BUG=440102,440977
Review URL: https://codereview.chromium.org/884323002
Cr-Commit-Position: refs/heads/master@{#313648}
Add an OWNERS file for //chrome/browser/chromeos/login/easy_unlock
BUG=none
TEST=none
[email protected], [email protected], [email protected]
Review URL: https://codereview.chromium.org/887553002
Cr-Commit-Position: refs/heads/master@{#313647}
Roll opus to opus-HEAD-66611f1.
The third_party/opus/src CL is https://codereview.chromium.org/882843002.
Support MIPS optimizations in opus.
[email protected],[email protected]
BUG=452984
Review URL: https://codereview.chromium.org/865853005
Cr-Commit-Position: refs/heads/master@{#313646}
[Extensions Toolbar] Don't show the "show button" for hidden browser actions
Since browser actions that are hidden are now just overflowed to the wrench
menu, we don't really need the show button anymore.
BUG=453152
Review URL: https://codereview.chromium.org/879213005
Cr-Commit-Position: refs/heads/master@{#313645}
Roll src/third_party/WebKit b02f7f1:d0e8386 (svn 189139:189148)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b02f7f1..d0e8386
[email protected],[email protected]
Review URL: https://codereview.chromium.org/881633004
Cr-Commit-Position: refs/heads/master@{#313644}
[cast] Add optional VideoEncoder method to flush frames.
This patch adds EmitFrames() to VideoEncoder. The method is documented
as indicating that the encoder should produce all the frames that it may
be buffering for analysis.
This patch modifies VideoSender::InsertRawVideoFrame() to call
EmitFrames() when a frames is dropped because the in-flight frames
duration exceeds the target playout delay.
This patch provides an implementation of EmitFrames() for the
VideoToolbox H.264 encoder, which buffers frames for analysis as
described in the bug. It also uses the existing
max_number_of_video_buffers_used field in VideoConfig to set the
upper bound on the encoder's frame window.
BUG=450798
R=hclam, miu, DaleCurtis, Robert Sesek
Review URL: https://codereview.chromium.org/863083002
Cr-Commit-Position: refs/heads/master@{#313643}
Mojo's network service should use a disk cache on Android
Launching Mojo apps on Android is slow because we keep the network cache in
memory, which means we lose it every time we launch MojoShell. After this CL,
we use a disk cache on Android. Note: We still use a memory cache on desktop
because we want to be able to run many instances of mojo_shell in parallel on
desktop for testing.
[email protected]
BUG=452226
Review URL: https://codereview.chromium.org/883073003
Cr-Commit-Position: refs/heads/master@{#313642}
Update EV root metadata for a new batch of CAs
BUG=69557, 147116, 156816, 371734, 436102, 439948, 444504
TEST=Test each of the URLs listed in the diff (Linux or Windows) and ensure EV status is granted.
[email protected]
Review URL: https://codereview.chromium.org/879183002
Cr-Commit-Position: refs/heads/master@{#313641}
Disable WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams on Chrome OS
It fails on the official builders.
NOTRY=true
[email protected]
BUG=452623
Review URL: https://codereview.chromium.org/858153004
Cr-Commit-Position: refs/heads/master@{#313640}
Should use sofile instead of soname.
If soname is used here, nm cannot find the file if non-default
toolchain is used.
Review URL: https://codereview.chromium.org/884663002
Cr-Commit-Position: refs/heads/master@{#313639}
Bug fix for the pointer lock string problem, including:
(1) make the tile of the denyButton adaptive, such that
"Deny" will show on a mouse lock request instead of "Exit full screen."
(2) add unittest to verify its behavior.
XIB changes:
* Remove the default deny button title IDS_FULLSCREEN_EXIT_FULLSCREEN.
BUG=139944
Review URL: https://codereview.chromium.org/856253002
Cr-Commit-Position: refs/heads/master@{#313638}
Add UMA to histograms.xml for PLT.*_HTTPS_DataReductionProxy
BUG=374264
Review URL: https://codereview.chromium.org/884713004
Cr-Commit-Position: refs/heads/master@{#313637}
[Android] Tune default timeouts in provision_devices.
BUG=452961
Review URL: https://codereview.chromium.org/882093003
Cr-Commit-Position: refs/heads/master@{#313636}
content: Change appcache_interfaces.* to use contants from url/ component.
BUG=394382
[email protected]
Review URL: https://codereview.chromium.org/874073002
Cr-Commit-Position: refs/heads/master@{#313635}
Fix uninitialized timestamps being passed to the gesture lib
The CL corrects a bug where clock_gettime was placed in
a DCHECK call and thus not executed on release builds.
Contributed by [email protected]
BUG=chrome-os-partner:35111
TEST=samus ChromeOS build
Review URL: https://codereview.chromium.org/884313002
Cr-Commit-Position: refs/heads/master@{#313634}
[android] Autofill popup behavior fixes.
- Don't hide autofill popup on browser height change on Android.
Android keyboard can show or hide a strip of suggestions when user
switches between input fields. If the input field triggers showing the
autofill popup, the keyboard resize will hide it, which causes a UI
flash.
- Remove redundant Views code to hide autofill popup on window resize.
Browser process now has a cross-platform way to listen to window
resize and close the autofill popup. Removed Views-only resize
listener was also firing on window move. Removing it means that moving
the window without resizing it will not close the autofill popup. The
popup stays attached to the field during window move, however.
- Let autofill know when a password popup may be showing. This enables
autofill agent to hide the popup when the page scrolls.
- Re-enable showing username suggestions on first click on Android,
which now behaves on par with desktop.
BUG=430318
Review URL: https://codereview.chromium.org/870833002
Cr-Commit-Position: refs/heads/master@{#313633}
Add IPC fuzzer GenerateTraits for some cc types.
BUG=450268
[email protected],[email protected]
Review URL: https://codereview.chromium.org/873253004
Cr-Commit-Position: refs/heads/master@{#313632}
Add a slide-in pane to the OOP PDF viewer.
This CL adds the groundwork for a slide-in pane to be used by the OOP PDF Viewer. It adheres to the principles of Material Design, and will be used as a base for the bookmarks pane (which will display a list of bookmarks) as well as an info pane to show metadata of the PDF.
BUG=110020
Review URL: https://codereview.chromium.org/864753002
Cr-Commit-Position: refs/heads/master@{#313631}
cc: Remove the RenderPassId field from AppendQuadsData.
This field is redundant now that we pass a RenderPass* to AppendQuads.
A few tests were passing a different id and the same RenderPass* to
test DelegatedRendererLayerImpl, so I had to adjust the tests to
pass different RenderPass* instead.
R=vmpstr
Review URL: https://codereview.chromium.org/879423002
Cr-Commit-Position: refs/heads/master@{#313630}
ozone: evdev: Factor device I/O out of EventFactoryOzone
This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.
This splits EventFactoryOzone into two parts: EventFactoryOzone and
InputDeviceFactoryOzone. The new InputDeviceFactoryOzone class is now the
device I/O-centric part, and is intended to exist on a low-latency thread.
Hotplug events still originate on the UI thread, but this is not a
problem because hotplug is not latency critical. We're sharing udev
with the display code, so its easiest leave that code alone for now.
This doesn't add a new thread yet. Everything still runs on the UI thread.
BUG=449710
TEST=boot link_freon & move mouse
Review URL: https://codereview.chromium.org/863353003
Cr-Commit-Position: refs/heads/master@{#313629}
Enable Roboto by default for testing purpose.
The testing team wants to enable 'Roboto' by default and have real users to help report bugs too.
In this CL 'Roboto' is enabled by default and can be disabled by going to chrome://flags and turn 'disable-roboto-font-ui' to on.
Also modify the OobeWebUITest to make the tests run in full screen, otherwise the tests will fail due to the incorrect layout of supervised user creation UI (based on xiyuan@'s advice).
BUG=448948
TEST=tested on device (Pixel)
Review URL: https://codereview.chromium.org/868753005
Cr-Commit-Position: refs/heads/master@{#313628}
Roll src/third_party/WebKit c6b67b8:b02f7f1 (svn 189129:189139)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c6b67b8..b02f7f1
[email protected],[email protected]
Review URL: https://codereview.chromium.org/885743002
Cr-Commit-Position: refs/heads/master@{#313627}
[Installer] Cleaning up dead code for App Launcher / App Host installs.
The "shadow" App Launcher registry keys are still managed. The code that
do this are concentrated to the new files app_launcher_installer.* to
facilitate future updates.
This CL also significantly reduces the size of setup.exe, presumably due
to removal of dependencies.
TEST=Windows only. Install and update still work as before.
- Right after fresh install, ensure reg key at user level exists:
Google\Update\Clients\{FDA71E6F-AC4C-4a00-8B70-9958A68906BF}
BUG=297647
Review URL: https://codereview.chromium.org/811283002
Cr-Commit-Position: refs/heads/master@{#313626}
Add wuchengli@ as content/common/gpu/media OWNER.
BUG=None
NOTRY=true
Review URL: https://codereview.chromium.org/866263002
Cr-Commit-Position: refs/heads/master@{#313625}
[Chromoting] Add app_remoting/internal to .gitignore
BUG=
Review URL: https://codereview.chromium.org/884213002
Cr-Commit-Position: refs/heads/master@{#313624}
Fix DCHECK(!config_watcher_) in HostProcess::~HostProcess().
When shutting down HostProcess config_watcher_ is supposed to be deleted
on the nework thread. Previously ShutdownOnNetworkThread() was deleting
it, but that line was mistakenly removed in crrev.com/302162 . Adding
it back.
Review URL: https://codereview.chromium.org/885693003
Cr-Commit-Position: refs/heads/master@{#313623}
Eliminate last vestiges of the command system design.
Update ImportController to push all updates to a new 'CommandWidget' class. Add more test coverage.
BUG=420680
TEST=browser_test: FileManagerJsTest.*
Review URL: https://codereview.chromium.org/880303002
Cr-Commit-Position: refs/heads/master@{#313622}
Files.app: Add deduplication code for imports to Google Drive.
Add calls to hash generation and comparison code so that files being imported
into Google Drive are actually deduplicated.
BUG=420680
TEST=FileManagerJsTest.DuplicateFinderTest FileManagerJsTest.MediaImportHandlerTest
Review URL: https://codereview.chromium.org/885653003
Cr-Commit-Position: refs/heads/master@{#313621}
Upstream ViewUtils
BUG=429254
Review URL: https://codereview.chromium.org/882853003
Cr-Commit-Position: refs/heads/master@{#313620}
Refactor and cleanup scheduler_unittest.cc
The following lines are repeated in almost every test cc/scheduler/scheduler_unittest.cc file
FakeSchedulerClient client;
SchedulerSettings scheduler_settings;
scheduler_settings.use_external_begin_frame_source = true;
CREATE_SCHEDULER_AND_INIT_SURFACE(scheduler_settings);
created test fixture class and clean up to remove duplicate codes.
BUG=449028
Review URL: https://codereview.chromium.org/844763008
Cr-Commit-Position: refs/heads/master@{#313619}
Fix tabindex in chrome://settings/passwords
Updated code so that the first row is focusable. This makes it possible to
tab into the first row making it more obvious that it is focused.
Applied Dan's feedback from previous CL (https://codereview.chromium.org/834323005).
BUG=449110
Review URL: https://codereview.chromium.org/869813002
Cr-Commit-Position: refs/heads/master@{#313618}
Return void in zoomBy plumbing to match zoomBy public API
BUG=410900
Review URL: https://codereview.chromium.org/881383002
Cr-Commit-Position: refs/heads/master@{#313617}
Fix record_android_profile.py
Review URL: https://codereview.chromium.org/877323005
Cr-Commit-Position: refs/heads/master@{#313616}
Add more fine grained UMA for ExtensionService initialization time. At the
moment there is only total time and time to load all non-component extensions.
Time to load component extensions and time to notify all listeners is not
instrumented.
[email protected], [email protected]
BUG=453073
Review URL: https://codereview.chromium.org/883023003
Cr-Commit-Position: refs/heads/master@{#313615}
Implement base.IPC
In Chrome Apps, some platform APIs can only be called from the background
page (e.g. reloading a chrome.app.AppWindow). Likewise, some chrome API's
must be initiated by user interaction, which can only be called from the
foreground.
This CL base.IPC that provides helper functions to invoke methods on
different pages using chrome.runtime.sendMessage.
BUG=452317
Review URL: https://codereview.chromium.org/877993002
Cr-Commit-Position: refs/heads/master@{#313614}
ozone: Turn on chromium-style warnings for ChromeOS ozone
BUG=417463
TEST=build with chromeos=1 use_ozone=1
Review URL: https://codereview.chromium.org/884233002
Cr-Commit-Position: refs/heads/master@{#313613}
Suppress native app install banner if the site has a manifest.
This is the first step on support 'add to homescreen' banners for sites
that have manifests.
BUG=452825
Review URL: https://codereview.chromium.org/884623003
Cr-Commit-Position: refs/heads/master@{#313612}
Instrumenting GPU initialization for jank
We want to see how much GPU initialization contributes to startup slowness.
BUG=125248
Review URL: https://codereview.chromium.org/860293004
Cr-Commit-Position: refs/heads/master@{#313611}
This reverts two CLs
"compositor: Fix texture flipping for SW mirroring with surfaceless"
and
"Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds."
Reason for revert:
The original patch breaks software mirroring mode on at least veyron_jerry,
and quite possibly all non-freon systems.
>Original issue's descriptions:
> Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds.
> This fixes the GN build on Android after https://codereview.chromium.org/846063002.
>
> (The GYP build didn't break because content/browser/compositor/ is completely excluded there; see https://code.google.com/p/chromium/codesearch#chromium/src/content/content_tests.gypi&sq=package:chromium&&type=cs&l=1099)
>
> [email protected]
>
> Review URL: https://codereview.chromium.org/879543002
>
> Cr-Commit-Position: refs/heads/master@{#313074}
> compositor: Fix texture flipping for SW mirroring with surfaceless
>
> Ozone-surfaceless renders the scene flipped, so the texture contents are
> inverted from what they should be. This fixes the mirroring logic to
> un-flip the texture when needed, and also to send the right sub-buffer
> update rect.
>
> BUG=434115
>
> Committed: https://crrev.com/c6a481fe79e0c4851a576495105edf2600bfe5be
> Cr-Commit-Position: refs/heads/master@{#312979}
[email protected],[email protected],[email protected]
BUG=434115,451804
Review URL: https://codereview.chromium.org/865673003
Cr-Commit-Position: refs/heads/master@{#313610}
Add additional UMAs to keep track of unprefixed EME promise results
Also renames existing CreateSession to GenerateRequest to better match
the purpose of the promise.
BUG=351501
TEST=existing EME tests pass
Review URL: https://codereview.chromium.org/878633004
Cr-Commit-Position: refs/heads/master@{#313609}
Cleanup GuestViewMessageFilter
1. Use auto to improve readability.
2. Rename methods to remove "Extension" prefix.
3. Use const where possible.
4. Use using content::* to improve readability.
BUG=none
Review URL: https://codereview.chromium.org/880343002
Cr-Commit-Position: refs/heads/master@{#313608}
Fixing typo in the docstring for bisect_perf_regression.py
NOTRY=True
Review URL: https://codereview.chromium.org/873313010
Cr-Commit-Position: refs/heads/master@{#313607}
Add is_external_protocol to NavigationParams
Java layer needs an exact way to determine whether a URL uses an external
protocol or not.
is_external_protocol will be true if a URL can't be handled by Chrome's
internal protocol handlers.
BUG=426751
Review URL: https://codereview.chromium.org/884473004
Cr-Commit-Position: refs/heads/master@{#313606}
Remove extra call to UsbDeviceHandle::Close in chrome.usb.closeDevice.
When chrome.usb.closeDevice is called the device is explicitly closed in
the extension function implementation and then closed again when the
UsbDeviceResource object is destroyed. Only the latter is necessary as
that covers other ways in which the resource can be released.
Review URL: https://codereview.chromium.org/881363004
Cr-Commit-Position: refs/heads/master@{#313605}
Set serial connection parameters immediately on connect.
This change merges the initial call to SetCommState/tcsetattr with
the call to ConfigurePort so that parameters such as baud rate are
configured immediately when the port is opened. Default values for
these parameters are now always applied.
This works around an issue with some serial adapter drivers on Windows
that report an invalid baud rate through GetCommState. Having the
intended baud rate available for the first call to SetCommState allows
an application to provide a valid value so that Chrome does not have
to guess.
BUG=448407
Review URL: https://codereview.chromium.org/873903002
Cr-Commit-Position: refs/heads/master@{#313604}
Reject certificates that are valid for too long.
This is in conformance with the CA/Browser Forum Baseline Requirements for
certificate issuance.
This CL is adapted from a diff provided by [email protected]. Thanks!
BUG=119211
[email protected]
Review URL: https://codereview.chromium.org/724543002
Cr-Commit-Position: refs/heads/master@{#313603}
Captive portal interstitial: Use the same string for page title and header.
I've noticed that the localization of the strings are done differently, so
it's better to use the same string for both.
BUG=
Review URL: https://codereview.chromium.org/881973002
Cr-Commit-Position: refs/heads/master@{#313602}
ui/gfx/color_profile: Add GetDisplayColorProfile for an NSWindow
Add a GetDisplayColorProfile variant on Mac to return the display
color profile associated with a native window (NSWindow).
Add unit tests for on-screen, partially-on-screen, off-screen and
empty and null windows.
Note an sRGB color profile is a common case, especially on win32,
so GetDisplayColorProfile returns true and an empty color profile
in that case. Add a header file comment about that.
TEST=gfx_unittests --gtest_filter="ColorProfileTest*Window"
BUG=368694
Review URL: https://codereview.chromium.org/849523003
Cr-Commit-Position: refs/heads/master@{#313601}
Roll DomDistillerJS
Picked up changes:
56f7579 Rewrite SimilarSiblingContentExpansion
2fda06e Fix printing of logged non-ascii characters
8f4713b Only strip one stack frame from JS exceptions
efa4dce Remove unnecessary indent from code generation.
6134342 Fix TerminatingBlocksFinderTest
1f237e8 Make TerminatingBlocksFinder use a RegExp
80a34cf Change LogUtil.LOG_BUILDER to a String
9b2cdb2 Move most tests from test/ to jstest/
169cb83 Add JavaScript.parseFloat and parseInt
22cebe8 Change how TextBlock nodes are tracked
9be60c8 Add correct imports for generated JsTestEntryImpl
6b17bca Convert uses of emulated Pattern/Matcher to RegExp
c6bbc1e Add StringUtil.countWords and simplify TextBlockBuilder
7e2865e Simplify TextBlockBuilder
c73a770 Split the handling of TextNodes out of BHTMLCH
8fad736 Make test debugging more better
3e1e81e Handle equally scored candidate lead images.
a7ec3c8 Make JsTestEntry report correct success result
d2213f3 Remove unused TextBlock statistics
755df35 Add some more fancy gwt flags
6380f5c Add ElementAction that simplifies TagAction+labelStack
870b65e Move ignoring elements into FilteringDomVisitor.
48aaaa2 Use JUnit-style null assertions in OpenGraphProtocolParserTest
4ba963b querySelectorAll usage in parseMetaTags is covered in jstests
6bb3e26 Add DomDistillerJsTestCase
3f5efb3 Flesh out jstest environment
ef708c4 Use bash in install-build-deps.sh
9ef7a04 Add protobuf and xvfb packages to build deps.
33b9a04 Implement rest of the Assert interface
d75ad6b Correct function name
1d72a60 Scope repeated value for JSON converter.
e482386 Fix install-build-deps.sh for missed package
da40e84 Make jstests not fail the build
0d6b80e Add automated driver for jstests
92ae3ba Add better stack traces for jstests
a97c624 Modular heuristics for images
3bf867e Add framework for running tests in Chrome
cea631f Add .clang-format file to enable git cl format
fc23a51 Make image source absolute.
486fd14 Use java 7 and closure compiler
0dbffc4 Fix TextDocumentConstruction expectations
05c76c0 Remove gwt-2.5.1 and gwt_exporter
ed4df25 Roll gwt to 2.7.0 (from 2.5.1)
6dc14d3 Optimize SchemaOrgParser.parse for speed
d7c6805 Optimize OpenGraphProtocolParser.parseMetaTags for speed
64df32e Add fine-grained speed profiling inside MarkupParser
cd97d4f Remove a bunch of unused stuff
bf5347c Refactor handling of labels and tagactions
03cbda8 Rewrite DomWalker.walk
ee46df0 Create a simple reader mode extension
BUG=431067,435264,435371,440102,440977
Review URL: https://codereview.chromium.org/803963004
Cr-Commit-Position: refs/heads/master@{#313600}
Roll ANGLE with build fix.
BUG=453037
Review URL: https://codereview.chromium.org/886633002
Cr-Commit-Position: refs/heads/master@{#313599}
Add per-file wildcard for chromeos/BUILD.gn
So that changes to this file do not need approval from
chromeos/OWNERS
BUG=none
Review URL: https://codereview.chromium.org/882903003
Cr-Commit-Position: refs/heads/master@{#313598}
Add per-file wildcard for build files under google_apis
So that changes in build files don't need approval from
google_apis/OWNERS.
BUG=none
Review URL: https://codereview.chromium.org/882923002
Cr-Commit-Position: refs/heads/master@{#313597}
Absence of keyboard layout is fatal.
R=spang
Review URL: https://codereview.chromium.org/880283003
Cr-Commit-Position: refs/heads/master@{#313596}
Removed harrym from owners
BUG=0
Review URL: https://codereview.chromium.org/883043002
Cr-Commit-Position: refs/heads/master@{#313595}
Revert of Tweak output of (memcheck|drmemory)_analyze.py. (patchset #1 id:1 of https://codereview.chromium.org/884813002/)
Reason for revert:
broke tree. don't use NOTRY=true again http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/38252
Original issue's description:
> Tweak output of (memcheck|drmemory)_analyze.py.
>
> Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
> to extract them with GTestLogParser and use them as snippets.
>
> BUG=453020
> [email protected]
> NOTRY=true
>
> Committed: https://crrev.com/9794e18ce8653e49c1b9f6da0033276a79f88579
> Cr-Commit-Position: refs/heads/master@{#313572}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453020
Review URL: https://codereview.chromium.org/883073006
Cr-Commit-Position: refs/heads/master@{#313594}
[Profiles] Send out less profile avatar related notifications
With the new profiles UI and the high res avatar downloading code, we are sending out
waaaay too many OnProfileAvatarChanged notifications. This is particularly terrible on
Windows, where basically on every Chrome startup we refresh all the icons.
Most importantly, we need to stop downloading the avatar files every time profiles get
loaded in the ProfileInfoCache. We did this originally because the avatar files were pretty
volatile, but it's safe to assume they've stopped changing.
Secondly, the only things that care about the high res avatar files are the UserManager
and the profile switcher, so they should get a special notification that this particular
file is ready, rather that annoy all the other listeners who only care about the tiny avatars.
BUG=449569
Review URL: https://codereview.chromium.org/861053004
Cr-Commit-Position: refs/heads/master@{#313593}
This is the first patch to separate JNI registration with initialization, currently, we have JNI_OnLoad defined multiple places which has a lot of
duplicated code and JNI registration and initialization are mixed;
This patch
- Added JNIOnLoadDelegate class for each component specific initialization.
- Added base::android::OnJNIOnLoad() to call a list of delegates
- Migrate testing, content_shell, chrome_shell.
BUG=447393
TBR=thakis
Review URL: https://codereview.chromium.org/864563002
Cr-Commit-Position: refs/heads/master@{#313592}
Fix a crash which occurs due to a CHECK firing in the HWNDMessageHandler::OnKeyEvent code path on Windows.
This crash occurs when the LegacyRenderWidgetHostHWND instance sends WM_CHAR/WM_SYSCHAR messages via the
WindowEventTarget::HandleKeyboardMessage function.
The HWNDMessageHandler class handles these messages via the OnImeMessages handler in the normal case.
The CHECK fires in the KeyEvent ctor where we validate that the KeyEvent instance has a valid event type.
In this case the WM_CHAR/WM_SYSCHAR messages are processed via the OnKeyEvent handler which leads to the problem.
Fix is to add a check for WM_CHAR/WM_SYSCHAR messages in the HWNDMessageHandler::HandleKeyboardMessage function
and call the OnImeMessages handler there. The alternative would be to add a new method to the WindowEventTarget
interface and change the LegacyRenderWidgetHostHWND class to handle these messages separately and call the new
method. I think that change would be a touch big for this case.
I also added WM_SYSDEADCHAR to the list of messages processed by the EventTypeFromNative function. We set the
type as ET_KEY_RELEASED on the same lines as WM_DEADCHAR.
BUG=451797
TEST=Covered by views_unittest WidgetTest.CharMessagesAsKeyboardMessagesDoesNotCrash
Review URL: https://codereview.chromium.org/881163002
Cr-Commit-Position: refs/heads/master@{#313591}
Roll src/third_party/skia 073720e:52f401e
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/073720e..52f401e
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/884253002
Cr-Commit-Position: refs/heads/master@{#313590}
Remove the use of page id from building the commit params.
BUG=369661
TEST=tests stay green
Committed: https://crrev.com/66f3ec8e5ee6c3b528b5a6054cdca85ac0b29699
Reverted: https://crrev.com/96545af0f94ec1ac19a57c86806c95834de5d33c
Review URL: https://codereview.chromium.org/839413004
Cr-Commit-Position: refs/heads/master@{#313589}
Stop sending an async touchmove for the app slop region
With throttled, async touch dispatch, an uncancelable touchmove is sent
as soon as the touch sequence exceeds an arbitrarily defined
application slop region, separate from the platform slop region. The
intent in doing so was to allow web apps to clear any tap/press-related
state after a scroll has begun. However, the sending of this touchmove
at the start of a scroll sequence can be problematic; the early part of
a scroll sequence is often sensitive to minor bottlenecks, and the
dispatch of an additional touchmove can conceivably push the app into
high latency mode by delaying frame production.
Stop sending this slop-exceeding touchmove, instead relying on the
existing timer-based async touchmove dispatch.
Note that while this may regress touch behavior on certain sites (e.g.,
causing faulty tap interpretation), it's likely that behavior on such
sites was already racy and fragile, subject to the arbitrary value of
the fixed "application" slop region.
BUG=449275
Review URL: https://codereview.chromium.org/872633005
Cr-Commit-Position: refs/heads/master@{#313588}
NaCl: Update revision in DEPS, 945d334 -> 58c9abe
This pulls in the following Native Client changes:
58c9abe: ([email protected]) Update revision for PNaCl
fd92de8: ([email protected]) Revert "Output depfile from build_nexe."
fb70836: ([email protected]) PNaCl: Update libc++abi revision in pnacl/COMPONENT_REVISIONS
939a13a: ([email protected]) Provide an irt_core_lib GN target.
dbf2af4: ([email protected]) Remove include of build_config.h from nacl_exception.h
e205317: ([email protected]) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
7c8a96b: ([email protected]) Update revision for PNaCl
3d00a54: ([email protected]) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
1de8ba8: ([email protected]) Update codereview.settings following the switch from SVN to Git
7a6cf46: ([email protected]) Update revision for PNaCl
bc28c0b: ([email protected]) Fix the native_client URL in the PNaCl REV file.
f8aa9dc: ([email protected]) Adding le32-nacl build of pnacl tools.
cfda521: ([email protected]) Explicitly include build_config.h.
61b7ba9: ([email protected]) Output depfile from build_nexe.
2d65c23: ([email protected]) PNaCl: Update LLVM and Subzero revision in pnacl/COMPONENT_REVISIONS
5f5cd88: ([email protected]) Fix PNaCl redirectors for i686-nacl-xx -> x86_64-nacl-xx
1baa204: ([email protected]) Remove some more dead code and variables from pnacl/build.sh.
f116471: ([email protected]) Update revision for PNaCl
01f3d97: ([email protected]) Always define product_dir in build_nexe.
8a5a846: ([email protected]) Remove the IRT's now-unneeded call to NaClSrpcModuleInit()
c14b58a: ([email protected]) Remove NaClPluginLowLevelInitializationComplete() (caller of "init_done" SRPC)
c5d8394: ([email protected]) Change driver bash scripts to work in devenv.
490e554: ([email protected]) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
2a7391a: ([email protected]) Fix several issues with update_pnacl_tool_revisions.py
fbc3b5c: ([email protected]) Support filenames with spaces in the PNaCl driver scripts.
4f726e8: ([email protected]) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
28a1341: ([email protected]) Move pnacl driver test runs from buildbot_pnacl.sh to buildbot_pnacl_toolchain.py
9f9d773: ([email protected]) Update GCC revision in tools/REVISIONS
29ae54a: ([email protected]) Update revision for PNaCl
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk
Review URL: https://codereview.chromium.org/883073002
Cr-Commit-Position: refs/heads/master@{#313587}
[Mac, Linux] Add People in the menu bar should automatically create a default profile
This will make it have the same behaviour as the User Manager, vs. navigating to
chrome://settings/createProfile.
BUG=452125
TEST=Choose Add Person from the OS menu bar. This should create a profile and
switch to it immediately.
Review URL: https://codereview.chromium.org/870203003
Cr-Commit-Position: refs/heads/master@{#313586}
net: fix typo and add ustr.gov to HSTS preloaded list.
Cr-Commit-Position: refs/heads/master@{#313585}
webui: add [lang] attribute to <html> element on all webui pages so
screen readers know which human language to read a page in.
[email protected]
[email protected],[email protected]
BUG=438704
Review URL: https://codereview.chromium.org/880313002
Cr-Commit-Position: refs/heads/master@{#313584}
Loading the Launcher with a Locked Profile launched UserManager.
On Mac, the --show-app-list flag causes the AppLauncher to start loading before the Profile is loaded. For this, the profile_path is sent to AppListService::InitAll(), so that this load can be aborted if it would point to a Locked Profile.
The AppListService will no longer permit loading a locked profile, and will direct to the UserManager instead. StartupBrowserCreator has a similar flow.
BUG=421308
TEST=Try to load the App Launcher for a locked profile in any possible way the Launcher can be launched ;) It should always direct to the UserManager, upon Profile Selection which then directs to the AppLauncher. Opening the AppLauncher for a non-locked profile should always work smoothly.
Review URL: https://codereview.chromium.org/856733004
Cr-Commit-Position: refs/heads/master@{#313583}
media: Rename PERMISSION_PROTECTED_MEDIA to PERMISSION_PROTECTED_MEDIA_IDENTIFIER.
This makes the naming consistent with other use cases, e.g. CONTENT_SETTINGS_TYPE_PROTECTED_MEDIA_IDENTIFIER, ProtectedMediaIdentifierPermissionContext etc.
BUG=446263
TEST=Renaming only.
Review URL: https://codereview.chromium.org/881023002
Cr-Commit-Position: refs/heads/master@{#313582}
Update V8 to version 4.2.34 (based on 5bd8407f8c8d7ed08574ca532ae5f1f4d6a8b39f).
[email protected]
Review URL: https://codereview.chromium.org/884823002
Cr-Commit-Position: refs/heads/master@{#313581}
[Views] Don't reset button state after dragging if the button is disabled.
Review URL: https://codereview.chromium.org/868473002
Cr-Commit-Position: refs/heads/master@{#313580}
Passing key frame info flag renderer to browser process
For MediaSourcePlayer, we can use this flag to reduce the browser seek when codec is recreated.
Will implement the logic to reduce browser seek in a follow up CL.
BUG=304234
Review URL: https://codereview.chromium.org/872253008
Cr-Commit-Position: refs/heads/master@{#313579}
Use setProperties for Cellular APN
This actually represents a pretty huge milestone - no more usage of
{Unmanaged} NetworkConnectionHandler from InternetOptionsHandler!
Everything is now using setProperties which uses MNCH.
BUG=430113
Review URL: https://codereview.chromium.org/700383008
Cr-Commit-Position: refs/heads/master@{#313578}
cc: Change the activation/ready for draw check from layer to queue.
This patch changes where we do the ready to draw or ready to activate
check. Previously, this was done in the layers. Tile manager got all
of the picture layers, and asked them if they were ready. How, it
just builds a queue of an appropriate type to get this information.
R=reveman, danakj
Review URL: https://codereview.chromium.org/868803002
Cr-Commit-Position: refs/heads/master@{#313577}
Reset manual zoom mode on navigation.
When an app/extension places a ZoomController in manual mode, it is
reasonable to expect that navigating the main frame should reset that
mode, since the app/extension will be reloaded in the process.
The root cause of this bug was the sending of a ZoomChangeEvent that
contained stale information (the old, manually managed, zoom level),
which in turn caused the zoom bubble to be displayed.
BUG=450909
Review URL: https://codereview.chromium.org/884063004
Cr-Commit-Position: refs/heads/master@{#313576}
Fix left-side navigation for top-level pages
And don't break presubmit!
Basically, the change I put in previously that kind of fixed extensions redirects
actually meant presubmit would fail.
So I've gone and put in a real fix.
I also updated the redirects.json files in these GitHub repos for this to work: devtools, multi-device, and store.
Thanks, Ben, for your help.
Review URL: https://codereview.chromium.org/883963002
Cr-Commit-Position: refs/heads/master@{#313575}
Omnibox: BookmarksProvider: Make Multiple Prefix Matches Work
This code significantly simplies the logic for matching.
Indeed, the old logic was buggy because multiple prefix matches could
results in explosive growth of the list of matches (even if only one
bookmark matches). Reviewer, I would avoid reading and trying to
understand what CombineMatches() and the code that calls it is currently
broken. See the second test case I added. Before this
change, that test never terminates (in the time I waited) and explodes
the machine's memory. Luckily this was rare; there are few reports on
crbug.
It's possible this new code is slower or faster than before (when the
old code behaved correctly). I plan to look at the
Omnibox.Providertime.Bookmarks numbers before and after this change.
TBR=sky for owners stamp; review it if you feel like
BUG=450850,434604
Review URL: https://codereview.chromium.org/882823004
Cr-Commit-Position: refs/heads/master@{#313574}
Watch the preferences for changes per profile instead of per tab.
PrefsTabHelper was watching > 1K prefs so that it could update the renderer side data structures when they change. When session restore was used and it had 50 tabs, this would take almost a second on a Z620. Switch this to watching these prefs once per profile instead.
BUG=452693
Review URL: https://codereview.chromium.org/878363002
Cr-Commit-Position: refs/heads/master@{#313573}
Tweak output of (memcheck|drmemory)_analyze.py.
Wrap error reports in "### (BEGIN|END) MEMORY TOOL REPORT". This will allow us
to extract them with GTestLogParser and use them as snippets.
BUG=453020
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/884813002
Cr-Commit-Position: refs/heads/master@{#313572}
Don't navigate to destination on import.
BUG=420680
TEST=browser_test: FileManagerJsTest.*
Review URL: https://codereview.chromium.org/876203003
Cr-Commit-Position: refs/heads/master@{#313571}
Merged PolicyServiceWatcher into PolicyWatcher.
BUG=368321
Review URL: https://codereview.chromium.org/867463006
Cr-Commit-Position: refs/heads/master@{#313570}
Cleanup CQ configs.
Specifically, remove triggered builders from the list of "launched"
builders. The new CQ verifier will pick up triggered builders from
the "triggered" section. This eliminates the duplicate specs.
This CL depends on the deployment of the (Google-only) CL:
https://chromereviews.googleplex.com/145077013/
[email protected]
BUG=436774
Review URL: https://codereview.chromium.org/866293003
Cr-Commit-Position: refs/heads/master@{#313569}
Fix callback access in Pepper's UDP socket resource
BUG=452249
Review URL: https://codereview.chromium.org/881203002
Cr-Commit-Position: refs/heads/master@{#313568}
Roll src/third_party/WebKit db3c2b2:c6b67b8 (svn 189118:189129)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/db3c2b2..c6b67b8
[email protected],[email protected]
Review URL: https://codereview.chromium.org/884803002
Cr-Commit-Position: refs/heads/master@{#313567}
Log force-alt-protocols command line flag usage.
BUG=452514
Review URL: https://codereview.chromium.org/879863004
Cr-Commit-Position: refs/heads/master@{#313566}
Fix linux_me2me_host.py to handle relative path to self.
After crrev.com/310952 linux_me2me_host.py fails to start if it's called
using relative path. This CL fixes it. The problem was that it was trying
to run itself using sys.argv[0] after changing current directory, and
this works only if argv[0] is an absolute path.
Review URL: https://codereview.chromium.org/883063002
Cr-Commit-Position: refs/heads/master@{#313565}
Allow new zoom bubble to override current one.
At present, if a user changes zoom on OSX while the zoom bubble is
already being shown, the new zoom bubble (with the most up to date
information) is not shown. This CL changes this behaviour by allowing
a new zoom bubble to be created, and replace the existing one.
Example: load a PDF and repeatedly click the zoom +/- controls in the
lower-right corner of the viewer.
BUG=444995
Review URL: https://codereview.chromium.org/849693006
Cr-Commit-Position: refs/heads/master@{#313564}
Add content public APIs for Presentation API.
The pieces added are as follows:
1. PresentationServiceDelegate: An interface to be implemented by an
embedder to handle Presentation API requests. Includes an Observer
interface to observe the lifetime of the delegate object.
2. PresentationScreenAvailabilityListener: An interface to be
implemented by content/ code to receive screen availability results
from the embedder.
3. Added method to ContentBrowserClient: GetPresentationServiceDelegate.
Returns nullptr by default. Embedder may override it with an
implementation that can handle Presentation API requests. Added to
allow content/ code to obtain a reference to a
PresentationServiceDelegate to forward presentation API requests to.
Presentation Mojo service patch: crrev.com/839773002/
Blink plumbing: crrev.com/832263007
The Chrome implementation of PresentationServiceDelegate is currently
in a private repo.
BUG=412331
Review URL: https://codereview.chromium.org/883953002
Cr-Commit-Position: refs/heads/master@{#313563}
Switch DeviceCloudPolicyInvalidator to shared InvalidationService
The DeviceCloudPolicyInvalidator used to ensure that a suitable
InvalidationService is available on its own. This CL makes it a consumer
of AffiliatedInvalidationServiceProvider, which manages an
InvalidationService that can be shared by DeviceCloudPolicyInvalidator
and other consumers.
BUG=442800
TEST=Updated unit tests
Review URL: https://codereview.chromium.org/846453006
Cr-Commit-Position: refs/heads/master@{#313562}
ozone: Fix chromium-style method override warnings
BUG=417463
TEST=build with clang plugin
Review URL: https://codereview.chromium.org/885703002
Cr-Commit-Position: refs/heads/master@{#313561}
Delete chrome::kAutoPasswordGenerationLearnMoreURL
It's not used anymore, last usage was removed
in https://codereview.chromium.org/583883003
[email protected]
Review URL: https://codereview.chromium.org/877183003
Cr-Commit-Position: refs/heads/master@{#313560}
Remove suppression for cc_unittests LayerTreeHostPictureTestTwinLayer
The flake should hopefully be fixed by https://codereview.chromium.org/877213002/
R=earthdok
BUG=451988
Review URL: https://codereview.chromium.org/879053004
Cr-Commit-Position: refs/heads/master@{#313559}
[Chromoting] Set ar_service_environment for Official builds
There is a check in build-webapp.py (line 197) that ensures that
non-dev builds have this set to 'prod'. Up 'til now, we've been
setting this manually (hence the check in build-webapp), but it
is better to set it correctly in the gyp file.
This also allows the bots to build Official builds without
triggering the build-webapp check.
BUG=
Review URL: https://codereview.chromium.org/886543002
Cr-Commit-Position: refs/heads/master@{#313558}
Disabling Sync shouldn't prevent GaiaInfoUpdate.
Right now --disable-sync disables a lot of signin; any signin errors aren't surfaced, because nothing attempts to ping GAIA. This will help address that.
BUG=NONE
TEST=Run Chrome with the --disable-sync flag. Sign into a Profile and
the name (from G+) should appear in the Avatar Menu.
Review URL: https://codereview.chromium.org/870803003
Cr-Commit-Position: refs/heads/master@{#313557}
When an extension is unloaded, unregister all event listeners, not just the lazy ones.
This fixes a problem where event listeners could stick around for a
short time period after an extension is unloaded, causing problems
with the onInstalled event for a new version of an extension.
BUG=449654
Review URL: https://codereview.chromium.org/877233002
Cr-Commit-Position: refs/heads/master@{#313556}
Dump property values for the touch log source
The CL dumps gesture property values for touch devices that run
with the CrOS gesture library. The format is designed to be
backward-compatible with the X11 behaviour.
Contributed by [email protected]
BUG=450159
TEST=samus ChromeOS build
Committed: https://crrev.com/8b1fb4fdf2b13b71e969cd541e500549163f742b
Cr-Commit-Position: refs/heads/master@{#313446}
Review URL: https://codereview.chromium.org/864253002
Cr-Commit-Position: refs/heads/master@{#313555}
Roll asan_symbolize.py to upstream r227327.
r227327 Fix indents on argument parsing code. No behavior change.
r227326 Make asan_symbolize.py not crash on Windows.
BUG=451741
[email protected]
Review URL: https://codereview.chromium.org/884043004
Cr-Commit-Position: refs/heads/master@{#313554}
Restored line mistakenly deleted with re-factoring.
r313118 removed unused Cloud Devices code.
Cloud Print code must be untouched.
BUG=452871
Review URL: https://codereview.chromium.org/885683002
Cr-Commit-Position: refs/heads/master@{#313553}
Chromecast: connect CastBrowserCdmFactory during startup.
[email protected],[email protected]
BUG=408189
Review URL: https://codereview.chromium.org/886583002
Cr-Commit-Position: refs/heads/master@{#313552}
Autofill: Set requirements for number of recognized fields in an autofillable form
BUG=447332
Review URL: https://codereview.chromium.org/853523004
Cr-Commit-Position: refs/heads/master@{#313551}
Roll src/third_party/WebKit fb46751:db3c2b2 (svn 189109:189118)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fb46751..db3c2b2
[email protected],[email protected]
Review URL: https://codereview.chromium.org/881363002
Cr-Commit-Position: refs/heads/master@{#313550}
media: Enable Opus support in Clank <video> and MSE
Opus audio codec is supported by the android platform starting from Lollipop.
This CL enables canPlayType() support for Opus on Clank and MSE playback of Opus
in Clank. This brings Opus feature parity with Desktop Chromium.
BUG=318436
Review URL: https://codereview.chromium.org/866573004
Cr-Commit-Position: refs/heads/master@{#313549}
Observe UsbService from the FILE thread in DevicePermissionsManager.
As in the UsbEventRouter the UsbService must be observed from the FILE
thread (until bug 427985 is resolved, which will be soon). This change
fixes a DCHECK(CalledOnValidThread()) in UsbService::AddObserver when
permission to access an ephemeral (no serial number) device is added and
the DevicePermissionsManager starts listening for disconnection of that
device.
BUG=452652
Review URL: https://codereview.chromium.org/882813002
Cr-Commit-Position: refs/heads/master@{#313548}
cc: Remove SkSurface cache from Resource
The SkSurface that was being cached within the Resource was being held
and counted against skia's budget. cc's budget is 512MB, and skia's is
~100MB, so cc would always blow skia's budget. In the case of the ugam
page, we would end up redecoding, reupload and regenerating all of the
mip maps for each of the images on every frame.
Solution is to stop caching the SkSurface.
Additionally, we should investigate if this situation should even be
counted against skia's budget. See crbug.com/452344
BUG=452138
BUG=447291
Review URL: https://codereview.chromium.org/874353007
Cr-Commit-Position: refs/heads/master@{#313547}
Roll src/third_party/skia c2893c5:073720e
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c2893c5..073720e
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/878013003
Cr-Commit-Position: refs/heads/master@{#313546}
UAC and pin confirmation dialogs are not on foreground when updating pin #
In this change we elevate the me2me native messaging host before calling into the daemon controller for the tasks that requires elevation. The daemon controller still depends on the com component for those tasks but the elevation is now done in the me2me native messaging host itself.
In followup CLs I will remove the elevated daemon controller com component and move its implementation to DaemonControllerDelegateWin.
Note that the pin confirmation dialog is removed with this CL. This change has been approved by the chrome security team.
BUG=447246
Review URL: https://codereview.chromium.org/880133003
Cr-Commit-Position: refs/heads/master@{#313545}
[Mac] Always use the small, non-high res default avatars in the People menu bar
BUG=447311
TEST=Start Chrome. Click on the "People" menu in the OS menu bar. Any profiles
with default avatar should display the low res, transparent background images
(i.e. not the high res images with the grey background)
Review URL: https://codereview.chromium.org/882113003
Cr-Commit-Position: refs/heads/master@{#313544}
Fix truncation warning in PEImage on VS2015
d:\src\cr3\src\base\win\pe_image.h(250): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\base\win\pe_image.h(250): warning C4302: 'reinterpret_cast': truncation from 'LPCSTR' to 'WORD'
Separate ptr->int from truncation to WORD.
Also, while we're here, fix a cast in IsOrdinal.
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/883873002
Cr-Commit-Position: refs/heads/master@{#313543}
[Android] mostly deprecate craigdh and frankf from OWNERS
BUG=
Review URL: https://codereview.chromium.org/871543003
Cr-Commit-Position: refs/heads/master@{#313542}
change gaia endpoint by shortcut ctrl-shift-alt-w
BUG=451959
Review URL: https://codereview.chromium.org/878383003
Cr-Commit-Position: refs/heads/master@{#313541}
Generate the print messages in components/printing
Adds a new file to //printing to hold the enums to be included
during the IPC generation. This allows to use them in more than
one generator at the time.
BUG=311308
Review URL: https://codereview.chromium.org/857053002
Cr-Commit-Position: refs/heads/master@{#313540}
PasswordStore: Use ScopedVector to express ownership of forms
This is a clean-up, getting rid of many manual deletes and comments about who owns forms passed around in vectors.
BUG=451018
Review URL: https://codereview.chromium.org/825773003
Cr-Commit-Position: refs/heads/master@{#313539}
Revert "Revert of PlzNavigate: Add a browser test for basic navigations"
This reverts the revert of https://chromiumcodereview.appspot.com/715203004/ by
fixing the build error.
BUG=376014, 376006, 376091
Review URL: https://codereview.chromium.org/868313004
Cr-Commit-Position: refs/heads/master@{#313538}
Move networking_private to src/extensions
The major re-factoring for this has been done, this is mostly just
moving the files, with a small addition to ExtensionsBrowserClient.
For extensions/browser/api/networking_private/DEPS:
[email protected]
BUG=363776
Review URL: https://codereview.chromium.org/870163002
Cr-Commit-Position: refs/heads/master@{#313537}
This is step 1 in enabling XI2 mouse grab on Desktop Linux.
This CL replaces the use of XChangeActivePointerGrab() (of
which there is no XI2 equivalent) with XGrabPointer (of
which there is an XI2 equivalent).
BUG=426380
TEST=None
Review URL: https://codereview.chromium.org/821803002
Cr-Commit-Position: refs/heads/master@{#313536}
Refactored device status uploading out of policy fetch infrastructure.
Created StatusUploader class to manage the uploading of device status.
Refactored status uploading functionality in cloud policy infrastructure - the
timing and contents of the device upload are now controlled by StatusUploader,
while CloudPolicyClient exposes an API to create the upload job.
BUG=430908
Review URL: https://codereview.chromium.org/845313008
Cr-Commit-Position: refs/heads/master@{#313535}
[Telemetry] Remove empty_action_name_to_run for tab_switching
Remove scrolling action for pages of Top10PageSet.
Measurements that are paired with Top10PageSet are
TabSwitching & PageCycler. Both of these originally set
action_name_to_run='' which means that they don't expect
RunPageInteraction to run anything.
BUG=418375
Review URL: https://codereview.chromium.org/885493004
Cr-Commit-Position: refs/heads/master@{#313534}
[Skia] Add SK_SUPPORT_LEGACY_BLOB_BOUNDS config option.
To suppress upcoming changes in text blob bounds calculation.
BUG=451401
[email protected]
Review URL: https://codereview.chromium.org/881323002
Cr-Commit-Position: refs/heads/master@{#313533}
[Android] Add a java version of the test server spawner.
BUG=448626
Review URL: https://codereview.chromium.org/867073002
Cr-Commit-Position: refs/heads/master@{#313532}
Tear down ContentVideoView from content-layer
Background: ContentVideoView displays fullscreen video in a
VideoViewSurface. Currently, each Android content embedder
(WebView, ContentShell, and ChromeShell) is responsible for
releasing this surface when exiting fullscreen.
Problem: Releasing ContentVideoView from each embedder leads to
code duplication. Worse, this was never done for the WebView:
when it exits fullscreen video playback, AwContents's
exitFullScreen removes the VideoViewSurface which triggers
ContentVideoView's surfaceDestroyed(). surfaceDestroyed()
releases the MediaPlayerAndroid. Releasing the MediaPlayerAndroid
during playback gives a frozen video (see bug).
Solution: For all content embedders on Android, tear down
ContentVideoView, from content-layer (before the embedder
specific "exit fullscreen"-work).
BUG=449152
TEST=For unencrypted video, manually verify that video playback
continues inline when exiting fullscreen (tested in
com.android.browser, ContentShell and ChromeShell). Added
automatic test for VIDEO_HOLE-playback in WebView.
Review URL: https://codereview.chromium.org/845193005
Cr-Commit-Position: refs/heads/master@{#313531}
Roll src/third_party/skia 8b0a05a:c2893c5
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8b0a05a..c2893c5
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/876343006
Cr-Commit-Position: refs/heads/master@{#313530}
Instrumenting more of WM_ message processing for jank
This covers some Omnibox stuff, which is probably responsible for the jank in keyboard messages processing and drilling down some of issues.
There are some issues that require advanced investigations that are not included in this CL:
1. PeekMessage, which is probably processing hooks
2. DispatchMessage, maybe, having same issues
3. GetQueueStatus (!!!)
4. DefWndProc
BUG=440919
Review URL: https://codereview.chromium.org/879153002
Cr-Commit-Position: refs/heads/master@{#313529}
Refactor the symbol parsing, and move to NDK's nm.
First part of the orderfile generating script refactor. The aim here is to make
sure that all scripts parse the object files the same way, using the same
tool. This commit extracts the parsing logic from patch_orderfile.py. It uses nm
from the Android NDK.
BUG=452879
Review URL: https://codereview.chromium.org/884113002
Cr-Commit-Position: refs/heads/master@{#313528}
Roll src/third_party/WebKit 0d1eda3:fb46751 (svn 189107:189109)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0d1eda3..fb46751
[email protected],[email protected]
Review URL: https://codereview.chromium.org/877373002
Cr-Commit-Position: refs/heads/master@{#313527}
Remove Tommi from installer owners.
BUG=none
NOTRY=true
[email protected]
Review URL: https://codereview.chromium.org/886533002
Cr-Commit-Position: refs/heads/master@{#313526}
Reland (2): Linux Video Capture: Add support for multiplanar YUV420 format enumeration
This is a relanding of the original CL mentioned below, with
a fix for bug http://crbug.com/448599, where some strange cameras
were listed.
The problem was the filtering out of devices with
V4L2_CAP_VIDEO_OUTPUT_MPLANE capabilities, which is the case for
the strange camera enumerated in the mentioned bug, corresponding
to a V4L2 memory-to-memory graphics processor.
FI: the enumerated device is called exynos-gsc.m2m and is indeed
defined as having such capability in line [1]
[1] http://lxr.free-electrons.com/source/drivers/media/platform/exynos-gsc/gsc-m2m.c#L286
Original Reland description follows -------------------------------------
Relanding: Linux Video Capture: Add support for multiplanar YUV420 format enumeration.
This is a relanding of the original CL _with the designated initializers
changed by typical struct fields accesors_.
Note: Gcc does not support designated initializers and it seems that
there are still a few such builds around, hence the change.
Original CL description follows -----------------------------------------
multiplanar --> V4L2_CAP_VIDEO_CAPTURE_MPLANE
M420 is an example of I420 triplanar format, used
for testing and to be landed since there must be
at least one multiplanar format for this CL to be
consistent.
Following reviewer's hints, the VCDFLinux code is
refactored internally. Given that, some struct
initializations change from
struct A a = {} _or_ struct A a; memset(&a, 0, sizeof(a));
a.bla1 = foo1;
a.bla2 = foo2;
to
struct A a = {
.bla1 = foo1,
.bla2 = foo2,
};
Which is a very common idiom to initialize structs in
interactions with V4L2 IOCTL. I'm introducing it here and
I'm planning to use it further in VCDLinux CLs down the line.
This CL only adds support for enumerating multiplane
format, while the actual capture will be reviewed in
a later CL (WIP @ http://crrev.com/804473008).
BUG=441836, 448599
Review URL: https://codereview.chromium.org/877193005
Cr-Commit-Position: refs/heads/master@{#313525}
ozone: evdev: Replace dispatch callbacks with an interface
This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.
Rather than binding a large number of callbacks for every device, pass a
single new object DeviceEventDispatcherEvdev to each device.
BUG=449710
TEST=boot link_freon & move mouse
Review URL: https://codereview.chromium.org/869613003
Cr-Commit-Position: refs/heads/master@{#313524}
Add sdefresne as OWNERS of //components
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/883003002
Cr-Commit-Position: refs/heads/master@{#313523}
Revert of Dump property values for the touch log source (patchset #11 id:200001 of https://codereview.chromium.org/864253002/)
Reason for revert:
Broke the arm-generic-freon builder on Chrome OS:
https://uberchromegw.corp.google.com/i/chromeos/builders/arm-generic_freon%20nightly%20chromium%20PFQ/builds/549/steps/BuildPackages/logs/stdio
See crbug.com/452911 - looks like a printf format specifier is wrong on 32 bit
Original issue's description:
> Dump property values for the touch log source
>
> The CL dumps gesture property values for touch devices that run
> with the CrOS gesture library. The format is designed to be
> backward-compatible with the X11 behaviour.
>
> Contributed by [email protected]
>
> BUG=450159
> TEST=samus ChromeOS build
>
> Committed: https://crrev.com/8b1fb4fdf2b13b71e969cd541e500549163f742b
> Cr-Commit-Position: refs/heads/master@{#313446}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=450159
Review URL: https://codereview.chromium.org/881353002
Cr-Commit-Position: refs/heads/master@{#313522}
[Ozone-DRI] Assume window IPC arrives before surface IPC
Creating a DriWindow happens before the Compositor associated with
it. On DriWindow creation an IPC is sent to the GPU process to
initialize the window on the GPU side. The Compositor also sends
an IPC to create a surface for the window. Since the same channel
is used when IPC-ing both messages, the order of IPCs should be
maintained. Thus, assume that, on the GPU side, the window (delegate)
is already present when trying to create a surface.
Note the previous implementation was working around an issue during
initialization where the channel wasn't established. The issue was
that the channel in the platform was established late, so the IPCs
in Chrome would be serviced before the IPCs in the Ozone platform.
For clarity, these are the major steps taken at startup when creating
a window:
1) PostTaskOnUI(create GpuProcessHostShim)
2) Create WindowTreeHost
3) Create DriWindow
a) If channel established PostTaskOnIO(create window on GPU)
4) WindowTreeHost::OnAcceleratedWidget()
5) Create Compositor
6) PostTaskOnUI(create output surface)
7) MessageLoop::Run()
8) Execute task in (1)
a) Create GpuProcessHostShim
b) OnChannelEstablished
i) DriWindow::OnChannelEstablished -> PostTaskOnIO(create window
on GPU)
9) Execute task in (6) -> PostTaskOnIO(create surface on GPU)
Note, even if the channel isn't up and running in step (8), messages
will be queued internally in GpuProcessHost. Thus the messages in
(8) and (9) will be queued in the correct order.
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/883783002
Cr-Commit-Position: refs/heads/master@{#313521}
Don't refcount tracking id -> slot id mapping.
Previously we tried to refcount the tracking id to slot id mapping.
This broke in some circumstances where the number of press events was
not equal to the number of release events.
This patch switches to marking some touch events such that they don't
modify the mapping, simplifying logic, and fixing a nasty bug.
BUG=439051
TEST=EventsXTest.TouchEventNotRemovingFromNativeMapping
Review URL: https://codereview.chromium.org/785753002
Cr-Commit-Position: refs/heads/master@{#313520}
cleanup: ThreadLocalState::run_loop_ is never used, so remove it.
WorkerTaskRunner manages and uses the WebWorkerRunLoops in a map in |loop_map_|,
and |run_loop_| in ThreadLocalState remain unused. So remove it.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/880213002
Cr-Commit-Position: refs/heads/master@{#313519}
Revert of NaCl: Update revision in DEPS, 945d33419 -> 939a13aa3 (patchset #1 id:1 of https://codereview.chromium.org/881893003/)
Reason for revert:
Caused http://crbug.com/452846
Original issue's description:
> NaCl: Update revision in DEPS, 945d33419 -> 939a13aa3
>
> This pulls in the following Native Client changes:
>
> 939a13a ([email protected]) Provide an irt_core_lib GN target.
> dbf2af4 ([email protected]) Remove include of build_config.h from nacl_exception.h
> e205317 ([email protected]) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> 7c8a96b ([email protected]) Update revision for PNaCl
> 3d00a54 ([email protected]) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> 1de8ba8 ([email protected]) Update codereview.settings following the switch from SVN to Git
> 7a6cf46 ([email protected]) Update revision for PNaCl
> bc28c0b ([email protected]) Fix the native_client URL in the PNaCl REV file.
> f8aa9dc ([email protected]) Adding le32-nacl build of pnacl tools.
> cfda521 ([email protected]) Explicitly include build_config.h.
> 61b7ba9 ([email protected]) Output depfile from build_nexe.
> 2d65c23 ([email protected]) PNaCl: Update LLVM and Subzero revision in pnacl/COMPONENT_REVISIONS
> 5f5cd88 ([email protected]) Fix PNaCl redirectors for i686-nacl-xx -> x86_64-nacl-xx
> 1baa204 ([email protected]) Remove some more dead code and variables from pnacl/build.sh.
> f116471 ([email protected]) Update revision for PNaCl
> 01f3d97 ([email protected]) Always define product_dir in build_nexe.
> 8a5a846 ([email protected]) Remove the IRT's now-unneeded call to NaClSrpcModuleInit()
> c14b58a ([email protected]) Remove NaClPluginLowLevelInitializationComplete() (caller of "init_done" SRPC)
> c5d8394 ([email protected]) Change driver bash scripts to work in devenv.
> 490e554 ([email protected]) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
> 2a7391a ([email protected]) Fix several issues with update_pnacl_tool_revisions.py
> fbc3b5c ([email protected]) Support filenames with spaces in the PNaCl driver scripts.
> 4f726e8 ([email protected]) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
> 28a1341 ([email protected]) Move pnacl driver test runs from buildbot_pnacl.sh to buildbot_pnacl_toolchain.py
> 9f9d773 ([email protected]) Update GCC revision in tools/REVISIONS
> 29ae54a ([email protected]) Update revision for PNaCl
>
> BUG=none
> TEST=browser_tests and nacl_integration
> CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build
>
> Committed: https://crrev.com/4a8dee9ac9fd757f776f76a651d921f347305e82
> Cr-Commit-Position: refs/heads/master@{#313447}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/886513002
Cr-Commit-Position: refs/heads/master@{#313518}
Do not override CHROME_DEVEL_SANDBOX in tools/valgrind/valgrind_test.py
Setting that variable to an empty string is not a supported way of disabling the
sandbox. tools/valgrind/chrome_tests.py is supposed to pass "--no-sandbox" which
takes care of that.
BUG=245376
[email protected], [email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/880023003
Cr-Commit-Position: refs/heads/master@{#313517}
[MemSheriff] Broaden a DrMemory suppression and add a new one.
BUG=449989, 399842
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/884753002
Cr-Commit-Position: refs/heads/master@{#313516}
views: Remove dead code in CustomButton.
CustomButtonStateChangedDelegate was itnroduced in http://crrev.com/159994, and
its use was removed in http://crrev.com/185369 It hasn't been used since. So
remove the code.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/872473004
Cr-Commit-Position: refs/heads/master@{#313515}
Fixing and re-enabling WebRTC/AppRTC integration test.
This patch needs to land after
https://codereview.chromium.org/872423002/ since the path
to the AppRTC code changes.
BUG=451985
Review URL: https://codereview.chromium.org/864973003
Cr-Commit-Position: refs/heads/master@{#313514}
Speed up mergetraces.py.
list -> set, O(n^2) -> O(n).
Timing, without this patch (on a typical trace from a device):
real 1m49.774s
user 1m49.394s
sys 0m0.316s
With:
real 0m5.607s
user 0m5.482s
sys 0m0.120s
BUG=448054
Review URL: https://codereview.chromium.org/873003003
Cr-Commit-Position: refs/heads/master@{#313513}
ServiceWorker: Enqueue state change events until the worker thread gets ready
This CL supports the step 3 described in the design doc:
https://docs.google.com/document/d/1qDGbMlwKOXxCRBlw9IirK8Qmna3JqvnO3Aogkfu9UJQ/edit?usp=sharing
Queued events are flushed out when the worker thread gets ready and
the provider host is notified of the thread id.
BUG=437677
TEST=https://codereview.chromium.org/861743002/
Review URL: https://codereview.chromium.org/855383006
Cr-Commit-Position: refs/heads/master@{#313512}
Disable WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams under MSan
BUG=452892
NOTRY=True
Review URL: https://codereview.chromium.org/878553006
Cr-Commit-Position: refs/heads/master@{#313511}
Close the permission bubble when use clicks 'esc'
BUG=385088
Review URL: https://codereview.chromium.org/882873002
Cr-Commit-Position: refs/heads/master@{#313510}
[MemSheriff] Disable ICOImageDecoderTest.Decoding.
Fails on a subset of bots.
BUG=371290
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/879303003
Cr-Commit-Position: refs/heads/master@{#313509}
[Password manager tests] Write to spreadsheets.
Writes results of running tests to trix instead of local file.
[email protected]
BUG=435249
Review URL: https://codereview.chromium.org/873333002
Cr-Commit-Position: refs/heads/master@{#313508}
cc: Cleanup - remove unused 'Webkit' forward declaration.
"namespace Webkit" does not exist.
[email protected]
Review URL: https://codereview.chromium.org/868353002
Cr-Commit-Position: refs/heads/master@{#313507}
content: Cleanup - remove unused 'WebKit' forward declaration.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/871243002
Cr-Commit-Position: refs/heads/master@{#313506}
Roll src/breakpad/src 398c70a:d5d1eac (svn 1414:1416)
Summary of changes available at:
https://chromium.googlesource.com/external/google-breakpad/src/+log/398c70a..d5d1eac
d5d1eac Stop calling memmove when unnecessary
482062f Fix some fragile code that is likely to cause future memory corruption problems.
BUG=450137
[email protected]
Review URL: https://codereview.chromium.org/879283002
Cr-Commit-Position: refs/heads/master@{#313505}
Expose API on VariationsService to set the restrict mode param.
This paves the way to allowing logic living elsewhere in Chrome to
specify a value for this param (which will come in a later CL).
Also, cleans up a couple areas of the code, including cleaning up the
unit test for the URL generating function to abstract away the policy
pref code and using a weak pointer instead of base::Unretained() in
a callback.
BUG=452605
Review URL: https://codereview.chromium.org/883803002
Cr-Commit-Position: refs/heads/master@{#313504}
Files.app: Add a deduplication step to avoid importing duplicate media.
Add a DuplicateFinder and introduce it into the cloud import pipeline. Note: Deduplication takes place in-place on the source files, which could be slow for MTP devices. Profiling will be necessary to test this. The duplicate check returns a simple yes/no answer. Non-duplicate media is then imported as before.
Destination is now promoted to a top-level concept. MediaImportHandler has a new function which enables clients to register new import destinations. Each destination requires a DestinationFactory and an optional DuplicateFinder. The import destination is selected at import time by its ID.
The Observer pattern on the ImportTask class was tweaked to support auxiliary data being passed with each observer call. This is to allow richer updates (e.g. an entry-changed update that informs observers when a file was copied, and sends along the source and new destination).
A new importer.TestLogger had to be created and inserted into some tests in order to circumvent the running of the regular RunTimeLogger, which uses functionality that doesn't exist at test time (i.e. chrome.syncFileSystem.onFileStatusChanged)
MockEntry et al. were augmented to do more "realistic" moves and copies, needed to test the new two-stage import.
Unit tests were cleaned up.
BUG=420680
TEST=browser_test: FileManagerJsTest.MediaImportHandlerTest
Review URL: https://codereview.chromium.org/881463003
Cr-Commit-Position: refs/heads/master@{#313503}
Roll src/third_party/WebKit b27ee88:0d1eda3 (svn 189102:189107)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b27ee88..0d1eda3
[email protected],[email protected]
Review URL: https://codereview.chromium.org/885623003
Cr-Commit-Position: refs/heads/master@{#313502}
Updating trunk VERSION from 2290.0 to 2291.0
Cr-Commit-Position: refs/heads/master@{#313501}
Propagate push command line flag to the renderer process.
The renderer is using this to conditionally enable payload API surface
for incoming push messages, and thus needs to know about it.
This patch also re-enables the tests.
BUG=452666
Review URL: https://codereview.chromium.org/884093003
Cr-Commit-Position: refs/heads/master@{#313500}
Add profile_chrome_startup.py to generate combined traces for startup.
This is done following a suggestion in
https://codereview.chromium.org/686413002/.
BUG=361548
Review URL: https://codereview.chromium.org/879853002
Cr-Commit-Position: refs/heads/master@{#313499}
Revert of Reenable oobe spoken feedback test. (patchset #4 id:60001 of https://codereview.chromium.org/866713002/)
Reason for revert:
Still failing :(
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6244
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/6247
Original issue's description:
> Reenable oobe spoken feedback test.
>
> The test was disabled because it was flaky. This CL tries to address that
> and reenables the test.
>
> BUG=346797
> [email protected]
>
> Committed: https://crrev.com/e03f042d1c76262248e42334b1d0326b0e4319e7
> Cr-Commit-Position: refs/heads/master@{#313467}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=346797
Review URL: https://codereview.chromium.org/884643003
Cr-Commit-Position: refs/heads/master@{#313498}
ServiceWorker: Fix registration refcount handling in the renderer
- ServiceWorkerRegistrationHandleReference::Create() should increment registration refcount
- ServiceWorkerMessageFilter::OnStaleSetVersionAttributes shouldn’t decrement registration refcount
TEST=n/a
BUG=452403
Review URL: https://codereview.chromium.org/868483008
Cr-Commit-Position: refs/heads/master@{#313497}
Reland of Allow RunShellCommand to work even with very large commands
Currently RunShellCommand may not work if the command passed to
adb.Shell is too large (e.g. > 1024). This CL addresses this
issue, allowing to run even very large commands, by first writing
the command as a shell script and then running it.
Original CL: https://codereview.chromium.org/751063002/
BUG=436133
Review URL: https://codereview.chromium.org/787813002
Cr-Commit-Position: refs/heads/master@{#313496}
win/asan: Only package asan_dynamic dll in component builds.
No intended behavior change.
BUG=448790,451741
Review URL: https://codereview.chromium.org/882943002
Cr-Commit-Position: refs/heads/master@{#313495}
Mechanical rename of tracing includes for /gpu
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/881973004
Cr-Commit-Position: refs/heads/master@{#313494}
Roll src/third_party/WebKit f55332d:b27ee88 (svn 189100:189102)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f55332d..b27ee88
[email protected],[email protected]
Review URL: https://codereview.chromium.org/884703002
Cr-Commit-Position: refs/heads/master@{#313493}
Revert of Use data_deps rather then deps for mojo_bindings. (patchset #1 id:1 of https://codereview.chromium.org/876783003/)
Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=452847
Original issue's description:
> Use data_deps rather then deps for mojo_bindings.
>
> Using deps caused pulling a bit of mojo code to chrome.exe. That
> caused weird unresolved externatls problems during Windows GN build.
>
> Committed: https://crrev.com/f7b4f01989be22df44d9b5475143ef98b653b1ac
> Cr-Commit-Position: refs/heads/master@{#313126}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/880573005
Cr-Commit-Position: refs/heads/master@{#313492}
Add "OK, Google" and extended SafeBrowsing reporting to `chrome.privacy`
BUG=449500,449499
Review URL: https://codereview.chromium.org/854153003
Cr-Commit-Position: refs/heads/master@{#313491}
Mechanical rename of tracing includes for /chrome
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/877323002
Cr-Commit-Position: refs/heads/master@{#313490}
Mechanical rename of tracing includes for /media
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/868753004
Cr-Commit-Position: refs/heads/master@{#313489}
Add AffiliatedInvalidationServiceProvider
Device policy pushing requires a connected invalidation service which
belongs to an account that is affiliated with the device's enrollment
domain. If an affiliated user is logged in and has a connected per-profile
invalidation service, that service is used. Otherwise, a device-global
invalidation service is spun up.
This CL extracts the mechanism from DeviceCloudPolicyInvalidator and
generalizes it so that it can be used by any number of consumers. This
will allow the same invalidation service to be resued by e.g. device
policy pushing, device-local account policy pushing and device remote
commands.
The CL adds a new AffiliatedInvalidationServiceProvider with tests but
does not switch the DeviceCloudPolicyInvalidator to this new
infrastructure yet. That will be done in a follow-up CL.
BUG=442800
TEST=New unit tests
Review URL: https://codereview.chromium.org/828953004
Cr-Commit-Position: refs/heads/master@{#313488}
Explicitly call OnModelChanged when there are no titles to load
Fixs several release blocking regressions in the behaviour of the
startup page list. Lamentably there are no tests for this code and
adding new ones looks tricky (we'd either need to fix crbug.com/419370)
or refactor the classes to be testable.
BUG=452370,452407
Review URL: https://codereview.chromium.org/879953002
Cr-Commit-Position: refs/heads/master@{#313487}
Add IDR entries for the new select popup resources
BUG=346582
Review URL: https://codereview.chromium.org/874363002
Cr-Commit-Position: refs/heads/master@{#313486}
Remove dependencies of InMemoryURLIndex on Profile
Pass to InMemoryURLIndex a pointer to the owning HistoryService and
remove the reference to Profile that is no longer necessary.
Fix the unit tests to no longer pass the Profile, and to call the
Shutdown method before destroying the object so that it properly
remove itself from the HistoryService observer list.
BUG=370850
Review URL: https://codereview.chromium.org/879763002
Cr-Commit-Position: refs/heads/master@{#313485}
Update tracing includes in .mm files and generator for /ui
This is a follow up to crrev.com/866893002 which fixed the tracing
includes without updating the generator.
This CL involves mostly mechanical changes to trace include headers.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/885443005
Cr-Commit-Position: refs/heads/master@{#313484}
Don't notify existing observers in SupervisedUserWhitelistService::AddSiteListsChangedCallback().
The additional callbacks caused the SupervisedUserUrlFilter to update its filter unnecessarily, which in turn flakily quit the observer run loop too early.
This CL fixes the flakiness by using the main thread message loop for the SupervisedUserUrlFilter (removing non-determinism), spreading out the synchronization points for site list updates and URL filter updates, and adding additional sanity checks about observed changes.
BUG=452071
Review URL: https://codereview.chromium.org/875423002
Cr-Commit-Position: refs/heads/master@{#313483}
Remove unused #include in //chrome/browser/history
BUG=None
Review URL: https://codereview.chromium.org/882023004
Cr-Commit-Position: refs/heads/master@{#313482}
Revert of PlzNavigate: Add a browser test for basic navigations (patchset #6 id:100001 of https://codereview.chromium.org/715203004/)
Reason for revert:
Broke the build:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/7409
http://build.chromium.org/p/chromium.webkit/builders/Linux%20GN/builds/18976
http://build.chromium.org/p/chromium.webkit/builders/Win%20Builder/builds/73255
Original issue's description:
> PlzNavigate: Add a browser test for basic navigations
>
> This CL adds a browsertest that checks that basic browser initiated navigations
> work with browser side navigations enabled.
>
> BUG=376014,376006,376091
>
> Committed: https://crrev.com/cd857adbb07fb2e889fa24282648e1f64ede2c95
> Cr-Commit-Position: refs/heads/master@{#313480}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=376014,376006,376091
Review URL: https://codereview.chromium.org/884683002
Cr-Commit-Position: refs/heads/master@{#313481}
PlzNavigate: Add a browser test for basic navigations
This CL adds a browsertest that checks that basic browser initiated navigations
work with browser side navigations enabled.
BUG=376014,376006,376091
Review URL: https://codereview.chromium.org/715203004
Cr-Commit-Position: refs/heads/master@{#313480}
Fix GN build for components/session_manager and /chromeos
BUG=None
TEST=user_manager GN ninja build (debug|official; is_component_build=yes|no)
TBR=oshima
Review URL: https://codereview.chromium.org/880203003
Cr-Commit-Position: refs/heads/master@{#313479}
Add the IDL for chrome.platformKeys.
BUG=450167
Review URL: https://codereview.chromium.org/847163002
Cr-Commit-Position: refs/heads/master@{#313478}
Roll src/third_party/WebKit e57f7c1:f55332d (svn 189098:189100)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e57f7c1..f55332d
[email protected],[email protected]
Review URL: https://codereview.chromium.org/882033002
Cr-Commit-Position: refs/heads/master@{#313477}
Refactoring in unit_test_launcher.cc:
- expose RunUnitTestsSerially and RunUnitTestsBatch
- hide private static ProcessTestResults in anonymous namespace
This will be used to implement ios-specific unit test
relaunch logic. Exposing the helpers makes it possible
to re-use them in ios code.
BUG=426870
[email protected]
Review URL: https://codereview.chromium.org/879883002
Cr-Commit-Position: refs/heads/master@{#313476}
Re-add kUseGpuInTests flag in WebRTC browser tests.
This reverts the removal of the kUseGpuInTests flags done in
https://crrev.com/cf04d9696a7f1f321294bc0970037ddb23c1204d
since it seems this affected performance results.
It also adds it to the new chrome/browser/media/chrome_webrtc_simulcast_browsertest.cc
test.
BUG=452654,452655
Review URL: https://codereview.chromium.org/879223002
Cr-Commit-Position: refs/heads/master@{#313475}
Update visual style of directory tree.
Main changes are:
- Layout change.
- Selected tree item's color is not inverted now.
- Use core-icon's preset icons for for subfolders.
- Add touch feedback.
BUG=402344
TEST=run browser_tests
Review URL: https://codereview.chromium.org/884653002
Cr-Commit-Position: refs/heads/master@{#313474}
gpu: media: RenderingHelper: wait for the display & window to be ready
With the display configuration now asynchronous, we can't immediately read the display size. We need to wait until the hardware is probed.
Also the VSyncProvider cannot trigger the given callback until the PlatformWindow is properly setup with the display. We need to wait for it the actually be resized.
BUG=447798
TEST=run video_decode_accelerator_unittest on freon
Review URL: https://codereview.chromium.org/835653005
Cr-Commit-Position: refs/heads/master@{#313473}
Fix a crash in MimeHandlerServiceImpl::AbortStream().
BUG=452799
Review URL: https://codereview.chromium.org/885563002
Cr-Commit-Position: refs/heads/master@{#313472}
Run V8 GC before detecting Document leaks in inspector_memory_unittest.py.
Previously, this unit test was consistently failing because DOM wrappers were
retained at the time of detecting Document leaks. This patch adds a call to
V8's gc() before the leak check to make sure the DOM wrappers are freed.
BUG=422244
[email protected]
Review URL: https://codereview.chromium.org/882913002
Cr-Commit-Position: refs/heads/master@{#313471}
ServiceWorker: Get registration info and its version attributes in one lock operation
Registration info and its version attributes owned by SWProviderContext can be
accessed from both the main thread and the worker thread, so they are protected
by a lock operation. However, getter functions for those info and attributes are
separated and returned values could be in an invalid state due to interleaved
operations.
This CL merges getter functions (registration() and GetVersionAttributes()) into
GetRegistrationInfoAndVersionAttributes() and avoids such an unexpected state.
BUG=437677
TEST=should pass all existing tests
Review URL: https://codereview.chromium.org/885443006
Cr-Commit-Position: refs/heads/master@{#313470}
Roll src/third_party/WebKit cb45ad8:e57f7c1 (svn 189096:189098)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cb45ad8..e57f7c1
[email protected],[email protected]
Review URL: https://codereview.chromium.org/870263003
Cr-Commit-Position: refs/heads/master@{#313469}
Topsites become keyedService based.
TopSites was created and owned by profile.
This patch creates a TopSitesServicefactory which is keyedService.
So now instead of calling GetTopSites() from profile, can get the TopSites from
TopSitesFactory.
BUG=435501
Review URL: https://codereview.chromium.org/815983002
Cr-Commit-Position: refs/heads/master@{#313468}
Reenable oobe spoken feedback test.
The test was disabled because it was flaky. This CL tries to address that
and reenables the test.
BUG=346797
[email protected]
Review URL: https://codereview.chromium.org/866713002
Cr-Commit-Position: refs/heads/master@{#313467}
Update V8 to version 4.2.33 (based on aeb3a7174050e67267a4e2c123469f040400008e).
[email protected]
Review URL: https://codereview.chromium.org/879203003
Cr-Commit-Position: refs/heads/master@{#313466}
Roll src/third_party/WebKit c042635:cb45ad8 (svn 189094:189096)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c042635..cb45ad8
[email protected],[email protected]
Review URL: https://codereview.chromium.org/885573003
Cr-Commit-Position: refs/heads/master@{#313465}
ozone: evdev: Move EventModifiersEvdev usage to EventFactoryEvdev
This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.
EventModifiersEvdev is a UI thread object, so move all remaining
ui::Event construction outside of the device-specific objects. Devices
no longer get a EventModifiersEvdev* since they will execute on a
different thread.
This completes the series moving ui::Event construction out of device
objects and into EventFactoryEvdev.
BUG=449710
TEST=boot link_freon & click mouse
Review URL: https://codereview.chromium.org/867803004
Cr-Commit-Position: refs/heads/master@{#313464}
media: Support MojoRendererService in the browser process.
On some platforms, we run part of the media pipeline in the browser process. For example, on ChromeCast and on Android, audio/video buffers are decoded in the browser process. Currently, there are some ad-hoc IPC mechanism implemented for these platforms to support hosting the decoders in the browser process. This CL aims at providing a common mojo based path to support this scenario.
This CL makes it possible to host a mojo::MeidaRenderer service in the browser process. By default, it's using media::RendererImpl and some default audio/video decoders. In later CLs, I'll update this so that we can support embedder specific media::Renderer implementation in MojoRendererService.
Note that media playback is NOT working yet due to DataPipe is not working out-of-process.
Test steps:
1, Change "enable_media_mojo_renderer" to true in media/media_options.gni.
2, Build a GN build of Chrome.
3, Play <video> in Chrome.
BUG=431776
TEST=See above test steps.
Review URL: https://codereview.chromium.org/712463004
Cr-Commit-Position: refs/heads/master@{#313463}
Shift polymer.html imports to custom elements.
Move the polymer.html into the individual custom elements (such as viewer-progress-bar) from index.html and index-material.html.
Review URL: https://codereview.chromium.org/869013002
Cr-Commit-Position: refs/heads/master@{#313462}
Send notification when render process has failed to launch.
Before this patch, information about renderer that crashed
at startup (i.e. failed to start) was not forwarded to WebContents, etc...
BUG=452812
Review URL: https://codereview.chromium.org/879533006
Cr-Commit-Position: refs/heads/master@{#313461}
Automated Commit: Committing new LKGM version 6733.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#313460}
Roll src/third_party/WebKit 334b845:c042635 (svn 189088:189094)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/334b845..c042635
[email protected],[email protected]
Review URL: https://codereview.chromium.org/880203002
Cr-Commit-Position: refs/heads/master@{#313459}
Set audio format before adding pepper sink to audio track.
Some audio input devices don't generate caputure data in a continuous basis, and
instead only generate when some event happens. This may be an indefinite amount
of time. However, |AudioSink::OnSetFormat| is only called whenever new samples
come in. For pepper plugins, this means that |MediaStreamAudioTrack::Configure|
can be blocked indefintely on these devices. To work around this, get the
format before attaching to the audio track.
BUG=403138
Review URL: https://codereview.chromium.org/857093002
Cr-Commit-Position: refs/heads/master@{#313458}
[chromedriver] Release ChromeDriver 2.14
BUG=
Review URL: https://codereview.chromium.org/874393003
Cr-Commit-Position: refs/heads/master@{#313457}
Roll src/third_party/WebKit 7fa6ed7e:334b845 (svn 189085:189088)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7fa6ed7e..334b845
[email protected],[email protected]
Review URL: https://codereview.chromium.org/880193002
Cr-Commit-Position: refs/heads/master@{#313456}
Files.app: Add missing externs for FileManagerPrivate APIs.
searchFilesByHashes
computeChecksum
BUG=None
Review URL: https://codereview.chromium.org/883993003
Cr-Commit-Position: refs/heads/master@{#313455}
Move GuestView IPCs out of ExtensionMessageFilter to GuestViewMessageFilter
BUG=none
Review URL: https://codereview.chromium.org/880123002
Cr-Commit-Position: refs/heads/master@{#313454}
metrics: add metrics for wake on WiFi throttling
Add metric to log whether or not wake on WiFi is disabled
in the duration of a single suspend because of excessive
dark resume wakes.
BUG=chrome-os-partner:35518
TEST=None.
Review URL: https://codereview.chromium.org/876373002
Cr-Commit-Position: refs/heads/master@{#313453}
test_env.py: Disable sandbox on clang/win for now.
Swarming uses the command baked into the isolate (via test_env.py) for running
test instead of using the runtest.py script. Hence, test_env.py needs to
learn everything runtest.py already knows -- for example, that tests can't
run with the sandbox in asan/win yet.
BUG=451741,382867
[email protected]
Review URL: https://codereview.chromium.org/882913004
Cr-Commit-Position: refs/heads/master@{#313452}
Roll src/third_party/skia 25b7611:8b0a05a
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/25b7611..8b0a05a
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/884623002
Cr-Commit-Position: refs/heads/master@{#313451}
Roll src/third_party/WebKit 7f3bd0d:7fa6ed7e (svn 189069:189085)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7f3bd0d..7fa6ed7e
[email protected],[email protected]
Review URL: https://codereview.chromium.org/876343005
Cr-Commit-Position: refs/heads/master@{#313450}
Don't allow profile deletion in Metro mode.
Bad things happen if you delete the profile that started the Metro
process (at best, you crash), since relaunching Metro with a new user
is not supported. Hiding the button selectively depending on the
profile selected is a bit weird, so in Metro mode, hide it for all
profiles.
BUG=448352
Review URL: https://codereview.chromium.org/863063002
Cr-Commit-Position: refs/heads/master@{#313449}
text input focus: Supports Window::GetFocusedTextInputClient.
This CL is split off from http://crrev.com/785463002 and
Window::GetFocusedTextInputClient is necessary in that CL.
BUG=290701
Review URL: https://codereview.chromium.org/860983004
Cr-Commit-Position: refs/heads/master@{#313448}
NaCl: Update revision in DEPS, 945d33419 -> 939a13aa3
This pulls in the following Native Client changes:
939a13a ([email protected]) Provide an irt_core_lib GN target.
dbf2af4 ([email protected]) Remove include of build_config.h from nacl_exception.h
e205317 ([email protected]) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
7c8a96b ([email protected]) Update revision for PNaCl
3d00a54 ([email protected]) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
1de8ba8 ([email protected]) Update codereview.settings following the switch from SVN to Git
7a6cf46 ([email protected]) Update revision for PNaCl
bc28c0b ([email protected]) Fix the native_client URL in the PNaCl REV file.
f8aa9dc ([email protected]) Adding le32-nacl build of pnacl tools.
cfda521 ([email protected]) Explicitly include build_config.h.
61b7ba9 ([email protected]) Output depfile from build_nexe.
2d65c23 ([email protected]) PNaCl: Update LLVM and Subzero revision in pnacl/COMPONENT_REVISIONS
5f5cd88 ([email protected]) Fix PNaCl redirectors for i686-nacl-xx -> x86_64-nacl-xx
1baa204 ([email protected]) Remove some more dead code and variables from pnacl/build.sh.
f116471 ([email protected]) Update revision for PNaCl
01f3d97 ([email protected]) Always define product_dir in build_nexe.
8a5a846 ([email protected]) Remove the IRT's now-unneeded call to NaClSrpcModuleInit()
c14b58a ([email protected]) Remove NaClPluginLowLevelInitializationComplete() (caller of "init_done" SRPC)
c5d8394 ([email protected]) Change driver bash scripts to work in devenv.
490e554 ([email protected]) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
2a7391a ([email protected]) Fix several issues with update_pnacl_tool_revisions.py
fbc3b5c ([email protected]) Support filenames with spaces in the PNaCl driver scripts.
4f726e8 ([email protected]) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
28a1341 ([email protected]) Move pnacl driver test runs from buildbot_pnacl.sh to buildbot_pnacl_toolchain.py
9f9d773 ([email protected]) Update GCC revision in tools/REVISIONS
29ae54a ([email protected]) Update revision for PNaCl
BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_compile,linux_nacl_sdk_build
Review URL: https://codereview.chromium.org/881893003
Cr-Commit-Position: refs/heads/master@{#313447}
Dump property values for the touch log source
The CL dumps gesture property values for touch devices that run
with the CrOS gesture library. The format is designed to be
backward-compatible with the X11 behaviour.
Contributed by [email protected]
BUG=450159
TEST=samus ChromeOS build
Review URL: https://codereview.chromium.org/864253002
Cr-Commit-Position: refs/heads/master@{#313446}
Add helper method to check for invalid message source.
This CL refactors the check for invalid render_frame_message_source_ to a common method and uses it in all of the relevant IPC handlers. Ideally it will all be removed once RenderViewHost disappears or all of its IPC handling is removed.
BUG=451932, 449777
Review URL: https://codereview.chromium.org/877203002
Cr-Commit-Position: refs/heads/master@{#313445}
Ignore the default zoom level for the PDF extension and print preview.
Previously, the PDF extension UI was zoomed to the default zoom level
and the PDF was inversely affected (due to various calculations using
zoomed and not zoomed sizes). This resets the zoom level for extensions
used as mime handlers on mime handler WebContents creation and for print
preview (as the PDF extension zoom as controlled by the embedding print
preview dialog WebContents.
BUG=450910
Review URL: https://codereview.chromium.org/881553003
Cr-Commit-Position: refs/heads/master@{#313444}
Roll src/third_party/skia 6dbfb21:25b7611
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/6dbfb21..25b7611
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/878163003
Cr-Commit-Position: refs/heads/master@{#313443}
Mechanical rename of tracing includes for /cc
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/885543002
Cr-Commit-Position: refs/heads/master@{#313442}
Mac: Refine ui_controls_mac's SynthesizeKeyEvent()
In preparation for moving SynthesizeKeyEvent to cocoa_test_event_utils,
this refines the behavior of SynthesizeKeyEvent to more closely match
actual events. There were two bugs:
The unichar character being set on a simulated "Delete" key was actually
the unichar that Mac uses for "Backspace" (0x7f). Cocoa actually uses
0xf728 for the delete key (NSDeleteFunctionKey). Note "Backspace" stays
sending 0x8 (Ctrl+H) rather than being updated to 0x7f (ASCII DEL).
Either seems to work for Backspace (which meant simulated Deletes were
becoming deleteBackward action messages rather than deleteForward).
Also, SynthesizeKeyEvent is updated to closely follow the behavior on
Mac wrt Command/Shift modifiers. The bug here was that when *just*
Shift+letter is pressed, characters and charactersIgnoringModifiers
should *both* be uppercase. (r311815 swapped them for Ctrl, but didn't
try to fix Shift).
These changes are needed for comprehensive testing of views::TextField
on Mac. Specifically, to get TextfieldTest.ControlAndSelectTest and
TextfieldTest.ControlAndSelectTest passing with simulated NSEvents.
BUG=378134
Review URL: https://codereview.chromium.org/856313003
Cr-Commit-Position: refs/heads/master@{#313441}
Upstream script to get "salient" image from webpage.
This is used by enhanced bookmarks to choose an image to show for each
bookmark.
BUG=450287
Review URL: https://codereview.chromium.org/885513002
Cr-Commit-Position: refs/heads/master@{#313440}
Update V8 to version 4.2.32 (based on 701c6e747569926c13160d668035ac05d363e5dc).
[email protected]
Review URL: https://codereview.chromium.org/884603002
Cr-Commit-Position: refs/heads/master@{#313439}
Mechanical rename of tracing includes for /content [2/3]
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/862403005
Cr-Commit-Position: refs/heads/master@{#313438}
Mechanical rename of tracing includes for /content [3/3]
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/872363004
Cr-Commit-Position: refs/heads/master@{#313437}
Add a test for mime handler view iframes and make them work on Windows.
Review URL: https://codereview.chromium.org/878773002
Cr-Commit-Position: refs/heads/master@{#313436}
Roll src/third_party/WebKit 12a5230:7f3bd0d (svn 189000:189069)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/12a5230..7f3bd0d
[email protected],[email protected]
Review URL: https://codereview.chromium.org/882883002
Cr-Commit-Position: refs/heads/master@{#313435}
Distinguish between wired and Wi-Fi connections in the captive portal interstitial.
BUG=451272
Review URL: https://codereview.chromium.org/872993003
Cr-Commit-Position: refs/heads/master@{#313434}
fix autofill shadowing vars warning
found by the vc /analyze bot
BUG=440500
Review URL: https://codereview.chromium.org/876343004
Cr-Commit-Position: refs/heads/master@{#313433}
Make javac.py assume UTF-8 encoding always
My understanding is that by-default javac
pulls encoding from the user's environment
http://stackoverflow.com/questions/9661935/how-to-change-the-defaults-system-java-encode-form-in-windows
http://stackoverflow.com/questions/11343828/file-encoding-has-no-effect-lc-all-environment-variable-does-it
which is wrong for Chromium where all of our
source files are known to be UTF-8, regardless
of what the user has set in their environment.
In my case I was using Chrome Remote Desktop
to connect to my linux machine and for
whatever reason LANG was missing from the
resulting environment. After this patch
mojo_shell builds correctly for Android again.
BUG=419378
Review URL: https://codereview.chromium.org/869673002
Cr-Commit-Position: refs/heads/master@{#313432}
Hide pinch viewport scrollbars when near minimum scale.
This patch prevents the overlay scrollbars from showing up when we're near the
minimum scale. The threshold can be set per-platform; by default it's 0 so the
scrollbars will be visible regardless of the scale. On Windows/Linux/CrOS we'd
like to prevent the scrollbars from overlaying over the window scrollbars so
we set a small non-0 threshold.
BUG=446411
Review URL: https://codereview.chromium.org/877863002
Cr-Commit-Position: refs/heads/master@{#313431}
Remove google_apis::ResourceEntry and related code
The class derives from WAPI, which is no longer used.
BUG=357038
TEST=syncfs unit tests pass
[email protected]
# for google_apis/{BUILD.gn,google_apis.gyp)
Review URL: https://codereview.chromium.org/881723002
Cr-Commit-Position: refs/heads/master@{#313430}
clarify operator precedence in test.
VS /analyze complains about this.
BUG=427616
Review URL: https://codereview.chromium.org/878333002
Cr-Commit-Position: refs/heads/master@{#313429}
cc: Clean up tilings in UpdateTiles as well as in AppendQuads.
Sometimes we get into situations where we get frequent UpdateTiles,
but no AppendQuads. As a result we can start accumulating tilings
(during pinch zoom for example), but we never free any of them, since
the code to free tilings happens only during AppendQuads. This patch
remedies this by ensuring that if AppendQuads doesn't clean up the
tilings, and we've added some since last time we ran UpdateTiles,
we clean them up.
R=danakj
BUG=452304
Review URL: https://codereview.chromium.org/881083002
Cr-Commit-Position: refs/heads/master@{#313428}
Instrumenting NetworkChangeNotifierWin::GetCurrentConnectionType for jank
We suspect that this method may be causing jankiness of QuicClientSession constructor
BUG=422516
Review URL: https://codereview.chromium.org/879943003
Cr-Commit-Position: refs/heads/master@{#313427}
Move cloud import button to toolbar, make material designey.
This is the first of several steps in bringing a material design friendly cloud import feature.
BUG=420680
TEST=browser_test: FileManagerJsTest.*
Review URL: https://codereview.chromium.org/883973002
Cr-Commit-Position: refs/heads/master@{#313426}
ozone: evdev: Move MouseButtonMap usage during dispatch to EventFactoryEvdev
This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.
The mouse button map is a UI thread object, so move all of the mouse
processing that needs button map information outside of the
device-specific object. Devices no longer get a MouseButtonMapEvdev*
since they will execute on a different thread.
BUG=449710
TEST=boot link_freon & click mouse
Review URL: https://codereview.chromium.org/872683006
Cr-Commit-Position: refs/heads/master@{#313425}
Chromecast: rpath for loading NSS module in cast_shell directory.
[email protected],[email protected]
BUG=336640
Review URL: https://codereview.chromium.org/876373004
Cr-Commit-Position: refs/heads/master@{#313424}
Do not use Win32k renderer lockdown if DirectWrite is disabled.
OOP PDF is now enabled by default, so remove the check in ChromeBrowserMainPartsWin::PreCreateThreads
BUG=442157
TEST=launch with --enable-win32k-renderer-lockdown or --force-fieldtrials=Win32kLockdown/Enabled/ check chrome://histograms that Win32k lockdown is enabled. Check OOP PDF still works both with and without --disable-direct-write switch.
Review URL: https://codereview.chromium.org/872673002
Cr-Commit-Position: refs/heads/master@{#313423}
metrics: rename termination, suspend, dark resume action time histograms
Rename termination, suspend, and dark resume action time histograms. This is to
accomodate to the change in the max value of these non-enumerated histograms
introduced in Chrome OS CL:238890.
BUG=chromium:443458
TEST=none.
Review URL: https://codereview.chromium.org/819713007
Cr-Commit-Position: refs/heads/master@{#313422}
Mechanical rename of tracing includes for /content [1/3]
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/866803003
Cr-Commit-Position: refs/heads/master@{#313421}
Report viewport memory and timing correctly for Slimming Paint.
The rasterize_and_record benchmark was not using data from the
DisplayItemList. Now it does.
[email protected],[email protected]
BUG=451448
Review URL: https://codereview.chromium.org/867803003
Cr-Commit-Position: refs/heads/master@{#313420}
Added GPU performance metrics.
Metrics have been added for the GPU using the GPU Tracer. Currently
we record the average, max, and stddev ms for each category
per frame for the following categories:
render_compositor: Both CPU/GPU side spent on the render compositor.
browser_compositor: Both CPU/GPU spent on browser compositor.
total: Both CPU/GPU and total frame time spent in renderer.
swap: Time between swaps, total FPS.
[email protected]
BUG=None
Review URL: https://codereview.chromium.org/854833003
Cr-Commit-Position: refs/heads/master@{#313419}
Ensure that entries are correctly removed from the MimeHandlerViewContainer map
Currently if the RenderFrame is destroyed prior to the MimeHandlerViewContainer
then we will look for the wrong entry in the map. This fixes that issue by
removing the entry when the RenderFrame is destroyed.
Review URL: https://codereview.chromium.org/874293004
Cr-Commit-Position: refs/heads/master@{#313418}
Throw a DataError rather than OperationError in some cases when importing invalid EC key.
Review URL: https://codereview.chromium.org/839653002
Cr-Commit-Position: refs/heads/master@{#313417}
Android: Propagate sample rate change to audio decoder job
AudioDecoderJob maintains an object audio_timestamp_helper_ for use with AV sync. Previously, this object was configured with demuxer value for sample rate, whereas it should instead be synced with the decoder's reported sample rate.
This CL enables AudioDecoderJob to track decoder output rate, and ensures change in output format is propagated to this object.
BUG=internal b/18873488
Review URL: https://codereview.chromium.org/805273007
Cr-Commit-Position: refs/heads/master@{#313416}
Use builder_type when requesting/fetching builds, and add support for full linux builds.
Changes in this CL:
- In request_build.py, add a URL for linux try bot.
- Add sample config for functional bisect.
- Make perf-related config parameters optional.
- Use builder type when starting build try jobs, and when fetching builds.
A few other changes:
- Update bisect_perf_regression.py file docstring.
- Rename _BuilderTryjob to _StartBuilderTryJob and refactor.
- Remove unused code in request_build.py.
Proposed follow-up:
- Move functions related to builder to be methods of one class, so that the builder-specific info/logic (e.g. builder bot and archive location) is in one place.
BUG=
Review URL: https://codereview.chromium.org/806943007
Cr-Commit-Position: refs/heads/master@{#313415}
Fix flaky testWebView on Android
BUG=452266
Review URL: https://codereview.chromium.org/858093003
Cr-Commit-Position: refs/heads/master@{#313414}
[Telemetry] Remove empty action_name_to_run for skpicture_printer
BUG=418375
Review URL: https://codereview.chromium.org/883853004
Cr-Commit-Position: refs/heads/master@{#313413}
Roll src/third_party/skia 8ece6eb:6dbfb21
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8ece6eb..6dbfb21
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/871193004
Cr-Commit-Position: refs/heads/master@{#313412}
MacViews: Fix duplicate definition of ValidationMessageBubble::ShowAndCreate
Refactor into a virtual method on TabDialogs, with overrides for Views and
Cocoa.
ValidationMessageBubble is moved out of chrome namespace to be more
consistent with other dialogs.
BUG=425229
Review URL: https://codereview.chromium.org/867323005
Cr-Commit-Position: refs/heads/master@{#313411}
Fix variable shadowing warning in CRLSet on VS2015
d:\src\cr3\src\net\cert\crl_set.cc(53): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\net\cert\crl_set.cc(53): warning C4456: declaration of 'i' hides previous local declaration
d:\src\cr3\src\net\cert\crl_set.cc(47): note: see declaration of 'i'
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/882833002
Cr-Commit-Position: refs/heads/master@{#313410}
Copy Smart Lock user preferences to local state so we can access them on the sign-in screen.
The only preference right now is proximityRequired, which is now returned
through the chrome.easyUnlockPrivate.getUserInfo API.
BUG=403419
Review URL: https://codereview.chromium.org/880603003
Cr-Commit-Position: refs/heads/master@{#313409}
[Smart Lock] Add a private API to show an error bubble anchored to the Smart Lock app window.
BUG=406439
TEST=none
[email protected]
Review URL: https://codereview.chromium.org/843023002
Cr-Commit-Position: refs/heads/master@{#313408}
Minor Refactor:
Define kInvalidMediaPlayerID to replace "-1"
for BrowserMediaPlayerManager
BUG=
Review URL: https://codereview.chromium.org/883653002
Cr-Commit-Position: refs/heads/master@{#313407}
Remove NOTIFICATION_HISTORY_URLS_DELETED
Add the method OnURLsDeleted() to History{Backend,Service}Observer and
change History{Backend,Service} to call this method instead of sending
the notification.
Port client code to implement the History{Backend,Service}Observer
interface instead of using chrome::NOTIFICATION_HISTORY_URLS_DELETED.
Remove obsolete code for broadcasting notification from history code and
HistoryDetails type.
BUG=373326
Review URL: https://codereview.chromium.org/773103004
Cr-Commit-Position: refs/heads/master@{#313406}
Disable failing PushMessaging browser tests.
Failing on chromium.webkit/ChromiumOS
BUG=452666
[email protected]
Review URL: https://codereview.chromium.org/881073003
Cr-Commit-Position: refs/heads/master@{#313405}
Move sandboxed_unpacker.{h,cc} from chrome/ to extensions/
This is a mostly mechanical change to move these files over, and
make corresponding changes to strings, build files, and include paths.
BUG=447014
Review URL: https://codereview.chromium.org/864093002
Cr-Commit-Position: refs/heads/master@{#313404}
Add mojoPrivate.requireAsync method to chrome IDL.
Add unit tests for requireAsync.
[email protected],[email protected]
[email protected],[email protected]
BUG=
Review URL: https://codereview.chromium.org/862793003
Cr-Commit-Position: refs/heads/master@{#313403}
Introduce HostID and de-couple Extensions from "script injection System" [browser side]
The major refactor includes:
- Introduce HostID (a pair of |id, type|) to replace extension_id in browser
side.
- Abstract UserScriptLoader to be a base class, and introduces
a derived class ExtensionUserScriptLoader which is
responsible for loading user scripts for extensions.
- In DeclarativeUserScriptManager, a master is created per
extension/webUI.
- DeclarativeUserScriptManager becomes an
ExtensionRegistryObserver and is responsible for clearing scripts
for master objects when receive OnExensionUnloaded event.
BUG=437566
Review URL: https://codereview.chromium.org/822453002
Cr-Commit-Position: refs/heads/master@{#313402}
Revert of Reland "mac: Layer back the root view of the browser window on OSX 10.9+." (patchset #1 id:1 of https://codereview.chromium.org/878673006/)
Reason for revert:
Chrome Mac lost its rounded bottom corners
https://code.google.com/p/chromium/issues/detail?id=452707
Original issue's description:
> Reland "mac: Layer back the root view of the browser window on OSX 10.9+."
>
> The original CL was reverted because it caused non-deterministic failures in
> browser tests that used the file tab-restore-visibility.html. The test file had
> an edge case that caused thrashing and prevented the page from loading. This
> has since been fixed.
>
> > BrowserWindowController always layer-backs the contentView of the window. If
> > Chrome were linked against OSX 10.9, this would also cause the root view to be
> > layer backed. Since Chrome is linked against OSX 10.6, the root view by default
> > is not layer backed.
> >
> > BrowserWindowController is going to have a custom AppKit fullscreen animation,
> > which requires that the root view is layer backed. While it is possible to
> > implement a custom AppKit fullscreen animation as early as OSX 10.7, the
> > effects of layer backing the root view on OSX 10.7 are murky. It seems much
> > safer to just layer back the root view on OSX 10.9+, and only enable the custom
> > AppKit fullscreen animation on OSX 10.9+.
> >
> > As far as I know, this change has no detrimental side effects. There is no
> > spike in memory usage
> > (https://code.google.com/p/chromium/issues/detail?id=396264#c11), presumably
> > because NSThemeFrame implements -wantsUpdateLayer on OSX 10.9+.
> >
> > BUG=413009, 414527
> > Committed: https://crrev.com/8dec34f8f3504352e4eef95b2aaa36c561aea930
> > Cr-Commit-Position: refs/heads/master@{#311191}
>
> BUG=413009, 414527
> [email protected]
>
> Committed: https://crrev.com/4713180802457f8c6854c10db4689ab4fab98155
> Cr-Commit-Position: refs/heads/master@{#313207}
TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=413009, 414527
Review URL: https://codereview.chromium.org/881133002
Cr-Commit-Position: refs/heads/master@{#313401}
cc: Attempt to deflake the LayerTreeHostPictureTestTwinLayer test.
This test has been flaky (see bug), but I am not able to recreate the
flake locally. However, this test does PostSetNeedsCommit() from the
impl thread while also causing commits from the main thread in DidCommit
which could cause an extra commit to happen in theory.
This changes the test to stop using PostSetNeedsCommit() and always
cause commits from DidCommit on the main thread, to help make the test
more deterministic.
R=ajuma, [email protected], vmpstr
BUG=451988
Review URL: https://codereview.chromium.org/877213002
Cr-Commit-Position: refs/heads/master@{#313400}
Fix missing .Pass() on returning scoped_ptr<SdchManager::DictionarySet>
Warns on VS2015. I'm not sure why this is new, I guess something
become move-able (or not-move-able).
d:\src\cr3\src\net\base\sdch_manager.cc(459): error C2248: 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr': cannot access private
member declared in class 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>'
with
[
T=net::SdchManager::DictionarySet
]
d:\src\cr3\src\base\memory\scoped_ptr.h(312): note: see declaration of 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr'
with
[
T=net::SdchManager::DictionarySet
]
d:\src\cr3\src\net\base\sdch_manager.cc(463): error C2248: 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr': cannot access private
member declared in class 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>'
with
[
T=net::SdchManager::DictionarySet
]
d:\src\cr3\src\base\memory\scoped_ptr.h(312): note: see declaration of 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr'
with
[
T=net::SdchManager::DictionarySet
]
d:\src\cr3\src\net\base\sdch_manager.cc(467): error C2248: 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr': cannot access private
member declared in class 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>'
with
[
T=net::SdchManager::DictionarySet
]
d:\src\cr3\src\base\memory\scoped_ptr.h(312): note: see declaration of 'scoped_ptr<net::SdchManager::DictionarySet,base::DefaultDeleter<T>>::scoped_ptr'
with
[
T=net::SdchManager::DictionarySet
]
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/883753004
Cr-Commit-Position: refs/heads/master@{#313399}
Roll WebRTC 8141:8176, Libjingle 8141:8174
WebRTC 8141:8176
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/67d96fc..9fbfe8f
Libjingle 8141:8174
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/419aa31..6660ffc
[email protected]
Review URL: https://codereview.chromium.org/882813003
Cr-Commit-Position: refs/heads/master@{#313398}
ozone: evdev: Move KeyboardEvdev usage during dispatch to EventFactoryEvdev
This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.
The keyboard layout is a UI thread object, so move all of the keyboard
processing that needs layout information outside of the device-specific
processing. Devices no longer get a KeyboardEvdev* since they will
execute on a different thread.
BUG=449710
TEST=boot link_freon & press key
Review URL: https://codereview.chromium.org/872883003
Cr-Commit-Position: refs/heads/master@{#313397}
Assume Munjal's place in the cast channel OWNERS file.
BUG=
Review URL: https://codereview.chromium.org/883503004
Cr-Commit-Position: refs/heads/master@{#313396}
Also catch devtools_http.DevToolsClientConnectionError.
BUG=450278
TEST=cros unittests
Review URL: https://codereview.chromium.org/868253003
Cr-Commit-Position: refs/heads/master@{#313395}
Migrates legacy packaged app data when it's upgraded to a platform app
Currently, data stored by a legacy packaged app in the HTML5 filesystem
and IndexedDB is lost when it gets migrated to the new type of Chrome App
(internally referred to as "platform apps"). This is because Chrome stores
extension and legacy packaged app data in the general storage partition and
it stores platform app data in a it's own isolated storage partition.
When a legacy packaged app is upgraded to the new type of app, a new
isolated storage partition is created but the data gets left behind
in the general storage partition.
This change fixes this by performing a migration of the data to the new
storage partition at the time of the upgrade. It only migrates IndexedDB
and HTML5 filesystem because these are the only permanent data storage
options available to platform apps. Platform apps are prohibited from
using DOMStorage and WebSQL. Data stored by chrome.storage APIs is
separate from the storage partitions.
BUG=302577
Review URL: https://codereview.chromium.org/671873004
Cr-Commit-Position: refs/heads/master@{#313394}
A better fix for crash when opening Incognito window.
A better fix for https://codereview.chromium.org/822083004/.
Set kServiceRedirectedInIncognito so that
ExtensionCommandsGlobalRegistry::Get does not return null on incognito
profiles, and remove null checks that are no longer necessary.
BUG=450903
Review URL: https://codereview.chromium.org/883553002
Cr-Commit-Position: refs/heads/master@{#313393}
Remove obsolete sandbox disabling logic from testing/test_env.py.
This mirrors the change made to build/runtest.py in
https://codereview.chromium.org/881743004
BUG=245376
[email protected], [email protected]
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/880053003
Cr-Commit-Position: refs/heads/master@{#313392}
Chromecast Android buildfix: use new ContentViewCore.initialize API.
See: https://codereview.chromium.org/831523005
[email protected],[email protected]
BUG=None
Review URL: https://codereview.chromium.org/879073002
Cr-Commit-Position: refs/heads/master@{#313391}
Fix variable shadowing warnings in UDPSocketWin on VS2015
d:\src\cr3\src\net\udp\udp_socket_win.cc(330): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\net\udp\udp_socket_win.cc(330): warning C4457: declaration of 'address' hides function parameter
d:\src\cr3\src\net\udp\udp_socket_win.cc(319): note: see declaration of 'address'
d:\src\cr3\src\net\udp\udp_socket_win.cc(351): warning C4457: declaration of 'address' hides function parameter
d:\src\cr3\src\net\udp\udp_socket_win.cc(340): note: see declaration of 'address'
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/882733003
Cr-Commit-Position: refs/heads/master@{#313390}
Roll libvpx: 097fdc:cf86fa
Correctly try to detect AVX2:
https://codereview.chromium.org/869853003
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_vista_rel_ng
[email protected]
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/882793002
Cr-Commit-Position: refs/heads/master@{#313389}
Add AddMessageToDevToolsConsole to WebContentsAndroid
For now there isn't any API to write some logs to dev tools console from
Java layer.
It is required to fix http://crbug.com/426751 .
BUG=426751
Review URL: https://codereview.chromium.org/873133002
Cr-Commit-Position: refs/heads/master@{#313388}
Make in-process gpu init thread safe
Initialize in-process gpu before threads are created.
In-process gpu init appends command line switches to the
global current process command line, which is only safe to
do before any background threads start and read the command
line.
BUG=450396
Review URL: https://codereview.chromium.org/879703003
Cr-Commit-Position: refs/heads/master@{#313387}
[chromedriver] Drop support for M38 and add support for M41.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/883743003
Cr-Commit-Position: refs/heads/master@{#313386}
Expose --site-per-process in chrome://flags
BUG=99379
Review URL: https://codereview.chromium.org/880093002
Cr-Commit-Position: refs/heads/master@{#313385}
Replicate sandbox flags for OOPIF (Chromium part 2).
* Remove old versions of createChildFrame.
* Add browser tests.
Related CLs:
Chromium part 1: https://codereview.chromium.org/837283003/
Blink part 1: https://codereview.chromium.org/793493003/
Blink part 2: https://codereview.chromium.org/838903002/
BUG=426512
Review URL: https://codereview.chromium.org/797813006
Cr-Commit-Position: refs/heads/master@{#313384}
Remove indirection for SiteInstance and RenderProcessHost from RenderFrameHost.
Currently the SiteInstance and RenderProcessHost for a RenderFrameHost are retrieved from the associated RenderViewHost. The RFH code is sufficiently along the way to keep track of these on its own.
BUG=304341
Review URL: https://codereview.chromium.org/881683002
Cr-Commit-Position: refs/heads/master@{#313383}
Replace NULL with nullptr.
BUG=
Review URL: https://codereview.chromium.org/843453002
Cr-Commit-Position: refs/heads/master@{#313382}
Do not send PASV until RETR or LIST
Some servers get confused when we send PASV twice. This CL delays sending
PASV/EPSV until RETR or LIST.
BUG=450687
Review URL: https://codereview.chromium.org/861193007
Cr-Commit-Position: refs/heads/master@{#313381}
Add CopyTexSubImage3D to GPU command buffer.
BUG=429053
TEST=gpu_unittests
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/878793002
Cr-Commit-Position: refs/heads/master@{#313380}
[fsp] Add an information that root entry name should be an empty string
Before, it was not well defined what's the name of a root entry.
TEST=None
BUG=446437
Review URL: https://codereview.chromium.org/881903002
Cr-Commit-Position: refs/heads/master@{#313379}
Add missing .Pass() on return of SampleVector
On VS2015 without this causes:
d:\src\cr3\src\base\metrics\histogram.cc(372): error C2248: 'scoped_ptr<base::SampleVector,base::DefaultDeleter<T>>::scoped_ptr': cannot access private member declared in class 'scoped_ptr<base::SampleVector,base::DefaultDeleter<T>>'
with
[
T=base::SampleVector
]
d:\src\cr3\src\base\memory\scoped_ptr.h(312): note: see declaration of 'scoped_ptr<base::SampleVector,base::DefaultDeleter<T>>::scoped_ptr'
with
[
T=base::SampleVector
]
I'm not entirely sure why this doesn't happen on earlier compilers,
I guess something's move-ability changed.
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/882783002
Cr-Commit-Position: refs/heads/master@{#313378}
[MemSheriff] No longer exclude a fixed test on DrMemory.
BUG=451983
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/881933002
Cr-Commit-Position: refs/heads/master@{#313377}
Roll Syzygy DEPS to version 0.8.4.1
Version 0.8.4.1
[----------] Fixed some unittest failures.
Version 0.8.4.0
[5130039b66] Synchronize page protection modifications.
[e204e630ba] SyzyASan - Fix an issue when the first block of a corrupt range has
page protections.
[aef343e391] Preserve alignment of code blocks generated by unsupported
compilers.
See https://code.google.com/p/syzygy/source/browse/syzygy/build/RELEASE-NOTES.TXT for the full version of the release notes.
BUG=
Review URL: https://codereview.chromium.org/882803002
Cr-Commit-Position: refs/heads/master@{#313376}
Remove Omnibox Disallow Inlining Field Trial
The results are summarized here: goto/disallow-inlining-trial-results
This is effectively a revert of
https://src.chromium.org/viewvc/chrome?revision=273966&view=revision
and
http://src.chromium.org/viewvc/chrome?view=revision&revision=278811
BUG=
Review URL: https://codereview.chromium.org/879053002
Cr-Commit-Position: refs/heads/master@{#313375}
Fix shadowing warning in json_parser on VS2015
d:\src\cr3\src\base\json\json_parser.cc(431): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\base\json\json_parser.cc(431): warning C4456: declaration of 'next_char' hides previous local declaration
d:\src\cr3\src\base\json\json_parser.cc(427): note: see declaration of 'next_char'
I don't think there's any need for a new variable inside the loop.
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/881003003
Cr-Commit-Position: refs/heads/master@{#313374}
Fix variable shadowing warning in registry on VS2015
d:\src\cr3\src\base\win\registry.cc(665): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\base\win\registry.cc(665): warning C4456: declaration of 'result' hides previous local declaration
d:\src\cr3\src\base\win\registry.cc(659): note: see declaration of 'result'
I don't think there's any need for separate variables.
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/868253004
Cr-Commit-Position: refs/heads/master@{#313373}
Roll src/third_party/skia 52b64b4:8ece6eb
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/52b64b4..8ece6eb
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/881053002
Cr-Commit-Position: refs/heads/master@{#313372}
[MemSheriff] Broaden Valgrind suppressions for benign tracked_objects leaks.
BUG=104806,106912,416957
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/878783003
Cr-Commit-Position: refs/heads/master@{#313371}
Rename StreamlinedHostedApps to NewBookmarkApps in the code.
This feature is now known by the name 'bookmark apps'.
BUG=441127
Review URL: https://codereview.chromium.org/883603002
Cr-Commit-Position: refs/heads/master@{#313370}
Disable WebInputEventAuraTest.TestMakeWebKeyboardEventWindowsKeyCode under TSan.
BUG=449103
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/885463002
Cr-Commit-Position: refs/heads/master@{#313369}
Linux sandbox: disable a few tests on ASAN
Disable DropFileSystemAccessIsSafe and CannotRegainPrivileges on ASAN.
BUG=451603
Review URL: https://codereview.chromium.org/881923002
Cr-Commit-Position: refs/heads/master@{#313368}
Use GSC0 instead of GSC1 for video encoding.
BUG=368775
TEST=Casting WebRTC works on daisy and peach_pit
Review URL: https://codereview.chromium.org/880643004
Cr-Commit-Position: refs/heads/master@{#313367}
[Ozone] Fix ui::Event::GetCharacter() when Ctrl is pressed
On X11, ui::Event::GetCharacter() returns 0x0 when the correct return value
when control is pressed is unclear (e.g. Ctrl+[). This CL makes Ozone follow
the same behavior.
BUG=450849
TEST=Manual, see bug
Review URL: https://codereview.chromium.org/872213002
Cr-Commit-Position: refs/heads/master@{#313366}
Update Skia GYP and GN configs to read source lists from opts.gypi.
Add me to OWNERS too to shut up the presubmits.
I tested this locally on OS X / x86-64. Relying on the bots for the rest.
BUG=
Review URL: https://codereview.chromium.org/859393004
Cr-Commit-Position: refs/heads/master@{#313365}
Fix variable shadowing warning in logging on VS2015
d:\src\cr3\src\base\logging.cc(167): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\base\logging.cc(167): warning C4459: declaration of 'log_file' hides global declaration
d:\src\cr3\src\base\logging.cc(103): note: see declaration of 'logging::`anonymous-namespace'::log_file'
There was 3 different things called log_file in this file: a global FileHandle,
a local PathString, and a PathChar* member variable in LoggingSettings. :/
(Should probably rename all the globals to g_ prefixed in a followup.)
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/883853003
Cr-Commit-Position: refs/heads/master@{#313364}
Switch off secure redirect until we have a cert for gonacl.com
BUG=None
TEST=None
[email protected]
Review URL: https://codereview.chromium.org/884523002
Cr-Commit-Position: refs/heads/master@{#313363}
Roll google-toolbax-for-mac a095262:17eee69 (svn 685:703).
Summary of changes available at:
https://chromium.googlesource.com/external/google-toolbox-for-mac.git/+log/a095262..17eee69
Notable changes include:
17eee69 Make GTMSMJobRemove() have the same behavior on OSX 10.10+ as it has
on previous OSX versions.
BUG=390276
Review URL: https://codereview.chromium.org/858093004
Cr-Commit-Position: refs/heads/master@{#313362}
Fix Histogram shadowing warning on vs2015
d:\src\cr3\src\base\metrics\histogram.cc(498): warning C4457: declaration of 'count' hides function parameter
d:\src\cr3\src\base\metrics\histogram.cc(490): note: see declaration of 'count'
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/878223002
Cr-Commit-Position: refs/heads/master@{#313361}
Make running asanified tests on swarming work on Windows.
With swarming, the run command gets baked into the .isolate file instead
of going through runtest.py. Usually, an invocation of test_env.py is
baked into the isolate file. In asan mode, this used to call
asan_symbolize.py, which on Windows doesn't work -- prepend it with
sys.executable to make this work on all platforms.
BUG=451741
Review URL: https://codereview.chromium.org/877183002
Cr-Commit-Position: refs/heads/master@{#313360}
Re-prompt Chrome users to run the SRT when a finch param changes.
BUG=438287
Review URL: https://codereview.chromium.org/856393005
Cr-Commit-Position: refs/heads/master@{#313359}
Report PIPELINE_ERROR_DECODE when SourceState::Append fails.
In old implementaion, when SourceState::Append failed, it will report
DEMUXER_ERROR_COULD_NOT_OPEN error in ChunkDemuxer::AppendData case INITIALIZING.
But in fact, appended data may include initialization segment and media segment both.
The error can happen in any point.
In MSE spec
( http://w3c.github.io/media-source/#byte-stream-formats )
The user agent must run the end of stream algorithm with the error parameter
set to "decode" when in some conditions. They all happen in parsing the appended data.
So, here when SourceState::Append fails, it should report PIPELINE_ERROR_DECODE.
Another side, when the segment parser loop successfully parses a complete
initialization segment, it should call ReportMetadata immediately. Otherwise,
when meeting PIPELINE_ERROR_DECODE but WebMediaPlayer's ready_state_ is still
ReadyStateHaveNothing, it will be treated as NetworkStateFormatError not
NetworkStateDecodeError.
This Cl will resolve above two problems.
BUG=None
TEST=LayoutTest: https://codereview.chromium.org/742653002
Review URL: https://codereview.chromium.org/710693003
Cr-Commit-Position: refs/heads/master@{#313358}
cc: Fix multiple outstanding output surface requests
SingleThreadProxy was previously not considering
DidFailToInitializeOutputSurface responses as an outstanding
RequestNewOutputSurface call. This would cause the embedder to start
servicing an output surface request, then composite, receive another,
and then have double output surface requests.
The fix is to consider this failure state as a request.
BUG=444277
Review URL: https://codereview.chromium.org/871743002
Cr-Commit-Position: refs/heads/master@{#313357}
Disabling RenderFrameHostImplBrowserTest.IsFocused_AtLoad due to flaky failures
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=RenderFrameHostImplBrowserTest.IsFocused_Change&testType=content_browsertests
BUG=452631
[email protected]
Review URL: https://codereview.chromium.org/865063003
Cr-Commit-Position: refs/heads/master@{#313356}
PPAPI: Release renderer Var refcount when returning to plugin
BUG=451624
[email protected]
Review URL: https://codereview.chromium.org/874703003
Cr-Commit-Position: refs/heads/master@{#313355}
Roll libvpx: cc9c0c:097fdc
Cherry-pick potential divide-by-zero fix
https://codereview.chromium.org/877783004
This also removes the last remnants of the AVX attempts:
https://codereview.chromium.org/873313005
It should have been a no-op since it only changes cpu detection. The functions
themselves have been disabled and are not compiled so this is the last remaining
related change.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_chromium_vista_rel_ng
[email protected]
BUG=396572
Review URL: https://codereview.chromium.org/877123002
Cr-Commit-Position: refs/heads/master@{#313354}
Disable WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams on Win
The test fails or times out.
NOTRY=True
[email protected]
BUG=452623
Review URL: https://codereview.chromium.org/882713003
Cr-Commit-Position: refs/heads/master@{#313353}
Chromecast: update VideoPlane CoordinateType list.
[email protected],[email protected]
BUG=None
Review URL: https://codereview.chromium.org/878843004
Cr-Commit-Position: refs/heads/master@{#313352}
Control permission bubbles with Finch flag
This adds a Finch trial that can enable and disable bubbles as needed.
The flags will still override the Finch trial.
BUG=364686
TEST=
Visit https://adrifelt.github.io/bubble-demo.html and check to see if
you get a permission bubbles or an infobar, depending on the setting:
1. Infobar: set chrome://flags/#enable-permissions-bubbles to 'Disabled'
2. Bubble: set chrome://flags/#enable-permissions-bubbles to 'Enabled'
3. Infobar: set chrome://flags/#enable-permissions-bubbles to 'Default'
4. Infobar: --force-fieldtrials=PermissionBubbleRollout/Disabled/
5. Bubble: --force-fieldtrials=PermissionBubbleRollout/Enabled/
Review URL: https://codereview.chromium.org/791033004
Cr-Commit-Position: refs/heads/master@{#313351}
Remove Greg from OWNERS file
BUG=none
Review URL: https://codereview.chromium.org/873643002
Cr-Commit-Position: refs/heads/master@{#313350}
Add conversion rule for aria-grabbed attributes.
This patch adds conversion rule for aria-grabbed attribute and
exposes it only when it's defined.
The related patch is
https://codereview.chromium.org/736943002/
BUG=98817
Review URL: https://codereview.chromium.org/736023002
Cr-Commit-Position: refs/heads/master@{#313349}
Add param trait for IPC::Message in ipc fuzzer.
[email protected], [email protected]
BUG=450268
Review URL: https://codereview.chromium.org/881883002
Cr-Commit-Position: refs/heads/master@{#313348}
Clean up pref state in the wake of removing the omnibox watcher.
BUG=451173
[email protected]
Review URL: https://codereview.chromium.org/880603002
Cr-Commit-Position: refs/heads/master@{#313347}
Revert of [Chromoting] Enable AppRemoting sample apps by default in all.gyp. (patchset #4 id:60001 of https://codereview.chromium.org/878793003/)
Reason for revert:
Broke the official builders:
Traceback (most recent call last):
File "../remoting/webapp/build-webapp.py", line 413, in <module>
sys.exit(main())
File "../remoting/webapp/build-webapp.py", line 409, in main
service_environment)
File "../remoting/webapp/build-webapp.py", line 198, in buildWebApp
+ buildtype + ': ' + service_environment)
Exception: Invalid service_environment targeted for Official: dev
ninja: build stopped: subcommand failed.
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/55334/steps/compile/logs/stdio#error1
Original issue's description:
> [Chromoting] Enable AppRemoting sample apps by default in all.gyp.
>
> Where "by default" = whenever we build Chromoting.
>
> BUG=
>
> Committed: https://crrev.com/e0bf65f1e2fcd3515b92c1b49f04aa30fd0d47e6
> Cr-Commit-Position: refs/heads/master@{#313324}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review URL: https://codereview.chromium.org/880083002
Cr-Commit-Position: refs/heads/master@{#313346}
Revert of Plumb allow_overlay flag for video path into cc (patchset #3 id:80001 of https://codereview.chromium.org/806413004/)
Reason for revert:
This breaks the Chrome OS daisy (32-bit ARM) builder:
http://build.chromium.org/p/chromiumos.chromium/builders/Daisy%20%28chromium%29/builds/4364/steps/BuildPackages/logs/stdio
It just looks like a missing callsite.
Original issue's description:
> Plumb allow_overlay flag for video path into cc
>
> This will allow hardware video overlays to be enabled in the compositor
>
> Committed: https://crrev.com/32c0609baa6c3eea2400c6fe899a0ff60a1358dd
> Cr-Commit-Position: refs/heads/master@{#313310}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/881893002
Cr-Commit-Position: refs/heads/master@{#313345}
Roll pdfium to eef005055d6aafc2cc6066af37ce47d8b15ec7cd
There is a small API change in a recently-added pdfium API exposed by
this roll, so pdfium_engine.cc is simultaneously updated to match.
This pulls in:
eef0050 Kill scattered extern _PDF_CharType declarations.
a039323 Fix infinite recursion in CPDF_Parser::ParseIndirectObjectAt().
fa370ac Fix test naming in previous commit.
e0bbe4a Fix null crash in CheckTrailer.
af9be4f Add pdfium_embeddertests to BUILD.gn
36faa4a Fix build of pdfium_embeddertest under V8_USE_EXTERNAL_STARTUP_DATA.
219e462 Use IPDF_DataAvail interface to hide CPDF_DataAvail.
83f96a0 Add API tests: NamedDestsByName, DestGetPageIndex.
9dcd7b8 Add tests for GetNamedDests() API.
dc43b32 Use signed long for FPDF_GetNamedDest buffer length.
0185408 Simplify UTF16LE_Encode and add unittest.
Review URL: https://codereview.chromium.org/881013002
Cr-Commit-Position: refs/heads/master@{#313344}
Fix variable shadowing warning in safe_sprintf in VS2015
d:\src\cr3\src\base\strings\safe_sprintf.cc(513): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\base\strings\safe_sprintf.cc(513): warning C4456: declaration of 'ch' hides previous local declaration
d:\src\cr3\src\base\strings\safe_sprintf.cc(450): note: see declaration of 'ch'
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/868023005
Cr-Commit-Position: refs/heads/master@{#313343}
Fix variable shadowing in TLS code on VS2015
d:\src\cr3\src\base\threading\thread_local_storage.cc(143): error C2220: warning treated as error - no 'object' file generated
d:\src\cr3\src\base\threading\thread_local_storage.cc(143): warning C4457: declaration of 'value' hides function parameter
d:\src\cr3\src\base\threading\thread_local_storage.cc(110): note: see declaration of 'value'
[email protected]
BUG=440500
Review URL: https://codereview.chromium.org/880023002
Cr-Commit-Position: refs/heads/master@{#313342}
Handle Caps Lock for Ozone.
BUG=447277
Review URL: https://codereview.chromium.org/878673004
Cr-Commit-Position: refs/heads/master@{#313341}
Update stylesheets to format NaCl demos.
Review URL: https://codereview.chromium.org/875593002
Cr-Commit-Position: refs/heads/master@{#313340}
Roll src/third_party/skia f77365f:52b64b4
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f77365f..52b64b4
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/883693003
Cr-Commit-Position: refs/heads/master@{#313339}
Remove most native WebContents references from Java
- Make all Tab#initialize(0 methods take a WebContents instead of a native WebContents pointer or a ContentViewCore.
- Make ContentViewCore#initialize() take a java WebContents
- Update methods in ContentViewUtil to no longer expose native WebContents.
- Add WebContents#destroy() to handle deleting a native WebContents and Java WebContents object.
- Remove many other references that cascade from these changes.
Review URL: https://codereview.chromium.org/831523005
Cr-Commit-Position: refs/heads/master@{#313338}
Mechanical rename of tracing includes for /ui
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/866893002
Cr-Commit-Position: refs/heads/master@{#313337}
[Ozone] Constrain the cursor when overscan insets are set
Constrain the mouse cursor to the painted region of the screen when overscan
insets are set.
BUG=427619
TEST=Manual, see bug
Review URL: https://codereview.chromium.org/873563002
Cr-Commit-Position: refs/heads/master@{#313336}
Initialize render_frame_message_source_ in WebContentsImpl ctor.
Yet another cluster-fuzz crash happens due to invalid
render_frame_message_source_. As I see the code, this field is
always reset to NULL at the every IPC message but not initialized
at all, therefore the crash may still happen if the message is
the very first message to the object.
BUG=451755
[email protected]
Review URL: https://codereview.chromium.org/869053004
Cr-Commit-Position: refs/heads/master@{#313335}
Add ChannelPosix::ResetSafely() to deal with a lingering crash
The CL [1] tightened the error check too much and revealed
an existing inconsistency and resulted a production crash.
This CL makes a workaround to that crash, turning a PCHECK()
to DPCHECK().
This is the second attempt. The first one was reverted at [2]
[1] https://crrev.com/ce44fef5fd60dd2be5c587d4b084bdcd36adcee4
[2] https://crrev.com/b83c03c7b691914a054abaab13fb9131b4e0152b
BUG=449233,448245
[email protected],[email protected]
Committed: https://crrev.com/cf3eae19b456536c5ff8dacf8800ec09f9af4bca
Cr-Commit-Position: refs/heads/master@{#313188}
Review URL: https://codereview.chromium.org/882543002
Cr-Commit-Position: refs/heads/master@{#313334}
Chromecast: #elif --> #else.
Damien mentioned an odd issue when adding this about it not compiling
correctly at the time. It compiles fine for me now.
[email protected]
BUG=None
Review URL: https://codereview.chromium.org/881043002
Cr-Commit-Position: refs/heads/master@{#313333}
Pepper: PPB_VideoDecoder software fallback should support all YUV formats.
Modifies media/filters/skcanvas_video_renderer to expose its utility
method to convert YUV VideoFrames to RGB.
BUG=450205
Review URL: https://codereview.chromium.org/864113002
Cr-Commit-Position: refs/heads/master@{#313332}
Begin uniting the TabPersistentStore and StorageDelegate
* Gives the two classes a common base class called
TabPersister to extend.
* Moves some functions for dealing with TabStates into
the TabState class.
* Starts combining logic for saving Tabs between the
StorageDelegate and the TabPersistentStore.
BUG=443773,451280
Review URL: https://codereview.chromium.org/868323003
Cr-Commit-Position: refs/heads/master@{#313331}
cc: Prevent resources from being allocated for solid tiles
If the tile is solid, don't create a resource. In tile manager,
check for null resources before attempting to release.
BUG=445919
Review URL: https://codereview.chromium.org/884453003
Cr-Commit-Position: refs/heads/master@{#313330}
cc: Stop pushing properties every activation for picture layers.
Since we don't swap tilings anymore, we only need to push properties
when a property, or a tiling, or the raster source (invalidation) has
changed.
R=vmpstr
BUG=303943
Review URL: https://codereview.chromium.org/874613003
Cr-Commit-Position: refs/heads/master@{#313329}
Disable flaky testHTTPResponseTimelineRecorder on Android
BUG=452279
Review URL: https://codereview.chromium.org/878223003
Cr-Commit-Position: refs/heads/master@{#313328}
[Chromoting] Fix broken OK/Cancel button in loading window.
The recent change to add jscompile annotations include a change that
breaks that default OK/Cancel button of the loading window (because
of the number -> string conversion).
This cl removes the conversion that was added and and updates the
type annotation for sendReply_ to address the jscompile warning.
NOTRY=True
BUG=
Review URL: https://codereview.chromium.org/883813002
Cr-Commit-Position: refs/heads/master@{#313327}
[NaCl SDK] Update the sdk_tools version.
This will include the recent fix to fancy_urllib when running Python 2.7.9
BUG=452137
[email protected]
Review URL: https://codereview.chromium.org/880963003
Cr-Commit-Position: refs/heads/master@{#313326}
Mechanical rename of tracing includes for /components
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/864333003
Cr-Commit-Position: refs/heads/master@{#313325}
[Chromoting] Enable AppRemoting sample apps by default in all.gyp.
Where "by default" = whenever we build Chromoting.
BUG=
Review URL: https://codereview.chromium.org/878793003
Cr-Commit-Position: refs/heads/master@{#313324}
[Chromoting] Add socket permission to AppRemoting manifest.
NOTRY=True
BUG=
Review URL: https://codereview.chromium.org/868393003
Cr-Commit-Position: refs/heads/master@{#313323}
Add a command-line flag to set GPU rasterization multisampling.
The new flag is
--gpu-rasterization-msaa-sample-count=X
similar to the existing
--canvas-msaa-sample-count=X
where X is the sample count.
Review URL: https://codereview.chromium.org/881513004
Cr-Commit-Position: refs/heads/master@{#313322}
Disable -Wl,--as-needed in sanitizer mode.
We've had problems with this linker flag in --as-needed a few times now;
just disable it if we're doing a sanitizer build.
BUG=452105
Review URL: https://codereview.chromium.org/882443003
Cr-Commit-Position: refs/heads/master@{#313321}
Add AwDataReductionProxyManager
This class reads the settings, enables/disables the data reduction
proxy, and sets the data reduction proxy auth key.
BUG=451287
Review URL: https://codereview.chromium.org/870883002
Cr-Commit-Position: refs/heads/master@{#313320}
[NaCl SDK] Update Windows build to use vs2013 from depot_tools.
I'm not sure why this was working on the bots, but the sdk build was no longer
working on my Windows machine. After some research, I found that Chromium must
be built with vs2013, which was not supported by build_sdk, or by the Native
Client build (see https://code.google.com/p/nativeclient/issues/detail?id=4022)
This change modifies build_sdk.py (and build_artifacts.py) to use VS2013 from
depot_tools if it is available, as well as switching to using gyp_chromium
instead of gyp_nacl for building Native Client host binaries.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/811533002
Cr-Commit-Position: refs/heads/master@{#313319}
Revert of Revert of Enable ChannelMojo (patchset #1 id:1 of https://codereview.chromium.org/875333002/)
Reason for revert:
This revert was innocent. The culprit was
https://codereview.chromium.org/878843002/
Original issue's description:
> Revert of Enable ChannelMojo (patchset #3 id:40001 of https://codereview.chromium.org/857483004/)
>
> Reason for revert:
> many ipc test failed.
> https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/10036
>
> Original issue's description:
> > Enable ChannelMojo
> >
> > As we addressed certain amount of the performance problem,
> > it's time to give it another try.
> >
> > [email protected]
> > BUG=377980
> >
> > Committed: https://crrev.com/a06cd1b2fe83b51b0874ca504066f00a17192026
> > Cr-Commit-Position: refs/heads/master@{#313184}
>
> [email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=377980
>
> Committed: https://crrev.com/af01416ada7b968c55224be9e61272ad73e59fe1
> Cr-Commit-Position: refs/heads/master@{#313225}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=377980
Review URL: https://codereview.chromium.org/881863002
Cr-Commit-Position: refs/heads/master@{#313318}
autofill - Keep showing form preview while card unmasking prompt is up.
This used to work, but was broken by d0a0c992fc0eb9c81d514a
BUG=none
Review URL: https://codereview.chromium.org/872713005
Cr-Commit-Position: refs/heads/master@{#313317}
mac: Fix a dangling delegate bug with MCPopupController.
Due to the odd implementation of MCPopupController, all the clean up happens in
-close rather than -dealloc. In all instances but one, the owner would destroy
MCPopupController by calling -close or -closeWithAnimation. There was one
instance where the owner was calling -release, which was preventing
MCPopupController from properly cleaning up.
BUG=423001
Review URL: https://codereview.chromium.org/857463003
Cr-Commit-Position: refs/heads/master@{#313316}
Roll src/third_party/skia 776c0cd:f77365f
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/776c0cd..f77365f
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/878193002
Cr-Commit-Position: refs/heads/master@{#313315}
Update mojo sdk to rev a85a2cea82d816de115e15253742b0f88a9924eb
BUG=None
[email protected] for html_viewer
[email protected]
Review URL: https://codereview.chromium.org/866263004
Cr-Commit-Position: refs/heads/master@{#313314}
Implement a stub cloud import banner.
This CL adds a stub cloud import banner shown only on DCIM directories on
volumes eligible for import.
TEST=Tested manually.
BUG=451658
Review URL: https://codereview.chromium.org/873913003
Cr-Commit-Position: refs/heads/master@{#313313}
Elim FontList::DeriveWithStyle from ash/system
Currently FontList::DeriveWithStyle is extremely slow, making the
frequent calls in ash/system very costly. That is being addressed
separately in crbug.com/444894, but there is still no reason to be
deriving fonts when building the views when we just want to use the
ones in the shared resource bundle anyway.
This also changes the 'style' parameter in a number of function calls to
'highlight' so that the intention of the styling is passed to the views
and we can adjust the appearance uniformly in the future if we wish.
BUG=452291
Review URL: https://codereview.chromium.org/875913003
Cr-Commit-Position: refs/heads/master@{#313312}
Introduce NetworkState::is_captive_portal()
For c/b/ui/webui/chromeos/login/network_state_informer.cc
[email protected]
BUG=450364
Review URL: https://codereview.chromium.org/873713004
Cr-Commit-Position: refs/heads/master@{#313311}
Plumb allow_overlay flag for video path into cc
This will allow hardware video overlays to be enabled in the compositor
Review URL: https://codereview.chromium.org/806413004
Cr-Commit-Position: refs/heads/master@{#313310}
Remove NOTIFICATION_SESSION_RESTORE_DONE
BUG=chromium:268984
TEST=build successfully
[email protected]
Signed-off-by: Simon Que <[email protected]>
Review URL: https://codereview.chromium.org/880593006
Cr-Commit-Position: refs/heads/master@{#313309}
Add GenerateParam helper and add some more param traits to ipc fuzzer.
[email protected], [email protected]
BUG=450268
Review URL: https://codereview.chromium.org/875243004
Cr-Commit-Position: refs/heads/master@{#313308}
Fix EnableTerminationOnOutOfMemory for malloc
Currently only crashes on new and new[]. With the change it will also
crash when there is no memory for malloc as well.
BUG=434397
TEST=none.
Committed: https://crrev.com/22d64abdc792516fd0f4895b26ae3a73c85239e0
Cr-Commit-Position: refs/heads/master@{#310320}
Review URL: https://codereview.chromium.org/836733006
Cr-Commit-Position: refs/heads/master@{#313307}
Instrumenting CopyData to analyze its slowing down
The previous CL moved the copy part from IO thread.
Now, in the worker thread, copying data 15ms on average, instead of the old 5ms in IO thread, which I want to investigate.
I want to separate possible slowness from the task wrapper (what if params are copied in an inefficient way?) from the slowness from the memcpy.
BUG=422489
Review URL: https://codereview.chromium.org/880973002
Cr-Commit-Position: refs/heads/master@{#313306}
Update histograms to reflect changes in V8.
[email protected], [email protected]
Review URL: https://codereview.chromium.org/872993004
Cr-Commit-Position: refs/heads/master@{#313305}
undo zturner visualc compiler workaround
An optimization on the compiler.
https://connect.microsoft.com/VisualStudio/feedback/details/800200/preprocessing-broken-in-vs2013
also see comment #56 on the bug below
BUG=288948
Review URL: https://codereview.chromium.org/878763003
Cr-Commit-Position: refs/heads/master@{#313304}
media: Add MediaPermission interface and MediaPermissionDispatcher.
MediaPermission is the interface for media code to check/request media related
permissions. MediaPermissionDispatcher is a MediaPermission implementation in
content/.
Plan of follow-up CL:
- Use MediaPermission in ProxyDecryptor and remove current protected media
identifier info bar code in the browser process (on Android and ChromeOS).
BUG=446263
TEST=Tested on Android with encrypted-media-requestmediakeysystemaccess.html
layout test by calling MediaPermission methods manually in
webencryptedmediaclient_impl.cc.
Review URL: https://codereview.chromium.org/871663003
Cr-Commit-Position: refs/heads/master@{#313303}
MIPS: remove immediate constraint within CompareAndSwap.
Improper use of immediate constraint is slightly non-optimal
with gcc/gnu-as but may cause breakage with clang.
BUG=
Review URL: https://codereview.chromium.org/872393003
Cr-Commit-Position: refs/heads/master@{#313302}
[Favicon] Minor code cleanup.
TBR=jam
Review URL: https://codereview.chromium.org/861333002
Cr-Commit-Position: refs/heads/master@{#313301}
Suppress zero-velocity flings after touch-action filtering
The GestureProvider suppresses zero velocity flings, instead sending a
regular scroll-ending event. However, it's still possible that the
TouchActionFilter can zero the sole component of the velocity, yielding
an unexpected zero-velocity fling.
Avoid this case by translating zero-velocity flings produced by the
TouchActionFilter to GestureScrollEnd events.
BUG=452118
Review URL: https://codereview.chromium.org/876063002
Cr-Commit-Position: refs/heads/master@{#313300}
Revert ANGLE to 9e0478f62fbc2f24.
BUG=450257
Review URL: https://codereview.chromium.org/874083003
Cr-Commit-Position: refs/heads/master@{#313299}
chromeos: Add DBus binding for privetd Ping command
Extend PrivetDaemonClient to invoke the "Ping" D-Bus method
on org.chromium.privetd.Manager.
This is connected to the chrome.shell.gcd API for manual
testing, but that will be deleted soon in favor of talking to
privetd as part of Chrome OS OOBE. Manual tests require
adding user chronos to group privetd in /etc/groups until
https://code.google.com/p/brillo/issues/detail?id=3 lands.
BUG=428848
TEST=added chromeos_unittests PrivetDaemonClient.*
Review URL: https://codereview.chromium.org/869153005
Cr-Commit-Position: refs/heads/master@{#313298}
[MemSheriff] Exclude WebSocketEndpointLockManagerTest.UnlockEndpointIsDelayed
The fix did not fix it.
BUG=451999
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/881823003
Cr-Commit-Position: refs/heads/master@{#313297}
Updating DEPS to pick up the latest third_party/openmax_dl
Review URL: https://codereview.chromium.org/876943002
Cr-Commit-Position: refs/heads/master@{#313296}
Add video metrics from webrtc to histograms.xml.
- send/receive bitrate for FEC
BUG=419657
Review URL: https://codereview.chromium.org/875373003
Cr-Commit-Position: refs/heads/master@{#313295}
Revert of Revert of Swarm cc_unittests. (patchset #1 id:1 of https://codereview.chromium.org/861173002/)
Reason for revert:
just saw this revert. can't find sergeyv online, and don't see information on what broke. so reverting the revert and watching the tree.
Original issue's description:
> Revert of Swarm cc_unittests. (patchset #6 id:100001 of https://codereview.chromium.org/854743002/)
>
> Reason for revert:
> Failures on chrome.mac
>
> Original issue's description:
> > Swarm cc_unittests.
> >
> > BUG=448877
> >
> > Committed: https://crrev.com/9086ff0072268267bacf28e6098a7b5bd8478982
> > Cr-Commit-Position: refs/heads/master@{#312252}
>
> [email protected],[email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=448877
>
> Committed: https://crrev.com/c497f3788bc5007ee3bbe2f6aa1cc101b6d66d8b
> Cr-Commit-Position: refs/heads/master@{#312322}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=448877
Review URL: https://codereview.chromium.org/880803004
Cr-Commit-Position: refs/heads/master@{#313294}
ui_touch_selection_unittests.isolate: Don't bundle osmesa on Win and Mac.
The build target doesn't depend on it, so there's a chance that the file doesn't
exist yet when the isolate step runs. Since it kind of looks like this is only
here due to a copy-paste error, removing the file from the isolate rather than
adding a dependency.
BUG=98637
Review URL: https://codereview.chromium.org/880573002
Cr-Commit-Position: refs/heads/master@{#313293}
Remove a non-existent path from checklicenses.py.
NOTRY=true
Review URL: https://codereview.chromium.org/875223003
Cr-Commit-Position: refs/heads/master@{#313292}
Roll src/third_party/skia 5f213d9:776c0cd
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5f213d9..776c0cd
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/879953004
Cr-Commit-Position: refs/heads/master@{#313291}
Initial RemoteCommands for CrOS
BUG=
Review URL: https://codereview.chromium.org/777033004
Cr-Commit-Position: refs/heads/master@{#313290}
Update Valgrind's run_chrome_tests.py to pass sharding flags.
Previously we relied on environment variables. This unbreaks Valgrind following
a recent CL which changed runtest.py to pass those flags.
BUG=none
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/882713002
Cr-Commit-Position: refs/heads/master@{#313289}
Revert of Update SSL/malware/net error interstitial design (patchset #10 id:180001 of https://codereview.chromium.org/865943002/)
Reason for revert:
ErrorPageTests are failing on Linux ChromiumOS:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55305
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55306
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/55307
Original issue's description:
> + On small screens the navigation buttons are anchored to the bottom of the screen.
> + Tweaks to the text colour
> + Change button styling of safe browsing page
>
> BUG=422882
>
> Committed: https://crrev.com/7ee5b21903f8a466e8f8e995e62354deceb987f0
> Cr-Commit-Position: refs/heads/master@{#313280}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=422882
Review URL: https://codereview.chromium.org/866723005
Cr-Commit-Position: refs/heads/master@{#313288}
More class names for views class.
record the layer name in Widget::Show
BUG=450703
[email protected]
Review URL: https://codereview.chromium.org/863173004
Cr-Commit-Position: refs/heads/master@{#313287}
Update histograms.xml.
Update histograms.xml using update_use_counter_feature_enum.py.
BUG=436770, 435393
Review URL: https://codereview.chromium.org/872403005
Cr-Commit-Position: refs/heads/master@{#313286}
Implement necessary changes for sync to get variation ids.
BUG=450365
Review URL: https://codereview.chromium.org/865213003
Cr-Commit-Position: refs/heads/master@{#313285}
[Chromoting] Include AppRemoting HTML/JS files in the localization check.
Move duplicate locale-related gyp vars into a separate .gypi.
Add gyp vars that contain the set of localizable html/js files.
Remove remoting_host_locale_files since it is not used anywhere.
BUG=
Review URL: https://codereview.chromium.org/875083004
Cr-Commit-Position: refs/heads/master@{#313284}
LoginDatabase::RemoveLogin should return false if there was no matching form in the database.
BUG=396900
Review URL: https://codereview.chromium.org/881793002
Cr-Commit-Position: refs/heads/master@{#313283}
Roll src/third_party/skia 36c57df:5f213d9
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/36c57df..5f213d9
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/878123002
Cr-Commit-Position: refs/heads/master@{#313282}
Fixing comment.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/864043006
Cr-Commit-Position: refs/heads/master@{#313281}
+ On small screens the navigation buttons are anchored to the bottom of the screen.
+ Tweaks to the text colour
+ Change button styling of safe browsing page
BUG=422882
Review URL: https://codereview.chromium.org/865943002
Cr-Commit-Position: refs/heads/master@{#313280}
Mechanical rename of tracing includes for /cc
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
Review URL: https://codereview.chromium.org/866853002
Cr-Commit-Position: refs/heads/master@{#313279}
GuestView: More C++ 11'ification
Convert more NULLs into nullptrs.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/878083002
Cr-Commit-Position: refs/heads/master@{#313278}
[ServiceWorker] globally unique protobuf target names
Protobuf targets need to have globally unique names.
BUG=449939
Review URL: https://codereview.chromium.org/875903003
Cr-Commit-Position: refs/heads/master@{#313277}
PepperVideoDestinationHost: Check that recieved frames have strictly increasing timestamps
BUG=451021
Review URL: https://codereview.chromium.org/867923003
Cr-Commit-Position: refs/heads/master@{#313276}
On disabling cookies, make sure reconcilor does not act.
Also don't add the chrome connected header to gaia endpoints.
BUG=436660
Review URL: https://codereview.chromium.org/862163003
Cr-Commit-Position: refs/heads/master@{#313275}
Provision devices: use ReadFile/WriteFile to load/restore adb keys
Instead of using a cat/echo combination to read and write adb keys one
by one, we can now use the dedicated and more robust ReadFile/WriteFile.
Depends on: https://codereview.chromium.org/806843002/
BUG=436133
Review URL: https://codereview.chromium.org/801283004
Cr-Commit-Position: refs/heads/master@{#313274}
[ServiceWorkerCache] Remove flaky tests
SimpleCache operations continue after the cache is closed. If you open
it again while it's writing you might not see the in-progress
entries. We were going to delay SimpleCache opens until the in-progress
finished. Instead, we just don't close the cache until all operations finish writing.
Therefore the tests that close the cache while still writing and
open them again quickly are no longer needed and cause flakes. This CL
removes the flaky tests.
Also resaved the file as UTF-8, hence the character change.
BUG=452077,413775
Review URL: https://codereview.chromium.org/865683010
Cr-Commit-Position: refs/heads/master@{#313273}
Mechanical rename of tracing includes for /android_webview
This is just a mechanical rename of tracing includes.
See crrev.com/837303004 and the related bug for motivations.
BUG=451032
[email protected]
Review URL: https://codereview.chromium.org/868753002
Cr-Commit-Position: refs/heads/master@{#313272}
Run task queue manager work in batches
This patch lets the task queue manager run more than one posted task
per invocation. This helps reduce the overhead of yielding to and from
the main message loop and can speed up cases where tasks are posted
very frequently. One example is indexeddb, where some operations such as
index building can result in 2500 posted tasks/s (Nexus 7).
This patch also adds accounting for the desired run time of the next
pending delayed task. This information is used to break out of a work
batch if a delayed task should be run instead. Doing this avoids adding
extra delay to delayed tasks.
A potential downside of this change is that it can penalize work that
runs on the message loop without going through the task queue manager.
Based on performance tests[1], almost all tasks on the renderer main
thread are already getting executed by the task queue manager, so I
believe this change shouldn't cause a regression.
Note that this version of the patch still uses a batch size of 1 while
we investigate some mac test failures triggered by larger batch sizes.
[1] https://docs.google.com/a/chromium.org/spreadsheets/d/1IJZpBabW1pr4fb2T8BlkleHcOvHYrjvmCx_dLesxfMA/edit#gid=1492760051
BUG=444764,451593
Review URL: https://codereview.chromium.org/845543004
Cr-Commit-Position: refs/heads/master@{#313271}
Updating trunk VERSION from 2289.0 to 2290.0
Cr-Commit-Position: refs/heads/master@{#313270}
Move NDK gyp file from third_party/android_tools.
BUG=428426
Review URL: https://codereview.chromium.org/864323002
Cr-Commit-Position: refs/heads/master@{#313269}
Enable tree view for all volumes.
This CL enables tree navigation view for all volumes by making VolumeItem as a subclass of DirectoryItem.
VolumeItem for Google Drive has special treatments so that Google Drive always reveals its root directory and fake entries(Shared with me, Recent, and Offline).
Drive shortcuts are not shown as a tree intentionally.
BUG=398291
TEST=run browser_tests
Review URL: https://codereview.chromium.org/864773002
Cr-Commit-Position: refs/heads/master@{#313268}
Update the path to the ASan/Win MD runtime now that we're using clang 3.7.0
BUG=448789,345874
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/879863003
Cr-Commit-Position: refs/heads/master@{#313267}
Move base/debug/trace_event* to base/trace_event/ [part 1]
Trace Event used to be a single file, base/debug/trace_event.h. Then we
added more functionality, so it was base/debug/trace_event*.*
For many years, we have had per-file OWNERS for Trace Event based off
of trace_event*. This let us do trace_event improvements/iteration out
of band with the much slower base/OWNERS process.
But, this leads to a lot of poor filename choices for tracing related
features, specifically to fall under trace event reviewers instead of
base/ reviewers. That's clearly wrong.
BUG=451032
Review URL: https://codereview.chromium.org/837303004
Cr-Commit-Position: refs/heads/master@{#313266}
Don't share Push API message payloads unless explicitly enabled.
There are open security issues about exposing payloads for the Push API,
so we'd like to guard those behind a command line flag for now.
This is part of a three-sided patch:
[1] https://codereview.chromium.org/872013002
[2] This patch.
[3] https://codereview.chromium.org/869303002
BUG=449184
Review URL: https://codereview.chromium.org/874613002
Cr-Commit-Position: refs/heads/master@{#313265}
Expose the visibility state of a frame to the browser process.
A frame knows whether it is visible or hidden based on its
RenderWidgetHost. In addition, a frame can be prerendered. To have that
information, it is required to go via ContentBrowserClient.
BUG=450634
Review URL: https://codereview.chromium.org/871443004
Cr-Commit-Position: refs/heads/master@{#313264}
Support the Service-Worker-Allowed header
This allows a site to customize Service Worker's path restriction
policy, which by default means a script can only control a scope within
the directory of the script.
Service-Worker-Allowed is an optional HTTP response header for a Service
Worker script. The value is a URL that is the maximum allowed scope that
the script can control. If it's a relative URL, it's relative to the
script URL. For example, when included in the response for a script at
"http://www.example.com/resources/sw.js", a value of ".." means that
sw.js can control a max scope of "/", rather than the default max scope
of "resources/".
As spec'd at:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#update-algorithm
Blink-side test:
https://codereview.chromium.org/868973004/
BUG=436747
Review URL: https://codereview.chromium.org/866403002
Cr-Commit-Position: refs/heads/master@{#313263}
Disabled animation in indeterminate progress bar.
The animation caused high CPU usage at OOBE, even when progress bar was hidden.
<indeterminate-progress> is used only in Hotrod pairing flow, which is not
released yet, so the animation could be safely disabled for now. <indeterminate-
progress> will be completely replaced by <paper-progress indeterminate> in
scope of http://crbug.com/423363
BUG=450758
NOTRY=true
Review URL: https://codereview.chromium.org/874923003
Cr-Commit-Position: refs/heads/master@{#313262}
Fix handle_watcher when start is called twice on the same handle.
This carries over a fix by qsr@ for the mojo helper handle_watcher
landed in the mojo repo in https://codereview.chromium.org/781753004.
The fix allows the network service apptests not to crash when built
against the Chromium copy of mojo/common.
BUG=450356
Review URL: https://codereview.chromium.org/878513003
Cr-Commit-Position: refs/heads/master@{#313261}
Libsecret kill switch by Finch.
This is client side, the server config is in CL 84424958
BUG=450225
Review URL: https://codereview.chromium.org/851053003
Cr-Commit-Position: refs/heads/master@{#313260}
Revert of Reland On Android, links inside headings should be announced as headings by TalkBack (patchset #1 id:1 of https://codereview.chromium.org/854203003/)
Reason for revert:
DumpAccessibilityEventsTests are failing on Windows: http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/34786
Original issue's description:
> Reland On Android, links inside headings should be announced as headings by TalkBack
> https://codereview.chromium.org/845663002
>
> BUG=446216
>
> Committed: https://crrev.com/217066c608ea473d2ac70e737c69ff11a0425d44
> Cr-Commit-Position: refs/heads/master@{#313248}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446216
Review URL: https://codereview.chromium.org/881763002
Cr-Commit-Position: refs/heads/master@{#313259}
Revert "Roll libvpx: cc9c0c:8dc6ea"
This reverts commit efd856c2a46810e742f7aba0130d534783db6b2a.
Fails on Windows (e.g.
http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/52878)
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/882483006
Cr-Commit-Position: refs/heads/master@{#313258}
Implement word wrapping for braille in ChromeVox.
BUG=341673
[email protected]
Review URL: https://codereview.chromium.org/856403002
Cr-Commit-Position: refs/heads/master@{#313257}
Update V8 to version 4.2.31 (based on d93c4d19f13736c0538f4f66ca4a4a08d0cab9ca).
[email protected]
Review URL: https://codereview.chromium.org/883663002
Cr-Commit-Position: refs/heads/master@{#313256}
Remove mkosiba from OWNERS files.
Removing myself as I won't be active on the project anymore.
BUG=None
[email protected]
Review URL: https://codereview.chromium.org/879513004
Cr-Commit-Position: refs/heads/master@{#313255}
WebResourceService is no longer reference counted
WebResourceService was extending its own lifetime while network requests
were in progress. This was not needed, and made the lifetime management
of request contexts harder.
This CL removes this behavior and cancels the requests when the service
is deleted.
Finally, the virtual method GetRequestContext(), which was a workaround
for the lifetime issues, is removed.
BUG=447575
Review URL: https://codereview.chromium.org/872703003
Cr-Commit-Position: refs/heads/master@{#313254}
Add GN targets for chrome_process_finder, image_pre_reader, chrome_watcher.
Review URL: https://codereview.chromium.org/876473003
Cr-Commit-Position: refs/heads/master@{#313253}
Remove the use of DirectShow MJPG filter.
Instead, let chrome decode MJPG.
TEST= Remove any logitech video capture driver and make sure to use Windows USB default. Test that local preview works on https://apprtc.appspot.com/
BUG=450222
Review URL: https://codereview.chromium.org/867243002
Cr-Commit-Position: refs/heads/master@{#313252}
Correct margin of breadsrumbs for RTL languages.
BUG=452401
Review URL: https://codereview.chromium.org/876273002
Cr-Commit-Position: refs/heads/master@{#313251}
Roll src/third_party/skia 7f7036a:36c57df
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7f7036a..36c57df
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/879473003
Cr-Commit-Position: refs/heads/master@{#313250}
Update V8 to version 4.2.30 (based on 3937dd679bba168499d87b4b412429bad083d628).
[email protected]
Review URL: https://codereview.chromium.org/878893002
Cr-Commit-Position: refs/heads/master@{#313249}
Reland On Android, links inside headings should be announced as headings by TalkBack
https://codereview.chromium.org/845663002
BUG=446216
Review URL: https://codereview.chromium.org/854203003
Cr-Commit-Position: refs/heads/master@{#313248}
Remove the default format from ResourcePool.
Let each client store the format locally instead.
BUG=434699
Review URL: https://codereview.chromium.org/860813002
Cr-Commit-Position: refs/heads/master@{#313247}
OOP PDF: Ensure the load callback gets fired multiple times for print preview
Previously we weren't firing the document load callback multiple times
when print preview was reset with a new document. This was causing
print preview to hang.
BUG=452366
Review URL: https://codereview.chromium.org/880813002
Cr-Commit-Position: refs/heads/master@{#313246}
Roll src/third_party/skia f7069d5:7f7036a
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f7069d5..7f7036a
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/880803003
Cr-Commit-Position: refs/heads/master@{#313245}
Update style of column header and background color of each pane.
Along with the style change, removed an unused selector.
BUG=402344
Review URL: https://codereview.chromium.org/876233002
Cr-Commit-Position: refs/heads/master@{#313244}
Fix the test WebSocket...UnlockEndpointIsDelayed
Test WebSocketEndpointLockManagerTest.UnlockEndpointIsDelayed failed on
the Chromium Memory FYI on Chromium Mac (valgrind)(2) bot. Change the
test to measure the time taken, rather than wait the expected amount
of time, which should make it more deterministic.
BUG=442756, 451999
TEST=net_unittests
Review URL: https://codereview.chromium.org/871843003
Cr-Commit-Position: refs/heads/master@{#313243}
Stop defining __SOFTFP for Chromecast.
Chromecast has updated to GCC 4.9.
BUG=388933
Review URL: https://codereview.chromium.org/875353002
Cr-Commit-Position: refs/heads/master@{#313242}
Automated Commit: Committing new LKGM version 6728.0.0 for chromeos.
Cr-Commit-Position: refs/heads/master@{#313241}
text input focus: Updates WebView::GetTextInputClient when the underlying RenderView is destroyed.
This CL is split off from http://crrev.com/785463002 .
WebView implements RenderProcessHostObserver and updates the text input client when the render process exits (i.e. the underlying RenderView / RWHVA are going to be destroyed). Because WebView::GetTextInputClient() returns RWHVA::GetTextInputClient(), we need to discard a reference to the object returned by RWHVA::GetTextInputClient() before RWHVA is destroyed.
BUG=290701
TEST=Run interactive_ui_tests.
Review URL: https://codereview.chromium.org/862643002
Cr-Commit-Position: refs/heads/master@{#313240}
Adds desktopCapturePrivate permission for extensions whitelisted for desktop
capture.
BUG=452128
Review URL: https://codereview.chromium.org/882533002
Cr-Commit-Position: refs/heads/master@{#313239}
[Windows] Fix for Browser IO MessageLoop spinning the CPU.
This corrects an integer overflow issue which resulted in the Browser IO
MessageLoop spinning, eating up 100% of a CPU core. The conversion from
a double to a 32-bit int was sometimes out-of-range: A large positive
double value was being assigned as a negative int value. Because of
this, MessagePumpWin acted as if a delayed task was past-due for running
and refused to sleep the thread. Downstream code paths would instead
see the task as "in the future" and then refuse to run it and remove it
from the queue. This resulted in a "never-wait, never-dequeue" bad
spinning state.
While researching this problem, a number of code points have been
exposed that are erroneously posting delayed tasks with huge delays,
likely due to bad math on 64-bit platforms. Added DLOG warnings to
whine at developers to avoid this in the future.
See bug for additional details.
BUG=450045
[email protected]
Review URL: https://codereview.chromium.org/873393004
Cr-Commit-Position: refs/heads/master@{#313238}
Remove unnecessary includes and forward declarations about ResourcEntry
Just to clarify in what places ResourceEntry is actualy used.
BUG=357038
TEST=everything builds as before
Review URL: https://codereview.chromium.org/879823002
Cr-Commit-Position: refs/heads/master@{#313237}
GuestView: Guests create instance ID
GuestViews currently take in an instance ID that's created by the GuestViewManager.
This seems a little odd. When we create a new GuestView, we always want a new guest
instance ID, so it doesn't really make sense to take in the instance ID as a parameter.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/876213002
Cr-Commit-Position: refs/heads/master@{#313236}
Correct 32x32 app icon of Files.app.
BUG=451661
Review URL: https://codereview.chromium.org/876223002
Cr-Commit-Position: refs/heads/master@{#313235}
MacViews: Don't call UpdateLayerProperties if there is no layer.
UpdateLayerProperties() assumes that a layer is present, callers should check
for the presence of a layer before calling it.
BUG=424058
Review URL: https://codereview.chromium.org/870073002
Cr-Commit-Position: refs/heads/master@{#313234}
[Cleanup] Remove Screenshot measurement test from telemetry.
As Screenshot measurement is no longer used, remove it from the telemetry tests.
The patch is based on the discussion in the graphics-dev [1] and the bug as well.
[1] https://groups.google.com/a/chromium.org/forum/#!topic/graphics-dev/R68sq4vjUwA
BUG=386572
R=nduca,ernstm
Review URL: https://codereview.chromium.org/869163003
Cr-Commit-Position: refs/heads/master@{#313233}
Roll src/third_party/WebKit 543f3bc:12a5230 (svn 188999:189000)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/543f3bc..12a5230
[email protected],[email protected]
Review URL: https://codereview.chromium.org/883573004
Cr-Commit-Position: refs/heads/master@{#313232}
Roll src/third_party/skia c98fe3a:f7069d5
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c98fe3a..f7069d5
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/876053003
Cr-Commit-Position: refs/heads/master@{#313231}
Using "static_assert" in lieu of "COMPILE_ASSERT" in extensions module
All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now.
BUG=442514
Review URL: https://codereview.chromium.org/859993002
Cr-Commit-Position: refs/heads/master@{#313230}
Add UMA to track maximum # of workers in a single renderer process
To help us understand how many # of SW could run in parallel.
BUG=403258
Review URL: https://codereview.chromium.org/873613002
Cr-Commit-Position: refs/heads/master@{#313229}
Remove chrome/browser/services/gcm/gcm_app_handler.h
Per git grep, this file is no longer included.
BUG=356716
TEST=everything builds as before
Review URL: https://codereview.chromium.org/826583005
Cr-Commit-Position: refs/heads/master@{#313228}
Hotword: Delete the speaker model.
Implements a method to delete the speaker model on request.
This cl depends on https://codereview.chromium.org/842413003/
BUG=449017
Review URL: https://codereview.chromium.org/811883003
Cr-Commit-Position: refs/heads/master@{#313227}
Revert of Add ChannelPosix::ResetSafely() to deal with a lingering crash (patchset #1 id:1 of https://codereview.chromium.org/882543002/)
Reason for revert:
many ipc test failed.
https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/10036
Original issue's description:
> Add ChannelPosix::ResetSafely() to deal with a lingering crash
>
> The CL [1] tightened the error check too much and revealed
> an existing inconsistency and resulted a production crash.
> This CL makes a workaround to that crash, turning a PCHECK()
> to DPCHECK().
>
> [1] https://crrev.com/ce44fef5fd60dd2be5c587d4b084bdcd36adcee4
>
> BUG=449233,448245
> [email protected],[email protected]
>
> Committed: https://crrev.com/cf3eae19b456536c5ff8dacf8800ec09f9af4bca
> Cr-Commit-Position: refs/heads/master@{#313188}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=449233,448245
Review URL: https://codereview.chromium.org/878843002
Cr-Commit-Position: refs/heads/master@{#313226}
Revert of Enable ChannelMojo (patchset #3 id:40001 of https://codereview.chromium.org/857483004/)
Reason for revert:
many ipc test failed.
https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/10036
Original issue's description:
> Enable ChannelMojo
>
> As we addressed certain amount of the performance problem,
> it's time to give it another try.
>
> [email protected]
> BUG=377980
>
> Committed: https://crrev.com/a06cd1b2fe83b51b0874ca504066f00a17192026
> Cr-Commit-Position: refs/heads/master@{#313184}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=377980
Review URL: https://codereview.chromium.org/875333002
Cr-Commit-Position: refs/heads/master@{#313225}
Fix print preview custom margin dragging in OOP PDF
With OOP PDF the plugin is in a separate iframe. Mouse events over iframes are
not sent to the parent window. So currently when dragging a margin (which is
contained in the parent window) if the user drags too quickly, the mouse events
start to get sent to the underlying iframe. This change sets the 'pointer-events'
CSS attribute of the iframe to 'none' while the margins are being dragged,
which prevents this from happening.
BUG=374673
Review URL: https://codereview.chromium.org/844503008
Cr-Commit-Position: refs/heads/master@{#313224}
This is a font regression that was introduced in https://codereview.chromium.org/786023002. Since
offline pages are interstitial pages and are loaded via data url and can't access text_defaults.css file,
this CL append it via the webui::AppendWebUICssTextDefaults() method.
BUG=448618, 443203
TEST=manually checked on device (Pixel)
Review URL: https://codereview.chromium.org/861783003
Cr-Commit-Position: refs/heads/master@{#313223}
Do not show webstore links for default extensions
The 'View In Store' link in the AppInfo dialog is meaningless for apps
which were installed by default, and could leak user counts for
private OEM-specific apps.
BUG=449095
Review URL: https://codereview.chromium.org/876193002
Cr-Commit-Position: refs/heads/master@{#313222}
Move a couple of utility functions to a new namespace_utils class.
The implementations are minorly different - uses /proc/self/ns/* files
to detect namespaces support, and always make sure to write uid_map in a
single write.
BUG=312380
Review URL: https://codereview.chromium.org/849893004
Cr-Commit-Position: refs/heads/master@{#313221}
Hotword: Adds hotword private api event to delete speaker model.
Deletes speaker model when Audio History is disabled.
BUG=449017
Review URL: https://codereview.chromium.org/842413003
Cr-Commit-Position: refs/heads/master@{#313220}
Roll src/third_party/skia 2d80dd2:c98fe3a
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/2d80dd2..c98fe3a
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/880653003
Cr-Commit-Position: refs/heads/master@{#313219}
Roll src/third_party/WebKit fa85120:543f3bc (svn 188997:188999)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/fa85120..543f3bc
[email protected],[email protected]
Review URL: https://codereview.chromium.org/878013002
Cr-Commit-Position: refs/heads/master@{#313218}
Increase timeout of PPAPI*.View tests and reenable on MSAN.
BUG=450908
Review URL: https://codereview.chromium.org/869863002
Cr-Commit-Position: refs/heads/master@{#313217}
Add more GURLTest.Resolve examples for clarity.
I was confused about how this worked when writing
http://crrev.com/864993002 and none of the existing
examples clarified it. Is there a utility method that will
just always append to the path? like "a.com/b" and "c"
makes "a.com/b/c"?
Review URL: https://codereview.chromium.org/870413005
Cr-Commit-Position: refs/heads/master@{#313216}
OOP PDF: Set the pdf extension URL permissions to <all_urls>.
Currently, the PDF extension isn't permitted access to paths to network
mounts (e.g. file://network_share/path.pdf). A permission of <all_urls>
allows access to such URLs.
BUG=452319
Review URL: https://codereview.chromium.org/880773002
Cr-Commit-Position: refs/heads/master@{#313215}
Re-enable always-on hotwording for m42 on supported hardware.
Revert "Remove hardware check that enables always-on hotwording."
This reverts commit e014345eab81e39c48956f9dae0cc0c66e170f08.
Review URL: https://codereview.chromium.org/838753004
Cr-Commit-Position: refs/heads/master@{#313214}
Fix JingleThreadWrapper initialization in PNaCl plugin.
Previously JingleThreadWrapper was initialized in the remoting PNaCl
plugin such that JingleThreadWrapper::current() was always returning
NULL. JingleThreadWrapper::current() is used only to implement
rtc::Thread::Send() and until recently Send() wasn't used in the parts
of webrtc used in remoting. Now rtc::StunRequest uses Send(), which
crashes the plugin.
Added JingleThreadWrapper::WrapTaskRunner() that properly initializes
current() and is used in the remoting plugin now.
Also JingleThreadWrapper is no longer passes SocketServer to the
parent as it is no longer necessary.
BUG=451643
Review URL: https://codereview.chromium.org/876433003
Cr-Commit-Position: refs/heads/master@{#313213}
Run draw callback immediately if no Display is damaged.
This may cause the draw callback to be run earlier than before if the Surface would later be added to a Display, but prevents it ensures that the callback runs if the Surface wouldn't be drawn at all
BUG=440269
Review URL: https://codereview.chromium.org/792383004
Cr-Commit-Position: refs/heads/master@{#313212}
Chromecast: fixes CMA renderer initialization crash.
[email protected],[email protected]
BUG=None
Review URL: https://codereview.chromium.org/882563002
Cr-Commit-Position: refs/heads/master@{#313211}
Plugin Power Saver: --enable-plugin-power-saver only overrides ALLOW.
--enable-plugin-power-saver flag previously overrode anything in the
content settings flag. This breaks for BLOCK setting and unauthorized
plugins, as the browser side needs to authorize the plugin first.
This patch restricts the flag to only impact users on ALLOW. This makes
sense to me, as the flag should not decrease the security of users
who have explicitly chosen ASK or BLOCK.
It will also dodge the bug.
BUG=448171,403800
Review URL: https://codereview.chromium.org/876803005
Cr-Commit-Position: refs/heads/master@{#313210}
Isolate extensions_browsertests
[email protected], [email protected]
[email protected]
BUG=98637
Committed: https://crrev.com/d1caf97fe8db47e5c76043bccbf4dd4a42265831
Cr-Commit-Position: refs/heads/master@{#312993}
Review URL: https://codereview.chromium.org/869783004
Cr-Commit-Position: refs/heads/master@{#313209}
Remove CHECKs from WebContentsImpl::OnDocumentLoadedInFrame
BUG=451932
Review URL: https://codereview.chromium.org/883503003
Cr-Commit-Position: refs/heads/master@{#313208}
Reland "mac: Layer back the root view of the browser window on OSX 10.9+."
The original CL was reverted because it caused non-deterministic failures in
browser tests that used the file tab-restore-visibility.html. The test file had
an edge case that caused thrashing and prevented the page from loading. This
has since been fixed.
> BrowserWindowController always layer-backs the contentView of the window. If
> Chrome were linked against OSX 10.9, this would also cause the root view to be
> layer backed. Since Chrome is linked against OSX 10.6, the root view by default
> is not layer backed.
>
> BrowserWindowController is going to have a custom AppKit fullscreen animation,
> which requires that the root view is layer backed. While it is possible to
> implement a custom AppKit fullscreen animation as early as OSX 10.7, the
> effects of layer backing the root view on OSX 10.7 are murky. It seems much
> safer to just layer back the root view on OSX 10.9+, and only enable the custom
> AppKit fullscreen animation on OSX 10.9+.
>
> As far as I know, this change has no detrimental side effects. There is no
> spike in memory usage
> (https://code.google.com/p/chromium/issues/detail?id=396264#c11), presumably
> because NSThemeFrame implements -wantsUpdateLayer on OSX 10.9+.
>
> BUG=413009, 414527
> Committed: https://crrev.com/8dec34f8f3504352e4eef95b2aaa36c561aea930
> Cr-Commit-Position: refs/heads/master@{#311191}
BUG=413009, 414527
[email protected]
Review URL: https://codereview.chromium.org/878673006
Cr-Commit-Position: refs/heads/master@{#313207}
[telemetry] Disable inbox_benchmark.Inbox.
Failing on the bots. See:
http://build.chromium.org/p/chromium.perf/builders/Mac%2010.9%20Perf%20%285%29/builds/3254
BUG=452257
[email protected]
Review URL: https://codereview.chromium.org/879763003
Cr-Commit-Position: refs/heads/master@{#313206}
Roll src/third_party/skia 1d124c3:2d80dd2
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1d124c3..2d80dd2
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/875293002
Cr-Commit-Position: refs/heads/master@{#313205}
ozone: evdev: Move touch ui::Event transformation to EventFactoryEvdev
This is part of a series moving IO on evdev devices to a fast thread,
since UI thread is too slow for the cursor.
DeviceDataManager is a UI thread object, so move final transformation
of touches into EventFactoryEvdev prior to dispatch into UI. This
will avoid sharing state across threads.
BUG=449710
TEST=boot link_freon & move cursor
Review URL: https://codereview.chromium.org/874713002
Cr-Commit-Position: refs/heads/master@{#313204}
Roll src/third_party/WebKit 02cd199:fa85120 (svn 188996:188997)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/02cd199..fa85120
[email protected],[email protected]
Review URL: https://codereview.chromium.org/877973002
Cr-Commit-Position: refs/heads/master@{#313203}
Remove WAPI-related code, except the type definition of ResourceEntry.
To remove ResourceEntry completely, tests for syncFileSystem need to be modified.
I'll do it by a separate CL.
BUG=357038
[email protected]
TBRing for removal of unused files from *.gyp and *.gn under google_api
TEST=build all targets
Review URL: https://codereview.chromium.org/861133002
Cr-Commit-Position: refs/heads/master@{#313202}
Add glGetFragDataLocation to gpu command buffer.
BUG=429053
TEST=gpu_unittests
[email protected]
Review URL: https://codereview.chromium.org/867123008
Cr-Commit-Position: refs/heads/master@{#313201}
Roll src/breakpad/src 58aca2d:398c70a (svn 1413:1414)
Summary of changes available at:
https://chromium.googlesource.com/external/google-breakpad/src/+log/58aca2d..398c70a
398c70a Fix a source of memory corruption.
BUG=449214
Review URL: https://codereview.chromium.org/877943002
Cr-Commit-Position: refs/heads/master@{#313200}
Create setup and arrange duplicated the following lines for Issue 443821
StateMachine state(scheduler_settings);
state.SetCanStart();
state.UpdateState(state.NextAction());
state.CreateAndInitializeOutputSurfaceWithActivatedCommit();
state.SetVisible(true);
state.SetCanDraw(true);
BUG=443821
Review URL: https://codereview.chromium.org/875613002
Cr-Commit-Position: refs/heads/master@{#313199}
Introduce new test for bookmark loading.
BUG=110020
Committed: https://crrev.com/50567ebbd5ca2ff79d87382addc11d25658776d2
Cr-Commit-Position: refs/heads/master@{#312076}
Review URL: https://codereview.chromium.org/840493002
Cr-Commit-Position: refs/heads/master@{#313198}
Modify SetAlternateProtocol logging behavior.
Modify SetAlternateProtocol() behavior with respect to logging and histograms, by
ignoring alternate protocol being shadowed by |g_forced_alternate_protocol| or
being inactive due to too high probability threshold.
Also clean up HasAlternateProtocol() and GetAlternateProtocol().
BUG=392575
Review URL: https://codereview.chromium.org/858433004
Cr-Commit-Position: refs/heads/master@{#313197}
Move to SkStreamAsset for SkTypeface streams.
SkTypeface is moving to use SkStreamAsset instead of SkStream. The
implementations are already assuming this, and all users are in
practice already creating the correct types. This change simply
clarifies existing practice and documents actual restrictions.
The Skia side change will be https://codereview.chromium.org/869763002/
Review URL: https://codereview.chromium.org/870133002
Cr-Commit-Position: refs/heads/master@{#313196}
Chromecast buildfix: update CmaRenderer for Initialize API change.
See: https://codereview.chromium.org/870693002
[email protected],[email protected]
BUG=450764
Review URL: https://codereview.chromium.org/869283003
Cr-Commit-Position: refs/heads/master@{#313195}
[Password Generation] Remove reference to a fixed bug.
BUG=152422
Review URL: https://codereview.chromium.org/880733002
Cr-Commit-Position: refs/heads/master@{#313194}
Use audio shifter instead of a fifo for local mediastream playback.
There are two reasons for this change:
1. The current code path doesn't work correctly if the media stream and the output devices clocks don't match up *exactly*. Underruns/lipsync issues can occur.
2. This allows for audio to be explicitly buffered for some period of time, which I plan to utilize in the cast_streaming receiver code.
Currently this code path is not often used, since it only happens when you get a media stream from getUserMedia and plug it into a media player without going through webrtc.
Review URL: https://codereview.chromium.org/856843002
Cr-Commit-Position: refs/heads/master@{#313193}
Fix pnacl_support_extension null build on linux/mac (no longer have libgcc_eh.a).
The libgcc_eh.a file is no longer in the translator tarball
possibly after NaCl revision:
1fceb45: (dschuff) Wrap PNaCl sandboxed translator build in toolchain_build recipe
Cr-Commit-Position: refs/heads/master@{#312891}, fixed
this for windows builds, but not linux / mac.
Review URL: https://codereview.chromium.org/879803002
Cr-Commit-Position: refs/heads/master@{#313192}
Deleted ash/shelf/alternate_app_list_button.cc.
This file was unused since r263451 and it looks like it was accidentally
not deleted.
Review URL: https://codereview.chromium.org/836753005
Cr-Commit-Position: refs/heads/master@{#313191}
Turns out the CHECK I added for debugging can fail due to yet another bad side
effect of the prerenderer not working right.
Convert the CHECK into a conditional for now and leave an explanation of why it
can fail.
BUG=452299
TEST=none
TBR=vitalybuka
Review URL: https://codereview.chromium.org/876203002
Cr-Commit-Position: refs/heads/master@{#313190}
Removes "ui-sans" from the ChromeOS system UI default font list.
The ChromeOS system UI (rendered through HarfBuzz) now
relies on gfx::RenderText::CreateSkiaTypeface(), and
skia actually returns exactly same typeface for
'Noto Sans UI' and 'ui-sans' in the current configuration.
ui-sans is simply redundant.
BUG=444894
[email protected]
Review URL: https://codereview.chromium.org/823003002
Cr-Commit-Position: refs/heads/master@{#313189}
Add ChannelPosix::ResetSafely() to deal with a lingering crash
The CL [1] tightened the error check too much and revealed
an existing inconsistency and resulted a production crash.
This CL makes a workaround to that crash, turning a PCHECK()
to DPCHECK().
[1] https://crrev.com/ce44fef5fd60dd2be5c587d4b084bdcd36adcee4
BUG=449233,448245
[email protected],[email protected]
Review URL: https://codereview.chromium.org/882543002
Cr-Commit-Position: refs/heads/master@{#313188}
Remove unused constant.
This constant is no longer used in internal repository.
[email protected]
BUG=436083
Review URL: https://codereview.chromium.org/876013004
Cr-Commit-Position: refs/heads/master@{#313187}
Autofill - show expiration date in CVC prompt when card is expired. (Views)
BUG=451654
Review URL: https://codereview.chromium.org/873403004
Cr-Commit-Position: refs/heads/master@{#313186}
Refactor navigator.connect code to make it more flexible.
This separates out all the service worker specific code from the generic
connection handling. As well as exposing some API in content/public so
code outside of content/ can handle connections.
This is the first step in making it possible to have chrome extensions,
or other code outside of content/ be the endpoint of a connection.
This doesn't change any functionality, it just moves code around.
BUG=426458
Review URL: https://codereview.chromium.org/861373002
Cr-Commit-Position: refs/heads/master@{#313185}
Enable ChannelMojo
As we addressed certain amount of the performance problem,
it's time to give it another try.
[email protected]
BUG=377980
Review URL: https://codereview.chromium.org/857483004
Cr-Commit-Position: refs/heads/master@{#313184}
cc: Remove tile and scale specific code from raster source
Fix a TODO I added a while back. Instead of calling SetMinContentsScale
and SetTileGridSize directly, pass these as parameters to constructor of the
PicturePile.
Committed: https://crrev.com/6d1f2981f3204852a9189d0b6e7ad0b18659d68d
Cr-Commit-Position: refs/heads/master@{#309867}
Review URL: https://codereview.chromium.org/811953005
Cr-Commit-Position: refs/heads/master@{#313183}
Roll libvpx: cc9c0c:5da40c
Cherry-pick potential divide-by-zero fix
https://codereview.chromium.org/877783004
This includes remnants of an attempt to turn on AVX2. That failed and the
critical parts have been reverted. However, the attempt revealed some necessary
changes which have been kept for the next attempt. These constitute a no-op for
this particular roll.
Enable AVX2:
https://codereview.chromium.org/863143002
Fix GN build:
https://codereview.chromium.org/865893004
https://codereview.chromium.org/817293008
https://codereview.chromium.org/866273003
Fix cpu detection:
https://codereview.chromium.org/864393002
Disable AVX2:
https://codereview.chromium.org/880513003
[email protected]
[email protected]
BUG=396572
Review URL: https://codereview.chromium.org/883503002
Cr-Commit-Position: refs/heads/master@{#313182}
Fix Security Key proxying.
Gnubby was added a a Capbility in https://codereview.chromium.org/787033003,
but since it is not negotiated between host and client, that's not the right
way to make it configurable.
BUG=448131
Review URL: https://codereview.chromium.org/878573006
Cr-Commit-Position: refs/heads/master@{#313181}
Reenable -Wl,-z,defs on mipsel
The flags were disabled to suppress a build error in ffmpeg.
The error should be fixed now:
https://crrev.com/a458f95e5718918a70506be2a33ea3be55e59024
BUG=450771, 371125
TEST=emerge-mipsel-o32-generic chromeos-chrome
cbuildbot --remote mipsel-o32-generic-tot-chromium-pfq-informational
Review URL: https://codereview.chromium.org/878603005
Cr-Commit-Position: refs/heads/master@{#313180}
Re-land: Send Windows accessibility events based on tree updates.
The idea of this change is to fire Win AX events
based on the AX tree changing, rather than based
on Blink firing the right event and mapping it to a
Win event.
Store the Win-specific AX attributes (ia role,
ia state, name, value, etc.) in a struct, and when a
node is updated, compare the old value of each attribute
to the new value and fire an appropriate event for each
one (name changed, state changed, etc.).
Handle hypertext_ similarly, and properly diff the old and new hypertext in get_oldText and get_newText.
This enables all of the "event" tests that were
previously added to pass now, and it makes live regions
work correctly in NVDA and JAWS.
BUG=447962
Committed: https://crrev.com/eb691a960bef3c2aefa38627baa7cbdde480b81e
Cr-Commit-Position: refs/heads/master@{#313052}
Review URL: https://codereview.chromium.org/848653002
Cr-Commit-Position: refs/heads/master@{#313179}
Fix a style issue: Add braces around a multi-line if statement.
Also removes some now unreachable code following the BoringSSL roll.
Review URL: https://codereview.chromium.org/877783005
Cr-Commit-Position: refs/heads/master@{#313178}
Insert in-process GPU switches on UI thread
For in-process gpu, the CommandLine of the current process is a shared
resource and cannot be safely manipulated on the IO thread.
This moves inserting the gpu command line switches to the UI thread, and
slightly start up. Although still need additional fixes to start up code
to ensure it's safe to manipulate it on UI thread.
This also fixes the bug of inserting gpu switches when GpuProcessHost is
not used, for example in android webview.
BUG=450396
Review URL: https://codereview.chromium.org/865063002
Cr-Commit-Position: refs/heads/master@{#313177}
[NaCl SDK] Update fancy_urllib for Python 2.7.9
Python 2.7.9 adds an additional parameter to the HTTPSHandler.do_open function.
This function is overriden in fancy_urllib and called externally. This causes
the SDK updater to fail with a Python traceback. This CL fixes the calling
signature of the overriden do_open function.
BUG=452137
[email protected]
Review URL: https://codereview.chromium.org/874393004
Cr-Commit-Position: refs/heads/master@{#313176}
Roll src/third_party/WebKit 9994197:02cd199 (svn 188902:188996)
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9994197..02cd199
[email protected],[email protected]
Review URL: https://codereview.chromium.org/877553004
Cr-Commit-Position: refs/heads/master@{#313175}
[Android] Cache Java-based histogram lookup through RecordHistogram
Avoid JNI string translation for each histogrom update routed through
RecordHistogram by caching the histogram lookup. Use the Java string
handle as the key.
BUG=442300
Review URL: https://codereview.chromium.org/867063006
Cr-Commit-Position: refs/heads/master@{#313174}
Snow has a slow TPM and appears to be slow in general.
Some tests are failing on Snow because cryptohome doesn't unmount in time.
Attempting to increase this timeout to alleviate the issue.
We can revert this patch if it doesn't help.
BUG=449746
TEST=various telemetry-based autotests on Snow
Review URL: https://codereview.chromium.org/871923007
Cr-Commit-Position: refs/heads/master@{#313173}
Remove unwanted includes from toolbar_view.h
BUG=
Review URL: https://codereview.chromium.org/865203004
Cr-Commit-Position: refs/heads/master@{#313172}
Revert of Fix for the font files being maped multiple times (Fontconfig). (patchset #4 id:60001 of https://codereview.chromium.org/697383002/)
BUG=452227
Reason for revert:
Suspected for breaking security_OpenFDs on cros (http://crbug.com/452227):
01/26 13:31:23.658 ERROR|security_O:0147| Found unexpected fds in chrome type=renderer: set(['0500 /usr/share/fonts/croscore/Tinos-Regular.ttf', '0500 /usr/share/fonts/noto/NotoSans-Regular.ttc', '0500 /usr/share/fonts/noto/NotoSans-Bold.ttc'])
01/26 13:31:23.658 DEBUG|security_O:0138| Found pid 8280 for chrome
01/26 13:31:23.660 ERROR|security_O:0147| Found unexpected fds in chrome type=renderer: set(['0500 /usr/share/fonts/noto/NotoSans-Regular.ttc'])
Original issue's description:
> Fix for font files being mmaped multiple times (Fontconfig).
>
> Before this change, when there were a lot of font fallbacks happening on
> the web site, the fallback font was mmaped multiple times, reaching up to
> 200 times in the TC url: http://jsfiddle.net/p5pe81vs/, leading to OOMs
> and crashes for renderer process.
>
> This happens after the change introduced in
> https://codereview.chromium.org/307243002
>
> This CL keeps track of the mmaps for each font ID to avoid any further
> unnecessary IPC requests and mmaps for future requests of the same font
> ID that would result in new FD.
>
> BUG=430021
>
> NOPRESUBMIT=true
> brettw indicates this use of ScopedAllowIO is acceptable.
> Previous code eluded IO checks, this change makes the IO use find-able.
>
> Committed: https://crrev.com/78db5e535ef48c596223fe272572e5679fbb44fd
> Cr-Commit-Position: refs/heads/master@{#313102}
[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=430021
Review URL: https://codereview.chromium.org/873213003
Cr-Commit-Position: refs/heads/master@{#313171}
Add one Skia suppression.
Additional suppression for http://crrev.com/776673002.
BUG=452219
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/876183002
Cr-Commit-Position: refs/heads/master@{#313170}
Enable beamforming in Swanky
BUG=405270
Review URL: https://codereview.chromium.org/816353011
Cr-Commit-Position: refs/heads/master@{#313169}
Revert of Instrumenting opening password database to find jank (patchset #1 id:1 of https://codereview.chromium.org/807263003/)
Reason for revert:
Undoing profiler instrumentations since the jank is fixed.
Original issue's description:
> Instrumenting opening password database to find jank.
>
> This database opening happens in UI thread. Checking what jankiness this causes.
>
> Background: one of jankiness investigations (crbug.com/426272) came to a conclusion that the jank is actually caused by this issue. Instrumenting to get the numbers.
>
> BUG=138903
>
> Committed: https://crrev.com/42466460ec1a5c0f2953d13e57d0d290cb38ca21
> Cr-Commit-Position: refs/heads/master@{#308702}
[email protected]
BUG=138903
Review URL: https://codereview.chromium.org/878763002
Cr-Commit-Position: refs/heads/master@{#313168}
cc: Render to destination transform when rendering into a separate surface
The existing code would render the separate surface render pass in source
space, rather than in target space, which means it would render small,
apply the filter, then scale up to target space, which caused scaling
artifacts.
I've updated the surface transforms to respect combined_transform_scales,
which are the x and y axis lengths of combined_transform.
I've also written a test that demonstrates the issue, and is fixed by
this cl.
BUG=411079
Review URL: https://codereview.chromium.org/846453005
Cr-Commit-Position: refs/heads/master@{#313167}
Remove unused MSVS 2013 hack from base/numerics
[email protected]
Review URL: https://codereview.chromium.org/875983006
Cr-Commit-Position: refs/heads/master@{#313166}
Add OAuth2 token to RealPanRequest.
Depends on https://codereview.chromium.org/869003003/
BUG=451286
[email protected]
Review URL: https://codereview.chromium.org/873583007
Cr-Commit-Position: refs/heads/master@{#313165}
Reverse logic of window / tab control in bookmark app creation.
The option is now 'open as window', before it was 'open as tab'.
The default has also been changed so by default the checkbox is unchecked (and the bookmark app will open as a tab).
BUG=450102
Review URL: https://codereview.chromium.org/869483003
Cr-Commit-Position: refs/heads/master@{#313164}
Make components_browsertests swarmable and add to main waterfall. (2nd try)
- Makes components_browsertests swarmable.
- Adds components_browsertests to the main waterfall for linux, mac and
win bots.
- Updates the chromium tryserver to run components_browsertests as
swarmable.
- Add content_shell as a dependency for components_browsertests for
Mac, which is needed for the Content Shell helper on that platform.
The original CL did not add content_shell as a dependency for
components_browsertests, which made the build step for the isolate flaky
dependent upon whether content_shell happened to have already been built.
BUG=311270
Original CL:
Review: https://codereview.chromium.org/863023003/
Committed: https://crrev.com/7a3df3b7171fa87f556d22803fdc02a67e975865
Cr-Commit-Position: refs/heads/master@{#312886}
Revert CL:
https://codereview.chromium.org/856323003/
Committed: https://crrev.com/27ac8082963904942aaebcbf85620ae6e27ad5c9
Cr-Commit-Position: refs/heads/master@{#312976}
Review URL: https://codereview.chromium.org/874843002
Cr-Commit-Position: refs/heads/master@{#313163}
Replace "enable-encrypted-media" flag with "disable-encrypted-media".
Invert the logic now that unprefixed EME APIs are enabled by default.
BUG=394918
TEST=Encrypted Media browser tests pass.
Review URL: https://codereview.chromium.org/865793003
Cr-Commit-Position: refs/heads/master@{#313162}
[Telemetry] Fix exception handling in user story runner.
Currently, unrecoverable exception raised during a user story run does not
create a failure value for that user story. This leads to confusing log output
by gtest_progress_reporter.
This patch fixes this by catching unrecoverable exception and add failure value
to the currently user story value. This patch also improve unittest in
user_story_runner_unittest to make sure that the stdout output captures the
raise exceptions.
BUG=448827
Review URL: https://codereview.chromium.org/875993002
Cr-Commit-Position: refs/heads/master@{#313161}
Record layer name when recording paint event.
BUG=None
Review URL: https://codereview.chromium.org/876863002
Cr-Commit-Position: refs/heads/master@{#313160}
Refactor fullscreen_controller.
Split FullscreenController to MouseController (and leave fullscreen related parts in original class). ExclusiveAccessManager is responsible for coordinating the different exclusive access controllers.
BUG=166928
TEST=Requires MANUAL testing of fullscreen and pointer/mouse lock is required as tests are disabled for being flaky
Review URL: https://codereview.chromium.org/836933005
Cr-Commit-Position: refs/heads/master@{#313159}
Don't touch the renderer without the lock!
It's accessed concurrently on the render thread and the media thread internally and externally.
BUG=452093
TEST=none
Review URL: https://codereview.chromium.org/879483004
Cr-Commit-Position: refs/heads/master@{#313158}
IPC: Introduce MessageAttachment and PlatformFileAttachment.
This is another preparation for crbug.com/448190.
This change encapsulates a platform file as a MessageAttachment
abstract class and its subclass called PlatformFileAttachment.
This abstraction allows MessageAttachmentSet to contain not only
platform files, but also a mojo MessagePipes, which will be
encapsulated by another MessageAttachment subclass.
BUG=448190
[email protected], [email protected]
Review URL: https://codereview.chromium.org/856443003
Cr-Commit-Position: refs/heads/master@{#313157}
Set class names for ime's view classes.
BUG=450703
[email protected]
Review URL: https://codereview.chromium.org/866403006
Cr-Commit-Position: refs/heads/master@{#313156}
Ensure the OOP PDF progress bar segments are visible
Currently they don't get displayed at all!
BUG=450232
[email protected]
Review URL: https://codereview.chromium.org/867123002
Cr-Commit-Position: refs/heads/master@{#313155}
Remove Skia SK_SUPPORT_LEGACY_HQ_SCALING suppressions
Rebaselined in Blink.
BUG=449873
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/872183003
Cr-Commit-Position: refs/heads/master@{#313154}
Restart browser between smoke tests, fixes failing webview bypass test.
The bypass smoke test uses an existing browser session, where the favicon requewst has already been made and completed through the data saver proxy. When the favicon is requested again during the bypass test, it will still appear to come through the proxy causing the case to fail. If instead we use a fresh browser session, bypass works as expected for the favicon.
In general, it's good practice to make tests as atomic as possible, so this should be better design for the smoke tests (although it adds ~12 seconds to the total execution time).
BUG=452161
Review URL: https://codereview.chromium.org/862803004
Cr-Commit-Position: refs/heads/master@{#313153}
Remove exceptions for component_updater files which don't exist anymore.
BUG=450337
Review URL: https://codereview.chromium.org/877763003
Cr-Commit-Position: refs/heads/master@{#313152}
Use callbacks in SessionRestore unit tests
BUG=chromium:268984
TEST=All tests pass in SessionRestoreBrowserTest and
BetterSessionRestoreBrowserTest
Signed-off-by: Simon Que <[email protected]>
Review URL: https://codereview.chromium.org/871013006
Cr-Commit-Position: refs/heads/master@{#313151}
Updated parsing of PrivetV3 mDns record.
DeviceDescription::id is set from "gcd_id" value.
DeviceDescription::type is set from "class" value.
Removed some unused values.
BUG=449864
Review URL: https://codereview.chromium.org/861523002
Cr-Commit-Position: refs/heads/master@{#313150}
Skia suppressions for crrev.com/776673002
BUG=452219
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/875203002
Cr-Commit-Position: refs/heads/master@{#313149}
Initial implementation of continuous read for ChromeVox Next.
Review URL: https://codereview.chromium.org/845693004
Cr-Commit-Position: refs/heads/master@{#313148}
net: add a number of .gov HSTS entries.
Cr-Commit-Position: refs/heads/master@{#313147}
Fix popup window repositioning in Desktop Chrome.
We need to use Widget::SetBounds in place of Widget::SetSize as the position of the window
may have changed.
BUG=374705
TEST=Covered by views_unittest DesktopAuraWidgetTest.TopLevelOwnedPopupRepositionTest
Review URL: https://codereview.chromium.org/871813003
Cr-Commit-Position: refs/heads/master@{#313146}
IndexedDB: Reject bad OnDestroyed messages
Reject a message with a bogus object id, rather than null crashing.
BUG=451752
[email protected]
Review URL: https://codereview.chromium.org/874983003
Cr-Commit-Position: refs/heads/master@{#313145}
Fixed Privet v3 auth header.
v1 uses "X-Privet-Auth".
v3 uses "Authorization".
Privet v3 client should use "Authorization: Privet anonymous" before pairing.
BUG=449864
Review URL: https://codereview.chromium.org/878463002
Cr-Commit-Position: refs/heads/master@{#313144}
Update V8 to version 4.2.29 (based on 0ae9eb038fd47f94493141ebf6144363363fac6b).
[email protected]
Review URL: https://codereview.chromium.org/873483005
Cr-Commit-Position: refs/heads/master@{#313143}
net: manual removal of segu-info.com.ar from HSTS list.
Cr-Commit-Position: refs/heads/master@{#313142}
Only release the result of a register request to a tab if it's still the foreground tab when the result is received.
BUG=451165
[email protected],[email protected]
Review URL: https://codereview.chromium.org/872603003
Cr-Commit-Position: refs/heads/master@{#313141}
Fixed and reenabled the flaky test "WebViewAPITest.TestAutosizeAfterNavigation".
[email protected]
Review URL: https://codereview.chromium.org/851813002
Cr-Commit-Position: refs/heads/master@{#313140}
Make InitializeMojo() idempotent.
For tests, there are some difficulties to guarantee it being called just once.
This is a retake of https://codereview.chromium.org/866973004/,
which didn't work with some tests.
[email protected], [email protected]
TEST=RenderThreadImplBrowserTest
BUG=
Review URL: https://codereview.chromium.org/872973003
Cr-Commit-Position: refs/heads/master@{#313139}
Add some paramtraits to ipc fuzzer.
[email protected], [email protected]
BUG=450268
Review URL: https://codereview.chromium.org/873233003
Cr-Commit-Position: refs/heads/master@{#313138}
Remove NOTIFICATION_BROWSING_DATA_REMOVED
Replace the notification system with a static callback list in
BrowsingDataRemover.
BUG=chromium:268984
TEST=BrowsingDataRemoverTest and ExtensionBrowsingDataTest pass.
Signed-off-by: Simon Que <[email protected]>
Review URL: https://codereview.chromium.org/874613004
Cr-Commit-Position: refs/heads/master@{#313137}
Fix to the GCM Account Tracker flooding on a stale refresh token
As a solution to a problem the Account Tracker will assume a stale
refresh token when it cannot get access token. Backoff logic in
token fetcher handles the case where service might not be reachale
and situations like that.
If the user signs in properly the account will be re-added.
BUG=452131
[email protected],[email protected]
Review URL: https://codereview.chromium.org/878713002
Cr-Commit-Position: refs/heads/master@{#313136}
Suppress conformance_extensions_oes_texture{_half}_float_with_canvas on D3D9.
BUG=angleproject:896
Review URL: https://codereview.chromium.org/873383002
Cr-Commit-Position: refs/heads/master@{#313135}
Add missing views class names so that correct view's class name show up in chrome://tracing instead of just "View".
BUG=450703
Review URL: https://codereview.chromium.org/863223002
Cr-Commit-Position: refs/heads/master@{#313134}
Add histograms for temperatures and thermal states.
BUG=None
Review URL: https://codereview.chromium.org/851503005
Cr-Commit-Position: refs/heads/master@{#313133}
[Telemetry] Make psutil use the new external_modules helper.
BUG=
Review URL: https://codereview.chromium.org/820603002
Cr-Commit-Position: refs/heads/master@{#313132}
Define class names for views class in c/b/ui/views so that they show up on chrome://tracing
We're working on UI junk elimination and this is to help identify the class/methods that spend too long on UI thread.
BUG=450703
Review URL: https://codereview.chromium.org/869453002
Cr-Commit-Position: refs/heads/master@{#313131}
Roll FFmpeg DEPs to pick up MIPS build fixes.
BUG=450771
TEST=none
Review URL: https://codereview.chromium.org/875143002
Cr-Commit-Position: refs/heads/master@{#313130}
Remove unused ScopedPath.
https://codereview.chromium.org/74253002 removed the only use.
No behavior change.
BUG=452130
TBR=eroman
Review URL: https://codereview.chromium.org/876823002
Cr-Commit-Position: refs/heads/master@{#313129}
Remove reference to FileNotFoundError, as it is not available in python 2.
NOTRY=true
Review URL: https://codereview.chromium.org/874403003
Cr-Commit-Position: refs/heads/master@{#313128}
Add builder_type to fetch builds for android-chrome.
BUG=
NOTRY=True
Review URL: https://codereview.chromium.org/866573003
Cr-Commit-Position: refs/heads/master@{#313127}
Use data_deps rather then deps for mojo_bindings.
Using deps caused pulling a bit of mojo code to chrome.exe. That
caused weird unresolved externatls problems during Windows GN build.
Review URL: https://codereview.chromium.org/876783003
Cr-Commit-Position: refs/heads/master@{#313126}
In SdchDictionaryFetcher, don't set state when scheduling if loop is active.
BUG=450724
[email protected]
Review URL: https://codereview.chromium.org/864923002
Cr-Commit-Position: refs/heads/master@{#313125}
Roll BoringSSL.
347f025 Remove unused modexp512-x86_64.pl.
6ae7f07 Only send sigalgs extension in 1.2-capable ClientHellos.
4189bd9 Test application data and Finished reordering.
78e6978 Disable NPN and Channel ID in DTLS.
33e799f Don't allow CCS just before CertificateVerify in DTLS.
c898ce7 Add generated documentation to .gitignore
2a0e72f Fix segfault with empty fields as last in the config.
df1cda3 Use inner algorithm when printing certificate.
e3b2467 sha256-armv4.pl: fix typo.
8604eda Add Broadwell performance results.
See https://code.google.com/p/webrtc/issues/detail?id=4223
BUG=none
Review URL: https://codereview.chromium.org/874363003
Cr-Commit-Position: refs/heads/master@{#313124}
Touch emulator: enable double tap support for pages similarly to Chrome on Android.
This patch also moves the logic which decides on enabling/disabling double tap
to a common place to be reused both in touch emulation and android gesture detection.
BUG=425586,325506
Review URL: https://codereview.chromium.org/859973003
Cr-Commit-Position: refs/heads/master@{#313123}
Fix ComponentLoader unit tests on cros_trunk
Some ComponentLoader unit_tests are crashing on official chromeos bot
in IsNormalSession() due to uninitialized user manager.
This is hit when loading quickoffice component extension, which is
guarded with #if defined(GOOGLE_CHROME_BUILD), thus it's seen only on
official builds.
This makes sure that UserManager is initialized before checking
if a user is logged in.
Example trace:
#0 0x00000b44302e base::debug::StackTrace::StackTrace()
#1 0x00000b442c6c base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x0000f776f410 ([vdso]+0x40f)
#3 0x00000d702745 user_manager::UserManager::Get()
#4 0x00000e4c4bec extensions::ComponentLoader::EnableFileSystemInGuestMode()
#5 0x00000e4c5811 extensions::ComponentLoader::AddDefaultComponentExtensionsWithBackgroundPages()
#6 0x00000e4c523e extensions::ComponentLoader::AddDefaultComponentExtensions()
#7 0x000008fa03ff extensions::ComponentLoaderTest_LoadAll_Test::TestBody()
BUG=None
Review URL: https://codereview.chromium.org/874483005
Cr-Commit-Position: refs/heads/master@{#313122}
Removed unused Privet related classes.
BUG=451851
Review URL: https://codereview.chromium.org/869383003
Cr-Commit-Position: refs/heads/master@{#313121}
Add status to server credit cards.
Update some dialog strings for unmasking/updating expired cards.
TODO: Actual month/year inputs.
BUG=451654
Review URL: https://codereview.chromium.org/870203002
Cr-Commit-Position: refs/heads/master@{#313120}
Remove --ash-enable-tray-dragging flag
BUG=449849
TEST=Peter is happy
Review URL: https://codereview.chromium.org/879653002
Cr-Commit-Position: refs/heads/master@{#313119}
Removed unused native code related to wifi bootstrapping.
Chrome App will replace this functionality.
BUG=451851
Review URL: https://codereview.chromium.org/873103002
Cr-Commit-Position: refs/heads/master@{#313118}
[ServiceWorkerCache] Make the cache operations run serially.
There are correctness issues in the ServiceWorkerCache when multiple
operations occur on the same key in parallel. The various steps of the
operations can interleave. This CL serializes all cache operations by
placing all operations in a queue and calling the next operation from
the callback of the previous operation.
While this provides correctness, it is sub-optimal. We really only
need to serialize operations that affect the same entry. A smarter
scheduler can be created in the future to implement that (see
https://crbug.com/451174).
BUG=421226
Review URL: https://codereview.chromium.org/863263003
Cr-Commit-Position: refs/heads/master@{#313117}
Invalid press events don't create multiple pointers with the same id.
Previously if we got an invalid event stream such as
Press id 0
Press id 0
MotionEventAura would happily add the second pointer. Now we replace
the first pointer with the second pointer.
This work around is required due to crbug.com/373125.
BUG=450880
Review URL: https://codereview.chromium.org/873283003
Cr-Commit-Position: refs/heads/master@{#313116}
Remove the use of page id from NavController's GetVisibleEntry.
BUG=369661
TEST=tests stay green
Committed: https://crrev.com/6b988de501639cc9a8f9d40aa25fc44b431de71d
Reverted: https://crrev.com/67d33496116a22ce2244977569314d818525da04
Review URL: https://codereview.chromium.org/850953002
Cr-Commit-Position: refs/heads/master@{#313115}
[Telemetry] Increase the timeout amount for devtool alive check from 0.1s to 30s
BUG=448827
Review URL: https://codereview.chromium.org/876803002
Cr-Commit-Position: refs/heads/master@{#313114}
Update Touch Feedback on Volume tray
Update the visual feedback for touch on the volume tray.
Increased the touch region for the mute button. Combined the views after the
volume slider into one touch region that opens the detailed view.
Additionally removed subclasses of ui/views/controls/ inside VolumeView, where
update logic was only extension.
Removed need for custom layout by setting up the BoxLayout to tread the slider
as a flex region.
TEST=Manually tested on device
BUG=447213
Review URL: https://codereview.chromium.org/865333002
Cr-Commit-Position: refs/heads/master@{#313113}
Cleanup: Remove unused blink::WebTextDirection parameter from Notification ctor.
BUG=None
[email protected]
[email protected]
Review URL: https://codereview.chromium.org/873033002
Cr-Commit-Position: refs/heads/master@{#313112}
Remove the use of page id from determining whether to send the initial document notification.
BUG=369661
TEST=tests stay green
Committed: https://crrev.com/4442a6507d04b27eea65065c3a849f3c9d570352
Reverted: https://crrev.com/a4758bcdbf0cf027f18e3e87f15de51ce757eee0
Review URL: https://codereview.chromium.org/853693003
Cr-Commit-Position: refs/heads/master@{#313111}
Don't do auto-enrollment if the write protect switch is off.
Rationale is that disengaged write protect switch indicates the user
already has control over firmware and VPD contents, trying to force
enrollment in this environment doesn't make sense.
BUG=chromium:450325
Review URL: https://codereview.chromium.org/871013004
Cr-Commit-Position: refs/heads/master@{#313110}
wifi_sync: implement ACTION_ADD in WifiCredentialSyncableService
Implement support for adding networks. Specifically:
1) When an ACTION_ADD change is received from sync, apply that
change to the platform's network configruation.
2) Provide a method that upper layers can call, to add a network
to Chrome Sync.
BUG=chromium:431435
TEST=components_unittests --gtest_filter="Wifi*"
Review URL: https://codereview.chromium.org/836303004
Cr-Commit-Position: refs/heads/master@{#313109}
Restore debug allocator functions.
These are needed for Debug builds when using allocator_shim.
These were accidently removed in r312720.
BUG=451663
TEST=base_unittests, allocator_unittests (Debug, component=static_library)
Review URL: https://codereview.chromium.org/872153002
Cr-Commit-Position: refs/heads/master@{#313108}
Reland: Add more trace events to "benchmark" category
This CL was reverted at
https://codereview.chromium.org/867773002/
due to perf bot redness at that time. Now that the perf bot has
recovered, we can reland it.
This is to make the trace events captured during smoothness test more
useful in debugging smoothness/latency issues.
These added trace events are supposed to be giving most useful information
about the input/scheduling/rendering pipeline and have low occurrence in
each frame so as to minimize the performance overhead.
Following are the list for the added trace events roughly in the order
of the input->rendering pipeline:
LatencyInfo.Flow // so we can follow the input latency flow
RenderWidgetHostViewAndroid::OnVSync // when frame is started
InputHandlerProxy::HandleInputEvent // when the input event is handled on impl
RenderWidget::OnHandleInputEvent // when the input event is handled on main
Scheduler::BeginFrame // cc decides to schedule a frame
Scheduler::BeginRetroFrame // cc starts a retro frame
Scheduler::BeginImplFrame // impl frame is scheduled
Scheduler::OnBeginImplFrameDeadline // impl frame actually starts
OnSwapCompositorFrame // browser gets notified that renderer frame is ready
CompositorImpl::PostComposit // browser schedules a frame
SingleThreadProxy::CompositeImmediately // browser starts a frame
SingleThreadProxy::DidSwapBuffersCompleteOnImplThread // browser frame is done
BUG=449258
[email protected],[email protected],[email protected]
Review URL: https://codereview.chromium.org/874283004
Cr-Commit-Position: refs/heads/master@{#313107}
[chromedriver] Generate as much filler text as needed for testMoveToElementAndClick
BUG=
Review URL: https://codereview.chromium.org/872883002
Cr-Commit-Position: refs/heads/master@{#313106}
[Views] Make MenuButton track its desired state while pressed
Make MenuButton track its desried state while it's pressed so that, upon
release, it returns to the proper state (instead of assuming STATE_NORMAL).
BUG=431481
Review URL: https://codereview.chromium.org/873513002
Cr-Commit-Position: refs/heads/master@{#313105}
x11: Fix build for virtual/override style changes.
BUG=none
[email protected]
Review URL: https://codereview.chromium.org/875133002
Cr-Commit-Position: refs/heads/master@{#313104}
[cast] Force 4:2:0 pixel formats in H264VideoToolboxEncoder.
On some platforms, notably the iOS simulator, VideoToolbox compression
sessions vend 4:2:2 pixel buffers by default. This is not supported by
the VideoFrame-CVPixelBuffer integration code.
This patch forces VideoToolbox to vend I420 or NV12 buffers. For
encoders that natively support those formats, this effectively changes
nothing. For encoders that do not, VideoToolbox will convert submitted
frames to whatever format the encoder wants.
In practice, this is a defensive patch that also allows testing iOS cast
streaming on the iOS simulator.
BUG=450804
R=miu, hclam
Review URL: https://codereview.chromium.org/859303004
Cr-Commit-Position: refs/heads/master@{#313103}
Fix for font files being mmaped multiple times (Fontconfig).
Before this change, when there were a lot of font fallbacks happening on
the web site, the fallback font was mmaped multiple times, reaching up to
200 times in the TC url: http://jsfiddle.net/p5pe81vs/, leading to OOMs
and crashes for renderer process.
This happens after the change introduced in
https://codereview.chromium.org/307243002
This CL keeps track of the mmaps for each font ID to avoid any further
unnecessary IPC requests and mmaps for future requests of the same font
ID that would result in new FD.
BUG=430021
NOPRESUBMIT=true
brettw indicates this use of ScopedAllowIO is acceptable.
Previous code eluded IO checks, this change makes the IO use find-able.
Review URL: https://codereview.chromium.org/697383002
Cr-Commit-Position: refs/heads/master@{#313102}
In ShillClientHelper use a{sv} for property dictionaries
This is dependent on Shill change:
https://chromium-review.googlesource.com/242491
(This change won't work without the Shill change, but it also won't make
anything any more broken than it already is).
BUG=449273
Review URL: https://codereview.chromium.org/867043002
Cr-Commit-Position: refs/heads/master@{#313101}
GN: Change webrtc_base -> rtc_base
The target was renamed in GYP a while back
and in https://code.google.com/p/webrtc/source/detail?r=8117
for GN. This is the last reference left using the
'webrtc_base' target name.
[email protected]
Review URL: https://codereview.chromium.org/868573003
Cr-Commit-Position: refs/heads/master@{#313100}
Added a new process mitigation to harden process token IL policy.
This adds a new process mitigation policy to harden the current process
token's integrity level policy. What this actually means is the token's
IL policy in its SACL is modified to add no-read-up and no-execute-up
which is not the default. This prevents a lower privilege process from
opening the token object with rights such as duplicate and impersonation
which could be used to circumvent sandbox restrictions and elevate
privileges. While the policy is only enabled on the browser process by
making it a general mitigation policy it could be applied to all process
levels such as the GPU process to provide a similar effect.
BUG=440692
Review URL: https://codereview.chromium.org/810083002
Cr-Commit-Position: refs/heads/master@{#313099}
Integration tests for desktop platforms and safebrowsing.
Fix timeout check: If _expect_timeout flag is set, and timeout does not occur, then raise an exception.
Add new test for safebrowsing for desktop: Confirm that safebrowsing is turned off on server when ChromeProxy header identifies request as originating from desktop platforms with c=<clienttype>.
Fix safebrowsing test for mobile: Remove checks for safebrowsing response headers since it is not visible to telemetry tests.
BUG=434769
Review URL: https://codereview.chromium.org/820093002
Cr-Commit-Position: refs/heads/master@{#313098}
Fix {virtual,override,final} build failure on official CrOS build
BUG=417463
[email protected]
Review URL: https://codereview.chromium.org/878573005
Cr-Commit-Position: refs/heads/master@{#313097}
Use local render surface variable
Instead of going through the layer pointer again.
Review URL: https://codereview.chromium.org/872323003
Cr-Commit-Position: refs/heads/master@{#313096}
Add simulcast browser test.
Also cleanup some unneeded setting of the kUseGpuInTests
command line flag.
TESTED=Successful run using:
out/Release/browser_tests --gtest_filter=WebRtcSimulcastBrowserTest.TestVgaReturnsTwoSimulcastStreams
BUG=
Review URL: https://codereview.chromium.org/874993002
Cr-Commit-Position: refs/heads/master@{#313095}
Temporary disable VP8 HW video decoding on Exynos and MediaTek devices while HW decoder video freezes and distortions are investigated.
BUG=446974, https://code.google.com/p/webrtc/issues/detail?id=4056
Review URL: https://codereview.chromium.org/866923003
Cr-Commit-Position: refs/heads/master@{#313094}
cc: Add frame timing request plumbing through the layers.
This patch adds frame timing request class, which contains a rect and
an id for that rect. Furthermore, it adds plumbing so that the requests
get propagated from the original Layer into both pending and active
LayerImpls. Verified using tracing that the requests appear correctly.
R=danakj, [email protected]
BUG=441555
Review URL: https://codereview.chromium.org/834343004
Cr-Commit-Position: refs/heads/master@{#313093}
[Ozone] Fix building ozone unittests in component build
Symbols used in the unittests need to be exported otherwise they
can't be referenced at link time.
BUG=none
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/876753002
Cr-Commit-Position: refs/heads/master@{#313092}
NaCl: Fix Chromium style warnings in src/trusted/plugin/
This fixes warnings that appear when moving this code into
components/nacl/. (The Chromium style checker is disabled for code
under ppapi/.)
Fix warnings about "override".
Fix warning about NaClSubprocess:
"[chromium-style] Complex constructor has an inlined body".
BUG=239656
TEST=none
Review URL: https://codereview.chromium.org/868273002
Cr-Commit-Position: refs/heads/master@{#313091}
[MemSheriff] Disable two failing tests on Valgrind.
BUG=452077, 452071
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/873343002
Cr-Commit-Position: refs/heads/master@{#313090}
Disable flaky chromevox_tests BackgroundTest.SelectSingleBasic
Looks like this test has failed 41 of the last 200 runs.
BUG=451362
TBR=dtseng
Review URL: https://codereview.chromium.org/879623002
Cr-Commit-Position: refs/heads/master@{#313089}
Disable 2 flaky content_browsertests on Mac.
Disabling FrameTreeBrowserTest.NavigateWithLeftoverFrames and
RenderFrameHostManagerTest.RestoreFileAccessForHistoryNavigation as
they've failed roughly 31 of the last 200 runs on Mac 10.9 bot.
BUG=452018
R=jam
Review URL: https://codereview.chromium.org/877693003
Cr-Commit-Position: refs/heads/master@{#313088}
Chromium side of adding postLoading task to the blink scheduler.
BUG=391005
Review URL: https://codereview.chromium.org/854053003
Cr-Commit-Position: refs/heads/master@{#313087}
[MemSheriff] Disable two tests which are flaky by design.
Previously only disabled on Win.
BUG=396393, 396386
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/880593002
Cr-Commit-Position: refs/heads/master@{#313086}
Expose whether a frame is focused to the browser process
A frame is considered focused if its associated RenderWidgetHost is
focused and it is the focused frame inside its frame tree.
BUG=450634
Review URL: https://codereview.chromium.org/860393004
Cr-Commit-Position: refs/heads/master@{#313085}
Replaces instances of the deprecated TimeTicks::HighResNow() with TimeTicks::Now().
BUG=
Review URL: https://codereview.chromium.org/864943002
Cr-Commit-Position: refs/heads/master@{#313084}
[Android] Provide a logging suppressing context manager
Using this we will be able to write:
with logging_utils.SuppressLogging():
# all but CRITICAL logging messages are suppressed
logging.info('just doing some thing') # not shown
logging.critical('something really bad happened') # still shown
BUG=
Review URL: https://codereview.chromium.org/875083002
Cr-Commit-Position: refs/heads/master@{#313083}
Roll src/third_party/skia dc0f408:1d124c3
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/dc0f408..1d124c3
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/877763002
Cr-Commit-Position: refs/heads/master@{#313082}
Land Recent QUIC Changes.
Remove unused QuicDecrypter::Decrypt method and implementations.
Merge internal change: 84548556
https://codereview.chromium.org/868953002/
Changed verify_details_ check to verify_details_.get() to keep code in
sync with internal source.
Merge internal change: 84442484
https://codereview.chromium.org/872483002/
Removing an obselete TOOD. It is obselte becasue FrameOverlapsBufferedData
does this.
Merge internal change: 84372263
https://codereview.chromium.org/871733002/
Replace the map in QuicAckNotifier with a counter.
No functionality change.
This reduces memory and CPU usage of the ack notifier.
Merge internal change: 84345868
https://codereview.chromium.org/867033002/
Change some of QUIC's AckNotifier datastructures from maps to hashmaps
and sets to lists. No behavior change.
This should reduce CPU consumption substantially, particularly on
internal servers.
Merge internal change: 84156430
https://codereview.chromium.org/870733002/
Add a new RTO connection option to QUIC. Flag protected behind the
existing flag FLAGS_quic_use_new_rto.
This new RTO connection option uses loss detection to reduce the
congestion window after an RTO, instead of always reducing the
CWND to 2.
Merge internal change: 84036848
https://codereview.chromium.org/824693007/
QUIC - sync'ing with internal source tree changes.
Minor change to keep the code similar to chromium and internal tree.
Merge internal change: 83993217
https://codereview.chromium.org/870723002/
Fix a bug in QUIC's RTO. Flag protected by FLAGS_quic_use_new_rto.
Ensures a beta based loss reduction is not triggered directly before
OnRetransmissionTimeout when recovering from RTO.
Merge internal change: 83986840
https://codereview.chromium.org/868813003/
[email protected]
Review URL: https://codereview.chromium.org/868993002
Cr-Commit-Position: refs/heads/master@{#313081}
Add trace rerun options to benchmark and pass them through chartjson.
After discussion with Annie/Dave/Fadi/Kari and myself, seems like we settled on not exposing an arbitrary # of new command lines. Rather, there'd be an optional param to rerun with extra tracing categories enabled. The benchmark would specify that there's a debug option available, and has a way of customizing the exact categories it needs.
Example of v8 benchmark modified:
class V8GarbageCollectionCases(benchmark.Benchmark):
"""Measure V8 metrics on the garbage collection cases."""
def CreateTimelineBasedMeasurementOptions(self):
# TODO(ernstm): Remove v8-overhead when benchmark relevant v8 events become
# available in the 'benchmark' category.
# This can theoretically be handled now by the "default" override
return timeline_based_measurement.Options()
@classmethod
def HasBenchmarkTraceRerunDebugOption(cls):
return True
def SetupBenchmarkDefaultTraceRerunOptions(self, tbm_options):
tbm_options.ExtendTraceCategoryFilters(['v8'])
def SetupBenchmarkDebugTraceRerunOptions(self, tbm_options):
tbm_options.ExtendTraceCategoryFilters(['*'])
BUG=
Review URL: https://codereview.chromium.org/840043004
Cr-Commit-Position: refs/heads/master@{#313080}
media_stream_audio_processor: Default enabled Finch experiments now also applies
The Finch experiments ReplaceAECMWithAEC and UseDelayAgnosticAEC make appropriate changes to webrtc::AudioProcessing at create time. If any of these experiments are enabled by default using a different experiment name (which it should have) the desired config change is not made.
BUG=368175,450193
Review URL: https://codereview.chromium.org/879523003
Cr-Commit-Position: refs/heads/master@{#313079}
Change OK to NO_ERROR in enum ParserError.
Change OK to NO_ERROR in enum ParserError for convergence with server code.
BUG=345769
Review URL: https://codereview.chromium.org/867273002
Cr-Commit-Position: refs/heads/master@{#313078}
components: Cleanup and sort components_unittests deps list.
BUG=None
TEST=components_unittests
[email protected]
Review URL: https://codereview.chromium.org/873083002
Cr-Commit-Position: refs/heads/master@{#313077}
Revert of Revert of Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText (patchset #1 id:1 of https://codereview.chromium.org/821233003/)
Reason for revert:
The regression is fixed in the extension code. It should be safe to land this again.
Original issue's description:
> Revert of Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText (patchset #1 id:1 of https://codereview.chromium.org/851333002/)
>
> Reason for revert:
> This cl caused regression that the backspace-to-decommit feature for both VK and physical keyboard autocorrect.
>
> Original issue's description:
> > Add support for deleting non preceeding surrounding text in chrome.input.ime.deleteSurroundingText
> >
> > Previously, only text before cursor will be removed regardless the value of
> > offset. This CL adds support for deleting text after cursor. We want to this
> > feature in order to implement "set existing word to composition mode" feature
> > when cursor is moved inside an existing word. We want to be able to remove the
> > parts of the existing word before cursor and after cursor first and then call
> > setComposition to set the word to composition mode.
> >
> > Note: this API tries to comform the API spec of ibus delete_surrounding_text
> > here: ibus.googlecode.com/svn/docs/ibus-1.5/IBusInputContext.html#IBusInputContext-delete-surrounding-text
> > A noticible difference is a positive offset value in this API does not take effect.
> >
> > BUG=446249
> >
> > Committed: https://crrev.com/756820cb2c42a7b302a16d24909d820ee18dad0e
> > Cr-Commit-Position: refs/heads/master@{#312113}
>
> [email protected],[email protected]
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=446249
>
> Committed: https://crrev.com/7f17a7758881aa33e8790494b170962bc37e05d8
> Cr-Commit-Position: refs/heads/master@{#312304}
[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=446249
Review URL: https://codereview.chromium.org/868663005
Cr-Commit-Position: refs/heads/master@{#313076}
Updating trunk VERSION from 2288.0 to 2289.0
Cr-Commit-Position: refs/heads/master@{#313075}
Exclude reflector_impl_unittest.cc from GN non-Aura, non-Mac builds.
This fixes the GN build on Android after https://codereview.chromium.org/846063002.
(The GYP build didn't break because content/browser/compositor/ is completely excluded there; see https://code.google.com/p/chromium/codesearch#chromium/src/content/content_tests.gypi&sq=package:chromium&&type=cs&l=1099)
[email protected]
Review URL: https://codereview.chromium.org/879543002
Cr-Commit-Position: refs/heads/master@{#313074}
User class update made independent of profile state update.
BUG=450828
Review URL: https://codereview.chromium.org/866763002
Cr-Commit-Position: refs/heads/master@{#313073}
Fix referrer policy handling in service workers
BUG=450589
[email protected],[email protected]
Review URL: https://codereview.chromium.org/862053002
Cr-Commit-Position: refs/heads/master@{#313072}
Update content_shell to match blink side renames.
This CL updates content_shell to a recent move to the RenderTreeAsText
to be LayoutTreeAsText.
BUG=450612
Review URL: https://codereview.chromium.org/872173002
Cr-Commit-Position: refs/heads/master@{#313071}
[MemSheriff] Suppress, exclude Valgrind failures.
BUG=452002, 451999
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/878603002
Cr-Commit-Position: refs/heads/master@{#313070}
Implement posting location tracking in WebThread
This patch adds two variants for postTask and postDelayedTask which
take the original posting location as a parameter. This mirrors the
similar task posting interface of base::TaskRunner and makes it
possible to trace where tasks are being posted from.
BUG=450977
Review URL: https://codereview.chromium.org/869573005
Cr-Commit-Position: refs/heads/master@{#313069}
Update V8 to version 4.2.28 (based on a7d67a64f11100434b196143e2ba516f8c13697a).
[email protected]
Review URL: https://codereview.chromium.org/872263003
Cr-Commit-Position: refs/heads/master@{#313068}
Revert of Send Windows accessibility events based on tree updates. (patchset #9 id:160001 of https://codereview.chromium.org/848653002/)
Reason for revert:
DumpAccessibilityEventsTest.AccessibilityEventsTextChanged failing frequently on Windows bots. Fails most of the time on Win8 Aura.
Original issue's description:
> Send Windows accessibility events based on tree updates.
>
> The idea of this change is to fire Win AX events
> based on the AX tree changing, rather than based
> on Blink firing the right event and mapping it to a
> Win event.
>
> Store the Win-specific AX attributes (ia role,
> ia state, name, value, etc.) in a struct, and when a
> node is updated, compare the old value of each attribute
> to the new value and fire an appropriate event for each
> one (name changed, state changed, etc.).
>
> Handle hypertext_ similarly, and properly diff the old and new hypertext in get_oldText and get_newText.
>
> This enables all of the "event" tests that were
> previously added to pass now, and it makes live regions
> work correctly in NVDA and JAWS.
>
> BUG=447962
>
> Committed: https://crrev.com/eb691a960bef3c2aefa38627baa7cbdde480b81e
> Cr-Commit-Position: refs/heads/master@{#313052}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447962
Review URL: https://codereview.chromium.org/880523002
Cr-Commit-Position: refs/heads/master@{#313067}
Supervised icon added to unicorn userpods on account picker screen.
BUG=450795
Review URL: https://codereview.chromium.org/869543005
Cr-Commit-Position: refs/heads/master@{#313066}
ChildAccountService: periodically re-fetch parent info; retry on failure
with exponential backoff!
BUG=372381,450828
Review URL: https://codereview.chromium.org/880483002
Cr-Commit-Position: refs/heads/master@{#313065}
[MemSheriff] Exclude/suppress failing tests on DrMemory.
BUG=446256, 451991, 451992, 451988, 293125, 451983
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/875923002
Cr-Commit-Position: refs/heads/master@{#313064}
In-process JSON parsing for web resources on iOS
BUG=447575
Review URL: https://codereview.chromium.org/880433002
Cr-Commit-Position: refs/heads/master@{#313063}
Revert of Isolate extensions_browsertests (patchset #7 id:120001 of https://codereview.chromium.org/869783004/)
Reason for revert:
This CL seem to cause the failure in extension browser test in Windows Vista SP2
Original issue's description:
> Isolate extensions_browsertests
>
> [email protected], [email protected]
> [email protected]
> BUG=98637
>
> Committed: https://crrev.com/d1caf97fe8db47e5c76043bccbf4dd4a42265831
> Cr-Commit-Position: refs/heads/master@{#312993}
[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=98637
Review URL: https://codereview.chromium.org/876633002
Cr-Commit-Position: refs/heads/master@{#313062}
Disable aria-columnheader.html, aria-row.html, aria-rowheader.html, aria-sort.html
Re-baseline after the Blink(crbug.com/451047) change goes in.
BUG=451047
Review URL: https://codereview.chromium.org/873593003
Cr-Commit-Position: refs/heads/master@{#313061}
Exposed mouselock content setting to extensions.
BUG=451024
Review URL: https://codereview.chromium.org/870573002
Cr-Commit-Position: refs/heads/master@{#313060}
Roll src/third_party/skia 5c1dad7:dc0f408
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/5c1dad7..dc0f408
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/871403002
Cr-Commit-Position: refs/heads/master@{#313059}
Directly inline shared WebUI CSS declarations into the security and supervised user interstitials.
BUG=446599,443203
Review URL: https://codereview.chromium.org/830743003
Cr-Commit-Position: refs/heads/master@{#313058}
[memory-inspector] UI fixes + bump version number for release.
BUG=448399
[email protected]
NOTRY=true
Review URL: https://codereview.chromium.org/867263002
Cr-Commit-Position: refs/heads/master@{#313057}
Fixes and reenables SystemUse24HourClockPolicyTest
Adds code which attempts to exit by closing all browser instances and gracefully shuts down the test.
BUG=450651
Review URL: https://codereview.chromium.org/874933002
Cr-Commit-Position: refs/heads/master@{#313056}
Reland of Migrate DeviceUtils.ReadFile to adb_wrapper (try 3)
Original description:
The implementation is based on a simple 'cat' run by shell on the
device (with optional as_root).
Interface changes:
- The return value is a string (instead of a list of lines).
- An exception is raised if the file cannot be read
(instead of returning an empty list).
Previous CLs:
- https://codereview.chromium.org/794583004/
- https://codereview.chromium.org/775333002/
BUG=267773
Review URL: https://codereview.chromium.org/806843002
Cr-Commit-Position: refs/heads/master@{#313055}
Increase AsyncExtensionSettingsWebUITest.testDeveloperModeA11y timout.
Increasing timeout (again) to see if it helps with the DrMemory test
failures.
NOTRY=true
TBR=finnur
BUG=451299
Review URL: https://codereview.chromium.org/878533002
Cr-Commit-Position: refs/heads/master@{#313054}
Credential Manager API: Showing both local and federated logins.
Showing both local and federated logins and passing information about
type of credentials choosing by user back to blink.
BUG=400674
[email protected],[email protected]
Review URL: https://codereview.chromium.org/848723002
Cr-Commit-Position: refs/heads/master@{#313053}
Send Windows accessibility events based on tree updates.
The idea of this change is to fire Win AX events
based on the AX tree changing, rather than based
on Blink firing the right event and mapping it to a
Win event.
Store the Win-specific AX attributes (ia role,
ia state, name, value, etc.) in a struct, and when a
node is updated, compare the old value of each attribute
to the new value and fire an appropriate event for each
one (name changed, state changed, etc.).
Handle hypertext_ similarly, and properly diff the old and new hypertext in get_oldText and get_newText.
This enables all of the "event" tests that were
previously added to pass now, and it makes live regions
work correctly in NVDA and JAWS.
BUG=447962
Review URL: https://codereview.chromium.org/848653002
Cr-Commit-Position: refs/heads/master@{#313052}
Allow universal access from file if flag is set and url is file scheme.
BUG=449075
TEST=content_unittests --gtest_filter=NavigationControllerTest.IsInPageNavigation
Review URL: https://codereview.chromium.org/855883002
Cr-Commit-Position: refs/heads/master@{#313051}
UMA histogram: Corrects misspelled histogram name
The UMA stat WebRTC.AecDelayBasedQuality was not logged due to a misspelling.
Correct name https://code.google.com/p/chromium/codesearch#chromium/src/tools/metrics/histograms/histograms.xml&q=AecDelay&sq=package:chromium&type=cs&l=41307
BUG=N/A
[email protected]
Review URL: https://codereview.chromium.org/867233002
Cr-Commit-Position: refs/heads/master@{#313050}
Roll src/third_party/skia 96a857e:5c1dad7
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/96a857e..5c1dad7
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
[email protected]
Review URL: https://codereview.chromium.org/868453003
Cr-Commit-Position: refs/heads/master@{#313049}
Added test for proxy auth dialog on sign-in screen.
BUG=330607
TEST=browser_tests:ProxyAuthOnUserBoardScreenTest.*
Review URL: https://codereview.chromium.org/869993003
Cr-Commit-Position: refs/heads/master@{#313048}
Re-enabling fixed CanMakeEmptyCallThenAddStreamsAndRenegotiate test.
BUG=293125
Review URL: https://codereview.chromium.org/877433002
Cr-Commit-Position: refs/heads/master@{#313047}
