Please provide this for all skins. We do not want the functionality of the skins to deviate.

bug 24659 asks for WAI ARIA stuff to be allowed in wiki text. That may help with allowing it for skins, too.

jp.posma wrote:

WAI-ARIA landmark roles

In fact these landmark roles can be used for all skins. Included them in mediawiki.utils.js.

Apply to trunk/phase3.

Attached:

Any reason we're not hardcoding them? Afaik, a few screen readers ignore Javascript

peter.krantz wrote:

(In reply to comment #4)

Any reason we're not hardcoding them? Afaik, a few screen readers ignore
Javascript

Screenreders do not ignore javascript, but it is better to code them straight into the HTML. Only problem is with sensitive people who favor validation above accessibility therefore the javascript.

But real attributes in markup is a better option.

Doing this straight in the HTML would indeed be better, though the JS should usually work.

We should however actually research *AND TEST* this with actual screen readers.

ayg wrote:

We should definitely add this to the HTML output, not just via JS. The role attribute is valid in HTML5. I'd also say we should test this with actual screen readers before adding the roles, though, to make sure we understand what effect they're having.

sumanah wrote:

Jan Paul, do you have time to revise the patch to integrate the review and suggestions here?

I've created a change that add these role directly in skins:
https://gerrit.wikimedia.org/r/#/c/27734/

It's not valid in XHTML 1.0 but jQuery UI already use it without any problem.

(In reply to comment #9)

I've created a change that add these role directly in skins:
https://gerrit.wikimedia.org/r/#/c/27734/

Status Merged

Potential regression of this commit: see bug 42394.
Thomaspt: Could you take a look?

As of T44394: After introduction of WAI ARIA roles, VoiceOver is extremely slow task description change by @MattFitzpatrick today, possible connection change introduced by current task.