Bug 92029 - should prevent autocorrecting into opening quote when typing 's or 't in Dutch
Summary: should prevent autocorrecting into opening quote when typing 's or 't in Dutch
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: Other All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:25.2.0 target:24.8.0.0.beta2
Keywords:
Depends on:
Blocks: AutoCorrect-Complete
  Show dependency treegraph
 
Reported: 2015-06-12 09:51 UTC by Pierre François
Modified: 2024-06-30 13:06 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre François 2015-06-12 09:51:53 UTC
In Dutch (in Belgium as in the Netherlands), when you type "'s" or "'t" in sentences like: "Ik ben 's morgens opgestaan", the apostrophe is changed into an opening quote by the autocorrect feature, which is incorrect and requires a manual correction.

There are two cases possible:

a) The buggy behaviour happens when Tools > AutoCorrect Options... > Localized Options > Single Quotes > Enabled is checked.

This behaviour can be corrected by editing the file DocumentList.xml contained in the ZIP containers as explained below:

/usr/lib/libreoffice/share/autocorr/acor_nl-BE.dat
/usr/lib/libreoffice/share/autocorr/acor_nl-NL.dat

b) When the Single Quotes > Enabled option above is not checked, there is no buggy behaviour, but it is still recommended to autocorrect the introduction of the U+0027 character (apostrophe) into the U+02BC character, for aesthetical reasons.

So two rules must be added for "'s" and two for "'t", in order the changes to work in both cases, a) and b).

Therefor, the changes I suggest for the DocumentList.xml file inside the ZIP containers mentioned above consist in adding four "block-list:block" nodes on the right place into it with next content:

<block-list:block block-list:abbreviated-name="&apos;s" block-list:name="ʼs"/><block-list:block block-list:abbreviated-name="&apos;t" block-list:name="ʼt"/><block-list:block block-list:abbreviated-name="‘s" block-list:name="’s"/><block-list:block block-list:abbreviated-name="‘t" block-list:name="’t"/>
Comment 1 Buovjaga 2015-06-13 14:24:19 UTC
Sounds like a reasonable suggestion -> NEW.
Comment 2 Commit Notification 2024-06-27 21:07:52 UTC
László Németh committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8fc2fd284bca88d491ff5975a7110c188344976b

tdf#92029 AutoCorrect: correct 's and 't in Dutch to apostrophe

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 László Németh 2024-06-27 23:24:27 UTC
Fixed in master, started back-porting to 24.8.

@Pierre François and all: thanks for the bug report and feedback!

Commit description:

df#92029 AutoCorrect: correct 's and 't in Dutch to apostrophe

“In Dutch (in Belgium as in the Netherlands), when you type "'s"
or "'t" in sentences like: "Ik ben 's morgens opgestaan", the
apostrophe is changed into an opening quote by the autocorrect
feature, which is incorrect and requires a manual correction.”

The bug reported with the suggested AutoCorrect extension
by Pierre François. The difference here is always to use the
de facto standard typographic apostrophe in the replacement.
Comment 4 Commit Notification 2024-06-28 19:24:51 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/93987194f5dee2b917e32c18b8a377be95f0ab71

tdf#92029: sw_autocorrect: Add unittest

It will be available in 25.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2024-06-29 09:33:40 UTC
László Németh committed a patch related to this issue.
It has been pushed to "libreoffice-24-8":

https://git.libreoffice.org/core/commit/d41604c16054e8e64aa4cd818ff252325f3eac58

tdf#92029 AutoCorrect: correct 's and 't in Dutch to apostrophe

It will be available in 24.8.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.