Created attachment 193493 [details] preview with more than 7 columns and only 4 different colors First, select more than 4 columns to view in a chart. While generating a chart, in chart wizard we select first or at any time "Stock chart". Next, still in the same chart wizard, just with preview chart, without chart, change to chart Column, bar ... The result is only 4 colors for the columns : the fourth one is cyan and repeated for all last columns. It failed on versions : windows 1124.2.2.2 and lunbuntu 22.04 7.3.7.2.
Please attach a sample file, reduce the size as much as possible without private information, and paste the information in Menu/Help/About LibreOffice, there is a copy icon.
Version: 24.2.2.2 (X86_64) / LibreOffice Community Build ID: d56cc158d8a96260b836f100ef4b4ef25d6f1a01 CPU threads: 8; OS: Windows 10.0 Build 22631; UI render: Skia/Raster; VCL: win Locale: fr-FR (fr_FR); UI: fr-FR Calc: CL threaded
Version: 7.3.7.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 4; OS: Linux 6.2; UI render: default; VCL: qt5 (cairo+xcb) Locale: fr-FR (fr_FR.UTF-8); UI: en-US Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.4 Calc: threaded
Still waiting for a sample file.
Created attachment 194681 [details] File with data an graphic error Hello, I send you a basi sample of error color for the graphic generated, with same color for several columns. Process : start beginning the graphic, while previiew click on all possible optios of graphics and tuen back to the first view option. Generate the graphic. See the result inside the .calc file. Best Regards B.R.
One more: As I preview my calc file, graphic is ok. You must follow the steps I send you to generate the bug. Best Regards Bernard
I said preview the attach file : I talk about Created attachment 194681 [details] If you want a demo of the bug, We can make a visio, it could be more simple. Best Regard Bernard
Thanks, I have found out the responsible commit. I will investigate a bit more.
Bibisected with linux-64-7.0 to 337a9a454c1bc95214111578d3f9c0622c55c509 use for-range on Sequence in chart2 The commit changes dozens of files, so it is difficult to figure out which one is relevant. Purely by guessing, I tried reverting the changes to chart2/source/tools/ConfigColorScheme.cxx (involving also a later commit), but it did not get rid of the issue. Probably debugging is needed. Steps: 1. Open attachment 194681 [details] 2. Click Insert Chart in toolbar, observe the column colours in the preview 3. Click Stock in the chart type list 4. Click back to Column
Did some brute force debugging on the files modified in the commit (first broad strokes with 'rbreak path/to/file:.' for one file at a time) and so far I found this loop is hit when switching from Column to Stock: https://opengrok.libreoffice.org/xref/core/chart2/source/model/template/ChartType.cxx#205
Also hit: https://opengrok.libreoffice.org/xref/core/chart2/source/model/template/ChartTypeTemplate.cxx#219 https://opengrok.libreoffice.org/xref/core/chart2/source/model/template/ChartTypeTemplate.cxx#230 https://opengrok.libreoffice.org/xref/core/chart2/source/model/template/ChartTypeTemplate.cxx#430 https://opengrok.libreoffice.org/xref/core/chart2/source/model/template/ChartTypeTemplate.cxx#550 https://opengrok.libreoffice.org/xref/core/chart2/source/model/template/ChartTypeTemplate.cxx#671 https://opengrok.libreoffice.org/xref/core/chart2/source/model/template/ChartTypeTemplate.cxx#805 So it's quite a lot unfortunately :( (and I didn't yet check the rest)
buovjaga, so, when I want to track down which part of a larger patch caused a bug, what I do (*) first do a revert, and fix up any merging issues. (*) Then I make a patch out of the revert (git format-patch -1). (*) Then I apply that patch (git apply foo). (*) Then I reset half of the files modified. Then I test that. (*) Depending on if that works our not, I know which half of patch caused the bug. (*) Then I repeat, doing cutting the affected files in half until I find the file that caused the problem. (*) Then I reset only part of the file, and repeat until I find the smallest chunk that caused the problem.
(In reply to Noel Grandin from comment #12) > buovjaga, so, when I want to track down which part of a larger patch caused > a bug, what I do > (*) first do a revert, and fix up any merging issues. > (*) Then I make a patch out of the revert (git format-patch -1). > (*) Then I apply that patch (git apply foo). > (*) Then I reset half of the files modified. Then I test that. > (*) Depending on if that works our not, I know which half of patch caused > the bug. > (*) Then I repeat, doing cutting the affected files in half until I find the > file that caused the problem. > (*) Then I reset only part of the file, and repeat until I find the smallest > chunk that caused the problem. It sounds good, but in this case there is an insane number of merging issues :)
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/013282b1421c0bba66ef54ccbfe4a649a4b97628 tdf#160522 Chart > 4 columns, Only 4 colors It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/d186dd8958a5f28abcf6da8af63f8e597861305b tdf#160522 Chart > 4 columns, Only 4 colors It will be available in 24.8.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "libreoffice-24-2": https://git.libreoffice.org/core/commit/0b0b46770cf97a82c2565269fe293462312aec20 tdf#160522 Chart > 4 columns, Only 4 colors It will be available in 24.2.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified, thanks! Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: cfffcbc39b2c6794eaeddae5134fb59848a76d41 CPU threads: 8; OS: Linux 6.9; UI render: default; VCL: kf6 (cairo+wayland) Locale: fi-FI (fi_FI.UTF-8); UI: en-US Calc: CL threaded