Provides syntax highlighting in wikitext editor (homepage)
Not to be confused with SyntaxHighlight
syntax highlighting when editing JS, CSS, JSON and Lua pages currently uses CodeEditor instead.
Provides syntax highlighting in wikitext editor (homepage)
Not to be confused with SyntaxHighlight
syntax highlighting when editing JS, CSS, JSON and Lua pages currently uses CodeEditor instead.
Is this ready to be re-added to Tech News this week? (Prior removal diff for reuse). Thanks!
@MusikAnimal Let me know if the videos below are fine. I do have an unrelated issue that I also wanted you to check out regarding a weird alignment issue in dark mode for source editing but light mode was fine?
We are having quite the struggle over at T357482: 2017 wikitext editor integration in CodeMirror 6. Unless we get everything fixed in a timely fashion, I'm going to shift our target deployment date to align with MW 1.43, when CodeMirror 5 is supposed to be formally deprecated. So, the new goal is sometime in November 2024. This is better I think anyway because the other features of CM6 should be in place by then, and more importantly the ability to toggle them on and off (T359498). This way, when our users finally get CM6, it's a big giant "wow" moment, and there should be no complaints as all features are off by default (except line numbering, see T347211). And of course, all this extra times mean more quality assurance, too.
I'd also like to invite @Esanders to this task now that he is back from sabbatical. He authored the original integration, so maybe he'll have some helpful insight. To Ed: rest assured that I am keeping my promise of not shipping a broken 2017 editor :)
In T357482#10121607, Bhsd wrote:Using the same article that dom_walden mentions, I see misalignment with hyphen-related line wrapping on L174, and the problem is only present in CM6.
Re-ran the job, and it published: https://doc.wikimedia.org/CodeMirror/master/js/js/
Mentioned in SAL (#wikimedia-releng) [2024-09-06T14:21:34Z] <James_F> jforrester@integration-castor05:/srv/castor$ sudo -u jenkins-deploy rm -rf /srv/castor/castor-mw-ext-and-skins/master/mwext-node18-docs-publish/ # T373937
I'll manually delete the cache for this job and see if that helps.
In T357482#10112821, @Bhsd wrote:... By the way, I notice that the misalignment also appears when switching between LTR and RTL.
Okay, I'm going to postpone deployment, then. It sounds like these issues need to be fixed, first.
Using the same article that dom_walden mentions, I see misalignment with hyphen-related line wrapping on L174, and the problem is only present in CM6.
In T357482#10119540, @MusikAnimal wrote:I've been able to reproduce some misalignment in Sauce Labs, but it appeared to be a result of the same issue described at T357482#10114702, where a line wrap happens at a hyphen in CodeMirror, but not in the VE surface. Could you scroll up a bit on Beta and see if the issue is also due to line breaks and hyphens for you?