Principal software engineer at WMF
User Details
- User Since
- Nov 6 2014, 11:05 PM (512 w, 11 h)
- Availability
- Available
- IRC Nick
- jdlrobson
- LDAP User
- Unknown
- MediaWiki User
- Jdlrobson [ Global Accounts ]
Today
Should these patches be reverted?
I believe this is just something we never got round to doing.
Yesterday
Marking as stalled as this looks like a placeholder for now. I assume this will be fleshed out later.
I suggest this might be best resolved by also applying a min-width: 200px; to the h1 or a max-width to the indicators? Even without the word-break, this display looks undesirable? cc @JScherer-WMF
I think this should be "medium" priority, but even with the arrows inverted, they can be difficult to read. perhaps they also need an outline? Please have a look and move to "Groomed" once you think this bug is well defined. Thanks in advance!
If Russian Wikipedia want to do this they should feel free to do this as part of the https://wikitech.wikimedia.org/wiki/Wikimedia_site_requests once it has been discussed publicly on wiki. Feel free to reach out to the web team if you need any assistance.
Jan: Could you update this ticket to use the task template and move it to groomed? I assume this work entails updating the portal to use Codex design tokens and CSS variables? Is that accurate?
This would make for some very hard to maintain code - the code is already pretty complex given the behaviour being different on different pages. I would prefer us to find another way to solve this problem if possible.
Jan to expand on questions that came up during our estimation today.
Perfect! Thank you!
To summarize the discussion:
- When adding a new gadget to the site that is default for anonymous users this requires updating the HTML of the page
- The HTML of the page is cached for up to 24 hrs in Varnish
- In addition to this Apache Traffic Server (ATC) checks If-Modified headers and will serve an older version of the page if they are still valid
- A page can be served from ATC typically up to 2 weeks.
- Existing gadgets / site CSS are already in the page HTML so is not subject to this cache. They instead are subject to a ResourceLoader cache which is a much shorter period of time.
- This means pages served from ATC / Varnish do not have the new gadget and thus the new styles are loading, but the site styles where the CSS was removed are - this resulted in the infoboxes not being styled in these pages.
@ovasileva yes. See https://www.mediawiki.org/wiki/Extension:QuickSurveys#Defining_an_audience for what's currently supported.
@jwang if we just logged total numbers of impressions for the following would that be sufficient, or do you need session Ids and additional information e.g. browser resolution?
@Gehel the web team isn't responsible for this code so I've untagged web backlog: https://gerrit.wikimedia.org/g/mediawiki/core/+/f78d2f950d6a8a5b8f8bbf57c027e77d450d06f0/resources/src/mediawiki.special.search.interwikiwidget.styles.less
@Jgiannelos https://en.wikipedia.beta.wmflabs.org/api/rest_v1/page/summary/Polar_bear is still not resolving. I'm getting "Our servers are currently under maintenance or experiencing a technical problem. Please try again in a few minutes." Should I open a new ticket?
Wed, Aug 28
Needs code reviewer assigned.
Okay there are a few issues with task:
- QuickSurveys don't go through translatewiki so we'll need the copy in Spanish for these surveys before we can work on this!
- Looking through the survey proposed won't actually work - external surveys need a yes and no answer. Is that okay? Currently the requirements suggest a "Next" and only a "Yes" button.
- It's not clear what the privacy policy text should be - this needs to be in the ticket!
After talking about this with the team, we'll move this to next sprint when we have access to the browser extension URL. This will minimize the likelihood of mistakes.
From my experience it's really difficult to find someone willing to merge patches to Flow so I wouldn't want a volunteer to spend time on this for nothing.
Yes this one is not completely fixed. It will need a follow up ticket and stay open. Thanks for confirming that!