Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall we define transport concept? #191

Closed
yutakahirano opened this issue Feb 9, 2021 · 2 comments
Closed

Shall we define transport concept? #191

yutakahirano opened this issue Feb 9, 2021 · 2 comments

Comments

@yutakahirano
Copy link
Contributor

yutakahirano commented Feb 9, 2021

Hi, I'm wondering if we want to define concept-transport, like we have concept-request and Request class
in the fetch spec. Such a separation would be good for describing things like #152. Issues like #185, #128, #79, #93 are related.

I'm thinking about something like acf10ee (for #152 and #185; still WIP).

What do people think?

@aboba @jan-ivar

@yutakahirano yutakahirano changed the title Shell we define transport concept? Shall we define transport concept? Feb 9, 2021
@jan-ivar
Copy link
Member

jan-ivar commented Feb 9, 2021

I'm not sure request is the right concept. That's a JS input object to fetch, we have no such input. From your patch, this sounds like the datagram writable's underlying sink. But other specs seem to make due without actually defining the underlying sink/source as concepts, because there's usually a 1-1 higher-level browser object to attach the [[internal slots]] to.

Even fetch does this: "9. Let pullAlgorithm be an action that resumes the ongoing fetch if it is suspended. ... 13. Let stream be the result of creating a ReadableStream with pullAlgorithm set to pullAlgorithm ..."

I would try it without abstractions first, as I think there's only 4 algorithms.

I would model this on https://w3c.github.io/webrtc-insertable-streams/#stream-creation by hanging all our algorithms off of stream creation of the various streams we create.

@yutakahirano
Copy link
Contributor Author

Makes sense, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants