[css-view-transition-2] Clarify timeout behavior for inbound view transition #10817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwoodrow
added a commit
to mattwoodrow/WebKit
that referenced
this pull request
Sep 3, 2024
https://bugs.webkit.org/show_bug.cgi?id=279044 <rdar://135166838> Reviewed by NOBODY (OOPS!). w3c/csswg-drafts#10817 There should be a timeout, starting from before the page swap event is fired. This implements half of the resolution, making sure we don't provide a view transition to pagereveal if it takes too long. * LayoutTests/TestExpectations: * Source/WebCore/dom/Document.cpp: (WebCore::Document::dispatchPageswapEvent): * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::resolveInboundCrossDocumentViewTransition): * Source/WebCore/dom/ViewTransition.h:
mattwoodrow
added a commit
to mattwoodrow/WebKit
that referenced
this pull request
Sep 3, 2024
https://bugs.webkit.org/show_bug.cgi?id=279044 <rdar://135166838> Reviewed by NOBODY (OOPS!). w3c/csswg-drafts#10817 There should be a timeout, starting from before the page swap event is fired. This implements half of the resolution, making sure we don't provide a view transition to pagereveal if it takes too long. * LayoutTests/TestExpectations: * Source/WebCore/dom/Document.cpp: (WebCore::Document::dispatchPageswapEvent): * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::resolveInboundCrossDocumentViewTransition): * Source/WebCore/dom/ViewTransition.h:
webkit-commit-queue
pushed a commit
to mattwoodrow/WebKit
that referenced
this pull request
Sep 3, 2024
https://bugs.webkit.org/show_bug.cgi?id=279044 <rdar://135166838> Reviewed by Tim Nguyen. w3c/csswg-drafts#10817 There should be a timeout, starting from before the page swap event is fired. This implements half of the resolution, making sure we don't provide a view transition to pagereveal if it takes too long. * LayoutTests/TestExpectations: * Source/WebCore/dom/Document.cpp: (WebCore::Document::dispatchPageswapEvent): * Source/WebCore/dom/ViewTransition.cpp: (WebCore::ViewTransition::resolveInboundCrossDocumentViewTransition): * Source/WebCore/dom/ViewTransition.h: Canonical link: https://commits.webkit.org/283113@main
css-view-transitions-2/Overview.bs
Outdated
| @@ -875,6 +875,9 @@ It has the following [=struct/items=]: | |||
|
|
|||
| : <dfn>initial snapshot containing block size</dfn> | |||
| :: a [=tuple=] of two numbers (width and height). | |||
|
|
|||
| : <dfn>resolved transition</dfn> | |||
There was a problem hiding this comment.
This doesn't look right. This data structure is meant to be serialized across Documents and I don't think we can or want to serialize the script "ViewTransition" object?
…nsition The previous wording of this was somewhat handwavy, made it more rigorous. - The timeout starts when the transition is created (before pageswap) - If the timeout expires before the transition is resolved (pagereveal), the inbound transition params are cleared and the behavior is similar to having the transition skipped at pageswap. - If the timeout expires while the navigation is active, it is skipped with a `TimeoutError`. Closes w3c#10800
3e18d12
to
288762f
Compare
khushalsagar
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous wording of this was somewhat handwavy, made it more rigorous.
TimeoutError.Closes #10800