-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-typed-om] Fill out TODO in toColor(colorspace)
#1031
Comments
I added a new Converting between predefined RGB color spaces section to CSS Color 4, because expecting people to concatenate So that would be a suitable reference for the conversion here. |
That was a TODO because the structure was still a little uncertain at the time; now that we've dropped a lot of the complexity I fixed up the class definition, and that TODO can be filled in properly now. |
Where is the fixed-up definition? Type OM has only one commit in 2021, in January. |
ARGH MY LOCAL REPO WAS STILL PUSHING TO MASTER Sorry, fixed, main is updated and pushed now. |
In 4.6 CSSColorValue objects, the
toColor(colorspace)
method states:This should be expanded out, at least to the basic level of detail of the other
toFoo
methods on the same object.Suggested minimal text (still lacking references to how to actually do this):
The text was updated successfully, but these errors were encountered: