Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VK Company Feedback] OneTap widgets #148

Closed
NekR opened this issue Nov 14, 2021 · 10 comments
Closed

[VK Company Feedback] OneTap widgets #148

NekR opened this issue Nov 14, 2021 · 10 comments

Comments

@NekR
Copy link

NekR commented Nov 14, 2021

Hello!

I saw a few mentions of OneTap widgets in the docs, but wasn't able to found proposals about it.
Closest thing I saw is this mock for Mediation-oriented API: https://github.com/WICG/FedCM/blob/main/explainer/static/mock40.gif
It looks just like OneTap on mobile. Is it meant to be exactly that and if so, what would be it's UI on desktop?

@dj2
Copy link
Collaborator

dj2 commented Nov 15, 2021

The OneTap widget is an existing widget. You can see more information about it on https://developers.google.com/identity/gsi/web. There is also a use case with the FedIDCG which details some more information and provides links to examples: fedidcg/use-case-library#12

@NekR
Copy link
Author

NekR commented Nov 15, 2021

The OneTap widget is an existing widget. You can see more information about it on https://developers.google.com/identity/gsi/web.

That's a widget from Google. We're looking into continue having our OneTap widgets working properly once third-party cookie are gone.

There is also a use case with the FedIDCG which details some more information and provides links to examples: fedidcg/use-case-library#12

Can you please help navigate me to the best place to provide feedback about OneTap widgets (them being gone with third-party cookie, them being needed after that fact, etc.)? Maybe it's that issue or maybe we better continue here.

@NekR NekR changed the title OneTap widgets [VK Company Feedback] OneTap widgets Nov 15, 2021
@dj2
Copy link
Collaborator

dj2 commented Nov 15, 2021

Sorry, I provided the Google example as that's the OneTap widget I know. If you have a separate one, and can share what it is, we'd love to hear about it.

The first step for the OneTap question is, does the use case I linked above match up to how your OneTap widget works? We believe it's correct, and it matches the Google case, but if it doesn't match your case can you please add comments as to what is different / won't work? We're working off the use case to determine if our mediation flow will work correctly. Any feedback on the use cases (or if you want to file new issues with the FedID-CG listing other use cases) would be greatly appreciated.

Our mediation flow, and the API you can see in #145 is, we think, sufficient for OneTap widgets to continue to function post third-party cookie deprecation. We're working on updating Chrome to use the new API, it's currently on an older version of the API that didn't follow the Credential Management API spec as the new one does.

@samuelgoto
Copy link
Collaborator

We're looking into continue having our OneTap widgets working properly once third-party cookie are gone.

Ah, interesting! Could you share with us a link of how yours work?

@NekR
Copy link
Author

NekR commented Feb 13, 2022

The first step for the OneTap question is, does the use case I linked above match up to how your OneTap widget works?

In more general use case, yes. But there are details which should be covered to understand if it works for all the cases.
I wrote some questions here: fedidcg/use-case-library#12

Our mediation flow, and the API you can see in #145 is, we think, sufficient for OneTap widgets to continue to function post third-party cookie deprecation.

As far as I understand, it covers only "popover over website" OneTap case, but there are cases for inline/in-markup OneTap, basically what is done with <iframe> nowdays. Demo here: https://youtu.be/sbCU12GrMP8 and on the picture below.

Also, the "OneTap" in some cases may need to open a "popup" to the user with additional UI: scopes, additional registration steps user needs to finish, e.g. website integrating OneTap requires phone number but user haven't specified it yet, etc. Right now there are several ways to open such UI: a new window popup, e.g. window.open(), a new tab popup (window.open() too) and current tab navigation. With the built-in browser UI involved, I suppose a native popup over current page might be enough, but sometimes for people who integrate the "OneTap" and IDP Auth in general -- a redirect on current page is more friendly. I do not remember exact details, but it maybe something like "all other our system work that way already" and "we do not want this data to showup in JavaScript, but rather directly on backend".
Demo of opening a popup from OneTap is also on the video above.

Ah, interesting! Could you share with us a link of how yours work?

Better! A screenshot :) (and the video above)
Screenshot 2022-02-11 at 17 08 15

P.S.
I also left my feedback here fedidcg/use-case-library#10 (comment), since it seems relevant.

@samuelgoto
Copy link
Collaborator

Oh, that does look like a good candidate for the account chooser that we built!

@NekR any chance you could hop into one of the FedID CG calls to walk us through how your product works?

@NekR
Copy link
Author

NekR commented Feb 16, 2022

@samuelgoto yeah, sure. Where should I start to get there?

@samuelgoto
Copy link
Collaborator

@hlflanagan would know best, but I think it involves:

  1. joining the FedID CG by clicking here
  2. getting yourself into the agenda of one of the meetings in this schedule

Any chance that would work?

@hlflanagan
Copy link
Contributor

After you join, I can send you the Slack invite, too.

@tttzach
Copy link
Collaborator

tttzach commented May 9, 2024

Closing this issue for now. Feel free to file a new issue or hop on a FedIDCG call with us whenever you're ready.

@tttzach tttzach closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants