You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#584 and #588 showed decreases in test coverage that should be rectified. See their respective codecov results here and here for more information on the files affected. @mperrin suggested that at least some of the uncovered code (particularly new functions in trending.py) doesn't actually need tests and can instead take a # pragma : no cover comment in the appropriate places.
The text was updated successfully, but these errors were encountered:
@ojustino@BradleySappington I noticed this quite old and somewhat vague issue about test coverage. I'm not sure whether there's value in keeping open this stale issue any longer? What do you think? We could perhaps set up separate issues about improving test coverage for specific parts of the code, perhaps.
I think targeted issues for increased coverage on certain files is probably the ideal solution. Tangible steps that can be grabbed by anyone who is capable of understanding the file in need. @ojustino, what are your thoughts?
I agree with both of you about favoring targeted issues for matters like these. This ticket's goal was to keep us honest after hurrying in some eleventh-hour updates to v1.1.0.
#584 and #588 showed decreases in test coverage that should be rectified. See their respective codecov results here and here for more information on the files affected. @mperrin suggested that at least some of the uncovered code (particularly new functions in
trending.py
) doesn't actually need tests and can instead take a# pragma : no cover
comment in the appropriate places.The text was updated successfully, but these errors were encountered: