Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a conversation between two participants - (Works only for direct messages) #235

Open
pmochine opened this issue Jan 15, 2020 · 7 comments

Comments

@pmochine
Copy link
Contributor

pmochine commented Jan 15, 2020

Sorry, I'm too lazy to change the readme and to pull it here. But I'm currently migrating to the newest version and I was struggling why

$conversation = Chat::conversations()->between($participantModel1, $participantModel2)

is not working. It's because between sets the direct message to true. Would be nice to have a hint in the readme

@pmochine
Copy link
Contributor Author

I just tried testing the common function, and before that I looked at your code and could not find it anywhere. Nonetheless here is an example:

return \Chat::conversations()->common([$order->seller, $order->buyer]);

leads to:

Call to undefined method Musonza\Chat\Services\ConversationService::common()

@musonza
Copy link
Owner

musonza commented Jan 16, 2020

Hey, yeah that's a method that's no longer in this version. I have to update the readme

@pmochine
Copy link
Contributor Author

Hey, yeah that's a method that's no longer in this version. I have to update the readme

Thanks :)

@theMSY
Copy link

theMSY commented Mar 2, 2020

Hey, yeah that's a method that's no longer in this version. I have to update the readme

Hey @musonza
Can I ask you why it was removed?

@musonza
Copy link
Owner

musonza commented Mar 2, 2020

@theMSY I believe it was giving incorrect results since I had implemented it with user ids only. It needed work and I didn't have time but if you need it I would be glad to help if you have a PR started

@theMSY
Copy link

theMSY commented Mar 2, 2020

, it sounds like an opportunity to contribute. I would gladly help to implement it once I'm free. 😄

@nyoumi
Copy link

nyoumi commented Oct 19, 2021

hello, have you correct it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants