-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get a conversation between two participants - (Works only for direct messages) #235
Comments
I just tried testing the
leads to:
|
Hey, yeah that's a method that's no longer in this version. I have to update the readme |
Thanks :) |
Hey @musonza |
@theMSY I believe it was giving incorrect results since I had implemented it with user ids only. It needed work and I didn't have time but if you need it I would be glad to help if you have a PR started |
, it sounds like an opportunity to contribute. I would gladly help to implement it once I'm free. 😄 |
hello, have you correct it? |
Sorry, I'm too lazy to change the readme and to pull it here. But I'm currently migrating to the newest version and I was struggling why
$conversation = Chat::conversations()->between($participantModel1, $participantModel2)
is not working. It's because
between
sets the direct message to true. Would be nice to have a hint in the readmeThe text was updated successfully, but these errors were encountered: