Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License #8

Closed
theSpool opened this issue Jun 7, 2020 · 6 comments · Fixed by #12
Closed

License #8

theSpool opened this issue Jun 7, 2020 · 6 comments · Fixed by #12

Comments

@theSpool
Copy link

theSpool commented Jun 7, 2020

I noticed this repo and mtasa-resources don't have a license. I was looking to add a file from AMXModX, which is GPL 3.0. (namely a slightly old version of format.cpp, which is used by SA-MP to format strings in custom versions of the printf and format. The natives provided by amx_ConsoleInit are not actually used). mtasa-blue is GPL 3.0, so my assumption is that everything here also is GPL 3.0, but I'm not 100% if that's the case. It would be ideal to specify the license ASAP to avoid any problems if we want to use external stuff.

On the other hand, AMX/Pawn uses the "zLib/libpng" license which is very permissive (and therefore GPL compatible), so no problems on that regard.

As a side note, I realized SA-MP violates GPL because it doesn't publicly provide the source of this file!

@qaisjp
Copy link
Contributor

qaisjp commented Jun 7, 2020

Heh, yes, this is a little complicated.

Some more context:

And more complicated context:

Tricky!

@theSpool
Copy link
Author

theSpool commented Jun 7, 2020

Apparently this is also the zlib/libpng license, so it should be compatible as well.

Then I think it's a safe assumption that mta-resources is licensed as MIT. That said, the both licenses that are known as "MIT License" are compatible with GPL.

  • Since all modules link in with MTA, which is GPL licensed, surely all modules are bound by the GPL?

Well then, I guess that alone settles it. The repo (this one at least) should be then licensed as GPL 3.0

@sbx320
Copy link
Member

sbx320 commented Jun 7, 2020

Another bonus: The old modules project referenced the GPL in Google Code, but the repo then continued to have LICENSE files referring to MIT/zlib licenses for the individual modules. However amx wasn't included in that repository. I'm not quite sure where the old amx module code was located.

Since all modules link in with MTA, which is GPL licensed, surely all modules are bound by the GPL?

No. Modules are derivatives of the publicsdk (zlib license). The modules do not link to MTA itself and are hence not convered by the GPL.

As a side note, I realized SA-MP violates GPL because it doesn't publicly provide the source of this file!

That's assuming the file was originally GPL licensed. For example, something that's MIT licensed can be relicensed under GPL later on, without affecting old copies.

@qaisjp
Copy link
Contributor

qaisjp commented Jun 7, 2020

Reading very carefully, here's the difference between the publicsdk license and the zlib license.

Specifically the phrase "including commercial applications" vs. "excluding commercial applications"...

https://gist.github.com/qaisjp/84d97501642f95d0d70ef9f6669a1256/revisions?short_path=53e892b#diff-53e892b8b41cc4caece1cfd5ef21d6e7

@theSpool
Copy link
Author

theSpool commented Jun 7, 2020

Boy...

What now then? To be honest I don't feel very comfortable working without a License. The publicsdk is inside the mtasa repository which is GPL 3. The Sockets module seems to be under GPL 3, and the MySQL Module (although old) includes MySQL Community Edition source which also seems to be GPL. These are first party modules made by MTA.

This is a time wasting mess... we're just better off assuming the publicsdk is GPL 3 as well, just like these first party modules did...

@qaisjp
Copy link
Contributor

qaisjp commented Jun 8, 2020

I mean I think it's safe to assume the license is this https://www.github.com/multitheftauto/mtasa-blue/tree/master/Shared%2Fpublicsdk%2FLICENSE since that's the actual original source.

(The publicsdk folder being in a repo surrounded by GPL doesn't matter because the publicsdk folder has its own license)

@qaisjp qaisjp mentioned this issue Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants