Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-username not respected #482

Open
dholbach opened this issue Dec 14, 2021 · 5 comments
Open

slack-username not respected #482

dholbach opened this issue Dec 14, 2021 · 5 comments
Labels
bug keep This won't be closed by the stale bot. notifications

Comments

@dholbach
Copy link
Member

dholbach commented Dec 14, 2021

slack-username is not respected any more.

❯ git grep -i "slack.*username"
README.md:      --slack-username string               slack username for reboot notfications (default "kured")
charts/kured/README.md:| `configuration.slackUsername` | cli-parameter `--slack-username`                                      | `""`                      |
charts/kured/templates/daemonset.yaml:          {{- if .Values.configuration.slackUsername }}
charts/kured/templates/daemonset.yaml:            - --slack-username={{ .Values.configuration.slackUsername }}
charts/kured/values.minikube.yaml:  # slackUsername: ""         # slack username for reboot notfications (default "kured")
charts/kured/values.yaml:  slackUsername: ""          # slack username for reboot notfications (default "kured")
cmd/kured/main.go:      slackUsername                   string
cmd/kured/main.go:      rootCmd.PersistentFlags().StringVar(&slackUsername, "slack-username", "kured",
cmd/kured/main.go:              "slack username for notifications")
kured-ds.yaml:#            - --slack-username=prod

kured on  main via 🐹 v1.16.12 
❯ 

This came up after #368 (along with #469).

I'm a bit unsure what to do. I feel that going with shoutrrr is the right thing to do, but some "old" setups won't work they used to any more.

@Starefossen
Copy link

Looks like channel is not respected either... at least it looks like it in our deployments 😕

@ckotzbauer ckotzbauer added the bug label Jan 24, 2022
@dholbach
Copy link
Member Author

@atighineanu Can you help?

@github-actions
Copy link

This issue was automatically considered stale due to lack of activity. Please update it and/or join our slack channels to promote it, before it automatically closes (in 7 days).

@bengtfredh
Copy link

We still have this issue.

  • upgraded to chart version 1.12.1
  • changed to --notify-url

slack-username is not respected. Message to slack is sendt as Kured.

@bengtfredh
Copy link

After some testing I found that this works:

--notify-url=slack://myslackusername@token-a/token-b/token-c

Looks like --slack-username is deprecated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug keep This won't be closed by the stale bot. notifications
Projects
None yet
Development

No branches or pull requests

4 participants