Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Registration API: Consider not making requests to unknown login status #6

Open
cbiesinger opened this issue May 21, 2024 · 7 comments

Comments

@cbiesinger
Copy link

IdPs currently start out in an unknown status (in Chrome). But with the registration API, we may have a lot of IdPs. Maybe we should only make requests to IdPs with a logged-in status for the registration API specifically?

@samuelgoto
Copy link
Collaborator

Maybe we should only make requests to IdPs with a logged-in status for the registration API specifically?

If an IdP manages to call a IdentityProvider.register() to register a user, they can also manage to call a navigator.login.setStatus() to prime the Login Status initial state, right?

@cbiesinger
Copy link
Author

Yes that was my thinking

@samuelgoto
Copy link
Collaborator

Maybe we should only make requests to IdPs with a logged-in status for the registration API specifically?

Yeah, I think this would be a reasonable requirement.

@aaronpk
Copy link

aaronpk commented May 21, 2024

We should make sure we consider the implications to "button mode" too.

@samuelgoto samuelgoto changed the title Consider not making requests to unknown login status for the registration API The Registration API: Consider not making requests to unknown login status May 21, 2024
@npm1
Copy link

npm1 commented May 22, 2024

Is the suggestion basically to not have 'unknown' for registered IDPs? E.g. they are always either logged in or logged out?

@samuelgoto
Copy link
Collaborator

Is the suggestion basically to not have 'unknown' for registered IDPs? E.g. they are always either logged in or logged out?

Yeah, I think that's what Christian is suggesting.

@cbiesinger
Copy link
Author

When I filed this, I was thinking that in RequestToken we basically change unknown to logged-out for an IDP if it came from configURL:any.

However we could also have IdentityProvider.register have an implied setStatus(logged-out) if the status was unknown.

@samuelgoto samuelgoto transferred this issue from w3c-fedid/FedCM Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants