Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Labels issue #21

Open
sharpenedpixels opened this issue May 13, 2019 · 3 comments
Open

Fix Labels issue #21

sharpenedpixels opened this issue May 13, 2019 · 3 comments

Comments

@sharpenedpixels
Copy link

sharpenedpixels commented May 13, 2019

Upon using your plugin, great work by the way, I noticed on a lighthouse report that the search bar was showing as missing a label element. Upon inspecting the code I could see the label, but for some reason it wasn't working. I unchecked the fix labels within the plugin and added my own label within the header.php and now the label is working as it should. You might want to check on that part of the plugin. I'm not sure if this is just an issue on the search input or all inputs across the theme.

@sharpenedpixels
Copy link
Author

P.S. with the help of your plugin and a little tinkering of the original code in a child theme, I've hit 100% accessibility in a lighthouse report. Thanks.

@gjeflec
Copy link

gjeflec commented Nov 4, 2020

Can you share your fix? My one issue with the accessibility checks is always forms and the labels.

@sharpenedpixels
Copy link
Author

@gjeflec sorry for my delayed response. I'd love to help but honestly, it has been a while since I implemented these fixes and can't remember exactly what I did to resolve it apart from wrapping the search input field with a label tag in the header.php within a child theme.

I'm constantly tweaking code to try and keep it in line with accessibility, but haven't needed to do any changes for some time. What I usually do is run a lighthouse report to see what gets flagged in it, and then look to resolve any issues mentioned. I have also got a separate javascript file in my child theme that inject missing attributes from HTML elements, as some of these are flagged as missing within the Divi theme.

Sorry if my response is a bit vague, if I get some spare time I will look at each part of my child theme closely and see if I can give you some better details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants