Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Walker Nav #22

Closed
ambadesign opened this issue Mar 4, 2021 · 7 comments
Closed

Walker Nav #22

ambadesign opened this issue Mar 4, 2021 · 7 comments
Assignees
Labels

Comments

@ambadesign
Copy link

Description (small description where the bug is about):
When you add a parent page and child pages to the menu, not only is the parent not clickable, but the children don't drop down either.

Expected result:
Parent and child menu items should be clickable and dropdown respectively.

Actual result:
Parent not clickable. Child menu does not drop down.

Steps to reproduce
Added parent menu item with children.

@babobski
Copy link
Owner

babobski commented Mar 4, 2021

I changed the bootstrap nav walker when making it bootstrap 5 ready.
Can you test if you switch it back to the bootstrap 4 nav walker, it's fixes the issue?

The bootstrap 4 nav walker is still present in the theme.
You have to change the include back to bs4navwalker.php on line:
https://github.com/babobski/Bootstrap-on-WordPress/blob/master/functions.php#L33

You can then use the old navwalker like:

https://github.com/babobski/Bootstrap-on-WordPress/blob/2d2ce9c02a42294340396d3a05b4c477fa408121/parts/shared/header.php

@babobski babobski added the bug label Mar 4, 2021
@babobski
Copy link
Owner

babobski commented Mar 5, 2021

Thanks for the report, fixed it in the latest release

@ambadesign
Copy link
Author

Thank you for the fix; however there is another issue. The mobile menu does not work at all - can you fix this as well please?

@babobski
Copy link
Owner

Thanks for the report! fixed it in the latest release.

@ambadesign
Copy link
Author

I've downloaded the latest release and the mobile menu doesn't trigger at all. I've tested this on a site we were building for a client and on a new, bare bones install and it's still not working. You click on the hamburger and nothing happens.

@babobski
Copy link
Owner

The button was not working because the data-attributes has changed from data- to data-bs-. I've changed this in the parts/shared/header.php to make it work again with Bootstrap 5. Can you check the file in you're template if you see these changes?

@ambadesign
Copy link
Author

Ooooh I see! No it wasn't changed, but I've now changed it and wah lah! All kicks in! Thanks for that, appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants