Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify unit of fftSize #1745

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Clarify unit of fftSize #1745

merged 1 commit into from
Sep 13, 2018

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth commented Sep 10, 2018

index.bs Outdated
@@ -4100,7 +4100,7 @@ Attributes</h4>
<dl dfn-type=attribute dfn-for="AnalyserNode">
: <dfn>fftSize</dfn>
::
The size of the FFT used for frequency-domain analysis.
The size of the FFT used for frequency-domain analysis (in frames).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spec generally uses "sample-frames" for this. Don't know why. I always just say frames.

@Manishearth
Copy link
Contributor Author

Updated.

Copy link
Member

@rtoy rtoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rtoy rtoy merged commit 734e0d5 into WebAudio:master Sep 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants