Google Git
Sign in
chromium / chromium / src / f21ea0f1ba32495a04d3a131a55b925d115ff214
commitf21ea0f1ba32495a04d3a131a55b925d115ff214[log] [tgz]
authorBalazs Engedy <[email protected]>Thu Dec 12 20:33:25 2019
committerCommit Bot <[email protected]>Thu Dec 12 20:33:25 2019
treea406e0278d18d19e38398284e0fc502a80989310
parent5578c700e959021f105c3b66ec3372dd30a8f51f [diff]
Prioritize QuietUiReason::kTriggeredByCrowdDeny.

Even if displaying notification permission requests using the quiet UI
is enabled on all sites, the NotificationPermissionUiSelector should
still check the crowd deny state. If crowd deny prescribes triggering,
QuietUiReason::kTriggeredByCrowdDeny should be returned instead of
kEnabledInPrefs, so that the less-prominent version of the UI and the
correct string is shown.

(cherry picked from commit d7199b463e6cdec4629cd955374b5259bef8df66)

Bug: 1032043
Change-Id: I29f6b1773131f74952ef5816ffd2518c0d91fc15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958137
Commit-Queue: Balazs Engedy <[email protected]>
Reviewed-by: Kamila Hasanbega <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#723334}
TBR: [email protected]
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1965653
Reviewed-by: Balazs Engedy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#79}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
2 files changed
tree: a406e0278d18d19e38398284e0fc502a80989310
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .