Google Git
Sign in
chromium / chromium / src / c681020c29f6b22132b4cff6c8a200e8ce63fb64
commitc681020c29f6b22132b4cff6c8a200e8ce63fb64[log] [tgz]
authorJoel Hockey <[email protected]>Fri Dec 13 04:42:45 2019
committerCommit Bot <[email protected]>Fri Dec 13 04:42:45 2019
treefef05abfbde4cacc01a87a9ab46da84e03c2ebf9
parent311e7d0db8cc8641b63372c2986387464213993f [diff]
GuestOsSharePath FileWatcher crashes fix

There are some crashes where it seems that
GuestOsSharePath has been destroyed when
FileWatcher callbacks run.

This change fixes all code which runs in the
FileWatcher sequence to not access the
GuestOsSharePath object, but rather
post tasks to the UI thread where a WeakPtr
is used before running any code on the
GuestOsSharePath object.

[email protected]
(cherry picked from commit b062cd83993fd5083e836f314e1b33610e6fdf94)

Bug: 1031080
Change-Id: Ia8acae392eabf4f3d13847dbd7331c3321fba410
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1956981
Reviewed-by: Fergus Dall <[email protected]>
Commit-Queue: Joel Hockey <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#723259}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966793
Reviewed-by: Joel Hockey <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#106}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
3 files changed
tree: fef05abfbde4cacc01a87a9ab46da84e03c2ebf9
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .