Google Git
Sign in
chromium / chromium / src / c24742113c94364f92a09c5916848a50bea54585
commitc24742113c94364f92a09c5916848a50bea54585[log] [tgz]
authorDominic Battre <[email protected]>Mon Dec 16 14:43:08 2019
committerCommit Bot <[email protected]>Mon Dec 16 14:43:08 2019
tree08c30472628fa7b1a1739408c56eddf3ecbfcb43
parentc39be86fa0913c335826d8e388c3901e42e0dd7e [diff]
Fix communication with autofill server on iOS

This CL restores the communication of Chrome on iOS with the Autofill
server. It broke by commit fc59bb21057d0a077f421157e9bc2d2a8c3208e1
which assigned trusted_params to the network request. However, the
URLLoaderFactory originated from BrowserState and was therefore shared
and not trusted. As per the documentaiton of trusted_params:
"Setting these from an untrusted URLLoader will cause the request to
fail."

This CL removes the trusted_params to bring Autofill back to a working
situation. Maybe the iOS or network stack folks can see whether
we want to have special URLLoaderFactories for components on iOS.
I don't see a precedence for that.

(cherry picked from commit 87d33b5b6575a12367605d29fe7fbf8c85a7bfd0)
[email protected]

Bug: 1031136
Change-Id: Ic2e04f37f3a30e8adb98e23f19205be09fa5375a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953707
Reviewed-by: Matt Menke <[email protected]>
Reviewed-by: Olivier Robin <[email protected]>
Commit-Queue: Dominic Battré <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#722493}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969337
Reviewed-by: Dominic Battré <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#154}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
1 file changed
tree: 08c30472628fa7b1a1739408c56eddf3ecbfcb43
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .