Google Git
Sign in
chromium / chromium / src / bb04c53419179dbdb697576d89cd387d1a2c1d1d
commitbb04c53419179dbdb697576d89cd387d1a2c1d1d[log] [tgz]
authorManas Verma <[email protected]>Mon Dec 09 21:35:34 2019
committerCommit Bot <[email protected]>Mon Dec 09 21:35:34 2019
treeff33bf718fc0c014a86cda5fe3c3501c6823738e
parentf9e01e0ae37874e0b2512099cd20ed42f37c8719 [diff]
Revert "[Autofill Auth] Adding capability to disable WebAuthn UI from Autofill"

This reverts commit 69671ce55513fe27ab04917db7da0f234bf49ffa.

Reason for revert: Tested in Canary, and the flow stops immediately after authentication. Will try to debug this, and possibly just go ahead with the long term solution right away.

Original change's description:
> [Autofill Auth] Adding capability to disable WebAuthn UI from Autofill
> 
> Providing an option to disable WebAuthn UI from InternalAuthenticatorImpl.
> 
> By disabling WebAuthn UI, modal dialogs will stop conflicting between the two
> components and this will give Autofill full control over the user experience.
> 
> Bug: 949269
> Change-Id: Ibf88cdb0f014c022371546df54d10e2c9eb7bc24
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1948916
> Commit-Queue: Manas Verma <[email protected]>
> Reviewed-by: Martin Kreichgauer <[email protected]>
> Reviewed-by: Jared Saul <[email protected]>
> Reviewed-by: sebsg <[email protected]>
> Cr-Commit-Position: refs/heads/master@{#722230}

[email protected],[email protected],[email protected],[email protected]

(cherry picked from commit eeb29c7922f41c0211d29369b06e8f3811bb7bb7)

Change-Id: Iab4507114f3e19e59acddd49ea89244ee7390048
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1032165
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955910
Reviewed-by: Manas Verma <[email protected]>
Commit-Queue: Manas Verma <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#722571}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958893
Cr-Commit-Position: refs/branch-heads/3987@{#16}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
3 files changed
tree: ff33bf718fc0c014a86cda5fe3c3501c6823738e
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .