Google Git
Sign in
chromium / chromium / src / 8dbd7d05682cf84a0aced1d18efe135a2983c4a7
commit8dbd7d05682cf84a0aced1d18efe135a2983c4a7[log] [tgz]
authorLivvie Lin <[email protected]>Tue Dec 17 23:54:12 2019
committerCommit Bot <[email protected]>Tue Dec 17 23:54:12 2019
treed36ba291bab2b2b6d6dab164abfa59d35ad551ef
parentaf0108d9d61c07ef0bfaf9838cd27c7831935426 [diff]
Simplify security icon downgrade logic

Ignore mixed content that has the NONE state, since it will have the
WARNING state in M80. There is also no need to check secure schemes
in WARNING since the ones that shouldn't be warned will have the NONE
state.

This also fixes the issue where the icon shouldn't be downgraded when
the URL is loading (and has the NONE state).

[email protected],[email protected],[email protected]

(cherry picked from commit 0ca925ea185092e74260285825db738dc4223614)

Bug: 1031532
Change-Id: I167e74966cdd9dc7eb368209f481c24b9661c139
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1962801
Reviewed-by: Emily Stark <[email protected]>
Reviewed-by: Tommy Li <[email protected]>
Reviewed-by: Andrey Kosyakov <[email protected]>
Reviewed-by: Michael Thiessen <[email protected]>
Reviewed-by: Rohit Rao <[email protected]>
Commit-Queue: Livvie Lin <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#725212}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972462
Reviewed-by: Livvie Lin <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#227}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
18 files changed
tree: d36ba291bab2b2b6d6dab164abfa59d35ad551ef
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .