Google Git
Sign in
chromium / chromium / src / 853f63824aa09122d9d44a0b2d9fb04d230cee96
commit853f63824aa09122d9d44a0b2d9fb04d230cee96[log] [tgz]
authorDaniel Murphy <[email protected]>Tue Dec 17 19:39:33 2019
committerCommit Bot <[email protected]>Tue Dec 17 19:39:33 2019
tree2af6e7c66de31c4e631db25ba7c52a9eec8e9cac
parent175282613e68b0f2e47d55d56b4adee839c66058 [diff]
[IndexedDB] Prevent removal of index tombstones in readonly transactions

This change fixes the case where a readonly transaction was writing
changes to disk. It pipes the transaction mode into the IDBBackingStore
Transaction & the CursorOptions so index tombstones can be optionally
deleted.

This is tested by the web platform test idbindex_reverse_cursor.any.js
(among other web platform tests).

To combat the extra tombstones that will be generated by this change,
the tombstone sweeper's parameters have been tweaked to allow for more
sweeping.

Doc describing the root cause more:
https://docs.google.com/document/d/1R_l3LsgT6VtSh-T0gQlQ5AqvFdfGLehfqWhDa7Oor-E/edit#

[email protected]
R=​[email protected]

(cherry picked from commit d8cb393e5b93ae5769fb092d42912d1c4b9cd03b)

Bug: 1033996
Change-Id: I8354f3c76d14d4805c1072ce148ad9a1f0cceca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967926
Commit-Queue: Daniel Murphy <[email protected]>
Reviewed-by: Joshua Bell <[email protected]>
Reviewed-by: Victor Costan <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#724881}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971229
Reviewed-by: Daniel Murphy <[email protected]>
Cr-Commit-Position: refs/branch-heads/3987@{#216}
Cr-Branched-From: c4e8da9871cc266be74481e212f3a5252972509d-refs/heads/master@{#722274}
10 files changed
tree: 2af6e7c66de31c4e631db25ba7c52a9eec8e9cac
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .