Summary: | Use same border preset tooltips between toolbar and sidebar | ||
---|---|---|---|
Product: | LibreOffice | Reporter: | Stéphane Guillou (stragu) <stephane.guillou> |
Component: | Calc | Assignee: | Kira Tubo <kira.tubo> |
Status: | VERIFIED FIXED | ||
Severity: | normal | CC: | heiko.tietze, kira.tubo, mentoring, rafael.palma.lima |
Priority: | medium | Keywords: | difficultyBeginner, easyHack, skillCpp, topicUI |
Version: | 7.2.4.1 release | ||
Hardware: | x86-64 (AMD64) | ||
OS: | All | ||
See Also: |
https://bugs.documentfoundation.org/show_bug.cgi?id=146466 https://bugs.documentfoundation.org/show_bug.cgi?id=141774 https://bugs.documentfoundation.org/show_bug.cgi?id=161648 |
||
Whiteboard: | reviewed:2022 target:25.2.0 target:24.8.0.0.beta2 | ||
Crash report or crash signature: | Regression By: | ||
Bug Depends on: | |||
Bug Blocks: | 103428, 113654 | ||
Attachments: | Overview of options between toolbar, sidebar and dialog (LO 7.3) |
Description
Stéphane Guillou (stragu)
2021-12-29 10:48:11 UTC
Created attachment 177189 [details]
Overview of options between toolbar, sidebar and dialog (LO 7.3)
This spreadsheet shows the differences between toolbar, sidebar and cell format dialog.
The cells sharing a background colour are the ones that currently have different tooltips when they should probably have the same one.
I support this request. As a user, I also find it weird to have so many differences between the toolbar and the sidebar. Let's add the UX team in the loop. The toolbar button uses include/svx/strings.hrc starting with #define RID_SVXSTR_TABLE_PRESET_NONE while the sidebar is defined in a ui file with tooltips for each item. I suggest to assign the RID_SVXSTR* tooltips per code like sc/source/ui/sidebar/CellBorderStyleControl.cxx #include <svx/strings.hrc> #include <svx/dialmgr.hxx> void CellBorderStylePopup::Initialize() { mxTBBorder1->connect_clicked ( LINK(this, CellBorderStylePopup, TB1SelectHdl) ); mxTBBorder1->set_item_tooltip_text(0, SvxResId(RID_SVXSTR_TABLE_PRESET_NONE)); mxTBBorder1->set_item_tooltip_text(1, SvxResId( ... Perhaps it makes sense to clean up tooltip from the ui file to remove confusion. I would like to look into this. One doubt, till what index, do we need to assign the RID_SVXSTR to the code line? Like you have started from (0,...) then '(1,....)', so till which index we need to assign this? Thanks :) (In reply to Radhey Parekh from comment #4) > ...till what index, do we need to assign the RID_SVXSTR to the code line? Why not use all 20? I guess the presets are more than 20 , because when we select 2 adjecent cells, the presets are different which are not included in the excel sheet Kira Tubo committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/14231e45ce5c8f2615fc5a448479960dfe1ed22b tdf#146468: Match border tooltips in toolbar/sidebar It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Note: Tooltip values now controlled in svx/strings.hrc instead of sc/uiconfig/scalc/ui/floatingborderstyle.ui, accessible names will be added in context of tdf#161648" Addressing some minor comments in the last patch before closing this ticket. See: https://gerrit.libreoffice.org/c/core/+/169308 Regardless, the bug should have been fully resolved in the last patch. Kira Tubo committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e5c55b2cfc47dcc5b711811fedc75ee982e3d46e tdf#146468: Fix typo and move comments It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Thank you Kira! I tested the patch in my own build, looks good. Kira Tubo committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/4ab9fea75f552dcaa52e1c25d2bc841e965e0b4e tdf#146468: Match border tooltips in toolbar/sidebar It will be available in 24.8.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. Kira Tubo committed a patch related to this issue. It has been pushed to "libreoffice-24-8": https://git.libreoffice.org/core/commit/9b2d11fcdcdc5f75caf3e7645f795011afd4aef2 tdf#146468: Fix typo and move comments It will be available in 24.8.0.0.beta2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. |